[ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

How to configure multipath_port in static_route? I think the the multipath can be figured out from exist data of static_route, may not need to add this multipath_port column. And I think we should add a status column to indicate the nexthop state. When some of nexthop in multipath is down, ovn

[ovs-dev] [PATCH 07/10] odp-execute: Use const qualifer for batch size.

It is recommended to use const qualifer for 'num' that tracks the packet batch count. This way 'num' can't be modified by iterator. Signed-off-by: Bhanuprakash Bodireddy --- lib/odp-execute.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 06/10] netdev-bsd: Use DP_PACKET_BATCH_FOR_EACH in netdev_bsd_send.

Use DP_PACKET_BATCH_FOR_EACH macro in netdev_bsd_send(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-bsd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 8a4cdb3..96ba71c 100644 ---

Re: [ovs-dev] [PATCH 12/13] conntrack: Fix dead assignment reported by clang.

Thanks Bhanu It seems my scan-build usage was not catching these. I decided to do something a little different which I’ll send out later today as part of some other changes Darrell On 9/10/17, 10:25 AM, "Bodireddy, Bhanuprakash" wrote: Hi Darrell,

[ovs-dev] [PATCH RFC 04/52] util: Avoid trailing white space in hex dumps.

ovs_hex_dump() sometimes yields a trailing space in its output. This is annoying for the test infrastructure, since we have to specially mark the trailing white space in Autotest with a "@@" marker at the end of the line. This commit gets rid of the trailing white space and the annoying "@@"

[ovs-dev] [PATCH RFC 03/52] table: Avoid trailing white space in tables.

Commands that use the table library, such as ovs-vsctl and "ovsdb-client dump", print trailing white space in tabular output, to fill out the entire width of their tabular columns. This is annoying whenever we use these commands in the test infrastructure, since we have to specially mark the

[ovs-dev] [PATCH RFC 02/52] daemon-unix: With --monitor, only close standard fds if --detach also used.

Daemons generally should close the standard fds because they don't want to hold open an SSH session, etc. that is attached to a tty. But --monitor without --detach does not daemonize, so do not close fds in that case. Signed-off-by: Ben Pfaff --- lib/daemon-unix.c | 4 +++- 1

[ovs-dev] [PATCH RFC 11/52] log: Allow client to specify magic.

Until now, the logging code in ovsdb has only supported a single file format, for OVSDB standalone database files. Upcoming commits will add support for another, incompatible format, which uses a different magic string for identification. This commit allows the logging code to support both

[ovs-dev] [PATCH RFC 46/52] ovsdb: Add support for online schema conversion.

With this change, "ovsdb-client convert" can be used to convert a database from one schema to another without taking the database offline. Signed-off-by: Ben Pfaff --- NEWS| 2 + lib/ovsdb-data.c| 13 +++ lib/ovsdb-data.h| 6 ++

[ovs-dev] [PATCH RFC 48/52] ovsdb-client: Add new "backup" command.

Signed-off-by: Ben Pfaff --- NEWS| 1 + manpages.mk | 299 ovsdb/file.c| 22 ++-- ovsdb/file.h| 2 + ovsdb/log.c | 58 ++ ovsdb/log.h | 4

Re: [ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

Distributed gateway ? What do the kernel datapath flows look like ? On 9/18/17, 11:29 PM, "ovs-dev-boun...@openvswitch.org on behalf of Guoshuai Li" wrote: In an ovn gateway node with DPDK, the RECIRC_DEPTH may be greater than

[ovs-dev] [PATCH 10/10] dpif-netdev: Remove 'cnt' in dp_netdev_input__().

There is little use of 'cnt' variable in dp_netdev_input__(). Get rid of it and use dp_packet_batch_size() to initialize PKT_ARRAY_SIZE. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose wrote: > On 09/12/2017 12:49 PM, Andy Zhou wrote: >> >> When translating actions within open flow clone, actions generated >> by finish_freezeing() should also be enclosed within the datapath >> clone netlink encoding. >> >>

[ovs-dev] [PATCH RFC 00/52] clustering implementation

Here's a first version of the Raft-based clustering implementation. There is still significant work to do, but this is ready for people to take a basic look at. If you want to try it out, the final commit message has some basic instructions, and a to-do list before it's really ready. You might

[ovs-dev] [PATCH RFC 14/52] ovsdb-error: New function ovsdb_error_to_string_free().

Signed-off-by: Ben Pfaff --- lib/ovsdb-data.c | 5 ++--- lib/ovsdb-error.c| 21 +++-- lib/ovsdb-error.h| 3 ++- lib/ovsdb-idl.c | 9 +++-- ovsdb/file.c | 7 ++- ovsdb/ovsdb-server.c | 6 ++ tests/test-ovsdb.c | 18

[ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

Most of the OVS database-manipulation utilities (ovn-sbctl, ovn-nbctl, ovs-vsctl, vtep-ctl) don't retry their connections by default because they assume that the database is either up or down and likely to stay that way. The OVN southbound database, however, is a likely candidate for high

[ovs-dev] [PATCH RFC 22/52] test-ovsdb: Simplify code in do_trigger().

Signed-off-by: Ben Pfaff --- tests/test-ovsdb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c index 742c08a92106..7033a2dae611 100644 --- a/tests/test-ovsdb.c +++ b/tests/test-ovsdb.c @@ -1535,10 +1535,10 @@

[ovs-dev] [PATCH RFC 23/52] test-ovsdb: Triggers should wake up other triggers immediately.

Signed-off-by: Ben Pfaff --- tests/ovsdb-trigger.at | 2 +- tests/test-ovsdb.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ovsdb-trigger.at b/tests/ovsdb-trigger.at index 1da63364858f..aa7150ff3d2e 100644 --- a/tests/ovsdb-trigger.at +++

[ovs-dev] [PATCH RFC 43/52] ovsdb: Improve documentation.

Signed-off-by: Ben Pfaff --- NEWS| 2 + manpages.mk | 56 +--- ovn/controller/ovn-controller.8.xml | 5 +- ovn/northd/ovn-northd.8.xml | 6 +- ovn/utilities/ovn-sbctl.8.in| 19 +- ovsdb/.gitignore

[ovs-dev] [PATCH RFC 45/52] ovsdb-client: Move ovsdb-client specific tests to new .at file.

Also, move a few tests that were really ovsdb-client tests to the new file. Signed-off-by: Ben Pfaff --- tests/automake.mk | 1 + tests/ovsdb-client.at | 22 ++ tests/ovsdb-server.at | 21 - tests/ovsdb.at| 1 + 4 files

[ovs-dev] [PATCH RFC 32/52] ovsdb-idl: Fix assertion failure on error path parsing server reply.

If the database server sent an error reply to a monitor_cond request, and the error was not a JSON string, then passing the error to json_string() caused an assertion failure. Found by inspection. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 4 ++-- 1 file changed, 2

[ovs-dev] [PATCH RFC 27/52] jsonrpc-server: Separate changing read_only status from reconnecting.

Changing whether a server's databases are read-only is logically independent from whether its sessions need to reconnect, so use different functions for the purpose. Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 19 ++- ovsdb/jsonrpc-server.h | 7 +--

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On Tue, Sep 19, 2017 at 1:56 PM, Greg Rose wrote: > On 09/19/2017 01:26 PM, Andy Zhou wrote: >> >> On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose wrote: >>> >>> On 09/12/2017 12:49 PM, Andy Zhou wrote: When translating actions within open

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On 09/19/2017 04:11 PM, Andy Zhou wrote: On Tue, Sep 19, 2017 at 1:56 PM, Greg Rose wrote: On 09/19/2017 01:26 PM, Andy Zhou wrote: Yes, I just tried on a VM running Centos 7.3 with the 4.9 kernel and it passed there. /shrug? OK, I'll continue with review then.

[ovs-dev] Development Setup

Dear all, I am new a newbie, I am curious to know what development tools with Ubuntu as Host OS, will best fit for people entering into linux kernel development focusing on Netlink, Netdev and Wireless MAC. I have read many blogs describing the basic setup and things like that. But I felt input

Re: [ovs-dev] adding dpdk ports sharing same pci address to ovs-dpdk bridge

> Thanks for confirming Devendra > > Adding Ciara > There have been some offline discussions regarding the issue. The workaround discussed is a patch to enable backwards compatibility with the old port IDs. Something like the following: – set Interface portX options:dpdk-devargs=dpdkportid0

Re: [ovs-dev] [PATCH 2/5] conntrack: r/w upper limit value for connections.

On 9/18/17, 3:22 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: Read/Write the upper limit value for connections. Example: # set a new upper limit

[ovs-dev] [PATCH v3] ovn: Support for taas(tap-as-a-service) function

To support taas function, this patch add two type of logica_switch_port, "mirror" and "taas". port with type "mirror" is used as inport for monitor flow in logica_switch, and port with type "taas" is used as outport for monitor flow in logica_switch. The ovn-controller will make the relations

Re: [ovs-dev] 答复: Re: [PATCH] ovn: Discard flows for non-local ports.

Thanks for the patch Russell, Han Zhou comments make sense, I tested the patch manually and greatly reduced the number of flows per chassis. I still need to test connectivity more thoroughly but tests seemed ok. Best, Miguel Ángel. On Tue, Sep 19, 2017 at 2:45 AM,

Re: [ovs-dev] [PATCH 1/5] conntrack: add commands to r/w conntrack parameters.

Thanks for working on this Antonio Few initial comments; in some cases, I did not repeat the same comment. On 9/18/17, 3:22 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: Add

[ovs-dev] [PATCH RFC 06/52] jsonrpc: Allow jsonrpc_session to have more than one remote.

The implementation cycles through the remotes in random order. This allows clients to perform some load balancing across alternative implementations of a service. Signed-off-by: Ben Pfaff --- lib/jsonrpc.c | 66 ++-

[ovs-dev] [PATCH RFC 19/52] ovsdb: Drop distinction between monitors and replicas.

Until now, OVSDB distinguished between "monitors", which are associated with OVSDB JSON-RPC client sessions and allow clients to find out about database changes, and "replicas", which are associated with databases and also find out about database changes and act on them in some way. The rationale

[ovs-dev] [PATCH RFC 18/52] ovsdb-server: Distinguish logs from other replicas.

Until now, ovsdb-server has internally chained a list of replicas from each database. Whenever a transaction commits, it is passed to each of the replicas. The first replica, which until now is always the disk file that stores the database, is special because it is the only replica that can

[ovs-dev] [PATCH RFC 47/52] ovsdb-client; Add new "get-schema-cksum" command.

I don't have a particular use for this but it allows ovsdb-client to do all the things with schemas that ovsdb-tool can. Signed-off-by: Ben Pfaff --- NEWS| 1 + ovsdb/ovsdb-client.1.in | 5 + ovsdb/ovsdb-client.c| 13 + 3 files changed, 19

[ovs-dev] [PATCH RFC 10/52] json: New function json_object_put_format().

This will acquire users in an upcoming commit. Signed-off-by: Ben Pfaff --- include/openvswitch/json.h | 6 +- lib/json.c | 12 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/include/openvswitch/json.h b/include/openvswitch/json.h

[ovs-dev] [PATCH RFC 38/52] ovsdb-idl: Break out database-specific stuff into new data structure.

Until now, a given ovsdb-idl instances has only monitored a single database. In an upcoming commit, it will grow to also monitor a second database that represents the state of the database server itself. Much of the work is the same for both databases, so this commit breaks the common code and

[ovs-dev] [PATCH RFC 24/52] ovsdb-client: Show even invalid data in "dump" output.

The ovsdb-client "dump" command is a fairly low-level tool that can be used, among other purposes, to debug the OVSDB protocol. It's better if it just prints what the server sends without being too judgmental about it. Signed-off-by: Ben Pfaff --- lib/ovsdb-data.c | 17

[ovs-dev] [PATCH RFC 36/52] ovsdb-idl: Fix spelling error in comment.

Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 5860c305a9dd..85c74669024e 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -1151,7 +1151,7 @@

[ovs-dev] [PATCH 02/10] netdev-linux: Use DP_PACKET_BATCH_FOR_EACH in netdev_linux_tap_batch_send.

Use DP_PACKET_BATCH_FOR_EACH macro in netdev_linux_tap_batch_send(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index

[ovs-dev] [PATCH 01/10] netdev-linux: Clean up netdev_linux_sock_batch_send().

Use DP_PACKET_BATCH_FOR_EACH macro and dp_packet_batch_size() API in netdev_linux_sock_batch_send(). No change in functionality. Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-linux.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

[ovs-dev] [PATCH RFC 08/52] uuid: New function uuid_random().

Signed-off-by: Ben Pfaff --- lib/uuid.c | 8 lib/uuid.h | 1 + 2 files changed, 9 insertions(+) diff --git a/lib/uuid.c b/lib/uuid.c index 06f8792592d2..13d20ac64977 100644 --- a/lib/uuid.c +++ b/lib/uuid.c @@ -101,6 +101,14 @@ uuid_generate(struct uuid *uuid)

[ovs-dev] [PATCH RFC 07/52] socket-util: Make parse_bracketed_token() public, as inet_parse_token().

An upcoming commit will introduce a new user outside socket-util. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 14 +++--- lib/socket-util.h | 3 ++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index

[ovs-dev] [PATCH RFC 09/52] json: New function json_nullable_clone().

Signed-off-by: Ben Pfaff --- include/openvswitch/json.h | 1 + lib/json.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/openvswitch/json.h b/include/openvswitch/json.h index 83775ed0efdf..edf53e594eb0 100644 ---

[ovs-dev] [PATCH RFC 29/52] jsonrpc-server: Enforce uniqueness of monitor IDs.

This oversight allowed monitor IDs to be duplicated when the monitor_cond_change request changed them. Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/ovsdb/jsonrpc-server.c

[ovs-dev] [PATCH RFC 33/52] ovsdb-idl: Fix indentation in a couple of places.

White space changes only. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index c56c02db1f0c..79912b649056 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@

[ovs-dev] [PATCH] ovs-sandbox: Install .rst manpages into the sandbox as well.

Without this, "man ovs-test" and "man ovs-vlan-test" won't work in the sandbox. Signed-off-by: Ben Pfaff --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 258ea9b87db6..7ae8cdb8a782 100755

[ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.

DP_PACKET_BATCH_FOR_EACH macro was introduced early this year as part of enhancing packet batch APIs. Commit '72c84bc2' implemented this macro and replaced most of the calling sites with macros and simplified the logic. However there are still many APIs that needs to be fixed. This patch series

[ovs-dev] [PATCH RFC 01/52] replication: Avoid theoretical use-after-free error in reset_database().

Code that calls ovsdb_txn_row_delete() should avoid referencing the deleted row again, because it might be freed. In practice this shouldn't really happen in this case because of the particular circumstances, but it costs little to be careful. Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH RFC 05/52] ofp-print: Avoid trailing white space in OpenFlow dumps.

ofp_to_string() sometimes yields a trailing space in its output. This is annoying for the test infrastructure, since we have to specially mark the trailing white space in Autotest with a "@@" marker at the end of the line. This commit gets rid of the trailing white space and the annoying "@@"

[ovs-dev] [PATCH RFC 20/52] ovsdb-server: Drop 'txn' member from struct db.

This member was only used in one particular code path, so this commit adds code to pass it around as a function parameter instead. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-server.c | 40 1 file changed, 16 insertions(+), 24 deletions(-)

[ovs-dev] [PATCH RFC 42/52] ovsdb-server: Add support for a built-in _Server database.

Initially this database only reports databases' names and schemas, but when clustering support is added in a later commit it will also report important aspects of clustering and cluster status. Signed-off-by: Ben Pfaff --- Makefile.am | 8 --- NEWS

[ovs-dev] [PATCH RFC 44/52] ovsdb-server: Add new RPC "set_db_change_aware".

The _Server database recently added to ovsdb-server can be used to dump out information about databases, but monitoring updates to _Server is not yet very useful because for historical reasons ovsdb-server drops all of its OVSDB connections whenever databases are added or removed or otherwise

[ovs-dev] [PATCH RFC 34/52] ovsdb-idl: Remove 'uuid' member of struct ovsdb_idl.

This was used to uniquely identify the monitor, but there's no need for that. A fixed monitor name works fine. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c

[ovs-dev] [PATCH RFC 26/52] ovsdb-server: Forbid user-specified databases with reserved names.

Names that begin with "_" are reserved, but ovsdb-server didn't previously enforce this. Signed-off-by: Ben Pfaff --- ovsdb/execution.c| 17 - ovsdb/ovsdb-client.c | 19 ++- ovsdb/ovsdb-server.c | 51

[ovs-dev] [PATCH RFC 31/52] ovsdb-idl: Document state machine.

Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 62a6c3898227..d71188ab3c7c 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -79,12 +79,41

[ovs-dev] [PATCH 05/10] netdev-dpdk: Use DP_PACKET_BATCH_FOR_EACH in netdev_dpdk_ring_send

Use DP_PACKET_BATCH_FOR_EACH macro in netdev_dpdk_ring_send(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 4e75bf1..3ff79c1

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On 09/19/2017 01:26 PM, Andy Zhou wrote: On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose wrote: On 09/12/2017 12:49 PM, Andy Zhou wrote: When translating actions within open flow clone, actions generated by finish_freezeing() should also be enclosed within the datapath clone

Re: [ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.

Hi Bhanu You have many instances where you want to use DP_PACKET_BATCH_FOR_EACH You have another series partially about this: https://patchwork.ozlabs.org/patch/813007/ Also, this series mixes in other changes like creating new variables for clarity, I guess, and removing unneeded variables.

[ovs-dev] [PATCH RFC 16/52] ovsdb-parser: New function ovsdb_parser_put_error().

This will have its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/ovsdb-parser.c | 14 +- lib/ovsdb-parser.h | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-parser.c b/lib/ovsdb-parser.c index

[ovs-dev] [PATCH RFC 17/52] ovsdb-data: Add OVS_WARN_UNUSED_RESULT annotations to function definitions.

The function prototypes in ovsdb-data.h already have these, but it seems more complete to have the annotation on the definitions too. Signed-off-by: Ben Pfaff --- lib/ovsdb-data.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-data.c

[ovs-dev] [PATCH RFC 15/52] ovsdb-error: New function ovsdb_error_to_json_free().

This simplifies little bits of code here and there. Signed-off-by: Ben Pfaff --- lib/ovsdb-error.c | 8 lib/ovsdb-error.h | 1 + ovsdb/execution.c | 4 +--- ovsdb/jsonrpc-server.c | 24 ++-- 4 files changed, 16 insertions(+), 21

[ovs-dev] [PATCH RFC 25/52] ovsdb-server: Document monitor_cond_change behavior for unmentioned tables.

It seems best to be explicit about this. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-server.1.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-server.1.in b/ovsdb/ovsdb-server.1.in index cf3884ccc294..f1c6466ccb75 100644 ---

[ovs-dev] [PATCH 09/10] dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in fast_path_processing.

Use DP_PACKET_BATCH_FOR_EACH macro in fast_path_processing(). Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH 08/10] dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in dp_netdev_run_meter.

Use DP_PACKET_BATCH_FOR_EACH macro in dp_netdev_run_meter(). Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH RFC 50/52] ovsdb-client: Add new "query" command.

Signed-off-by: Ben Pfaff --- NEWS | 2 +- ovsdb/ovsdb-client.c | 42 -- 2 files changed, 37 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index 9782818a1b0d..fc8db4965737 100644 --- a/NEWS +++ b/NEWS @@ -7,7 +7,7 @@

[ovs-dev] [PATCH RFC 51/52] ovsdb-tool: Add new "db-name" and "schema-name" commands.

Signed-off-by: Ben Pfaff --- NEWS | 1 + ovsdb/ovsdb-tool.1.in | 4 ovsdb/ovsdb-tool.c| 26 ++ 3 files changed, 31 insertions(+) diff --git a/NEWS b/NEWS index fc8db4965737..d7d594546f01 100644 --- a/NEWS +++ b/NEWS @@ -9,6 +9,7

[ovs-dev] [PATCH 04/10] netdev-dpdk: Minor cleanup of netdev_dpdk_send__.

The variable 'cnt' is initialized and reused in multiple function calls inside netdev_dpdk_send__() and is confusing sometimes. Instead introduce 'batch_cnt' to hold the original packet count and 'tx_cnt' to store the final packet count resulting after filtering and qos operations. Finally

[ovs-dev] [PATCH 03/10] netdev-dpdk: Cleanup dpdk_do_tx_copy.

Clean up dpdk_do_tx_copy() Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-dpdk.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 648d719..2078c94 100644 ---

Re: [ovs-dev] [PATCH 3/5] conntrack: r/w clean-up interval.

Hi Antonio What is the motivation for this ? I don’t think this is a good idea, as it should not be needed under normal usage and has the potential to create unnecessary issues for the user and also maintenance issues. Thanks Darrell On 9/18/17, 3:23 AM, "ovs-dev-boun...@openvswitch.org on

[ovs-dev] [PATCH RFC 12/52] log: Require log entries to be JSON objects.

The current and upcoming users of the OVSDB logging module only use JSON objects as records. This commit simplifies the users slightly by allowing them to always assume that the records are JSON objects. Unfortunately this resulted in a large number of updates to tests, which didn't always use

[ovs-dev] [PATCH RFC 40/52] tests: Always ignore "Broken pipe" and "Connection reset" log messages.

Until now, the ovn-controller-vtep, ovn-nbctl, and ovn-sbctl tests have ignored "Broken pipe" and "Connection reset" messages. The same rationale that applies to them also applies to ovs-vsctl and other utilities. It seems easier to just always ignore them. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH RFC 41/52] reconnect: Add ability to do a number of retries without backoff.

This is aimed at an upcoming database clustering implementation, where it's desirable to try all of the cluster members quickly before backing off to retry them again in sequence. Signed-off-by: Ben Pfaff --- lib/reconnect.c | 52

[ovs-dev] [PATCH RFC 37/52] ovsdb-idl: Verify insertion into singleton tables.

This makes ovs-vsctl and similar tools tolerate initialization races, where more than one client at a time tries to initialize a table like Open_vSwitch or SB_Global. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl-provider.h | 1 + lib/ovsdb-idl.c | 24

[ovs-dev] [PATCH RFC 35/52] ovsdb-idl: Add comments.

Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 895abc283d96..5860c305a9dd 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -118,18 +118,23 @@ enum

[ovs-dev] [PATCH RFC 30/52] jsonrpc-server: Report monitor session ID properly in error message.

The error message in question is about the monitor session ID but it actually reports the JSON-RPC request ID instead, which is surprising. Found by inspection. Signed-off-by: Ben Pfaff --- ovsdb/jsonrpc-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

When sending a localnet port with vlan, the GARP packet needs push_vlan. --- ovn/controller/pinctrl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/ovn/controller/pinctrl.c b/ovn/controller/pinctrl.c index 469a35586..cf4f1331a 100644 ---

[ovs-dev] [PATCH v1 2/3] Add multipath support in ovn-controller and ovn-trace

1. Update actions.h, actions.c to handle multipath action in ovn-controller. 2. Update ovn-trace to simulate action of multipath. It helps multipath debugging. Signed-off-by: Zhenyu Gao --- include/ovn/actions.h | 32 - ovn/lib/actions.c | 168

[ovs-dev] [PATCH v1 3/3] Update ovn.at to add multipath testcase

1. Add multipath testcase in ovn testsuites. It simulates dispatching packets in router by consuming multipath feature in Logical_Router_Static_Route. Signed-off-by: Zhenyu Gao --- tests/ovn.at | 232 +++ 1 file

[ovs-dev] [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

1. ovn-nb.ovsschema was updated to add new field multipath_port. 2. Add multipath feature in ovn-northd part. northd generates multipath flows to dispatch traffic by using packet's IP dst address if user set Logical_Router_Static_Route's multipath_port with ports. 3. Add new table(lr_in_multipath)

Re: [ovs-dev] [PATCH v5] dpif-netdev: Avoid reading RSS hash when EMC is disabled

Acked-by: Billy O'Mahony > -Original Message- > From: Fischetti, Antonio > Sent: Tuesday, September 12, 2017 5:34 PM > To: d...@openvswitch.org > Cc: Darrell Ball ; O Mahony, Billy > ; Fischetti, Antonio >

[ovs-dev] [PATCH] ovn-northd: add chassis nonull check

op->sb->gateway_chassis[0]->chassis may null in some special cases, need to add a check to avoid segment fault. Signed-off-by: wang qianyu --- ovn/northd/ovn-northd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

Thansk for the questions. the multipath_port can be set via ovn-nbctl. Like : ovn-nbctl -- --id=@lrt create Logical_Router_Static_Route ip_prefix=0.0.0.0/0 nexthop=10.88.77.1 multipath_port=[mp1,mp2] -- add Logical_Router edge1 static_routes @lrt This patch haven't implement a ovn-nbctl command

[ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroy

pending_ct_zones in ovn-controller main should be destroy when exit. Signed-off-by: xu rong --- ovn/controller/ovn-controller.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index a935a79..32cdc9f

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

On Mon, Sep 18, 2017 at 7:31 PM, Han Zhou wrote: > Thanks Russell for the quick work! > > On Mon, Sep 18, 2017 at 8:24 AM, Russell Bryant wrote: > >> @@ -301,6 +305,22 @@ consider_logical_flow(struct controller_ctx *ctx, >> if

[ovs-dev] [PATCH] ovn: OVN Support QoS meter

ovn-northd modify: add bandwidth column in NB's QOS table. add QOS_METER stages in Logical switch ingress/egress. add set_meter() action in SB's LFlow table. ovn-controller modify: add meter_table for meter action process openflow meter table. This feature is only supported in DPDK. --- NEWS

Re: [ovs-dev] ovs_dpdk: dpdk-socket-mem usage question

Hi Wang, Typically I reserve between 512M and 1G on each Numa. There is no formula I am aware of for how much memory is actually required. Fundamentally this will be determined by the maximum number and size of packets in-flight at any given time. Which is determined by the ingress packet

Re: [ovs-dev] [PATCH 1/5] conntrack: add commands to r/w conntrack parameters.

On 09/18/2017 11:21 AM, antonio.fische...@intel.com wrote: > Add infrastructure to implement: > - dpctl/ct-get to read a current value of available >conntrack parameters. > - dpctl/ct-set to set a value to the available conntrack >parameters. > > Add dpctl/ct-get to read current values

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On 09/12/2017 12:49 PM, Andy Zhou wrote: When translating actions within open flow clone, actions generated by finish_freezeing() should also be enclosed within the datapath clone netlink encoding. Signed-off-by: Andy Zhou Andy, I am reviewing and testing your patches. I

[ovs-dev] Development Setup

Dear all, I am new a newbie, I am curious to know what development tools with Ubuntu as Host OS, will best fit for people entering into linux kernel development focusing on Netlink, Netdev and Wireless MAC. I have read many blogs describing the basic setup and things like that. But I felt input

[ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

In an ovn gateway node with DPDK, the RECIRC_DEPTH may be greater than 5. Scenes: VM ping self floating IP, or VM ping Floating IP of VMs with the same network. It need process UNDNAT SNAT in LRouter egress and UNSNAT DNAT in LRouter ingress, and output to geneve tunnel also need recirc. This

Re: [ovs-dev] adding dpdk ports sharing same pci address to ovs-dpdk bridge

On 9/19/17, 8:48 AM, "Darrell Ball" wrote: On 9/19/17, 8:22 AM, "Loftus, Ciara" wrote: > On 09/19/2017 08:58 AM, Loftus, Ciara wrote: > >> Thanks for confirming Devendra > >>

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

On Tue, Sep 19, 2017 at 9:38 AM, Russell Bryant wrote: > On Mon, Sep 18, 2017 at 7:31 PM, Han Zhou wrote: >> Thanks Russell for the quick work! >> >> On Mon, Sep 18, 2017 at 8:24 AM, Russell Bryant wrote: >> >>> @@ -301,6 +305,22 @@

[ovs-dev] [PATCH 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

This patch enhances dpif-netdev-perf to detect iterations with suspicious statistics according to the following criteria: - iteration lasts longer than US_THR microseconds (default 250). This can be used to capture events where a PMD is blocked or interrupted for such a period of time that

[ovs-dev] [PATCH 0/3]: dpif-netdev: Detailed PMD performance metrics and supervision

The run-time performance of PMDs is often difficult to understand and trouble-shoot. The existing PMD statistics counters only provide a coarse grained average picture. At packet rates of several Mpps sporadic drops of packet bursts happen at sub-millisecond time scales and are impossible to

[ovs-dev] [PATCH 2/3] dpif-netdev: Detailed performance stats for PMDs

This patch instruments the dpif-netdev datapath to record detailed statistics of what is happening in every iteration of a PMD thread. The covered metrics per iteration are: - cycles - packets - (rx) batches - packets/batch - max. vhostuser qlen - upcalls - cycles spent in upcalls

Re: [ovs-dev] adding dpdk ports sharing same pci address to ovs-dpdk bridge

On 9/19/17, 8:22 AM, "Loftus, Ciara" wrote: > On 09/19/2017 08:58 AM, Loftus, Ciara wrote: > >> Thanks for confirming Devendra > >> > >> Adding Ciara > >> There have been some offline discussions regarding the issue. > >

Re: [ovs-dev] adding dpdk ports sharing same pci address to ovs-dpdk bridge

On 09/19/2017 08:58 AM, Loftus, Ciara wrote: >> Thanks for confirming Devendra >> >> Adding Ciara >> There have been some offline discussions regarding the issue. > > The workaround discussed is a patch to enable backwards compatibility with > the old port IDs. Something like the following: > >

[ovs-dev] Bug Tracking Software Users List

Hello there, I would like to know if you are interested in acquiring Bug Tracking Software Users List. Some Bug Tracking Software Users Like: Zoho Projects, CaseCamp.com, QuickBase, Bugzilla, MantisBT, devZing, Axosoft, IBM Rational, ServiceNow Security Operations, BugAware, and many more...

Re: [ovs-dev] [PATCH] ovn-northd: add chassis nonull check

On Tue, Sep 19, 2017 at 5:49 AM, wrote: > op->sb->gateway_chassis[0]->chassis may null in some special cases, need > to add a check to avoid segment fault. > > Signed-off-by: wang qianyu Thanks! I applied this to master and branch-2.8. It looks

[ovs-dev] [PATCH] ofp-util: Fix buffer overread in ofputil_decode_bundle_add().

A buffer overread of up to 4 bytes was possible given a malformed message. The message was discarded following the overread. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 3 +++ 1 file changed, 3 insertions(+) diff

  1   2   >