Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Fri, Nov 17, 2017 at 03:51:34PM -0200, Flavio Leitner wrote: > No functional change, just fixing coding style. > > Signed-off-by: Flavio Leitner I see from the thread that there's some controversy here. I think that there are two aspects to it: technical and nontechnical.

[ovs-dev] [patch v1 3/4] conntrack: Disable algs by default.

Presently, alg processing is enabled by default to exercise testing. This is similar to kernels before 4.7. The recommended default behavior in the kernel is to only process algs if a helper is supplied in a conntrack rule. The behavior is changed to match the later kernels. Signed-off-by:

[ovs-dev] [patch v1 1/4] conntrack: Some formatting improvements.

Fix up some instances where variable declarations were not close enough to their use, as these were missed before. This is the preferred art in OVS code and flagged heavily in code reviews. This is highly desirable due to code clarity reasons. There are also some cases where newlines were not

[ovs-dev] [patch v1 4/4] conntrack: Change established state to match kernel.

Presently, the userpace connection tracker 'established' packet state diverges from the kernel and this patch brings them in line. The behavior is now that 'established' is only possible after a reply packet is seen. The previous behavior is hard to notice when rules are written to commit a

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Fri, Nov 17, 2017 at 07:34:49PM +, Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents > its own coding guidelines. > > 1/OVS prefers variable declarations near their usage and your patch violates > extensively. > Most of this patch is

Re: [ovs-dev] [ovs-discuss] Conntrack issue in OVS (2.6)+DPDK

Hi Jan As discussed and agreed at OVSCON, I submitted a patch to bring the userspace connection tracker established state In line with that of the kernel. I used a similar patch to what I earlier suggested earlier in this thread, adding a test and also made some documentation updates. Some of

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On Sat, 18 Nov 2017 00:41:27 + Darrell Ball wrote: > On 11/17/17, 3:01 PM, "Flavio Leitner" wrote: > > On Fri, 17 Nov 2017 19:34:49 + > Darrell Ball wrote: > > > This patch mostly breaks OVS coding style in many

[ovs-dev] Grüße

Grüße Ich bin Herr James Kross, ein Rechtsanwalt in der UK.I ich erreichen zu Ihnen in Bezug auf eine Investitionsmöglichkeit. Ich erbitten Ihre Hilfe bei der Rückführung der Gelder und die Eigenschaften links von meinem verstorbenen Kunden, bevor sie un-brauchbar von der Bank, wo die

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On 11/19/17, 10:25 AM, "Flavio Leitner" wrote: On Sat, 18 Nov 2017 00:41:27 + Darrell Ball wrote: > On 11/17/17, 3:01 PM, "Flavio Leitner" wrote: > > On Fri, 17 Nov 2017 19:34:49 + > Darrell

[ovs-dev] [patch v1 2/4] conntrack: Refactor algs.

Upcoming requirements for new algs make it necessary to split out alg helper more cleanly. Signed-off-by: Darrell Ball --- lib/conntrack.c | 73 ++--- 1 file changed, 44 insertions(+), 29 deletions(-) diff --git

[ovs-dev] [patch v1 0/4] conntrack: Improvements and fixes.

There are 3 main changes: Bring the userpace connection tracker 'established' state in line with the kernel. Disable alg processing by default and only allow it if the alg helper is supplied in the conntrack commit rule. There is also some refactoring to more cleanly splice out alg

Re: [ovs-dev] [PATCH] odp-execute: Bug Fix - missing break statement for CLONE action

Hi, Do any one sees issues with this patch ? If let loose, it may create issues once we have implementation of METER. Warm Regards, Vishal From: Vishal Deep Ajmera Sent: Thursday, November 09, 2017 3:45 PM To: d...@openvswitch.org Subject: [PATCH] odp-execute: Bug Fix - missing break statement

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

On 11/19/17, 11:18 AM, "Ben Pfaff" wrote: On Fri, Nov 17, 2017 at 07:34:49PM +, Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents its own coding guidelines. > > 1/OVS prefers variable declarations near their