[ovs-dev] [PATCH v3 6/6] netdev-linux: fail ops not supporting remote netns.

When the netdev is in another namespace and the operation doesn't support network namespaces, return the correct error. Signed-off-by: Flavio Leitner --- lib/netdev-linux.c | 134 +++-- 1 file changed, 120 insertions(+), 14

[ovs-dev] [PATCH v3 5/6] nlmon: added netns support.

Signed-off-by: Flavio Leitner --- utilities/nlmon.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/utilities/nlmon.c b/utilities/nlmon.c index d38a70b6f..448b5eb5d 100644 --- a/utilities/nlmon.c +++ b/utilities/nlmon.c @@ -25,6 +25,7 @@ #include

Re: [ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

On 12/6/17, 6:49 PM, "王志克" wrote: Hi Darrell, In fact I indeed considerred whether to keep partial check as your patch. My idea is that it is better to do as little work as possible. So in my opnion such validation (and even checksum validation and so on) is

Re: [ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

Hi Darrell, In fact I indeed considerred whether to keep partial check as your patch. My idea is that it is better to do as little work as possible. So in my opnion such validation (and even checksum validation and so on) is not necessary at all (OVS is middle device, and such error validation

[ovs-dev] [patch v1] conntrack: Fix icmp error address sanity check.

An address sanity check is done on icmp error packets to check that the icmp error payload makes sense w.r.t. the packet itself. The sanity check was partially incorrect since it tried to verify the source address of the error packet against the original destination, which does not makes since

Re: [ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

Hi Wang To speed up the process, I sent an alternative patch here: https://patchwork.ozlabs.org/patch/845407/ I agree the address sanity check is not correct but I think it should be partially retained rather than removed. I also think a test was needed. Pls let me know if it makes sense.

[ovs-dev] [PATCH] dpctl: Fix comment describing get_one_dp().

Signed-off-by: Justin Pettit --- lib/dpctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 06cfbc4abf21..5e064ec9c100 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -129,8 +129,8 @@ if_up(struct netdev *netdev) } /*

[ovs-dev] [PATCH v3 1/6] netlink: provide network namespace id from a msg.

The netlink notification's ancillary data contains the network namespace id (netnsid) needed to identify the device correctly. Signed-off-by: Flavio Leitner --- configure.ac | 3 +- lib/automake.mk| 1 + lib/dpif-netlink.c | 6 +-- lib/netdev-linux.c

[ovs-dev] [PATCH v3 4/6] netlink linux: enable listening to all nsids

Internal ports may be moved to another network namespace and when that happens, the vswitch stops receiving netlink notifications. This patch enables the vswitch to listen to all network namespaces that have a nsid assigned into the network namespace where the socket has been opened. It requires

[ovs-dev] [PATCH v3 2/6] netnsid: update device only if netnsid matches.

Recent kernels provide the network namespace ID of a port, so use that to discover where the port currently is. A network device in another network namespace could have the same name, so once the socket starts listening to other network namespaces, it is necessary to confirm the netnsid.

[ovs-dev] [PATCH v3 3/6] netdev-linux: use netlink to update netdev.

The ioctl interface doesn't support network namespaces, so try updating the netdev using netlink message instead. To provide backwards compatibility, fall back to the previous method if netlink isn't supported or fails. Signed-off-by: Flavio Leitner --- lib/netdev-linux.c |

[ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

Today Open vSwitch doesn't know about network namespaces (netns), but users are moving internal ports to other namespaces. Although packets are still flowing, the daemon fails to find out basic port information, like if it is UP or DOWN, for instance. This patchset rely on a new kernel vport API

Re: [ovs-dev] [PATCH v2 3/3] dpctl: Support flush conntrack by conntrack 5-tuple

> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote: > diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c > index 5cd6b5cfd870..3cad5c928e8b 100644 > --- a/lib/ct-dpif.c > +++ b/lib/ct-dpif.c > > @@ -434,3 +435,110 @@ ct_dpif_format_tcp_stat(struct ds * ds, int tcp_state, > int

[ovs-dev] TCP checksum errors from conntrack on padded packets

On a system running a 3.10-derived kernel along with out-of-tree OVS from around May 2017, we're getting "nf_ct_tcp: bad TCP checksum" errors when handling network traffic from certain applications on another system. One thing all the error packets have in common is that they are short. With a

Re: [ovs-dev] [PATCH 2/2] tests: Use $(MKDIR_P) instead of mkdir -p.

On Wed, Dec 06, 2017 at 09:42:35AM -0800, Gregory Rose wrote: > On 12/5/2017 4:27 PM, Ben Pfaff wrote: > >It is more portable. > > > >Signed-off-by: Ben Pfaff > >--- > > tests/automake.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git

Re: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist DPDK physical ports.

Thank you Billy for the review. Please find below my reply. Regards _Sugesh > -Original Message- > From: O Mahony, Billy > Sent: Wednesday, December 6, 2017 5:31 PM > To: Chandran, Sugesh ; d...@openvswitch.org; > b...@ovn.org > Subject: RE: [ovs-dev] [PATCH

Re: [ovs-dev] [patch v3 1/3] conntrack: Refactor algs.

Darrell Ball writes: > Upcoming requirements for new algs make it desirable to split out > alg helpers more cleanly. > > Signed-off-by: Darrell Ball > --- Acked-by: Aaron Conole ___ dev mailing

Re: [ovs-dev] [patch v3 2/3] conntrack: Allow specified alg port numbers.

Darrell Ball writes: > Algs can use variable control port numbers for servers. > The main use case is a kind of feeble security measure; the > thinking being by some is that it obscures the alg traffic. > It is really not very effective, but the kernel has this > capability.

Re: [ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

Thanks for looking at this. In the commit message, can you delineate. 1/ The forward direction packet in terms of src ip, dest ip, L4 attributes 2/ The reverse direction error packet in terms of src ip, dest ip, icmp error payload Darrell On 12/4/17, 10:22 PM, "ovs-dev-boun...@openvswitch.org

Re: [ovs-dev] [patch v3 3/3] conntrack: Disable algs by default.

Darrell Ball writes: > Presently, alg processing is enabled by default to better exercise code. > This is similar to kernels before 4.7 as well. The recommended default > behavior in the newer kernels is to only process algs if a helper is > supplied in a conntrack rule. The

[ovs-dev] Topquality Irish Mackerels

Deze email nieuwsbrief werd in grafisch HTML formaat verzonden. Als u deze tekstversie ziet, verkiest uw email programma "gewone tekst" emails. U kan de originele nieuwsbrief online bekijken:

[ovs-dev] Un traje a la medida de sus necesidades y finanzas

Una útil herramienta jurídica para sus necesidades personales y comerciales vial Fideicomisos en México 11 de Diciembre - Dr. Eduardo Rocha Núñez 9am-6pm Usted puede obtener numerosos beneficios económicos con la constitución e implementación de un fideicomiso, un instrumento legislativo y

Re: [ovs-dev] [patch v3 3/3] conntrack: Disable algs by default.

Thanks for the reviews Aaron. Darrell On 12/6/17, 11:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron Conole" wrote: Darrell Ball writes: > Presently, alg processing is enabled by

[ovs-dev] [PATCH branch-2.8 v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

From: Lucas Alvares Gomes The external_ids column is missing from the NAT and Logical_Router_Static_Route tables. As discussed at [0] the change to the schema for this backport should leave the version number unmodified. [0]

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

Hi, Thanks a lot Russell and Ben for this email. Having this change in the 2.8 will make certain things *a lot* easier in networking-ovn. I will go ahead and propose a patch for the 2.8 branch then. Cheers, Lucas On Tue, Dec 5, 2017 at 7:20 PM, Ben Pfaff wrote: > I don't object

Re: [ovs-dev] [PATCH V4 1/2] netdev-dpdk: DPDK v17.11 upgrade

I tested this patch series together with my PMD Performance Metrics and Supervision patch (https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/341099.html) and it worked out of the box. The new rte_vhost API call introduced in DPDK 17.08 my patch uses to read the vhostuser queue

Re: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist DPDK physical ports.

Hi Sugesh, This is definitely a very useful feature. I'm looking forward to running trex on the same DUT as my ovs-dpdk. However I'd suggest adding an sscanf or some such to verify that the domain is also specified for each whitelist member. And either add the default of '' or complain

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Justin Pettit > Sent: Tuesday, December 5, 2017 9:30 AM > To: d...@openvswitch.org; Alin Gabriel Serdean ; > Sairam Venugopal >

Re: [ovs-dev] [PATCH 2/2] tests: Use $(MKDIR_P) instead of mkdir -p.

On 12/5/2017 4:27 PM, Ben Pfaff wrote: It is more portable. Signed-off-by: Ben Pfaff --- tests/automake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/automake.mk b/tests/automake.mk index c5cc95251207..ad5362ff1f5b 100644 --- a/tests/automake.mk

Re: [ovs-dev] [PATCH 1/2] tests: Use $(MKDIR_P) to avoid races.

On 12/5/2017 4:27 PM, Ben Pfaff wrote: "test -d x || mkdir x" has a race when invoked in parallel: it is possible for two processes to both see that 'x' does not exist and both try to create it, and if that happens then one of them will fail. This avoids the problem. Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

On Wed, Dec 06, 2017 at 11:57:48AM +, Vishal Deep Ajmera wrote: > Hi Ben,> From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 05, 2017 12:52 AM > To: Vishal Deep Ajmera > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH]

[ovs-dev] Sale Fresh Water Shrimps HLSO

If you are not able to see this mail, click http://r.newsletter.bonescamail.nl/7xa28kqjioatrf.html  [ ]( http://r.newsletter.bonescamail.nl/track/click/vp48yay5paoatrd )    SALE OFF :   Fresh water Shrimps block HLSO 6 x 1,4 kg 50% Origin: Bangladesh Expiry: December 2018   Prices :   U5 = €

[ovs-dev] [PATCH] Configurable Link State Change (LSC) detection mode

It is possible to set LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. Global settings Service restart is necessary for the global settings to take effect. Command to set

Re: [ovs-dev] [PATCH 2/2] xlate: normalize the actions after translation

Hello Ben, I added 'const' to the ctx members to be copied during backup in order to see how big the code impact would be in case of using copy-on-write like method as you proposed when we were talking about this problem in a conference break. Actually there were more than 80 places indicated by

[ovs-dev] [PATCH v2 2/2] xlate: normalize the actions after translation

When all OF actions have been translated, there could be actions at the end of list of odp actions which are not needed to be executed. So, the list can be normalized at the end of xlate_actions(). Signed-off-by: Zoltan Balogh Signed-off-by: Sugesh Chandran

Re: [ovs-dev] [PATCH 2/2] xlate: normalize the actions after translation

Subject is incorrect, missing v2. Please use this instead: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341658.html > -Original Message- > From: Zoltán Balogh > Sent: Wednesday, December 06, 2017 11:55 AM > To: d...@openvswitch.org > Cc: Zoltán Balogh

[ovs-dev] Ademe / Okra / Pondu / Attieke / Placali

If you are not able to see this mail, click http://r.newsletter.bonescamail.nl/7xa28koymoatrf.html      New arrivals :   Egypt: 8666 Frozen Okra Zero/Gombo 20 x 400g € 0,99 per pack 8674 Frozen Molokhia / Ewedu / Krain / Ademe 20 x 400g € 0,89 per pack   Ivory Coast: 8722 Attieke / Cassava

Re: [ovs-dev] [PATCH] Configurable Link State Change (LSC) detection mode

Hi Ilya, Thank you for the comments, I try to refactor the code according to them. Regards, Robert -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Wednesday, December 06, 2017 12:40 PM To: ovs-dev@openvswitch.org; Róbert Mulik

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

Hi Ben, Thank you for reviewing the patch. Please see inline for comments. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Tuesday, December 05, 2017 12:52 AM To: Vishal Deep Ajmera Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH]

[ovs-dev] [PATCH] LACP: Check active partner sys id

A reboot of one switch in an MC-LAG bond makes all bond links to go down, causing a total connectivity loss for 3 seconds. Packet capture shows that spurious LACP PDUs are sent to OVS with a different MAC address (partner system id) during the final stages of the MC-LAG switch reboot. The current

[ovs-dev] [PATCH v2 0/2] xlate: optimize dp flow action in case of error in multi-bridge setup

If several bridges are connected via patch ports or the packet is sent via tunnel and an error occurs during translation in a subsequent bridge, e.g. Ethernet header cannot be pushed to the packet due to lack of prerequisites in the second bridge and there were flow actions already

[ovs-dev] [PATCH v2 1/2] xlate: rollback to valid known state in case of ctx->error on translation

If several bridges are connected via patch ports or the packet is sent via tunnel and an error occurs during translation in a subsequent bridge, e.g. Ethernet header cannot be pushed to the packet due to lack of prerequisites in the second bridge and there were flow actions already translated in

[ovs-dev] [PATCH 2/2] xlate: normalize the actions after translation

When all OF actions have been translated, there could be actions at the end of list of odp actions which are not needed to be executed. So, the list can be normalized at the end of xlate_actions(). Signed-off-by: Zoltan Balogh Signed-off-by: Sugesh Chandran

Re: [ovs-dev] [PATCH] Configurable Link State Change (LSC) detection mode

Hi Robert. Few general comments: If you'll move per-interface config from 'other_config' to 'options' column, you'll be able to localize code changes to only dpdk.c and netdev-dpdk.c. The changes in all other code files are redundant especially because the option could only affect dpdk ports.

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Support conntrack flush by ct 5-tuple

> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote: > > diff --git a/lib/conntrack.c b/lib/conntrack.c > index f5a3aa9fab34..c9077c07042c 100644 > --- a/lib/conntrack.c > +++ b/lib/conntrack.c > @@ -2335,6 +2335,18 @@ ct_endpoint_to_ct_dpif_inet_addr(const struct ct_addr >

Re: [ovs-dev] [PATCH v2] packets: Prefetch the packet metadata in cacheline1.

Tested on Intel Haswell platform and Acked! (Provided there are no performance regression are reported so far on other platforms for various tests too) Regards _Sugesh > -Original Message- > From: Bodireddy, Bhanuprakash > Sent: Monday, December 4, 2017 8:10 PM > To:

Re: [ovs-dev] [PATCH 3/6] datapath: Constify struct nf_conntrack_l4proto

On 12/5/2017 4:01 PM, Greg Rose wrote: Linux 4.14 requires this parameter to be constified. Signed-off-by: Greg Rose --- datapath/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index