Re: [ovs-dev] OVS-DPDK public meeting

2018-11-15 Thread Kevin Traynor
Next meeting 12th December (May cancel if no agenda items as DPDK/OVS confs the previous week) Minutes for 14th November. Attendees: Pieter, Asaf, Timothy, Ophir, Ian, Thomas, David, Matteo, Johann, Aaron, Tiago, Kevin. === GENERAL === - Ian is one of the core committers :-) -- He will

Re: [ovs-dev] [PATCH] coding-style: Remove redundant symbols from the examples.

2018-11-15 Thread Ben Pfaff
On Thu, Nov 15, 2018 at 02:55:35PM +0300, Ilya Maximets wrote: > Some backslashes was added while converting from .md to .rst. > These symbols are printable in both pdf and html docs and > should be removed. > > CC: Stephen Finucane > Fixes: d124a408a4bc ("doc: Convert CodingStyle to rST") >

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Alin Serdean
I applied the patch on master and as far as it goes without conflicts. -- Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Thursday, November 15, 2018 4:52 PM > Către: 'Sairam Venugopal' ;

[ovs-dev] [PATCH] Windows: Fix broken kernel userspace communication

2018-11-15 Thread Alin Gabriel Serdean
Patch: https://github.com/openvswitch/ovs/commit/69c51582ff786a68fc325c1c50624715482bc460 broke Windows userpace - kernel communication. On windows we create netlink sockets when the handlers are initiated and reuse them. This patch remaps the usage of the netlink socket pool. Fixes:

Re: [ovs-dev] [RFC dpdk-latest 2/2] netdev-dpdk: Replace rte_eth_dev_attach/detach.

2018-11-15 Thread Ophir Munk
Hi Kevin, Thanks for this RFC. Please find comments inline. > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, November 08, 2018 8:37 PM > To: d...@openvswitch.org; Ophir Munk ; > ian.sto...@intel.com; i.maxim...@samsung.com > Cc: Kevin Traynor >

Re: [ovs-dev] [PATCH] odp-util: Add checking to prevent buffer overflow when parsing push_nsh

2018-11-15 Thread Ben Pfaff
On Tue, Nov 13, 2018 at 11:25:24AM -0800, Yifeng Sun wrote: > Previously, the buffer size of 'struct ofpbuf b' is less than the > size of 'char buf[512]', this could cause memory overflow of ofpbuf > when calling ofpbuf_put_hex. This patch fixes it. > > Reported-at:

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

2018-11-15 Thread Ben Pfaff
That makes sense. I wish Unix had a delete-on-close flag, it would save a lot of trouble sometimes. On Thu, Nov 15, 2018 at 04:22:59PM +, Alin Serdean wrote: > Thanks for the suggestion Ben. > > I was thinking about changing the regular open to a CreateFile on > Windows with the flag: > ` >

Re: [ovs-dev] [RFC v2 dpdk-latest 1/2] netdev-dpdk: Update for DPDK CRC strip flags change.

2018-11-15 Thread Ophir Munk
> -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent: Wednesday, November 14, 2018 3:16 PM > To: Kevin Traynor ; d...@openvswitch.org; Ophir > Munk ; i.maxim...@samsung.com > Cc: Christian Ehrhardt > Subject: RE: [RFC v2 dpdk-latest 1/2] netdev-dpdk: Update for

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

2018-11-15 Thread Alin Serdean
Thanks for the suggestion Ben. I was thinking about changing the regular open to a CreateFile on Windows with the flag: ` FILE_FLAG_DELETE_ON_CLOSE 0x0400 The file is to be deleted immediately after all of its handles are closed, which includes the specified handle and any other open or

Re: [ovs-dev] [PATCH] pcap-file: Add support for Linux SLL formatted PCAP files.

2018-11-15 Thread Ben Pfaff
Thanks, applied to master. On Mon, Nov 12, 2018 at 11:09:37AM -0800, Yifeng Sun wrote: > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun > > On Sun, Nov 11, 2018 at 3:41 PM Ben Pfaff wrote: > > > Someone sent me one of these and OVS couldn't read it. This fixes the > > problem. > > >

Re: [ovs-dev] [PATCH] docs: Fix cross-references that referred to discussions that have moved.

2018-11-15 Thread Ben Pfaff
Thanks, applied to master. On Mon, Nov 12, 2018 at 09:58:19AM -0800, Yifeng Sun wrote: > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun > > On Thu, Nov 8, 2018 at 9:39 PM Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > include/openvswitch/meta-flow.h | 4 ++-- > >

Re: [ovs-dev] [PATCH] oss-fuzz: Fix memory leak in ofctl_parse_flow

2018-11-15 Thread Ben Pfaff
On Wed, Nov 14, 2018 at 03:14:05PM -0800, Yifeng Sun wrote: > If parse_ofp_flow_mod_str returns no error, ofputil_flow_mod.match > contains allocated memory that should be free. This patch fixes it. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11343 > Signed-off-by:

[ovs-dev] [PATCH] configure: Check for more specific function to pull in pthread library.

2018-11-15 Thread Ben Pfaff
On my laptop, pthread_create() is always available without -lpthread, but when I use -fsanitize=address, -lpthread is required to pull in other threading functions such as pthread_rwlock_tryrdlock(). Thus, with -fsanitize=address I have to manually add -lpthread to link commands one way or

Re: [ovs-dev] ofp-actions: Make all actions a multiple of OFPACT_ALIGNTO bytes.

2018-11-15 Thread Ben Pfaff
On Thu, Nov 15, 2018 at 02:10:23AM -0500, 0-day Robot wrote: > Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: >

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread aserdean
Thanks for the fix! Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Sairam Venugopal > Trimis: Wednesday, November 14, 2018 10:07 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

2018-11-15 Thread Ben Pfaff
On Thu, Nov 15, 2018 at 03:23:28PM +0200, aserd...@ovn.org wrote: > I have opened an issue for it: > https://github.com/openvswitch/ovs-issues/issues/165 > > It's not test specific unfortunately. The file is put up for unlink on exit, > but I'm guessing > someone still has an opened handle at

Re: [ovs-dev] [RFC v2 dpdk-latest 1/2] netdev-dpdk: Update for DPDK CRC strip flags change.

2018-11-15 Thread Kevin Traynor
On 11/15/2018 04:40 PM, Ophir Munk wrote: > > >> -Original Message- >> From: Stokes, Ian [mailto:ian.sto...@intel.com] >> Sent: Wednesday, November 14, 2018 3:16 PM >> To: Kevin Traynor ; d...@openvswitch.org; Ophir >> Munk ; i.maxim...@samsung.com >> Cc: Christian Ehrhardt >> Subject:

Re: [ovs-dev] [PATCH] Windows: Fix broken kernel userspace communication

2018-11-15 Thread Ben Pfaff
On Thu, Nov 15, 2018 at 06:42:38PM +0200, Alin Gabriel Serdean wrote: > Patch: > https://github.com/openvswitch/ovs/commit/69c51582ff786a68fc325c1c50624715482bc460 > broke Windows userpace - kernel communication. > > On windows we create netlink sockets when the handlers are initiated and >

[ovs-dev] [PATCH] dpif-netlink: Fix error behavior in dpif_netlink_port_add__().

2018-11-15 Thread Ben Pfaff
Until now, the code here would report an error to its caller as success. This fixes the problem. Found by inspection. Signed-off-by: Ben Pfaff --- lib/dpif-netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

2018-11-15 Thread aserdean
Applied on master, branch-2.10, branch-2.9. -- Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Thursday, November 15, 2018 3:23 PM > Către: 'Sairam Venugopal' ; 'Alin Gabriel Serdean' > ;

Re: [ovs-dev] OVS-DPDK public meeting

2018-11-15 Thread Eelco Chaudron
On 15 Nov 2018, at 15:18, Kevin Traynor wrote: Next meeting 12th December (May cancel if no agenda items as DPDK/OVS confs the previous week) Minutes for 14th November. Attendees: Pieter, Asaf, Timothy, Ophir, Ian, Thomas, David, Matteo, Johann, Aaron, Tiago, Kevin. === GENERAL ===

Re: [ovs-dev] [PATCH] ovsdb: Clarify that a server that leaves a cluster may never rejoin.

2018-11-15 Thread Ben Pfaff
I found and fixed some bugs in the Raft implementation. The patch series is currently waiting for review: https://patchwork.ozlabs.org/project/openvswitch/list/?series=76115 On Fri, Nov 09, 2018 at 04:22:51PM +, Paul Greenberg wrote: > Hi Ben, > > The issues are sporadic. I got

Re: [ovs-dev] [PATCH v3] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-11-15 Thread Ben Pfaff
On Thu, Nov 15, 2018 at 11:07:11AM -0800, Han Zhou wrote: > From: Han Zhou > > When adding a new chassis, if there is an old chassis with same IP > existed in Encap table, it is allowed to be added today. However, > allowing it to be added results in problems: > > 1. The new chassis cannot work

Re: [ovs-dev] [PATCH] Windows: Fix broken kernel userspace communication

2018-11-15 Thread Alin Serdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, November 15, 2018 7:12 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Windows: Fix broken kernel userspace >

Re: [ovs-dev] [ovs-dev, dpdk-latest, v1] netdev-dpdk: Upgrade to dpdk v18.11

2018-11-15 Thread Kevin Traynor
On 11/15/2018 07:07 AM, Ilya Maximets wrote: > Hmm. > Kevin already has a patch-set with the same purpose: > https://patchwork.ozlabs.org/project/openvswitch/list/?series=75100 > > This patch-set already has some review comments. You can make your > comments too. > > Anyway, Kevin, Ophir,

[ovs-dev] [v3 dpdk-latest 2/3] netdev-dpdk: Replace rte_eth_dev_attach/detach.

2018-11-15 Thread Kevin Traynor
rte_eth_dev_attach/detach have been removed from DPDK 18.11. Replace them with rte_dev_probe/remove. Signed-off-by: Kevin Traynor --- lib/netdev-dpdk.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index

Re: [ovs-dev] Windows: Fix broken kernel userspace communication

2018-11-15 Thread Alin Serdean
Yup in a couple of hours. Sent from phone > On 15 Nov 2018, at 20:27, 0-day Robot wrote: > > Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details

[ovs-dev] [v3 dpdk-latest 0/3] Update to DPDK 18.11-rc3

2018-11-15 Thread Kevin Traynor
Sharing minimal set of changes to enable OVS to work with DPDK 18.11-rc3. - No docs yet as they mainly point at the release tarball. - Split out to ease review but they should be squashed for a merge, or I can respin. v3: - Removed RFC as I think there are a candidate for dpdk-latest. - 1/3

Re: [ovs-dev] Windows: Fix broken kernel userspace communication

2018-11-15 Thread 0-day Robot
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Windows: Fix broken kernel userspace

[ovs-dev] [v3 dpdk-latest 1/3] netdev-dpdk: Update for DPDK CRC strip flags change.

2018-11-15 Thread Kevin Traynor
DEV_RX_OFFLOAD_CRC_STRIP has been removed from DPDK 18.11. DEV_RX_OFFLOAD_KEEP_CRC can now be used to keep the CRC. Use the correct flag and check it is supported. Signed-off-by: Kevin Traynor --- lib/netdev-dpdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Sairam Venugopal
Is it too late to backport this to 2.10? On 11/15/18, 7:03 AM, "Alin Serdean" wrote: I applied the patch on master and as far as it goes without conflicts. -- Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Ben Pfaff
Alin already did that. On Thu, Nov 15, 2018 at 06:40:00PM +, Sairam Venugopal wrote: > Is it too late to backport this to 2.10? > > On 11/15/18, 7:03 AM, "Alin Serdean" wrote: > > I applied the patch on master and as far as it goes without conflicts. > > -- > Alin. >

[ovs-dev] [v3 dpdk-latest 3/3] travis: Update to use DPDK 18.11-rc3.

2018-11-15 Thread Kevin Traynor
Signed-off-by: Kevin Traynor --- .travis/linux-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index 4c9e95201..a402b1a85 100755 --- a/.travis/linux-build.sh +++ b/.travis/linux-build.sh @@ -84,5 +84,5 @@ fi if [

Re: [ovs-dev] [PATCH] dpif-netlink: Fix error behavior in dpif_netlink_port_add__().

2018-11-15 Thread Ben Pfaff
Thanks, applied and backported. On Thu, Nov 15, 2018 at 07:27:11PM +0200, aserd...@ovn.org wrote: > Acked-by: Alin Gabriel Serdean > > > > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff > > Trimis: Thursday, November 15, 2018

Re: [ovs-dev] [PATCH v2] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-11-15 Thread Han Zhou
On Thu, Nov 15, 2018 at 9:24 AM Ben Pfaff wrote: > > On Tue, Nov 13, 2018 at 11:25:59AM -0800, Han Zhou wrote: > > From: Han Zhou > > > > When adding a new chassis, if there is an old chassis with same IP > > existed in Encap table, it is allowed to be added today. However, > > allowing it to be

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15 Thread Sairam Venugopal
Thanks! On 11/15/18, 10:45 AM, "Ben Pfaff" wrote: Alin already did that. On Thu, Nov 15, 2018 at 06:40:00PM +, Sairam Venugopal wrote: > Is it too late to backport this to 2.10? > > On 11/15/18, 7:03 AM, "Alin Serdean" wrote: > > I applied the patch

Re: [ovs-dev] [PATCH v2] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-11-15 Thread Ben Pfaff
On Tue, Nov 13, 2018 at 11:25:59AM -0800, Han Zhou wrote: > From: Han Zhou > > When adding a new chassis, if there is an old chassis with same IP > existed in Encap table, it is allowed to be added today. However, > allowing it to be added results in problems: > > 1. The new chassis cannot work

Re: [ovs-dev] [RFC dpdk-latest 2/2] netdev-dpdk: Replace rte_eth_dev_attach/detach.

2018-11-15 Thread Kevin Traynor
On 11/15/2018 04:38 PM, Ophir Munk wrote: > Hi Kevin, > Thanks for this RFC. Please find comments inline. > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Thursday, November 08, 2018 8:37 PM >> To: d...@openvswitch.org; Ophir Munk ; >>

Re: [ovs-dev] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-11-15 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #38 FILE: NEWS:13: user can

[ovs-dev] OVN multicast enhancements

2018-11-15 Thread Mark Michelson
Hi everyone, In today's IRC meeting I brought up the fact I was enhancing multicast support in OVN, and I was asked to expand on this a bit. So here are details about what all I am working on. Right now, OVN logical switches treat all multicast destinations as if they were broadcast. That

Re: [ovs-dev] [PATCH v3] ovn-sb.ovsschema: Avoid duplicated IPs in Encap table.

2018-11-15 Thread Han Zhou
On Thu, Nov 15, 2018 at 11:31 AM Ben Pfaff wrote: > > On Thu, Nov 15, 2018 at 11:07:11AM -0800, Han Zhou wrote: > > From: Han Zhou > > > > When adding a new chassis, if there is an old chassis with same IP > > existed in Encap table, it is allowed to be added today. However, > > allowing it to

Re: [ovs-dev] [PATCH 1/2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-11-15 Thread Guru Shetty
On Fri, 5 Oct 2018 at 10:15, wrote: > From: Numan Siddique > > An OVN deployment can have multiple logical switches each with a > localnet port connected to a distributed logical router with one > logical router port providing external connectivity (provider network) > and others used as tenant

Re: [ovs-dev] [RFC dpdk-latest 2/2] netdev-dpdk: Replace rte_eth_dev_attach/detach.

2018-11-15 Thread Stokes, Ian
> On 11/15/2018 04:38 PM, Ophir Munk wrote: > > Hi Kevin, > > Thanks for this RFC. Please find comments inline. > > > >> -Original Message- > >> From: Kevin Traynor [mailto:ktray...@redhat.com] > >> Sent: Thursday, November 08, 2018 8:37 PM > >> To: d...@openvswitch.org; Ophir Munk ; > >>

Re: [ovs-dev] (no subject)

2018-11-15 Thread Spende via dev
$500,000 wurden Ihnen von Ann-Marie Francis und Ian Warcup gespendet. Antwort für weitere Informationen: annwithian.foundationh...@gmail.com $500,000 has been donated to you by Ann-Marie Francis and Ian Warcup. reply for more info: annwithian.foundationh...@gmail.com Thanks

Re: [ovs-dev] VLAN tenant network patches

2018-11-15 Thread Miguel Angel Ajo Pelayo
Thanks for looking at this and keeping it moving forward. I'm also fine with both ways of implementing the feature, and of course, having distributed E/W for VLAN is great, It'd be amazing, based on not duplicating interfaces, that the implementations don't interfere each other, and that numan's

[ovs-dev] [PATCH] coding-style: Remove redundant symbols from the examples.

2018-11-15 Thread Ilya Maximets
Some backslashes was added while converting from .md to .rst. These symbols are printable in both pdf and html docs and should be removed. CC: Stephen Finucane Fixes: d124a408a4bc ("doc: Convert CodingStyle to rST") Signed-off-by: Ilya Maximets ---

Re: [ovs-dev] VLAN tenant network patches

2018-11-15 Thread Ankur Sharma
Hi Miguel, Thanks a lot for the clarification, sounds good to me. Hi Guru, Yes, Implementation will be generic (not specific to a particular use case) and should be seen as enhancement. Regards, Ankur From: Miguel Angel Ajo Pelayo Sent: Thursday, November 15,

[ovs-dev] Regalos empresariales

2018-11-15 Thread Maderpak via dev
ENVASES DE MADERA PARA TUS PRODUCTOS   ( https://maderpak.com/ ) Maderpak SA aporta envases en la actualidad para los requerimientos de packaging, envoltorio, conservación, transporte o guardado de áreas muy amplias y diversificadas. ¿Buscas bajar costos en el packaging de tus productos? VER

Re: [ovs-dev] [PATCH 1/2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-11-15 Thread Guru Shetty
On Fri, 5 Oct 2018 at 10:15, wrote: > From: Numan Siddique > > An OVN deployment can have multiple logical switches each with a > localnet port connected to a distributed logical router with one > logical router port providing external connectivity (provider network) > and others used as tenant