Re: [ovs-dev] [patch v1] conntrack: Fix FTP seq_skew boundary adjustments.

Hello, On Wed, Jan 9, 2019 at 4:44 AM Darrell Ball wrote: > Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") > Signed-off-by: Darrell Ball > --- > > Backport to 2.8. > > lib/conntrack.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On Thu, Jan 10, 2019 at 10:32 AM Lam, Tiago wrote: > On 10/01/2019 09:12, David Marchand wrote: > > On Thu, Jan 10, 2019 at 10:11 AM David Marchand > > mailto:david.march...@redhat.com>> wrote: > > > > This part triggers build (non fatal o_O) warnings on fedora 28. > > > > > > Oops,

[ovs-dev] [PATCH 0/2] Do not rewrite fields with the same values as

Hi This patch set avoids unnecessary rewrite actions to fields with the same values as matched on. Patch 1 is a pre-step by defining ovs key structs using macros Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly Travis link:

[ovs-dev] [PATCH 1/2] datapath: Declare ovs key structures using macros

Declare ovs key structures using macros as a pre-step of retrieving field information, with no functional change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- build-aux/extract-odp-netlink-h | 3 +- datapath/linux/compat/include/linux/openvswitch.h | 102

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On Thu, Jan 10, 2019 at 10:11 AM David Marchand wrote: > This part triggers build (non fatal o_O) warnings on fedora 28. > Oops, important. This is when building without dpdk support. -- David Marchand ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 3/8] vconn: Allow timout configuration for blocking connection.

On 09.01.2019 23:27, Ben Pfaff wrote: > On Wed, Jan 09, 2019 at 08:28:54PM +0300, Ilya Maximets wrote: >> On 27.12.2018 20:36, Ben Pfaff wrote: >>> On Wed, Dec 26, 2018 at 06:23:56PM +0300, Ilya Maximets wrote: On some systems in case where remote is not responding, socket could remain

Re: [ovs-dev] [PATCH] docs: Fix table title for VM MQ config in dpdk howto.

On 8/31/2018 3:27 PM, Stephen Finucane wrote: On Thu, 2018-08-30 at 17:36 +0100, Cian Ferriter wrote: Found this when searching "BIOS Settings" for use with DPDK. CC: Stephen Finucane Fixes: c50938a24031 ("doc: Convert INSTALL.DPDK-ADVANCED to rST") Signed-off-by: Cian Ferriter Oops.

[ovs-dev] [PATCH 2/2] odp-util: Do not rewrite fields with the same values as matched

To improve performance and avoid wasting resources for HW offloaded flows, do not rewrite fields that are matched with the same value. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- lib/odp-util.c| 110 +- tests/mpls-xlate.at |

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

Hi, 10/01/2019 12:32, Ilya Maximets: > On 08.01.2019 12:31, Ophir Munk wrote: > > if (dev->attached) { > > +/* Remove the port eth device. */ > > rte_eth_dev_close(dev->port_id); > > -rte_eth_dev_info_get(dev->port_id, _info); > > -if (dev_info.device &&

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

On 10.01.2019 16:42, Thomas Monjalon wrote: > Hi, > > 10/01/2019 12:32, Ilya Maximets: >> On 08.01.2019 12:31, Ophir Munk wrote: >>> if (dev->attached) { >>> +/* Remove the port eth device. */ >>> rte_eth_dev_close(dev->port_id); >>> -

[ovs-dev] I would like to have an important discussion with you,

I would like to have an important discussion with you, ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

Hello Tiago, On Thu, Jan 10, 2019 at 1:14 AM Tiago Lam wrote: > Previous commits have added support to the dp_packet API to handle > multi-segmented packets, where data is not stored contiguously in > memory. However, in some cases, it is inevitable and data must be > provided contiguously.

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On 10/01/2019 09:41, David Marchand wrote: > > On Thu, Jan 10, 2019 at 10:32 AM Lam, Tiago > wrote: > > On 10/01/2019 09:12, David Marchand wrote: > > On Thu, Jan 10, 2019 at 10:11 AM David Marchand > > mailto:david.march...@redhat.com> >

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

10/01/2019 15:23, Ilya Maximets: > On 10.01.2019 16:42, Thomas Monjalon wrote: > > Hi, > > > > 10/01/2019 12:32, Ilya Maximets: > >> On 08.01.2019 12:31, Ophir Munk wrote: > >>> if (dev->attached) { > >>> +/* Remove the port eth device. */ > >>>

[ovs-dev] Private Lender Bentex Funding Group Ltd.

Private Lender Bentex Funding Group Ltd. Greetings to you by (BFGL). We are a France-Paris based investment company known as Bentex Funding Group Ltd working on expanding its portfolio globally and financing projects. We would be happy to fund and invest with you in any profitable project if

Re: [ovs-dev] OVS-DPDK public meeting

Next meeting Jan 23 1700 UTC Minutes for 9th January. Attendees: David, Asaf, Flavio, Ian, Tiago, Ophir, Johann, Aaron, Frikkie, Simon, Pieter, Kevin. === GENERAL === - OVS 2.11 -- Release Dates

[ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

Enabling TSO offload allows a host stack to delegate the segmentation of oversized TCP packets to the underlying physical NIC, if supported. In the case of a VM this means that the segmentation of the packets is not performed by the guest kernel, but by the host NIC itself. In turn, since the TSO

[ovs-dev] [PATCH v2 2/3] netdev-dpdk: Consider packets marked for TSO.

Previously, TSO was being explicity disabled on vhost interfaces, meaning the guests wouldn't have TSO support negotiated in. With TSO negotiated and enabled, packets are now marked for TSO, through the PKT_TX_TCP_SEG flag. In order to deal with this type of packets, a new function,

[ovs-dev] [RFC v3 5/5] ovn: Generate ICMPv4 packet in router pipeline for larger packets

From: Numan Siddique Signed-off-by: Numan Siddique --- ovn/northd/ovn-northd.8.xml | 83 +- ovn/northd/ovn-northd.c | 89 ++- tests/ovn.at| 165 3 files changed, 331 insertions(+), 6 deletions(-) diff

[ovs-dev] [RFC v3 4/5] ovn: Support OVS action 'check_pkt_larger' in OVN

From: Numan Siddique Previous commit added a new OVS action 'check_pkt_larger'. This patch supports that action in OVN. The syntax to use this would be reg0[0] = check_pkt_larger(LEN) Upcoming commit will make use of this action in ovn-northd and will generate an ICMP4 packet if the packet

[ovs-dev] "soft freeze" for 2.11

We're now in the "soft freeze" stage for OVS 2.11 development. release-process.txt describes this stage as: 1. "Soft freeze" of the master branch. During the freeze, we ask committers to refrain from applying patches that add new features unless those patches were already being publicly

[ovs-dev] [RFC v3 0/5] Address MTU issue for larger packets in OVN

From: Numan Siddique This is an RFC series to address the MTU issues for OVN reported here [1]. To address this issue, a new OVS action - check_pkt_larger is added. A new datapath action is also added - check_pkt_len. The datapath patch is submitted here to get feedback before submitting to

Re: [ovs-dev] netdev-dpdk: Consider packets marked for TSO.

Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (lib/netdev-dpdk.c). Repository lacks necessary blobs to

[ovs-dev] [PATCH v2 1/3] netdev-dpdk: Validate packets burst before Tx.

Given that multi-segment mbufs might be sent between interfaces that support different capabilities, and may even support different layouts of mbufs, outgoing packets should be validated before sent on the egress interface. Thus, netdev_dpdk_eth_tx_burst() now calls DPDK's rte_eth_tx_prepare()

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: Enable TSO when using multi-seg mbufs

TCP Segmentation Offload (TSO) is a feature which enables the TCP/IP network stack to delegate segmentation of a TCP segment to the hardware NIC, thus saving compute resources. This may improve performance significantly for TCP workload in virtualized environments. While a previous commit already

[ovs-dev] [RFC v3 2/5] Add a new OVS action check_pkt_larger

From: Numan Siddique This patch adds a new action 'check_pkt_larger' which checks if the packet is larger than the given size and stores the result in the destination register. Usage: check_pkt_larger:len->REGISTER Eg. match=...,actions=check_pkt_larger:1442->NXM_NX_REG0[0],next; This patch

Re: [ovs-dev] [PATCH 3/8] vconn: Allow timout configuration for blocking connection.

On Thu, Jan 10, 2019 at 11:44:05AM +0300, Ilya Maximets wrote: > On 09.01.2019 23:27, Ben Pfaff wrote: > > On Wed, Jan 09, 2019 at 08:28:54PM +0300, Ilya Maximets wrote: > >> On 27.12.2018 20:36, Ben Pfaff wrote: > >>> On Wed, Dec 26, 2018 at 06:23:56PM +0300, Ilya Maximets wrote: > On some

Re: [ovs-dev] [PATCH v3] ovn: Support a new Logical_Switch_Port.type - 'external'

On Thu, Dec 20, 2018 at 5:34 AM Numan Siddique wrote: > > > > On Wed, Dec 19, 2018 at 4:23 PM Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: >> >> Oh, if requested chassis matches the chasis of the SRIOV instance, then we don't need HA. Ignore my comments regarding multiple chassis. >> >>

Re: [ovs-dev] [PATCH v3] ovn: Support a new Logical_Switch_Port.type - 'external'

On Fri, Jan 11, 2019 at 12:07 AM Han Zhou wrote: > > > > On Thu, Dec 20, 2018 at 5:34 AM Numan Siddique > wrote: > > > > > > > > On Wed, Dec 19, 2018 at 4:23 PM Miguel Angel Ajo Pelayo < > majop...@redhat.com> wrote: > >> > >> Oh, if requested chassis matches the chasis of the SRIOV instance,

Re: [ovs-dev] [PATCH 2/2] odp-util: Do not rewrite fields with the same values as matched

Hi, When I try to understand this patch, I feel there may be some issue in this loop below. It looks like each loop is doing the same thing. Can you please take a look? +for (i = 0; i < size; i++) +if (memcmp(pkey0, pkey1, size) == 0) +memset(pmask, 0, size);

Re: [ovs-dev] [PATCH v3] ovn: Support a new Logical_Switch_Port.type - 'external'

On Fri, Jan 11, 2019 at 12:09 AM Numan Siddique wrote: > > > On Fri, Jan 11, 2019 at 12:07 AM Han Zhou wrote: > >> >> >> >> On Thu, Dec 20, 2018 at 5:34 AM Numan Siddique >> wrote: >> > >> > >> > >> > On Wed, Dec 19, 2018 at 4:23 PM Miguel Angel Ajo Pelayo < >> majop...@redhat.com> wrote: >>

Re: [ovs-dev] [PATCH v5] ovs:group: support to insert bucket with weight value for select type

On Sun, Jan 06, 2019 at 05:17:34PM +0800, solomon wrote: > After creating a group with hash select type，then we need to insert a new > bucket with weight， Thanks for the patch. I applied this to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v2 1/1] utilities: gdb debug commands fix typos

Thanks Andreas and Eelco, I applied this to master. On Wed, Jan 02, 2019 at 01:32:53PM +0100, Eelco Chaudron wrote: > Thanks Andreas, > > Acked-by: Eelco Chaudron > > On 1 Jan 2019, at 15:34, Andreas Karis wrote: > > > Fix minor typos in ovs_gdb debug script. > > > > Signed-off-by: Andreas

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

> On Aug 30, 2018, at 1:00 PM, Ben Pfaff wrote: > > OpenFlow has a concept of multipart messages, that is, messages that can be > broken into multiple pieces that are sent separately. Before OpenFlow 1.3, > only replies could actually have multiple pieces. OpenFlow 1.3 introduced > the idea

Re: [ovs-dev] [PATCH 1/3] nroff: Increase width for .IP used for ordered lists.

Hi Ben, Excellent new document. This will be great to have in the code. For the series Acked-by: Mark Michelson On 11/9/18 12:39 AM, Ben Pfaff wrote: The ordered lists that a .25in width produced looked OK in PostScript or PDF output, but in text output every list item spanned two lines,

[ovs-dev] [PATCH v4] ovn: Support a new Logical_Switch_Port.type - 'external'

From: Numan Siddique In the case of OpenStack + OVN, when the VMs are booted on hypervisors supporting SR-IOV nics, there are no OVS ports for these VMs. When these VMs sends DHCPv4, DHPCv6 or IPv6 Router Solicitation requests, the local ovn-controller cannot reply to these packets. OpenStack

[ovs-dev] [PATCH v4] Adding support for PMD auto load balancing

Port rx queues that have not been statically assigned to PMDs are currently assigned based on periodically sampled load measurements. The assignment is performed at specific instances – port addition, port deletion, upon reassignment request via CLI etc. Due to change in traffic pattern over time

Re: [ovs-dev] [PATCH v13 03/11] dp-packet: Handle multi-seg mbufs in helper funcs.

On 1/9/2019 6:05 PM, Tiago Lam wrote: Most helper functions in dp-packet assume that the data held by a dp_packet is contiguous, and perform operations such as pointer arithmetic under that assumption. However, with the introduction of multi-segment mbufs, where data is non-contiguous, such

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

On 08.01.2019 12:31, Ophir Munk wrote: > Dpdk port representors were introduced in dpdk versions 18.xx. > Prior to port representors there was a one-to-one relationship > between an rte device (e.g. PCI bus) and an eth device (referenced as > dpdk port id in OVS). With port representors the

Re: [ovs-dev] [PATCH v13 08/11] netdev-dpdk: support multi-segment jumbo frames

On 09.01.2019 21:05, Tiago Lam wrote: > From: Mark Kavanagh > > Currently, jumbo frame support for OvS-DPDK is implemented by > increasing the size of mbufs within a mempool, such that each mbuf > within the pool is large enough to contain an entire jumbo frame of > a user-defined size.

Re: [ovs-dev] [PATCH 2/2] odp-util: Do not rewrite fields with the same values as matched

You are right. I'll fix it. On 1/10/2019 9:35 PM, Yifeng Sun wrote: Hi, When I try to understand this patch, I feel there may be some issue in this loop below. It looks like each loop is doing the same thing. Can you please take a look? +for (i = 0; i < size; i++) +if

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

On Fri, Jan 11, 2019 at 05:09:45AM +, Justin Pettit wrote: > > > On Jan 10, 2019, at 9:02 PM, Ben Pfaff wrote: > > > >> On Fri, Jan 11, 2019 at 01:56:01AM +, Justin Pettit wrote: > >> > >>> On Jan 10, 2019, at 4:03 PM, Ben Pfaff wrote: > >>> > >>> Thanks. I applied this to master. >

[ovs-dev] [PATCH V2 2/2] odp-util: Do not rewrite fields with the same values as matched

To improve performance and avoid wasting resources for HW offloaded flows, do not rewrite fields that are matched with the same value. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- lib/odp-util.c| 109 +- tests/mpls-xlate.at |

[ovs-dev] [PATCH V2 1/2] datapath: Declare ovs key structures using macros

Declare ovs key structures using macros as a pre-step of retrieving field information, with no functional change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- build-aux/extract-odp-netlink-h | 3 +- datapath/linux/compat/include/linux/openvswitch.h | 102

[ovs-dev] [PATCH V2 0/2] Do not rewrite fields with the same values as

Hi This patch set avoids unnecessary rewrite actions to fields with the same values as matched on. Patch 1 is a pre-step by defining ovs key structs using macros Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly Travis link:

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

> On Jan 10, 2019, at 9:02 PM, Ben Pfaff wrote: > >> On Fri, Jan 11, 2019 at 01:56:01AM +, Justin Pettit wrote: >> >>> On Jan 10, 2019, at 4:03 PM, Ben Pfaff wrote: >>> >>> Thanks. I applied this to master. >>> >>> Now, what about patches 7 and 8? >> >> I like to build up the

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

> On Jan 10, 2019, at 9:13 PM, Ben Pfaff wrote: > >> On Fri, Jan 11, 2019 at 05:09:45AM +, Justin Pettit wrote: >> On Jan 10, 2019, at 9:02 PM, Ben Pfaff wrote: > On Fri, Jan 11, 2019 at 01:56:01AM +, Justin Pettit wrote: > > On Jan 10, 2019, at 4:03 PM, Ben

Re: [ovs-dev] odp-util: Do not rewrite fields with the same values as matched

Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #49 FILE: lib/odp-util.c:7113: if (size

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

On Fri, Jan 11, 2019 at 01:56:01AM +, Justin Pettit wrote: > > > On Jan 10, 2019, at 4:03 PM, Ben Pfaff wrote: > > > > Thanks. I applied this to master. > > > > Now, what about patches 7 and 8? > > I like to build up the suspense. > > Just kidding. I hope to get them out tonight. I've

Re: [ovs-dev] datapath: Declare ovs key structures using macros

Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 122 characters long (recommended limit is 79) #25 FILE:

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

On Thu, Jan 10, 2019 at 07:22:11PM +, Justin Pettit wrote: > > > On Aug 30, 2018, at 1:00 PM, Ben Pfaff wrote: > > > > OpenFlow has a concept of multipart messages, that is, messages that can be > > broken into multiple pieces that are sent separately. Before OpenFlow 1.3, > > only replies

[ovs-dev] [RFC PATCH v1 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

OVN ACL implementation used ct_label to indicate if a previosuly allowed connection shoudl not be allowed anymore and vice versa. However, ct_label is a 128 bit value and we should rather leverage on ct_mark which is a 32 bit value. Using ct_mark for this purpose, allows us to use ct_label for

[ovs-dev] [RFC PATCH v1 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

OVN allows only an integer (or masked integer) to be assigned to ct_mark and ct_label. This patch, enhances the parser code to allow ct_mark and ct_label to be assigned from 32 bit registers (MFF_REG0 - MFF_REG15) and 128 bit registers (MFF_XXREG0 - MFF_XXREG3) respectively. signed-off-by:

[ovs-dev] [RFC PATCH v1 3/3] OVN ACL: Allow a user to input ct.label value for an acl

This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. signed-off-by: Ankur Sharma ---

[ovs-dev] [RFC PATCH v1 0/3] Associate identifier with OVN ACL connection tracking entry

What: a. Goal is to be able to associate some identifier with a connection tracking entry. b. This identifier can be used to map OVN ACL which added this entry or higher level constructs like openstack security group etc. c. There are 2 connection tracking fields which can be used for it.

[ovs-dev] [PATCH] datapath-windows: Add support for 'OVS_KEY_ATTR_ENCAP' key attribute.

Add a new structure in l2 header to accomodate vlan header, based of commit "d7efce7beff25052bd9083419200e1a47f0d6066 datapath: 802.1AD Flow handling, actions, vlan parsing, netlink attributes" Also reset vlan header in flow key, after deleting vlan tag from nbl With this change a sample vlan

[ovs-dev] [PATCH] compat: Fixup ipv6 fragmentation on 4.9.135+ kernels

Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed how ipv6 fragmentation is implemented. This patch was backported to the upstream stable 4.9.x kernel starting at 4.9.135. This patch creates the compatibility layer changes required to both compile and also operate

Re: [ovs-dev] [PATCH v2 1/2] stream: Allow timeout configuration for open_block.

On Wed, Jan 09, 2019 at 08:30:16PM +0300, Ilya Maximets wrote: > On some systems in case where remote is not responding, socket could > remain in SYN_SENT state for a really long time without errors waiting > for connection. This leads to situations where open_blok() hangs for > a few minutes

Re: [ovs-dev] [PATCH v2 1/2] conntrack: fix tcp seq adjustments when mangling commands

On Wed, Jan 9, 2019 at 12:53 AM David Marchand wrote: > Hello, > > On Wed, Jan 9, 2019 at 4:51 AM Darrell Ball wrote: > >> On Tue, Jan 8, 2019 at 2:57 PM Darrell Ball wrote: >> >>> On Tue, Jan 8, 2019 at 2:13 AM David Marchand >>> wrote: >>> Let me take an example with the test

[ovs-dev] [PATCH 1/2] python: Fix invalid escape sequences.

It appears that Python silently treats invalid escape sequences in strings as literals, e.g. "\." is the same as "\\.". Newer versions of checkpatch complain, and it does seem reasonable to me to fix these. Signed-off-by: Ben Pfaff --- python/build/nroff.py | 4 ++-- tests/test-ovsdb.py

[ovs-dev] [PATCH 2/2] python: Disable flake8 warning W504 "line break after binary operator".

OVS Python uses this style all over and I don't see a reason to avoid it. Signed-off-by: Ben Pfaff --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8408509c9a83..ff1f94b4841f 100644 --- a/Makefile.am +++ b/Makefile.am @@

Re: [ovs-dev] [PATCH] connmgr: Do not send asynchronous messages to rconns lacking protocols.

> On Dec 12, 2018, at 12:28 PM, Ben Pfaff wrote: > > There are corner cases in which an rconn might not have a defined OpenFlow > protocol or version. These happen at connection startup, before the > protocol version has been negotiated, and can also happen when a connection > is being shut

[ovs-dev] [PATCH] poll-loop: Set poll loop initial deadline to LLONG_MAX.

This is consistent with the re-initialization value that poll_block() uses. It is better than 0 because the monotonic clock can have a negative value, even though that is rare and pathological. Found by inspection. Signed-off-by: Ben Pfaff --- lib/poll-loop.c | 1 + 1 file changed, 1

Re: [ovs-dev] [PATCH v13 03/11] dp-packet: Handle multi-seg mbufs in helper funcs.

On 10/01/2019 11:17, Ian Stokes wrote: > On 1/9/2019 6:05 PM, Tiago Lam wrote: >> Most helper functions in dp-packet assume that the data held by a >> dp_packet is contiguous, and perform operations such as pointer >> arithmetic under that assumption. However, with the introduction of >>

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

thanks; not a full review On Wed, Jan 9, 2019 at 10:06 AM Tiago Lam wrote: > Previous commits have added support to the dp_packet API to handle > multi-segmented packets, where data is not stored contiguously in > memory. However, in some cases, it is inevitable and data must be > provided

Re: [ovs-dev] [PATCH v2 2/2] vconn: Allow timout configuration for blocking connection.

On Wed, Jan 09, 2019 at 08:30:17PM +0300, Ilya Maximets wrote: > On some systems in case where remote is not responding, socket could > remain in SYN_SENT state for a really long time without errors waiting > for connection. This leads to situations where vconn connection hangs > for a few minutes

Re: [ovs-dev] [patch v1] conntrack: Fix FTP seq_skew boundary adjustments.

On Thu, Jan 10, 2019 at 1:03 AM David Marchand wrote: > Hello, > > On Wed, Jan 9, 2019 at 4:44 AM Darrell Ball wrote: > >> Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") >> Signed-off-by: Darrell Ball >> --- >> >> Backport to 2.8. >> >> lib/conntrack.c | 10 -- >>

[ovs-dev] [PATCH v2 0/3] flake8 fixes

This is needed to make OVS work with flake8 3.6. v1->v2: - Added a few more fixes to patch 1. - Patch 3 is new. Ben Pfaff (3): python: Fix invalid escape sequences. python: Disable flake8 warning W504 "line break after binary operator". python: Avoid flake8 warning for unused

[ovs-dev] [PATCH v2 1/3] python: Fix invalid escape sequences.

It appears that Python silently treats invalid escape sequences in strings as literals, e.g. "\." is the same as "\\.". Newer versions of checkpatch complain, and it does seem reasonable to me to fix these. Signed-off-by: Ben Pfaff --- python/build/nroff.py | 4 ++--

[ovs-dev] [PATCH v2 3/3] python: Avoid flake8 warning for unused variables.

Signed-off-by: Ben Pfaff --- python/ovs/socket_util.py | 2 +- python/ovs/stream.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py index 2596ddefdb8c..8f9d31825c92 100644 --- a/python/ovs/socket_util.py +++

[ovs-dev] [PATCH v2 2/3] python: Disable flake8 warning W504 "line break after binary operator".

OVS Python uses this style all over and I don't see a reason to avoid it. Signed-off-by: Ben Pfaff --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 8408509c9a83..ff1f94b4841f 100644 --- a/Makefile.am +++ b/Makefile.am @@

Re: [ovs-dev] [PATCH 1/3] nroff: Increase width for .IP used for ordered lists.

Thank you for the review. I applied this series to master. On Thu, Jan 10, 2019 at 03:09:44PM -0500, Mark Michelson wrote: > Hi Ben, > > Excellent new document. This will be great to have in the code. > > For the series > Acked-by: Mark Michelson > > On 11/9/18 12:39 AM, Ben Pfaff wrote: > >

Re: [ovs-dev] [PATCH v13 06/11] dp-packet: Add support for data "linearization".

On 10/01/2019 09:12, David Marchand wrote: > On Thu, Jan 10, 2019 at 10:11 AM David Marchand > mailto:david.march...@redhat.com>> wrote: > > This part triggers build (non fatal o_O) warnings on fedora 28. > > > Oops, important. > This is when building without dpdk support. Hi David,

Re: [ovs-dev] [PATCH 6/8] ofproto: Handle multipart requests with multiple parts.

> On Jan 10, 2019, at 4:03 PM, Ben Pfaff wrote: > > Thanks. I applied this to master. > > Now, what about patches 7 and 8? I like to build up the suspense. Just kidding. I hope to get them out tonight. --Justin ___ dev mailing list