[ovs-dev] [PATCH] python: Escape backslashes while formatting logs.

2019-01-15 Thread Ilya Maximets
Since python version 3.7 (and some 3.6+ versions) regexp engine changed to treat the wrong escape sequences as errors. Previously, if the replace string had something like '\u', '\u' was qualified as a bad escape sequence and treated just as a sequence of characters '\' and 'u'. But know this

[ovs-dev] (no subject)

2019-01-15 Thread Phee Rujiphan
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 0/3] dpdk: Add support for TSO

2019-01-15 Thread Stokes, Ian
> On 14/01/2019 13:33, Ilya Maximets wrote: > > On 14.01.2019 15:51, Ian Stokes wrote: > >> On 1/11/2019 7:37 PM, Ian Stokes wrote: > >>> On 1/11/2019 4:14 PM, Ilya Maximets wrote: > Nothing significantly changed since the previous versions. > This patch set effectively breaks following

Re: [ovs-dev] [PATCH v5] Adding support for PMD auto load balancing

2019-01-15 Thread Kevin Traynor
On 01/15/2019 10:44 AM, Nitin Katiyar wrote: > > >> -Original Message- >> From: Ian Stokes [mailto:ian.sto...@intel.com] >> Sent: Tuesday, January 15, 2019 5:06 AM >> To: Nitin Katiyar ; ovs-dev@openvswitch.org; >> Kevin Traynor ; Ilya Maximets >> >> Subject: Re: [ovs-dev] [PATCH v5]

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Stokes, Ian
> Dpdk port representors were introduced in dpdk versions 18.xx. > Prior to port representors there was a one-to-one relationship between an > rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in > OVS). With port representors the relationship becomes one-to-many rte >

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Kevin Traynor
On 01/15/2019 09:47 AM, Ophir Munk wrote: > Dpdk port representors were introduced in dpdk versions 18.xx. > Prior to port representors there was a one-to-one relationship > between an rte device (e.g. PCI bus) and an eth device (referenced as > dpdk port id in OVS). With port representors the

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Ilya Maximets
Hmm. I received 5 copies of this patch. Are they different or you just have some strange issues with sending mails? Best regards, Ilya Maximets. On 15.01.2019 12:47, Ophir Munk wrote: > Dpdk port representors were introduced in dpdk versions 18.xx. > Prior to port representors there was a

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Ophir Munk
My apologies. My outlook server has issues. All patches are the same. Regards, Ophir > -Original Message- > From: Ilya Maximets > Sent: Tuesday, January 15, 2019 12:09 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor > Subject: Re: [PATCH

Re: [ovs-dev] [PATCH v5] Adding support for PMD auto load balancing

2019-01-15 Thread Nitin Katiyar
> -Original Message- > From: Federico Iezzi [mailto:fie...@redhat.com] > Sent: Monday, January 14, 2019 8:54 PM > To: Nitin Katiyar > Cc: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v5] Adding support for PMD auto load > balancing > > Maybe it's a bit late for this series,

Re: [ovs-dev] [PATCH v5] Adding support for PMD auto load balancing

2019-01-15 Thread Nitin Katiyar
> -Original Message- > From: Ian Stokes [mailto:ian.sto...@intel.com] > Sent: Tuesday, January 15, 2019 5:06 AM > To: Nitin Katiyar ; ovs-dev@openvswitch.org; > Kevin Traynor ; Ilya Maximets > > Subject: Re: [ovs-dev] [PATCH v5] Adding support for PMD auto load > balancing > > On

Re: [ovs-dev] a problem the userspace datapath failed to create a new datapath flow for the QinQ packet

2019-01-15 Thread 0-day Robot
Bleep bloop. Greetings wangyunjian, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: corrupt patch at line 7 Repository lacks necessary blobs to fall back on 3-way merge. Cannot

Re: [ovs-dev] conntrack: Fix FTP seq_skew boundary adjustments.

2019-01-15 Thread 0-day Robot
Bleep bloop. Greetings David Marchand, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] Python 3.7 test failures

2019-01-15 Thread Ilya Maximets
Hi, Ben. This is not a directly unicode related bug. It's a change in python regex library. I've sent a fix there: https://patchwork.ozlabs.org/patch/1025212/ Please, check it on your system. Best regards, Ilya Maximets. ___ dev mailing list

Re: [ovs-dev] [ovs-discuss] a problem the userspace datapath failed to create a new datapath flow for the QinQ packet

2019-01-15 Thread Ben Pfaff
On Mon, Jan 14, 2019 at 12:12:34PM +, wangyunjian wrote: > Hi, > > I found a problem the userspace datapath failed to create a > new datapath flow for the QinQ packet. When getting mask from > nlattrs with the mask include ip,udp,etc, it parsed 802.1Q > header wrongly. > > This patch fixes

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

2019-01-15 Thread Ben Pfaff
On Mon, Jan 14, 2019 at 08:15:36AM -0600, Terry Wilson wrote: > This fix was reverted because it depended on a small bit of code > in a patch that was reverted that changed some python/ovs testing > and build. The fix is still necessary. > > The OVS C-based JSON parser operates on bytes, so the

Re: [ovs-dev] [PATCH 2/2] rhel: Add ovs-actions manpage to rhel and Fedora spec files

2019-01-15 Thread Ben Pfaff
On Mon, Jan 14, 2019 at 04:20:30PM +0100, Timothy Redaelli wrote: > Fixes: be51cd417343 ("ovs-actions: New document describing OVS actions in > detail.") > Signed-off-by: Timothy Redaelli Thanks! I applied these to master. ___ dev mailing list

Re: [ovs-dev] [PATCH branch-2.9 1/1] netdev-dpdk: Fix flow control configuration.

2019-01-15 Thread Lam, Tiago
On 12/12/2018 22:18, Ian Stokes wrote: > From: Sugesh Chandran > > Currently devices that do not support configuring flow control via the eth_dev > API (e.g. SRIOV VFs) will fail during configuration setup when the interface > is added even if flow control is not requested. This is due to >

Re: [ovs-dev] [PATCH] Correct documentation for getting DB's cid

2019-01-15 Thread Ben Pfaff
Thanks, applied to master. On Thu, Dec 13, 2018 at 10:18:20AM -0600, Terry Wilson wrote: > Signed-off-by: Terry Wilson > --- > Documentation/ref/ovsdb.7.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/ref/ovsdb.7.rst b/Documentation/ref/ovsdb.7.rst >

Re: [ovs-dev] [PATCH] checkpatch: Check style of FOREACH loops.

2019-01-15 Thread Ben Pfaff
On Mon, Jan 14, 2019 at 06:04:32PM +0300, Ilya Maximets wrote: > Current checkpatch rules matches only OVS 'FOR_EACH' loops. > This change will apply same style checks for DPDK iterators > like 'RTE_ETH_FOREACH_MATCHING_DEV () {}'. > > Signed-off-by: Ilya Maximets Thanks, applied to master.

Re: [ovs-dev] Python 3.7 test failures

2019-01-15 Thread Ben Pfaff
On Tue, Jan 15, 2019 at 05:43:48PM +0300, Ilya Maximets wrote: > Hi, Ben. > This is not a directly unicode related bug. It's a change > in python regex library. > > I've sent a fix there: > https://patchwork.ozlabs.org/patch/1025212/ > > Please, check it on your system. Thanks!

Re: [ovs-dev] [PATCH v4] ovn: Support a new Logical_Switch_Port.type - 'external'

2019-01-15 Thread Numan Siddique
On Tue, Jan 15, 2019 at 5:42 AM Han Zhou wrote: > Hi Numan, > > The feature looks very good overall. I have some more comments inlined. > Thank Han for the review and the comments. You are right. The logical port's mac flaps too. I had to read the commit message again to recall :) > On Thu,

Re: [ovs-dev] [PATCH] python: Escape backslashes while formatting logs.

2019-01-15 Thread Ben Pfaff
On Tue, Jan 15, 2019 at 05:03:00PM +0300, Ilya Maximets wrote: > Since python version 3.7 (and some 3.6+ versions) regexp engine > changed to treat the wrong escape sequences as errors. Previously, > if the replace string had something like '\u', '\u' was > qualified as a bad escape sequence

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

2019-01-15 Thread Lucas Alvares Gomes
On Mon, Jan 14, 2019 at 2:35 PM Terry Wilson wrote: > > This fix was reverted because it depended on a small bit of code > in a patch that was reverted that changed some python/ovs testing > and build. The fix is still necessary. > > The OVS C-based JSON parser operates on bytes, so the

[ovs-dev] [PATCH v5] ovn: Support a new Logical_Switch_Port.type - 'external'

2019-01-15 Thread nusiddiq
From: Numan Siddique In the case of OpenStack + OVN, when the VMs are booted on hypervisors supporting SR-IOV nics, there are no OVS ports for these VMs. When these VMs sends DHCPv4, DHPCv6 or IPv6 Router Solicitation requests, the local ovn-controller cannot reply to these packets. OpenStack

[ovs-dev] [PATCH v3] rhel: Split OpenvSwitch and OVN packages

2019-01-15 Thread nusiddiq
From: Numan Siddique Up until now, OVN rpms were generated as sub packages of OpenvSwitch. This patch now splits it and makes OVN rpms independent. A new spec file - ovn-fedora.spec.in is added for this. The openvswitch-fedora.spec.in has been modified to create only OpenvSwitch packages.

[ovs-dev] [PATCH net-next] openvswitch: meter: Use struct_size() in kzalloc()

2019-01-15 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; instance =

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Stokes, Ian
> On 01/15/2019 09:47 AM, Ophir Munk wrote: > > Dpdk port representors were introduced in dpdk versions 18.xx. > > Prior to port representors there was a one-to-one relationship between > > an rte device (e.g. PCI bus) and an eth device (referenced as dpdk > > port id in OVS). With port

[ovs-dev] Fix OpenFlow v1.3.4 Conformance test failures: 430.500, 430.510

2019-01-15 Thread Iyengar, Prashanth
>From fc0a9e1329573692c04438370f85e87125a268b0 Mon Sep 17 00:00:00 2001 From: Prashanth Iyengar Date: Mon, 14 Jan 2019 12:53:11 -0800 Subject: [PATCH] Fix OpenFlow v1.3.4 Conf test failures: 430.500, 430.510 This commit adds additional verification to nx_pull_header__() in lib/nx-match.c to

[ovs-dev] DONATION

2019-01-15 Thread ESCUELA NRO 354 CORONEL RODRIGUEZ
$1,000,000.00 dollars has been donated to you by Maureen David Kaltschmidt who won the Powerball Jackpot of $758.7 million Dollars. Contact her via Email: maureendavidkaltschm...@gmail.com for more details ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 8/8] ofproto: Handle flow monitor requests with multiple parts.

2019-01-15 Thread Ben Pfaff
On Fri, Jan 11, 2019 at 10:09:05AM -0800, Justin Pettit wrote: > > > On Aug 30, 2018, at 1:00 PM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > --- > > ofproto/ofproto.c | 84 > > +-- > > 1 file changed, 44 insertions(+), 40

[ovs-dev] [patch v4 0/3] fixes for ftp alg in userspace dp.

2019-01-15 Thread Darrell Ball
Some small fixes to make the ftp alg behave a little better. I tried to come up with better tests but I am not too sure if we want to have a dependency on yet another external tool for it (lftp). Changelog since v3: - applied Darrell comments - more child connections, little style change in

Re: [ovs-dev] [PATCH 7/8] ovs-vswitchd: Implement OFPT_TABLE_FEATURES table modification request.

2019-01-15 Thread Ben Pfaff
Thanks for the review. I fixed the obvious stuff and just dropped the request. On Fri, Jan 11, 2019 at 01:07:36AM -0800, Justin Pettit wrote: > > > On Aug 30, 2018, at 1:00 PM, Ben Pfaff wrote: > > @@ -418,8 +425,11 @@ ofputil_decode_table_features(struct ofpbuf *msg, > > > > struct

[ovs-dev] Greetings From Mrs Awen Ken.

2019-01-15 Thread Mrs. Awen Ken via dev
Greetings From Mrs Awen Ken. I wrote you two days ago expecting that you would reply as regards the urgent information I passed to you. Anyway, I don't know if you did receive it or not that is the reason I am sending this reminder. I write to solicit for your partnership for a desired project

[ovs-dev] [PATCH v6] Adding support for PMD auto load balancing

2019-01-15 Thread Nitin Katiyar
Port rx queues that have not been statically assigned to PMDs are currently assigned based on periodically sampled load measurements. The assignment is performed at specific instances – port addition, port deletion, upon reassignment request via CLI etc. Due to change in traffic pattern over time

[ovs-dev] [PATCH] odp-util: Fix parsing QinQ packet in parse_8021q_onward.

2019-01-15 Thread wangyunjian
From: Yunjian Wang A problem the userspace datapath failed to create a new datapath flow when dealing with QinQ packets(the flow includeing ip,udp,etc). L2-L5 header should be considered before parsing the second 802.1Q header. Fixes: f0fb825a3785 ("Add support for 802.1ad (QinQ tunneling)")

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

2019-01-15 Thread Ophir Munk
Hi Ilya, Please find comments inline > -Original Message- > From: Ilya Maximets > Sent: Monday, January 14, 2019 12:11 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Asaf Penso ; Ian Stokes ; > Shahaf Shuler ; Thomas Monjalon > ; Olga Shern ; Kevin > Traynor > Subject: Re: [PATCH

[ovs-dev] [PATCH v4 0/3] fixes for ftp alg in userspace dp

2019-01-15 Thread David Marchand
Some small fixes to make the ftp alg behave a little better. I tried to come up with better tests but I am not too sure if we want to have a dependency on yet another external tool for it (lftp). Changelog since v3: - applied Darrell comments - more child connections, little style change in

[ovs-dev] [PATCH v4 1/3] conntrack: fix tcp seq adjustments when mangling commands

2019-01-15 Thread David Marchand
The ftp alg deals with packets in two ways for the command connection: either they are inspected and can be mangled when nat is enabled (CT_FTP_CTL_INTEREST) or they just go through without being modified (CT_FTP_CTL_OTHER). For CT_FTP_CTL_INTEREST packets, we must both adjust the packet tcp seq

Re: [ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-15 Thread David Marchand
On Tue, Jan 15, 2019 at 8:20 AM Darrell Ball wrote: > > On 1/14/19, 4:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of David > Marchand" david.march...@redhat.com> wrote: > > On Mon, Jan 14, 2019 at 7:32 AM Darrell Ball wrote: > > > 4/ I added another test below for reverse skew.

[ovs-dev] [PATCH] odp-util: Fix parsing QinQ packet in parse_8021q_onward.

2019-01-15 Thread wangyunjian
From: Yunjian Wang A problem the userspace datapath failed to create a new datapath flow when dealing with QinQ packets(the flow includeing ip,udp,etc). L2-L5 header should be considered before parsing the second 802.1Q header. Fixes: f0fb825a3785 ("Add support for 802.1ad (QinQ tunneling)")

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

2019-01-15 Thread Ilya Maximets
On 15.01.2019 11:39, Ophir Munk wrote: > Hi Ilya, > Please find comments inline > >> -Original Message- >> From: Ilya Maximets >> Sent: Monday, January 14, 2019 12:11 PM >> To: Ophir Munk ; ovs-dev@openvswitch.org >> Cc: Asaf Penso ; Ian Stokes ; >> Shahaf Shuler ; Thomas Monjalon >> ;

[ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Ophir Munk
Dpdk port representors were introduced in dpdk versions 18.xx. Prior to port representors there was a one-to-one relationship between an rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in OVS). With port representors the relationship becomes one-to-many rte device to eth

[ovs-dev] We offer loans with instant approval online at 3% interest

2019-01-15 Thread Sir Mark
We offer loans with instant approval online at 3% interest. Multi-Purpose Loans Available. We offer our Loans to our clients In ($)USD,(£)GBP,(€)Euro in the following categories. Personal Loan,Student Loans, Real Estate Loan, Business Loan and others. Contact us Via email

[ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Ophir Munk
Dpdk port representors were introduced in dpdk versions 18.xx. Prior to port representors there was a one-to-one relationship between an rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in OVS). With port representors the relationship becomes one-to-many rte device to eth

[ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Ophir Munk
Dpdk port representors were introduced in dpdk versions 18.xx. Prior to port representors there was a one-to-one relationship between an rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in OVS). With port representors the relationship becomes one-to-many rte device to eth

[ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-15 Thread Ophir Munk
Dpdk port representors were introduced in dpdk versions 18.xx. Prior to port representors there was a one-to-one relationship between an rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in OVS). With port representors the relationship becomes one-to-many rte device to eth