Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-28 Thread Ilya Maximets
On 28.08.2019 11:27, Nitin Katiyar wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Wednesday, August 28, 2019 12:44 PM >> To: Nitin Katiyar ; ovs-dev@openvswitch.org >> Cc: Stokes, Ian >> Subject: Re: [ovs-dev] [PATCH] packets: Fix using

Re: [ovs-dev] [PATCH V2] dpif-netdev: Do RCU synchronization at fixed interval in PMD main loop.

2019-08-28 Thread Nitin Katiyar
Hi, Please provide your feedback. Regards, Nitin > -Original Message- > From: Nitin Katiyar > Sent: Thursday, August 22, 2019 10:24 PM > To: ovs-dev@openvswitch.org > Cc: Nitin Katiyar ; Anju Thomas > > Subject: [PATCH V2] dpif-netdev: Do RCU synchronization at fixed interval in > PMD

Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-28 Thread Nitin Katiyar
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, August 27, 2019 5:37 PM > To: Nitin Katiyar ; ovs-dev@openvswitch.org > Cc: Stokes, Ian > Subject: Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after > MPLS decapsulation. > > Hi.

Re: [ovs-dev] vswitchd crashed when revalidate flows in ovs 2.8.2

2019-08-28 Thread ychen
(gdb) p/x seq_mutex $1 = { lock = { __data = { __lock = 0x2, __count = 0x0, __owner = 0x0, > owner is already 0, but still abort __nusers = 0x0, __kind = 0x2, __spins = 0x0, __elision = 0x0, __list = { __prev = 0x0,

Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-28 Thread Ilya Maximets
On 28.08.2019 10:03, Nitin Katiyar wrote: > > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Tuesday, August 27, 2019 5:37 PM >> To: Nitin Katiyar ; ovs-dev@openvswitch.org >> Cc: Stokes, Ian >> Subject: Re: [ovs-dev] [PATCH] packets: Fix using

Re: [ovs-dev] [patch v1] conntrack: Fix ICMPV4 error data L4 length check.

2019-08-28 Thread Vishal Deep Ajmera
That is interesting i just tried applying on top of tree and I see that the git applies some changes (2 lines) in extract_l4_icmp6() rather the intended extract_l4_icmp() as in the patch I sent out. My guess is that the surrounding lines are identical in the 2 functions and I had other patches

[ovs-dev] [PATCH V3] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-28 Thread Nitin Katiyar
When a packet is received, the RSS hash is calculated if it is not already available. The Exact Match Cache (EMC) entry is then looked up using this RSS hash. When a MPLS encapsulated packet is received, the MPLS header is popped and the packet is recirculated. Since the RSS hash has not been

Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after MPLS decapsulation.

2019-08-28 Thread Nitin Katiyar
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Wednesday, August 28, 2019 12:44 PM > To: Nitin Katiyar ; ovs-dev@openvswitch.org > Cc: Stokes, Ian > Subject: Re: [ovs-dev] [PATCH] packets: Fix using outdated RSS hash after > MPLS decapsulation. > >

[ovs-dev] [PATCH v4 ovn 1/2] OVN: add meter support to trigger_event action

2019-08-28 Thread Lorenzo Bianconi
Introduce meter support to trigger_event action in order to not overload pinctrl thread under heavy load Signed-off-by: Lorenzo Bianconi --- include/ovn/actions.h | 1 + lib/actions.c | 43 +-- ovn-sb.xml| 5 - tests/ovn.at

[ovs-dev] [PATCH v4 ovn 0/2] Add rate limiting support for controller_events

2019-08-28 Thread Lorenzo Bianconi
Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. For each event type we need to define a naming convention for the related meter: - empty_lb_backends: event-elb Changes since v3: - rebase on top of 'add

Re: [ovs-dev] [PATCH v4 ovn 2/2] OVN: northd: add rate limiting support for SB controller events

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (tests/ovn.at). Repository lacks necessary blobs

[ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.

[ovs-dev] Regarding TSO using AF_PACKET in OVS

2019-08-28 Thread Ramana Reddy
Hi Ben, Justin, Jesse and All, Hope everyone doing great. During my work, I create a socket using AF_PACKET with virtio_net_hdr and filled all the fields in the virtio_net_hdr and the flag to VIRTIO_NET_GSO_TCPV4 to enable TSO using af_packet. vnet->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; The

Re: [ovs-dev] [PATCH v6] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread Sriram Vatala via dev
Hi All, The patch " netdev-dpdk: Refactor vhost custom stats for extensibility" by Ilya is merged to master. So I will rebase and send updated patch to avoid any git conflicts. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 26 August 2019 18:29 To:

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-08-28 Thread Ilya Maximets
On 28.08.2019 13:24, Anil Kumar wrote: > OVS crashes when a packet sent with action set to OFPP_TABLE hits Openflow > rules with conntrack and learn actions. > > For example: > The crash can be triggered by installing the following Open flow rules and > sending packet with action set to

Re: [ovs-dev] [PATCH v2 ovn 2/3] ovn-controller: Optimize update of ct-zones external-ids.

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: > commit_ct_zones() is called at every ovn-controller iteration but updates > to > ct-zones don't happen at every iteration. Avoid cloning the > br-int->external_ids map unless an update is needed. > > Signed-off-by: Dumitru Ceara > --- >

[ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-08-28 Thread Anil Kumar via dev
OVS crashes when a packet sent with action set to OFPP_TABLE hits Openflow rules with conntrack and learn actions. For example: The crash can be triggered by installing the following Open flow rules and sending packet with action set to OFPP_TABLE 1. ovs-ofctl -OOpenflow13 add-flow br-int

Re: [ovs-dev] [PATCH v2 ovn 1/3] ofctrl: Avoid recomputing match hash in ofctrl_dup_flow().

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:54 PM Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > Thanks. I applied this patch to master. Numan > --- > controller/ofctrl.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/ofctrl.c b/controller/ofctrl.c > index

[ovs-dev] [PATCH v4 ovn 2/2] OVN: northd: add rate limiting support for SB controller events

2019-08-28 Thread Lorenzo Bianconi
Introduce the capability to associate a meter to each controller event type in order to not overload the pinctrl thread under heavy load. Each event type relies on a meter with a defined name: - empty_lb_backends: event-elb Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi ---

Re: [ovs-dev] [PATCH v2 ovn 3/3] ovn-controller: Minimize SB DB port_binding lookups.

2019-08-28 Thread Numan Siddique
On Fri, Aug 23, 2019 at 4:55 PM Dumitru Ceara wrote: > Instead of storing only peer_ports in struct local_datapath, store both > local-remote mappings for patch ports. Also, it's useful to directly > store sbrec_port_binding pointers for all datapath ports as we avoid > doing costly

Re: [ovs-dev] [PATCH v8 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:27 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v8 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:27 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-28 Thread Flavio Leitner via dev
Hi Ben and Ilya, This patch has two reviews, so any chance for you to take a look soon as well? Thanks in advance! fbl On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote: > When a packet needs to be encapsulated in userspace, the endpoint > address needs to be resolved to

Re: [ovs-dev] [PATCH v8 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-28 Thread Numan Siddique
On Wed, Aug 28, 2019 at 7:26 AM Ankur Sharma wrote: > Background: > With c0974331b7a19a87ab8f1f2cec8fbe366af92fa2, we have added > support for E-W workflow for vlan backed DVRs. > > This series enables N-S workflow for vlan backed DVRs. > > Key difference between E-W and N-S traffic flow is that

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Sriram Vatala via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 138 characters long (recommended limit is 79) #351 FILE:

Re: [ovs-dev] [PATCH v4 ovn 1/4] Build OVN using external OVS directory

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #143 FILE:

[ovs-dev] [PATCH branch-2.11] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-28 Thread Greg Rose
A Centos 7.5 kernel with an unencountered set of minor build numbers caused an upgrade bug. Adding the case for the rhel 7.5 kmod management script fixes the problem. Signed-off-by: Greg Rose Reviewed-by: Yifeng Sun Signed-off-by: Gurucharan Shetty ---

Re: [ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-28 Thread Gregory Rose
On 8/28/2019 10:16 AM, Gregory Rose wrote: On 8/28/2019 10:07 AM, Guru Shetty wrote: I applied this to master and 2.12. I got a conflict for 2.11. If you need this for 2.11, can you please rebase? Yes, it needs to go back to 2.10 where we introduce the %posttrans scriptlet in

[ovs-dev] [PATCH v3] userspace: Enable non-bridge port as tunnel endpoint.

2019-08-28 Thread Yifeng Sun
For userspace datapath, currently only the bridge itself, the LOCAL port, can be the tunnel endpoint to encap/decap tunnel packets. This patch enables non-bridge port as tunnel endpoint. One use case is for users to create a bridge and a vtep port as tap, and configure underlay IP at vtep port

[ovs-dev] [PATCH] ovn: Prevent erroneous duplicate IP address

2019-08-28 Thread Mark Michelson
When using dynamic address assignment for logical switches, OVN reserves the first address in the subnet for the attached router port to use. In commit 488d153ee87841c042af05bc0eb8b5481aaa98cf, the IPAM code was modified to add assigned router port addresses to IPAM. The use case for this was

Re: [ovs-dev] [PATCH v2.12] OVN: fix memory leak in build_pre_lb

2019-08-28 Thread Ben Pfaff
On Mon, Aug 26, 2019 at 11:19:32AM +0200, Lorenzo Bianconi wrote: > Fix memory leak of ip_address string in build_pre_lb routine if we > install logical flows for empty_lb controller event > > Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report 'empty_lb_rule' > events") >

[ovs-dev] [PATCH v4 ovn 1/4] Build OVN using external OVS directory

2019-08-28 Thread nusiddiq
From: Numan Siddique With this patch we have to configure OVN to refer to external OVS source/build directory instead of the ovs subtree. The new configuration options added are: * --with-ovs-source=/path/to/ovs/source/dir * --with-ovs-build=/path/to/ovs/build/dir The path to these

[ovs-dev] [PATCH v4 ovn 2/4] Add support for using OVN specific rundirs

2019-08-28 Thread nusiddiq
From: Numan Siddique Until now, OVN uses the openvswitch rundirs (rundir, logdir, etcdir). The commit [1] changed the package name from openvswitch to ovn, but it didn't take into the account the effects of it. When "make install" is run ovn-ctl utility is copied to /usr/local/share/ovn/scripts

[ovs-dev] [PATCH v4 ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-28 Thread nusiddiq
From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds the support to compile OVN from external OVS sources. The following configuration options are added when configuring OVN * --with-ovs-source (mandatory) * --with-ovs-build

Re: [ovs-dev] [PATCH] Docs: Add DPDK AF_XDP PMD use case.

2019-08-28 Thread William Tu
On Tue, Aug 27, 2019 at 10:38 AM Stokes, Ian wrote: > > > > On 8/22/2019 3:43 PM, William Tu wrote: > > On Thu, Aug 22, 2019 at 1:33 AM David Marchand > > wrote: > >> > >> On Thu, Aug 22, 2019 at 10:30 AM Stokes, Ian wrote: > >>> > >>> > >>> On 8/22/2019 7:00 AM, David Marchand wrote: > On

Re: [ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-28 Thread Flavio Leitner via dev
On Wed, Aug 28, 2019 at 11:29:54AM -0700, Ben Pfaff wrote: > On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote: > > When a packet needs to be encapsulated in userspace, the endpoint > > address needs to be resolved to fill in the headers. If it is not, > > then currently OvS

Re: [ovs-dev] [PATCH v4 ovn 2/4] Add support for using OVN specific rundirs

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #2123 FILE:

Re: [ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-28 Thread Guru Shetty
On Wed, 28 Aug 2019 at 10:42, Gregory Rose wrote: > > > On 8/28/2019 10:16 AM, Gregory Rose wrote: > > > > > > On 8/28/2019 10:07 AM, Guru Shetty wrote: > >> I applied this to master and 2.12. I got a conflict for 2.11. If you > >> need this for 2.11, can you please rebase? > > > > Yes, it needs

Re: [ovs-dev] [PATCH v3] userspace: Enable non-bridge port as tunnel endpoint.

2019-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2019 at 10:49:59AM -0700, Yifeng Sun wrote: > For userspace datapath, currently only the bridge itself, the LOCAL port, > can be the tunnel endpoint to encap/decap tunnel packets. This patch > enables non-bridge port as tunnel endpoint. One use case is for users to > create a

Re: [ovs-dev] [PATCH 1/2] ovs-thread: Make struct spin lock cache aligned.

2019-08-28 Thread Ben Pfaff
On Mon, Aug 26, 2019 at 04:00:31PM -0700, William Tu wrote: > Make the spin lock struct 64-byte aligned to avoid false sharing issue. > > Signed-off-by: William Tu Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] Regarding TSO using AF_PACKET in OVS

2019-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2019 at 04:40:41PM +0530, Ramana Reddy wrote: > Hi Ben, Justin, Jesse and All, > > Hope everyone doing great. For what it's worth, I'm not the kernel module maintainer and I don't really have an answer to this question. I hope that someone else pops up to answer it.

[ovs-dev] [PATCH v4 ovn 3/4] Fix "make rpm-fedora"

2019-08-28 Thread nusiddiq
From: Numan Siddique "make rpm-fedora" is broken and this patch fixes it. Previous patch in this series supported building OVN from external OVS sources. Before running "make rpm-fedora", it is expected that the developer has run "make dist" in the OVS source folder to generate the

[ovs-dev] [PATCH v4 ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

2019-08-28 Thread nusiddiq
From: Numan Siddique This patch could have created a new user 'ovn' for ovn services instead of using 'openvswitch' user. But this would require some amount of work and proper testing since the new user 'ovn' should be part of 'openvswitch' group (to access /var/run/openvswitch/db.sock.). If ovs

Re: [ovs-dev] [PATCH v4 ovn 3/4] Fix "make rpm-fedora"

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 108 characters long (recommended limit is 79) #284 FILE:

Re: [ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-28 Thread Guru Shetty
I applied this to master and 2.12. I got a conflict for 2.11. If you need this for 2.11, can you please rebase? On Tue, 27 Aug 2019 at 14:12, Yifeng Sun wrote: > Reviewed-by: Yifeng Sun > > On Tue, Aug 27, 2019 at 2:06 PM Greg Rose wrote: > > > > A Centos 7.5 kernel with an unencountered set

Re: [ovs-dev] [PATCH branch-2.11] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [patch v1] conntrack: Fix ICMPV4 error data L4 length check.

2019-08-28 Thread Darrell Ball
On Wed, Aug 28, 2019 at 1:43 AM Vishal Deep Ajmera < vishal.deep.ajm...@ericsson.com> wrote: > That is interesting > > i just tried applying on top of tree and I see that the git applies some > changes (2 lines) > > in extract_l4_icmp6() rather the intended extract_l4_icmp() as in the > patch I

Re: [ovs-dev] [PATCH v4] ovsdb-tool: Convert clustered db to standalone db.

2019-08-28 Thread Ben Pfaff
On Mon, Aug 26, 2019 at 04:04:21PM -0700, amgin...@gmail.com wrote: > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to migrate nb/sb db to standalone db from raft: > ovsdb-tool cluster-to-standalone ovnnb_db.db

Re: [ovs-dev] [PATCH] rhel: Add case for RHEL 7.5 major version to kmod manage script

2019-08-28 Thread Gregory Rose
On 8/28/2019 10:07 AM, Guru Shetty wrote: I applied this to master and 2.12. I got a conflict for 2.11. If you need this for 2.11, can you please rebase? Yes, it needs to go back to 2.10 where we introduce the %posttrans scriptlet in rhel/openvswitch-kmod-fedora.spec.in I'll send rebased

Re: [ovs-dev] [PATCHv2 ovn] Prevent erroneous duplicate IP address messages.

2019-08-28 Thread Mark Michelson
I pushed this to master. On 8/8/19 5:00 PM, Mark Michelson wrote: When using dynamic address assignment for logical switches, OVN reserves the first address in the subnet for the attached router port to use. In commit 488d153ee87841c042af05bc0eb8b5481aaa98cf, the IPAM code was modified to add

Re: [ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-28 Thread Ben Pfaff
On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote: > When a packet needs to be encapsulated in userspace, the endpoint > address needs to be resolved to fill in the headers. If it is not, > then currently OvS sends either a Neighbor Solicitation (IPv6) > or an ARP Query (IPv4)

[ovs-dev] [PATCH v5 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-28 Thread Yi-Hung Wei
This patch first defines the dpif interface for a datapath to support adding, deleting, getting and dumping conntrack timeout policy. The timeout policy is identified by a 4 bytes unsigned integer in datapath, and it currently support timeout for TCP, UDP, and ICMP protocols. Moreover, this patch

[ovs-dev] [PATCH v5 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-28 Thread Yi-Hung Wei
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains the zone-based configuration in the vswitchd. Whenever there is a database change, vswitchd will read the datapath, CT_Zone, and CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the database configuration

[ovs-dev] [PATCH v5 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-28 Thread Yi-Hung Wei
From: William Tu The patch adds commands creating/deleting/listing conntrack zone timeout policies: $ ovs-vsctl {add,del,list}-zone-tp dp zone=zone_id ... Signed-off-by: William Tu --- tests/ovs-vsctl.at | 34 +++- utilities/ovs-vsctl.8.in | 26 ++ utilities/ovs-vsctl.c|

[ovs-dev] [PATCH v5 5/9] simap: Add utility function to help compare two simaps.

2019-08-28 Thread Yi-Hung Wei
From: Ben Pfaff Signed-off-by: Ben Pfaff --- lib/simap.c | 15 ++- lib/simap.h | 1 + 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/simap.c b/lib/simap.c index d634f8ed9eea..f404ece67703 100644 --- a/lib/simap.c +++ b/lib/simap.c @@ -1,5 +1,5 @@ /* - *

[ovs-dev] [PATCH v5 3/9] ct-dpif: Export ct_dpif_format_ipproto()

2019-08-28 Thread Yi-Hung Wei
This function will be useful for following patches. Signed-off-by: Yi-Hung Wei Acked-by: Justin Pettit --- lib/ct-dpif.c | 3 +-- lib/ct-dpif.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c index 5d8a75d3a63f..6ea7feb0ee35 100644 ---

Re: [ovs-dev] [PATCH v1] doc: Added OVS Nicira Extension document

2019-08-28 Thread Ben Pfaff
Thanks for working on this! There's a lot here! More comments below. On Mon, Aug 12, 2019 at 12:00:26PM -0700, Ashish Varma wrote: > OVS supports Nicira Extensions as various vendor messages or as vendor > types in stats or multipart messages. Added a document to describe the >

Re: [ovs-dev] [PATCH v2.12] OVN: Repair memory leak for OVN controller events.

2019-08-28 Thread Ben Pfaff
On Thu, Aug 15, 2019 at 02:12:18PM -0400, Mark Michelson wrote: > Controller event action is leaking its genopts. This corrects the error. Needs a Signed-off-by. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v5 8/9] datapath: Add support for conntrack timeout policy

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Dan Carpenter needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread Greg Rose
Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments When IP fragments are reassembled before being sent to conntrack, the key from the last

[ovs-dev] [PATCH 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-28 Thread Greg Rose
From: Justin Pettit Upstream commit: commit 0754b4e8cdf3eec6e4122e79af26ed9bab20f8f8 Author: Justin Pettit Date: Tue Aug 27 07:58:10 2019 -0700 openvswitch: Clear the L4 portion of the key for "later" fragments. Only the first fragment in a datagram contains the L4

Re: [ovs-dev] [PATCH 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Justin Pettit needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2] flow: miniflow_extract metadata branchless optimization

2019-08-28 Thread Ben Pfaff
This fails to apply to current master. Whereas most of the time I'd be comfortable with reviewing 'flow' patches myself, this one is closed related to the dpif-netdev code and I'd prefer to have someone who understands that code well, as well as the tradeoffs between performance and

[ovs-dev] [PATCH v5 0/9] Support zone-based conntrack timeout policy

2019-08-28 Thread Yi-Hung Wei
This patch series enables zone-based conntrack timeout policy support in OVS. Timeout policy is a set of timeout attributes that can be associated with a connection when it is committed. Then, the connection tracking system will expire a connection based on its connection state. For example, one

[ovs-dev] [PATCH v5 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

2019-08-28 Thread Yi-Hung Wei
From: Justin Pettit Signed-off-by: Justin Pettit Signed-off-by: Yi-Hung Wei Co-authored-by: Yi-Hung Wei --- vswitchd/vswitch.ovsschema | 51 - vswitchd/vswitch.xml | 275 + 2 files changed, 277 insertions(+), 49 deletions(-) diff

[ovs-dev] [PATCH v5 7/9] datapath: compat: Backport nf_conntrack_timeout support

2019-08-28 Thread Yi-Hung Wei
This patch brings in nf_ct_timeout_put() and nf_ct_set_timeout() when it is not available in the kernel. Three symbols are created in acinclude.m4. * HAVE_NF_CT_SET_TIMEOUT is used to determine if upstream net-next commit 717700d183d65 ("netfilter: Export nf_ct_{set,destroy}_timeout()") is

[ovs-dev] [PATCH v5 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

2019-08-28 Thread Yi-Hung Wei
This patch derives the timeout policy based on ct zone from the internal data structure that we maintain on dpif layer. It also adds a system traffic test to verify the zone-based conntrack timeout feature. The test uses ovs-vsctl commands to configure the customized ICMP and UDP timeout on zone

[ovs-dev] [PATCH v5 8/9] datapath: Add support for conntrack timeout policy

2019-08-28 Thread Yi-Hung Wei
This patch adds support for specifying a timeout policy for a connection in connection tracking system in kernel datapath. The timeout policy will be attached to a connection when the connection is committed to conntrack. This patch introduces a new odp field OVS_CT_ATTR_TIMEOUT in the ct action

Re: [ovs-dev] [PATCH v3] datapath: compat: Backports bugfixes for nf_conncount

2019-08-28 Thread Ben Pfaff
On Wed, Aug 07, 2019 at 03:25:33PM -0700, Yifeng Sun wrote: > This patch backports several critical bug fixes related to > locking and data consistency in nf_conncount code. > > This backport is based on the following upstream net-next upstream commits. > a007232 ("netfilter: nf_conncount: fix

Re: [ovs-dev] [PATCH] utilities: Improve ovs-dpctl-top flow parsing

2019-08-28 Thread Ben Pfaff
On Mon, Aug 12, 2019 at 06:52:27PM +0200, Jaime Caamaño Ruiz wrote: > * check that expected bytes and packets stats are correctly read from > every flow. > * check that the expected elements are read for every field type > aggregation. > > Signed-off-by: Jaime Caamaño Ruiz Thanks! I

Re: [ovs-dev] [PATCH v3] datapath: compat: Backports bugfixes for nf_conncount

2019-08-28 Thread Yi-Hung Wei
On Wed, Aug 28, 2019 at 4:07 PM Ben Pfaff wrote: > > On Wed, Aug 07, 2019 at 03:25:33PM -0700, Yifeng Sun wrote: > > This patch backports several critical bug fixes related to > > locking and data consistency in nf_conncount code. > > > > This backport is based on the following upstream net-next

Re: [ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread Yi-Hung Wei
On Wed, Aug 28, 2019 at 4:50 PM Greg Rose wrote: > > Upstream commit: > commit ad06a566e118e57b852cab5933dbbbaebb141de3 > Author: Greg Rose > Date: Tue Aug 27 07:58:09 2019 -0700 > > openvswitch: Properly set L4 keys on "later" IP fragments > > When IP fragments are

Re: [ovs-dev] [PATCH 2/2] datapath: Clear the L4 portion of the key for "later" fragments

2019-08-28 Thread Yi-Hung Wei
On Wed, Aug 28, 2019 at 4:51 PM Greg Rose wrote: > > From: Justin Pettit > > Upstream commit: > commit 0754b4e8cdf3eec6e4122e79af26ed9bab20f8f8 > Author: Justin Pettit > Date: Tue Aug 27 07:58:10 2019 -0700 > > openvswitch: Clear the L4 portion of the key for "later"

Re: [ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread Justin Pettit
> On Aug 28, 2019, at 5:05 PM, Yi-Hung Wei wrote: > > Thanks for the backport. > > Acked-by: Yi-Hung Wei Thanks, Yi-Hung. I already pushed the backports. --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread Justin Pettit
> On Aug 28, 2019, at 4:50 PM, Greg Rose wrote: > > Upstream commit: >commit ad06a566e118e57b852cab5933dbbbaebb141de3 >Author: Greg Rose >Date: Tue Aug 27 07:58:09 2019 -0700 > >openvswitch: Properly set L4 keys on "later" IP fragments > >When IP fragments are

Re: [ovs-dev] [PATCH branch-2.12] pinctrl: Fix DNS packet parsing

2019-08-28 Thread Ben Pfaff
On Fri, Aug 16, 2019 at 04:35:52PM +0200, Dumitru Ceara wrote: > Please backport this to 2.11, 2.10, 2.9 at least. Done. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 ovn 0/4] External OVS source support and separate run dir for OVN

2019-08-28 Thread Mark Michelson
Acked-by: Mark Michelson On 8/28/19 12:38 PM, nusid...@redhat.com wrote: From: Numan Siddique This patch series adds support for building OVN from external OVS sources. The first patch adds the support to compile OVN from external OVS sources. The following configuration options are added

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-08-28 Thread Jin, Liang via dev
Hi, We upgrade the OVS recently from one version 2.10 to another version 2.10. on some HV upgrade, the HV is down when running force reload kernel. In the ovs-ctl log, kill ovs-vswitch is failed, but the script is still going to reload the modules. ``` ovsdb-server is running with pid 2431

Re: [ovs-dev] [PATCH v2 ] flow: save "vlan_hdrs" memset for untagged traffic

2019-08-28 Thread Ben Pfaff
On Thu, Aug 22, 2019 at 06:09:50PM +0800, Yanqin Wei wrote: > For untagged traffic, it is unnecessary to clear vlan_hdrs as it costs 32B > memset. So the patch improves it by postponing to clear vlan_hdrs until > ethtype check. It can benefit both untagged and single-tagged traffic. From >

Re: [ovs-dev] [PATCH] flow: Reduce metadata connection state branches in miniflow_extract

2019-08-28 Thread Ben Pfaff
On Tue, Aug 27, 2019 at 01:21:08PM -0500, Malvika Gupta wrote: > This patch merges two separate if-else branches for metadata connection state > into one if-else branch to improve performance. It gives an average > performance > improvement of ~3% on arm platforms and ~4.5% on x86 platforms. > >

Re: [ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread Gregory Rose
On 8/28/2019 5:17 PM, Justin Pettit wrote: On Aug 28, 2019, at 4:50 PM, Greg Rose wrote: Upstream commit: commit ad06a566e118e57b852cab5933dbbbaebb141de3 Author: Greg Rose Date: Tue Aug 27 07:58:09 2019 -0700 openvswitch: Properly set L4 keys on "later" IP fragments

Re: [ovs-dev] [PATCH v3] userspace: Enable non-bridge port as tunnel endpoint.

2019-08-28 Thread Darrell Ball
Thanks for the patch How about writing a system test ? Darrell On Wed, Aug 28, 2019 at 10:50 AM Yifeng Sun wrote: > For userspace datapath, currently only the bridge itself, the LOCAL port, > can be the tunnel endpoint to encap/decap tunnel packets. This patch > enables non-bridge port as

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-08-28 Thread Jin, Liang via dev
Hi, We upgrade the OVS recently from one version 2.10 to another version 2.10. on some HV upgrade, the HV is down when running force reload kernel. In the ovs-ctl log, kill ovs-vswitch is failed, but the script is still going to reload the modules. ``` ovsdb-server is running with pid 2431

Re: [ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-08-28 Thread Jin, Liang via dev
From: "Jin, Liang" Date: Wednesday, August 28, 2019 at 3:58 AM To: "ovs-dev@openvswitch.org" Cc: "Zhou, Han" , "Murthy, Sudheendra(sumurthy)" Subject: Hypervisor down during upgrade OVS 2.10.x to 2.10.y Hi, We upgrade the OVS recently from one version 2.10 to another version 2.10. on

[ovs-dev] Hypervisor down during upgrade OVS 2.10.x to 2.10.y

2019-08-28 Thread Jin, Liang via dev
Hi, We upgrade the OVS recently from one version 2.10 to another version 2.10. on some HV upgrade, the HV is down when running force reload kernel. In the ovs-ctl log, kill ovs-vswitch is failed, but the script is still going to reload the modules. ``` ovsdb-server is running with pid 2431

Re: [ovs-dev] [PATCH v2] flow: fix incorrect padding length checking and combine branch in ipv6_sanity_check

2019-08-28 Thread Ben Pfaff
On Thu, Aug 22, 2019 at 06:09:34PM +0800, Yanqin Wei wrote: > The padding length is (packet size - ipv6 header length - ipv6 plen). This > patch fixes incorrect ipv6 size checking and improves it by combining branch. > > Reviewed-by: Gavin Hu > Signed-off-by: Yanqin Wei > --- > lib/flow.c |

Re: [ovs-dev] [PATCH 2.9 2.8 2.7] tests: fix output indentation in tunnel.at

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Flavio Leitner via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: -e 's,[@]PYTHON[@],/bin/python2,g' \ -e

Re: [ovs-dev] [PATCH 2.9 2.8 2.7] tests: fix output indentation in tunnel.at

2019-08-28 Thread Ben Pfaff
On Thu, Aug 29, 2019 at 12:36:08AM -0300, Flavio Leitner via dev wrote: > The commit b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.") > uses the output indentation from newer OvS versions which include the > commit 7be29a47576d ("ofproto-dpif: Remove tabs from output."). > > Fixes:

Re: [ovs-dev] [patch v1] conntrack: Fix ICMPV4 error data L4 length check.

2019-08-28 Thread Vishal Deep Ajmera
Thanks Darrell. Patch looks ok to me. Warm Regards, Vishal Ajmera ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Open vSwitch 2.12 release ready?

2019-08-28 Thread Ben Pfaff
Hello, everyone. I believe that we're up-to-date with patches posted against branch-2.12. Does anyone know of anything that should hold up release? (Travis is currently doing a build, but the previous one did pass.) Thanks, Ben. ___ dev mailing list

[ovs-dev] [PATCHi v5] ovsdb-tool: Convert clustered db to standalone db.

2019-08-28 Thread amginwal
From: Aliasgar Ginwala Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. E.g. usage to migrate nb/sb db to standalone db from raft: ovsdb-tool cluster-to-standalone ovnnb_db.db ovnnb_db_cluster.db Signed-off-by: Aliasgar Ginwala --- Documentation/ref/ovsdb.7.rst | 3 +

Re: [ovs-dev] [PATCH v4] ovsdb-tool: Convert clustered db to standalone db.

2019-08-28 Thread Ginwala, Aliasgar via dev
Thanks Ben: Sent v5 https://patchwork.ozlabs.org/patch/1154959/ to address the same. PTAL. On 8/28/19, 9:53 AM, "Ben Pfaff" wrote: On Mon, Aug 26, 2019 at 04:04:21PM -0700, amgin...@gmail.com wrote: > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating

Re: [ovs-dev] [PATCH v3] datapath: compat: Backports bugfixes for nf_conncount

2019-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2019 at 04:48:52PM -0700, Yi-Hung Wei wrote: > On Wed, Aug 28, 2019 at 4:07 PM Ben Pfaff wrote: > > > > On Wed, Aug 07, 2019 at 03:25:33PM -0700, Yifeng Sun wrote: > > > This patch backports several critical bug fixes related to > > > locking and data consistency in nf_conncount

[ovs-dev] [PATCH v5] ovsdb-tool: Convert clustered db to standalone db.

2019-08-28 Thread amginwal
From: Aliasgar Ginwala Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. E.g. usage to migrate nb/sb db to standalone db from raft: ovsdb-tool cluster-to-standalone ovnnb_db.db ovnnb_db_cluster.db Signed-off-by: Aliasgar Ginwala --- Documentation/ref/ovsdb.7.rst | 3 +

[ovs-dev] [PATCH 2.9 2.8 2.7] tests: fix output indentation in tunnel.at

2019-08-28 Thread Flavio Leitner via dev
The commit b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.") uses the output indentation from newer OvS versions which include the commit 7be29a47576d ("ofproto-dpif: Remove tabs from output."). Fixes: b1356b50aa6a ("tnl-neigh: Use outgoing ofproto version.") Signed-off-by: Flavio Leitner

Re: [ovs-dev] [PATCH] tnl-neigh: Use outgoing ofproto version.

2019-08-28 Thread Flavio Leitner via dev
On Wed, Aug 28, 2019 at 11:29:54AM -0700, Ben Pfaff wrote: > On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote: > > When a packet needs to be encapsulated in userspace, the endpoint > > address needs to be resolved to fill in the headers. If it is not, > > then currently OvS