Re: [ovs-dev] [PATCH v7 ovn 1/2] ovn-northd: Fix get_router_load_balancer_ips() for mixed address families.

2019-11-12 Thread Dumitru Ceara
On Tue, Nov 12, 2019 at 6:02 PM Han Zhou wrote: > > > > On Tue, Nov 12, 2019 at 2:28 AM Dumitru Ceara wrote: > > > > Function get_router_load_balancer_ips() was incorrectly returning a > > single address_family even though the IP set could contain a mix of > > IPv4 and IPv6 addresses. > > > >

[ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-12 Thread Dumitru Ceara
ARP request and ND NS packets for router owned IPs were being flooded in the complete L2 domain (using the MC_FLOOD multicast group). However this creates a scaling issue in scenarios where aggregation logical switches are connected to more logical routers (~350). The logical pipelines of all

Re: [ovs-dev] [PATCH ovn] Fix testsuite 85 - "ensure one gw controller restart in HA doesn't bounce the master ok".

2019-11-12 Thread Lorenzo Bianconi
> From: Numan Siddique > > This testsuite is failing frequently in travis CI and locally when tests are > run with "-j5". > > The test case deletes the chassis row for chassis 'gw2' and expects that this > doesn't cause the chassisresident port on the master ('gw1') to not bounce as > 'gw1' >

[ovs-dev] [PATCH v2] netdev-afxdp: add afxdp specific maximum MTU check

2019-11-12 Thread Eelco Chaudron
Drivers natively supporting AF_XDP will check that a configured MTU size will not exceed the allowed size for AF_XDP. However, when the skb compatibility mode is used there is no check and any value is accepted. This, for example, is the case when using the TAP interface. This fix adds a check to

Re: [ovs-dev] [PATCH ovn] Fix testsuite 85 - "ensure one gw controller restart in HA doesn't bounce the master ok".

2019-11-12 Thread Dumitru Ceara
On Mon, Nov 11, 2019 at 8:15 AM wrote: > > From: Numan Siddique > > This testsuite is failing frequently in travis CI and locally when tests are > run with "-j5". > > The test case deletes the chassis row for chassis 'gw2' and expects that this > doesn't cause the chassisresident port on the

[ovs-dev] Hi! ovs-dev@openvswitch.org

2019-11-12 Thread Le Huy Hoa
We propose Sending your commercial offer through the Contact us form which can be found on the sites in the contact partition. Feedback forms are filled in by our program and the captcha is solved. The profit of this method is that messages sent through feedback forms are whitelisted. This

[ovs-dev] [PATCH v7 ovn 1/2] ovn-northd: Fix get_router_load_balancer_ips() for mixed address families.

2019-11-12 Thread Dumitru Ceara
Function get_router_load_balancer_ips() was incorrectly returning a single address_family even though the IP set could contain a mix of IPv4 and IPv6 addresses. Signed-off-by: Dumitru Ceara --- northd/ovn-northd.c | 126 +-- 1 file changed, 72

Re: [ovs-dev] [PATCHv4] netdev-afxdp: Enable loading XDP program.

2019-11-12 Thread Eelco Chaudron
See one remark below, however when I did a quick test with a program that would not load it goes into some re-try loop: 2019-11-12T10:13:21.658Z|01609|netdev_afxdp|INFO|eno1: Removing xdp program. 2019-11-12T10:13:21.658Z|01610|netdev_afxdp|INFO|Removed program ID: 0, fd: 0

[ovs-dev] [PATCH net-next] openvswitch: add TTL decrement action

2019-11-12 Thread Matteo Croce
New action to decrement TTL instead of setting it to a fixed value. This action will decrement the TTL and, in case of expired TTL, send the packet to userspace via output_userspace() to take care of it. Supports both IPv4 and IPv6 via the ttl and hop_limit fields, respectively. Tested with a

[ovs-dev] [PATCH 1/1] ovsdb-server: fix memory leak while deleting zone

2019-11-12 Thread Damijan Skvarc
memory leak was detected by valgrind during execution of "database commands -- positive checks" test. leaked memory was allocated in ovsdb_execute_mutate() function while parsing mutations from the apparent json entity: ==19563==at 0x4C2DB8F: malloc (in

Re: [ovs-dev] [PATCH ovn] Fix testsuite 85 - "ensure one gw controller restart in HA doesn't bounce the master ok".

2019-11-12 Thread Numan Siddique
On Tue, Nov 12, 2019 at 4:58 PM Dumitru Ceara wrote: > > On Mon, Nov 11, 2019 at 8:15 AM wrote: > > > > From: Numan Siddique > > > > This testsuite is failing frequently in travis CI and locally when tests > > are run with "-j5". > > > > The test case deletes the chassis row for chassis 'gw2'

Re: [ovs-dev] [PATCH ovn v2 02/13] ovn-inb: Interconnection northbound DB schema and CLI.

2019-11-12 Thread Numan Siddique
This patch has some whitespace warning when applying the patch. Applying: ovn-inb: Interconnection northbound DB schema and CLI. .git/rebase-apply/patch:167: new blank line at EOF. + warning: 1 line adds whitespace errors. On Thu, Oct 31, 2019 at 2:45 AM Han Zhou wrote: > > This patch

Re: [ovs-dev] [PATCH ovn v2 01/13] ovn-architecture: Add documentation for OVN interconnection feature.

2019-11-12 Thread Numan Siddique
Hi Han, I have started with reviewing the patches, but with skimming them faster so that I get the complete picture. So you might see some review comments now :) Thanks Numan On Thu, Oct 31, 2019 at 2:44 AM Han Zhou wrote: > > Signed-off-by: Han Zhou > --- > ovn-architecture.7.xml | 107 >

Re: [ovs-dev] [PATCH ovn v2 03/13] ovn-isb: Interconnection southbound DB schema and CLI.

2019-11-12 Thread Numan Siddique
This patch has some whitespace warning when applying the patch. Applying: ovn-isb: Interconnection southbound DB schema and CLI. .git/rebase-apply/patch:171: new blank line at EOF. + warning: 1 line adds whitespace errors. On Thu, Oct 31, 2019 at 2:48 AM Han Zhou wrote: > > This patch

Re: [ovs-dev] [PATCH v2] compat: Add compat fix for old kernels

2019-11-12 Thread Simon Horman
On Tue, Nov 12, 2019 at 08:33:02AM +, Roi Dayan wrote: > > > On 2019-11-12 10:28 AM, Roi Dayan wrote: > > > > > > On 2019-11-12 10:12 AM, Simon Horman wrote: > >> On Mon, Nov 11, 2019 at 04:49:18PM +, Roi Dayan wrote: > >>> > >>> > >>> On 2019-11-11 4:08 PM, Roi Dayan wrote: > >

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-12 Thread Ilya Maximets
On 12.11.2019 19:51, Stokes, Ian wrote: > > > On 11/12/2019 5:15 PM, David Marchand wrote: >> On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: >>> On 11/11/2019 3:01 PM, Ilya Maximets wrote: DPDK commit 660098d61f57 ("pdump: use generic multi-process channel") switched pdump to use

Re: [ovs-dev] [PATCH v3] travis: support ppc64le builds

2019-11-12 Thread Ilya Maximets
On 12.11.2019 18:57, dwilder wrote: > On 2019-11-08 14:52, Ilya Maximets wrote: >> On 06.11.2019 20:20, David Wilder wrote: >>> Add support for travis-ci ppc64le builds. >>> >>> - Updated matrix in .travis.yml to include an arch: ppc64le build. >>> - Move package install needed for 32bit builds to

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 10:10 AM Dumitru Ceara wrote: > > On Tue, Nov 12, 2019 at 6:17 PM Han Zhou wrote: > > > > > > > > On Tue, Nov 12, 2019 at 2:29 AM Dumitru Ceara wrote: > > > > > > ARP request and ND NS packets for router owned IPs were being > > > flooded in the complete L2 domain (using

Re: [ovs-dev] [PATCH v7 ovn 1/2] ovn-northd: Fix get_router_load_balancer_ips() for mixed address families.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 9:02 AM Han Zhou wrote: > > > > On Tue, Nov 12, 2019 at 2:28 AM Dumitru Ceara wrote: > > > > Function get_router_load_balancer_ips() was incorrectly returning a > > single address_family even though the IP set could contain a mix of > > IPv4 and IPv6 addresses. > > > >

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-12 Thread David Marchand
On Tue, Nov 12, 2019 at 8:41 PM Ilya Maximets wrote: > > On 12.11.2019 19:51, Stokes, Ian wrote: > > > > > > On 11/12/2019 5:15 PM, David Marchand wrote: > >> On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: > >>> On 11/11/2019 3:01 PM, Ilya Maximets wrote: > DPDK commit 660098d61f57

Re: [ovs-dev] [PATCH v3 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

2019-11-12 Thread Mark Michelson
For the series: Acked-by: Mark Michelson On 11/12/19 11:47 AM, Dumitru Ceara wrote: Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added support for more types of cookies (partial SB uuids) that are stored in OpenFlow entries created by ovn-controller. The

Re: [ovs-dev] [PATCH ovn v2 04/13] ovn-ic: Interconnection controller with AZ registeration.

2019-11-12 Thread Numan Siddique
On Thu, Oct 31, 2019 at 2:47 AM Han Zhou wrote: > > This patch introduces interconnection controller, ovn-ic, and > implements the basic AZ registration feature: taking the AZ > name from NB DB and create an Availability_Zone entry in > IC-SB DB. > > Signed-off-by: Han Zhou This patch doesn'

[ovs-dev] [PATCH v3 ovn 2/3] ovn-detrace: Fix line parsing.

2019-11-12 Thread Dumitru Ceara
The script was never parsing the first cookie in the input. Also, add a check to make sure that the cookie refers to a Logical_Flow before trying to print the record. Signed-off-by: Dumitru Ceara --- utilities/ovn-detrace.in | 24 ++-- 1 file changed, 14 insertions(+), 10

[ovs-dev] [PATCH v3 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

2019-11-12 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added support for more types of cookies (partial SB uuids) that are stored in OpenFlow entries created by ovn-controller. The last patch in this series implements support for parsing all these different cookies in

[ovs-dev] [PATCH v3 ovn 1/3] ovn-detrace: Fix rundir.

2019-11-12 Thread Dumitru Ceara
After the separation of OVS and OVN rundirs, the ovn-detrace script hasn't been updated to use the OVN rundir instead of the OVS one. Signed-off-by: Dumitru Ceara --- utilities/ovn-detrace.in |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/ovn-detrace.in

Re: [ovs-dev] [PATCH ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-12 Thread Dumitru Ceara
On Tue, Nov 12, 2019 at 5:21 PM Dumitru Ceara wrote: > > On Mon, Nov 11, 2019 at 8:02 PM Mark Michelson wrote: > > > > Hi Dumitru. Everything you've done looks good to me. > > > > However, when reviewing the patch, I educated myself on how ovn-detrace > > is implemented and I found a couple of

[ovs-dev] [PATCH v2.12] ovn: Prevent erroneous duplicate IP address messages.

2019-11-12 Thread Mark Michelson
This is a backport to OVS 2.12 of OVN master commit 21c29d5b0c. When using dynamic address assignment for logical switches, OVN reserves the first address in the subnet for the attached router port to use. In commit 488d153ee87841c042af05bc0eb8b5481aaa98cf, the IPAM code was modified to add

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 2:29 AM Dumitru Ceara wrote: > > ARP request and ND NS packets for router owned IPs were being > flooded in the complete L2 domain (using the MC_FLOOD multicast group). > However this creates a scaling issue in scenarios where aggregation > logical switches are connected

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-12 Thread Stokes, Ian
On 11/12/2019 5:15 PM, David Marchand wrote: On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: On 11/11/2019 3:01 PM, Ilya Maximets wrote: DPDK commit 660098d61f57 ("pdump: use generic multi-process channel") switched pdump to use generic DPDK IPC instead of sockets. Old API was

[ovs-dev] [PATCH ovn] Require Python 3 and remove support for Python 2.

2019-11-12 Thread numans
From: Numan Siddique OVS removed the support for Python 2 in the commit [1]. And its time we do the same for OVN. This patch takes care of removing Python 2 references. [1] - 1ca0323e7c29("Require Python 3 and remove support for Python 2.") Signed-off-by: Numan Siddique --- Makefile.am

Re: [ovs-dev] [PATCH ovn] Require Python 3 and remove support for Python 2.

2019-11-12 Thread Mark Michelson
Hi Numan, A couple of things: 1) It appears that configure will now fail if python3 is not found. Does this mean python is no longer optional when building? If so, I think that needs to be reflected in the commit message. Also, if it's required, then I don't see the point of having the

Re: [ovs-dev] [PATCH v3] travis: support ppc64le builds

2019-11-12 Thread dwilder
On 2019-11-08 14:52, Ilya Maximets wrote: On 06.11.2019 20:20, David Wilder wrote: Add support for travis-ci ppc64le builds. - Updated matrix in .travis.yml to include an arch: ppc64le build. - Move package install needed for 32bit builds to .travis/linux-prepare.sh. To keep the total build

Re: [ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

2019-11-12 Thread Gregory Rose
On 11/12/2019 7:08 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang When using the kernel datapath, the upcall don't include skb hash info relatived. That will introduce some problem, because the hash of skb is important in kernel stack. For example, VXLAN module uses it to select UDP

Re: [ovs-dev] [PATCH v2.12] ovn: Prevent erroneous duplicate IP address messages.

2019-11-12 Thread Mark Michelson
In addition to applying this to 2.12, I am requesting a backport to 2.11 as well. Thank you. On 11/12/19 11:59 AM, Mark Michelson wrote: This is a backport to OVS 2.12 of OVN master commit 21c29d5b0c. When using dynamic address assignment for logical switches, OVN reserves the first address

Re: [ovs-dev] [PATCH v7 ovn 1/2] ovn-northd: Fix get_router_load_balancer_ips() for mixed address families.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 2:28 AM Dumitru Ceara wrote: > > Function get_router_load_balancer_ips() was incorrectly returning a > single address_family even though the IP set could contain a mix of > IPv4 and IPv6 addresses. > > Signed-off-by: Dumitru Ceara > --- > northd/ovn-northd.c | 126

[ovs-dev] CDMX: Planes de carrera y sucesión

2019-11-12 Thread Impacto que tiene en nuestra empresa
06 de Diciembre | Horario de 10:00 A 13:30 Y 15:00 A 18:30 HRS | (hora del centro de México) | PRESENCIAL - CDMX: Planes de carrera y sucesión - ¿De qué hablaremos? La empresa moderna se enfrenta entre otras problemáticas a la rotación de personal. Los nuevos colaboradores buscan

Re: [ovs-dev] [PATCH ovn] Require Python 3 and remove support for Python 2.

2019-11-12 Thread Numan Siddique
On Tue, Nov 12, 2019 at 10:49 PM Mark Michelson wrote: > > Hi Numan, > > A couple of things: > > 1) It appears that configure will now fail if python3 is not found. Does > this mean python is no longer optional when building? I think so. To compile OVN we need to compile OVS and OVS fails anyway

Re: [ovs-dev] [PATCH v2.12] ovn: Prevent erroneous duplicate IP address messages.

2019-11-12 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 ovn: Prevent erroneous duplicate IP address

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-12 Thread Dumitru Ceara
On Tue, Nov 12, 2019 at 6:17 PM Han Zhou wrote: > > > > On Tue, Nov 12, 2019 at 2:29 AM Dumitru Ceara wrote: > > > > ARP request and ND NS packets for router owned IPs were being > > flooded in the complete L2 domain (using the MC_FLOOD multicast group). > > However this creates a scaling issue

Re: [ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

2019-11-12 Thread Tonghao Zhang
On Wed, Nov 13, 2019 at 2:06 AM Gregory Rose wrote: > > > On 11/12/2019 7:08 AM, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > When using the kernel datapath, the upcall don't > > include skb hash info relatived. That will introduce > > some problem, because the hash of skb is

[ovs-dev] [PATCH v3 ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-12 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added cookies for Port_Binding, Mac_Binding, Multicast_Group, Chassis records to the OpenfFlow entries they generate. Add support for parsing such cookies in ovn-detrace too. Also: - refactor ovn-detrace to allow a

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-12 Thread Stokes, Ian
On 11/11/2019 3:01 PM, Ilya Maximets wrote: DPDK commit 660098d61f57 ("pdump: use generic multi-process channel") switched pdump to use generic DPDK IPC instead of sockets. Old API was deprecated and removed. Updating OVS code accordingly. Signed-off-by: Ilya Maximets Thanks for the

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-12 Thread David Marchand
On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: > On 11/11/2019 3:01 PM, Ilya Maximets wrote: > > DPDK commit 660098d61f57 ("pdump: use generic multi-process channel") > > switched pdump to use generic DPDK IPC instead of sockets. > > Old API was deprecated and removed. Updating OVS code

Re: [ovs-dev] [PATCH ovn v2 08/13] ovn-ic: Interconnection gateway controller.

2019-11-12 Thread Numan Siddique
On Thu, Oct 31, 2019 at 2:48 AM Han Zhou wrote: > > Sync local and remote gateways between SB and ISB. > > Signed-off-by: Han Zhou > --- > ic/ovn-ic.c | 147 > > tests/ovn-ic.at | 56 + > 2 files changed, 203

[ovs-dev] [PATCH v2 ovn 1/3] ovn-detrace: Fix rundir.

2019-11-12 Thread Dumitru Ceara
After the separation of OVS and OVN rundirs, the ovn-detrace script hasn't been updated to use the OVN rundir instead of the OVS one. Signed-off-by: Dumitru Ceara --- utilities/ovn-detrace.in |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/ovn-detrace.in

Re: [ovs-dev] [PATCH ovn v2 04/13] ovn-ic: Interconnection controller with AZ registeration.

2019-11-12 Thread Numan Siddique
On Tue, Nov 12, 2019 at 9:12 PM Han Zhou wrote: > > On Tue, Nov 12, 2019 at 4:29 AM Numan Siddique wrote: > > > > On Thu, Oct 31, 2019 at 2:47 AM Han Zhou wrote: > > > > > > This patch introduces interconnection controller, ovn-ic, and > > > implements the basic AZ registration feature: taking

[ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

2019-11-12 Thread xiangxia . m . yue
From: Tonghao Zhang When using the kernel datapath, the upcall don't include skb hash info relatived. That will introduce some problem, because the hash of skb is important in kernel stack. For example, VXLAN module uses it to select UDP src port. The tx queue selection may also use the hash in

[ovs-dev] [PATCH v2 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

2019-11-12 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added support for more types of cookies (partial SB uuids) that are stored in OpenFlow entries created by ovn-controller. The last patch in this series implements support for parsing all these different cookies in

Re: [ovs-dev] [PATCH ovn v2 13/13] tutorial: Add tutorial for OVN Interconnection.

2019-11-12 Thread Han Zhou
On Wed, Oct 30, 2019 at 2:13 PM Han Zhou wrote: > > Added tutorial, and also updated NEWS and TODO. > > Tested-by: Aliasgar Ginwala > Signed-off-by: Han Zhou > --- > Documentation/automake.mk | 1 + > Documentation/tutorials/index.rst | 1 + >

Re: [ovs-dev] [PATCH ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-12 Thread Dumitru Ceara
On Mon, Nov 11, 2019 at 8:02 PM Mark Michelson wrote: > > Hi Dumitru. Everything you've done looks good to me. > > However, when reviewing the patch, I educated myself on how ovn-detrace > is implemented and I found a couple of problems. These problems aren't > introduced by you. However, I think

Re: [ovs-dev] [PATCH ovn v2 04/13] ovn-ic: Interconnection controller with AZ registeration.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 4:29 AM Numan Siddique wrote: > > On Thu, Oct 31, 2019 at 2:47 AM Han Zhou wrote: > > > > This patch introduces interconnection controller, ovn-ic, and > > implements the basic AZ registration feature: taking the AZ > > name from NB DB and create an Availability_Zone

[ovs-dev] [PATCH v2 ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-12 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added cookies for Port_Binding, Mac_Binding, Multicast_Group, Chassis records to the OpenfFlow entries they generate. Add support for parsing such cookies in ovn-detrace too. Also: - refactor ovn-detrace to allow a

[ovs-dev] [PATCH v2 ovn 2/3] ovn-detrace: Fix line parsing.

2019-11-12 Thread Dumitru Ceara
The script was never parsing the first cookie in the input. Also, add a check to make sure that the cookie refers to a Logical_Flow before trying to print the record. Signed-off-by: Dumitru Ceara --- utilities/ovn-detrace.in | 24 ++-- 1 file changed, 14 insertions(+), 10

Re: [ovs-dev] [PATCH net-next] openvswitch: add TTL decrement action

2019-11-12 Thread Simon Horman
On Tue, Nov 12, 2019 at 11:25:18AM +0100, Matteo Croce wrote: > New action to decrement TTL instead of setting it to a fixed value. > This action will decrement the TTL and, in case of expired TTL, send the > packet to userspace via output_userspace() to take care of it. > > Supports both IPv4

Re: [ovs-dev] [PATCH ovn v2 02/13] ovn-inb: Interconnection northbound DB schema and CLI.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 4:24 AM Numan Siddique wrote: > > This patch has some whitespace warning when applying the patch. > > Applying: ovn-inb: Interconnection northbound DB schema and CLI. > .git/rebase-apply/patch:167: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > It

Re: [ovs-dev] [PATCH net-next] openvswitch: add TTL decrement action

2019-11-12 Thread Matteo Croce
On Tue, Nov 12, 2019 at 4:00 PM Simon Horman wrote: > > On Tue, Nov 12, 2019 at 11:25:18AM +0100, Matteo Croce wrote: > > New action to decrement TTL instead of setting it to a fixed value. > > This action will decrement the TTL and, in case of expired TTL, send the > > packet to userspace via

Re: [ovs-dev] [PATCH ovn v2 01/13] ovn-architecture: Add documentation for OVN interconnection feature.

2019-11-12 Thread Han Zhou
Thanks Numan! On Tue, Nov 12, 2019 at 4:23 AM Numan Siddique wrote: > > Hi Han, > > I have started with reviewing the patches, but with skimming them > faster so that I get the complete > picture. So you might see some review comments now :) > > > Thanks > Numan > > > On Thu, Oct 31, 2019 at

Re: [ovs-dev] [PATCH v2] compat: Add compat fix for old kernels

2019-11-12 Thread Simon Horman
On Mon, Nov 11, 2019 at 04:49:18PM +, Roi Dayan wrote: > > > On 2019-11-11 4:08 PM, Roi Dayan wrote: > > > > > > On 2019-11-11 3:39 PM, Simon Horman wrote: > >> On Mon, Nov 04, 2019 at 11:49:44AM +0200, Roi Dayan wrote: > >>> In kernels older than 4.8, struct tcf_t didn't have the

[ovs-dev] [PATCH] lacp: Add support to recognize LACP Marker RX PDUs.

2019-11-12 Thread Nitin katiyar via dev
OVS does not support the LACP Marker protocol. Typically, ToR switches send a LACP Marker PDU when restarting LACP negotiation following a link flap or LACP timeout. When a LACP Marker PDU is received, OVS logs the following warning and drops the packet: “lacp(pmdXXX)|WARN|bond-prv: received

Re: [ovs-dev] [PATCH v2] compat: Add compat fix for old kernels

2019-11-12 Thread Roi Dayan
On 2019-11-12 10:12 AM, Simon Horman wrote: > On Mon, Nov 11, 2019 at 04:49:18PM +, Roi Dayan wrote: >> >> >> On 2019-11-11 4:08 PM, Roi Dayan wrote: >>> >>> >>> On 2019-11-11 3:39 PM, Simon Horman wrote: On Mon, Nov 04, 2019 at 11:49:44AM +0200, Roi Dayan wrote: > In kernels older

Re: [ovs-dev] [PATCH v2] compat: Add compat fix for old kernels

2019-11-12 Thread Roi Dayan
On 2019-11-12 10:28 AM, Roi Dayan wrote: > > > On 2019-11-12 10:12 AM, Simon Horman wrote: >> On Mon, Nov 11, 2019 at 04:49:18PM +, Roi Dayan wrote: >>> >>> >>> On 2019-11-11 4:08 PM, Roi Dayan wrote: On 2019-11-11 3:39 PM, Simon Horman wrote: > On Mon, Nov 04, 2019 at

[ovs-dev] [PATCH v1] ovs container build: Make kernel module configurable

2019-11-12 Thread amginwal
From: Aliasgar Ginwala --with-linux can be made configurable while building containers for leveraging kernel modules installed on host. KERNEL_VERSION=host should be used in env variable for the same. Signed-off-by: Aliasgar Ginwala --- utilities/docker/Makefile | 2 +-

Re: [ovs-dev] [PATCH net 1/2] openvswitch: support asymmetric conntrack

2019-11-12 Thread Nicolas Dichtel
Le 08/11/2019 à 22:07, Aaron Conole a écrit : > The openvswitch module shares a common conntrack and NAT infrastructure > exposed via netfilter. It's possible that a packet needs both SNAT and > DNAT manipulation, due to e.g. tuple collision. Netfilter can support > this because it runs through

Re: [ovs-dev] [PATCH v3 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

2019-11-12 Thread Han Zhou
On Tue, Nov 12, 2019 at 8:47 AM Dumitru Ceara wrote: > > Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") > added support for more types of cookies (partial SB uuids) that are stored > in OpenFlow entries created by ovn-controller. > > The last patch in this series

Re: [ovs-dev] [PATCH v3] travis: support ppc64le builds

2019-11-12 Thread dwilder
On 2019-11-12 11:30, Ilya Maximets wrote: On 12.11.2019 18:57, dwilder wrote: On 2019-11-08 14:52, Ilya Maximets wrote: On 06.11.2019 20:20, David Wilder wrote: Add support for travis-ci ppc64le builds. - Updated matrix in .travis.yml to include an arch: ppc64le build. - Move package install

Re: [ovs-dev] [PATCH v2] netdev-afxdp: Best-effort configuration of XDP mode.

2019-11-12 Thread William Tu
On Thu, Nov 7, 2019 at 3:36 AM Ilya Maximets wrote: > > Until now there was only two options for XDP mode in OVS: SKB or DRV. > i.e. 'generic XDP' or 'native XDP with zero-copy enabled'. > > Devices like 'veth' interfaces in Linux supports native XDP, but > doesn't support zero-copy mode. This

Re: [ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

2019-11-12 Thread Pravin Shelar
On Tue, Nov 12, 2019 at 7:09 AM wrote: > > From: Tonghao Zhang > > When using the kernel datapath, the upcall don't > include skb hash info relatived. That will introduce > some problem, because the hash of skb is important > in kernel stack. For example, VXLAN module uses > it to select UDP src

Re: [ovs-dev] [PATCH net-next] openvswitch: add TTL decrement action

2019-11-12 Thread Pravin Shelar
On Tue, Nov 12, 2019 at 2:25 AM Matteo Croce wrote: > > New action to decrement TTL instead of setting it to a fixed value. > This action will decrement the TTL and, in case of expired TTL, send the > packet to userspace via output_userspace() to take care of it. > > Supports both IPv4 and IPv6

Re: [ovs-dev] [PATCH v3 ovn 2/3] ovn-detrace: Fix line parsing.

2019-11-12 Thread Han Zhou
Hi Dumitru, Thanks for improving the tool. On Tue, Nov 12, 2019 at 8:47 AM Dumitru Ceara wrote: > > The script was never parsing the first cookie in the input. Also, add a > check to make sure that the cookie refers to a Logical_Flow before > trying to print the record. > > Signed-off-by:

Re: [ovs-dev] [PATCH net-next v3] net: openvswitch: add hash info to upcall

2019-11-12 Thread Tonghao Zhang
On Wed, Nov 13, 2019 at 12:54 PM Pravin Shelar wrote: > > On Tue, Nov 12, 2019 at 7:09 AM wrote: > > > > From: Tonghao Zhang > > > > When using the kernel datapath, the upcall don't > > include skb hash info relatived. That will introduce > > some problem, because the hash of skb is important >

Re: [ovs-dev] [PATCH net-next] openvswitch: add TTL decrement action

2019-11-12 Thread Simon Horman
On Tue, Nov 12, 2019 at 04:46:12PM +0100, Matteo Croce wrote: > On Tue, Nov 12, 2019 at 4:00 PM Simon Horman > wrote: > > > > On Tue, Nov 12, 2019 at 11:25:18AM +0100, Matteo Croce wrote: > > > New action to decrement TTL instead of setting it to a fixed value. > > > This action will decrement

[ovs-dev] [PATCH AUTOSEL 4.19 001/209] net: ovs: fix return type of ndo_start_xmit function

2019-11-12 Thread Sasha Levin
From: YueHaibing [ Upstream commit eddf11e18dff0e8671e06ce54e64cfc843303ab9 ] The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return

[ovs-dev] [PATCH AUTOSEL 4.19 011/209] openvswitch: Use correct reply values in datapath and vport ops

2019-11-12 Thread Sasha Levin
From: Yifeng Sun [ Upstream commit 804fe108fc92e591ddfe9447e7fb4691ed16daee ] This patch fixes the bug that all datapath and vport ops are returning wrong values (OVS_FLOW_CMD_NEW or OVS_DP_CMD_NEW) in their replies. Signed-off-by: Yifeng Sun Acked-by: Pravin B Shelar Signed-off-by: David S.

[ovs-dev] [PATCH AUTOSEL 4.4 01/48] net: ovs: fix return type of ndo_start_xmit function

2019-11-12 Thread Sasha Levin
From: YueHaibing [ Upstream commit eddf11e18dff0e8671e06ce54e64cfc843303ab9 ] The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return

Re: [ovs-dev] [PATCH v3] travis: support ppc64le builds

2019-11-12 Thread Lance Yang (Arm Technology China)
Hi, For pip missing issue, we have a workaround. In .travis/linux-prepare.sh. You can install pip or something else with package management commands. For arm64 on travis, we check the environment variables in the container and found a variable called "TRAVIS_ARCH". Thus we can use this

[ovs-dev] [PATCH AUTOSEL 4.14 001/115] net: ovs: fix return type of ndo_start_xmit function

2019-11-12 Thread Sasha Levin
From: YueHaibing [ Upstream commit eddf11e18dff0e8671e06ce54e64cfc843303ab9 ] The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return

[ovs-dev] [PATCH AUTOSEL 4.9 01/68] net: ovs: fix return type of ndo_start_xmit function

2019-11-12 Thread Sasha Levin
From: YueHaibing [ Upstream commit eddf11e18dff0e8671e06ce54e64cfc843303ab9 ] The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, so make sure the implementation in this driver has returns 'netdev_tx_t' value, and change the function return