[ovs-dev] [PATCH ovn] ovn-controller: Check for NULL before accessing ovsrec_open_vswitch row.

From: Numan Siddique There are occasional crashes seen with OpenShift CI gdb) bt * This patch fixes it. Reported-by: Alexander Constantinescu Signed-off-by: Numan Siddique --- controller/ovn-controller.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2] ovn-controller: Check for NULL before accessing ovsrec_open_vswitch row.

From: Numan Siddique There are occasional crashes seen with OpenShift CI gdb) bt 0 hmap_first_with_hash (hmap=0x128, hmap=0x128, hash=2563384147) at include/openvswitch/hmap.h:328 1 smap_find__ (smap=0x128, key=key@entry=0x558de1ab278f "ovn-openflow-probe-interval", key_len=27,

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Check for NULL before accessing ovsrec_open_vswitch row.

On 2/20/20 3:43 PM, num...@ovn.org wrote: > From: Numan Siddique > > There are occasional crashes seen with OpenShift CI > > > gdb) bt > 0 hmap_first_with_hash (hmap=0x128, hmap=0x128, hash=2563384147) at > include/openvswitch/hmap.h:328 > 1 smap_find__ (smap=0x128,

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Check for NULL before accessing ovsrec_open_vswitch row.

On Thu, Feb 20, 2020 at 8:25 PM Dumitru Ceara wrote: > > On 2/20/20 3:43 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > There are occasional crashes seen with OpenShift CI > > > > > > gdb) bt > > 0 hmap_first_with_hash (hmap=0x128, hmap=0x128, hash=2563384147) at > >

Re: [ovs-dev] 答复: [PATCH v4 0/3] Add support for TSO with DPDK

On Thu, Feb 20, 2020 at 10:10:36AM +, Yi Yang (杨�D)-云服务集团 wrote: > Hi, Flavio > > I find this tso feature doesn't work normally on my Ubuntu 16.04, here is my > result. My kernel version is > > $ uname -a > Linux cmp008 4.15.0-55-generic #60~16.04.2-Ubuntu SMP Thu Jul 4 09:03:09 UTC > 2019

Re: [ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

On Wed, Feb 19, 2020 at 9:27 PM Russell Bryant wrote: > > We recently hit a bug in ovn-kubernetes, where I accidentally added > /64 at the end of ipv6_prefix, to match the format we used for the > subnet option for IPv4. This was not allowed. > > This patch update ovn-northd to take the

Re: [ovs-dev] [PATCH] openvswitch: Distribute switch variables for initialization

From: Kees Cook Date: Wed, 19 Feb 2020 22:23:09 -0800 > Variables declared in a switch statement before any case statements > cannot be automatically initialized with compiler instrumentation (as > they are not part of any execution flow). With GCC's proposed automatic > stack variable

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Avoid adding neighbour flows for non-local datapaths.

On Thu, Feb 20, 2020 at 1:58 AM Dumitru Ceara wrote: > > On 2/19/20 6:36 PM, Han Zhou wrote: > > > > > > On Wed, Feb 19, 2020 at 4:50 AM Dumitru Ceara > > wrote: > >> > >> On 2/19/20 12:32 AM, Han Zhou wrote: > >> > This is usefule when external_ids:ovn-monitor-all is

Re: [ovs-dev] [PATCH ovn] ovn-controller: Avoid creating patch port for non-local datapaths.

On Wed, Feb 19, 2020 at 4:45 AM Dumitru Ceara wrote: > > On 2/18/20 11:26 PM, Han Zhou wrote: > > When external-ids:ovn-monitor-all is set to true, patch ports for > > non-local datapaths may be created, which is unnecessary and > > confusing. This patch avoids that by checking if a localnet

Re: [ovs-dev] 答复: [PATCH v4 0/3] Add support for TSO with DPDK

On Thu, Feb 20, 2020 at 2:12 AM Yi Yang (杨燚)-云服务集团 wrote: > > Hi, Flavio > > I find this tso feature doesn't work normally on my Ubuntu 16.04, here is my > result. My kernel version is Hi Yiyang, I'm so confused with your description. Which case does not work for you? Yifeng and Flavio were

Re: [ovs-dev] [PATCH v3 0/2] Support for non-consecutive numa nodes and core ids.

Ovs-numa currently makes the assumption that numa node ids and cpu core ids will be numbered consecutively. Current Power systems don't always follow this model. Furthermore, cpus on Power may be on/off lined based the setting of Simultaneous multithreading (SMT). The result can be gaps in the

[ovs-dev] [PATCHv2 1/2] userspace: Enable TSO support for non-DPDK.

This patch enables TSO support for non-DPDK use cases, and also add check-system-tso testsuite. Before TSO, we have to disable checksum offload, allowing the kernel to calculate the TCP/UDP packet checsum. With TSO, we can skip the checksum validation by enabling checksum offload, and with large

[ovs-dev] [PATCHv2 2/2] tests: Add tests using tap device.

Similar to using veth across namespaces, this patch creates tap devices, assigns to namespaces, and allows traffic to go through different test cases. Signed-off-by: William Tu --- tests/atlocal.in | 3 +++ tests/automake.mk | 1 + tests/system-tap.at | 34

Re: [ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

On Thu, Feb 20, 2020 at 10:46 AM Numan Siddique wrote: > On Wed, Feb 19, 2020 at 9:27 PM Russell Bryant wrote: > > > > We recently hit a bug in ovn-kubernetes, where I accidentally added > > /64 at the end of ipv6_prefix, to match the format we used for the > > subnet option for IPv4. This was

Re: [ovs-dev] 答复: [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

On Thu, Feb 20, 2020 at 11:39:21AM -0800, William Tu wrote: > On Tue, Feb 4, 2020 at 9:12 AM Flavio Leitner wrote: > > > > On Tue, Feb 04, 2020 at 12:00:19PM -0300, Flavio Leitner wrote: > > > On Tue, Feb 04, 2020 at 12:51:24AM +, Yi Yang (杨�D)-云服务集团 wrote: > > > > Hi, Flavio > > The code is

[ovs-dev] OVN 20.03.0 Release: Final call for patches

Hi everyone, We've had the OVN 20.03 branch created for a couple of weeks now, and we've seen some important issues found and fixed since then. Great job! As the branch becomes more stable, we look at the possibility of creating the 20.03.0 release. I think we can make it at the end of next

Re: [ovs-dev] OVN 20.03.0 Release: Final call for patches

On Thu, Feb 20, 2020 at 11:54 AM Mark Michelson wrote: > > Hi everyone, > > We've had the OVN 20.03 branch created for a couple of weeks now, and > we've seen some important issues found and fixed since then. Great job! > > As the branch becomes more stable, we look at the possibility of >

[ovs-dev] 答复: 答复: [PATCH v4 0/3] Add support for TSO with DPDK

No, I didn't use VMs, just veth in netns, I doubt it is Ubuntu kernel bug. -邮件原件- 发件人: William Tu [mailto:u9012...@gmail.com] 发送时间: 2020年2月21日 3:21 收件人: Yi Yang (杨燚)-云服务集团 抄送: f...@sysclose.org; pkusunyif...@gmail.com; d...@openvswitch.org; i.maxim...@ovn.org; txfh2...@aliyun.com 主题:

Re: [ovs-dev] [PATCH] conntrack: Fix conntrack new state

On Thu, Feb 20, 2020 at 4:42 AM Roni Bar Yanai wrote: > > Hi Yi-Hung, > > From the man page, it looks like the +est is the result of committing action > and not related to the TCP state machine itself. > I'm aware that this is not how it works in kernel conntrack, if you want to > align both ,

[ovs-dev] 答复: [PATCHv2 1/2] userspace: Enable TSO support for non-DPDK.

William, which kernel version did you use to test for this patch? I don't want to build a kernel if Ubuntu 16.04 kernel can work. -邮件原件- 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 William Tu 发送时间: 2020年2月21日 3:00 收件人: d...@openvswitch.org 抄送: f...@sysclose.org;

[ovs-dev] 答复: 答复: [PATCH v4 0/3] Add support for TSO with DPDK

Very weird, I built 4.15.9, it is from upstream kernel, the result is same, what's wrong? I can't understand. I directly used current ovs master for this time. $ ./run-iperf3.sh Connecting to host 10.15.1.3, port 5201 [ 4] local 10.15.1.2 port 54078 connected to 10.15.1.3 port 5201 [ ID]

Re: [ovs-dev] [PATCHv2 1/2] userspace: Enable TSO support for non-DPDK.

On Thu, Feb 20, 2020 at 4:50 PM Yi Yang (杨燚)-云服务集团 wrote: > > William, which kernel version did you use to test for this patch? I don't > want to build a kernel if Ubuntu 16.04 kernel can work. > I don't think this patch requires some new kernel feature. I'm using ubuntu 1604. William

[ovs-dev] NRL PROGRAM

Good Day, Capital Fund Corporation Limited are currently offering 95% Non-Recourse Loan (NRL) with our BG Leased Monetization program for trade finance,constructions, credit enhancement, government funding, property investment and all-round range of funding, with 2% interest rate per annul

Re: [ovs-dev] [PATCH ovn] [RFC] Add chassis liveness monitoring mechanism

Thanks for the review Dumitry! On Thu, Feb 20, 2020 at 9:19 AM Dumitru Ceara wrote: > > On 2/19/20 4:37 PM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > NOTE: SENDING THIS PATCH AS A RFC TO SEE WHAT OTHERS MIGHT THINK ABOUT > > THE IDEA PRIOR TO WRITTING TESTS TO IT. > > > >

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Avoid adding neighbour flows for non-local datapaths.

On 2/19/20 6:36 PM, Han Zhou wrote: > > > On Wed, Feb 19, 2020 at 4:50 AM Dumitru Ceara > wrote: >> >> On 2/19/20 12:32 AM, Han Zhou wrote: >> > This is usefule when external_ids:ovn-monitor-all is set to true. >> > >> > Signed-off-by: Han Zhou mailto:hz...@ovn.org>>

[ovs-dev] 答复: [PATCH v4 0/3] Add support for TSO with DPDK

Hi, Flavio I find this tso feature doesn't work normally on my Ubuntu 16.04, here is my result. My kernel version is $ uname -a Linux cmp008 4.15.0-55-generic #60~16.04.2-Ubuntu SMP Thu Jul 4 09:03:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux $ $ ./run-iperf3.sh Connecting to host 10.15.1.3,

Re: [ovs-dev] [PATCH ovn] [RFC] Add chassis liveness monitoring mechanism

On 2/19/20 4:37 PM, lmart...@redhat.com wrote: > From: Lucas Alvares Gomes > > NOTE: SENDING THIS PATCH AS A RFC TO SEE WHAT OTHERS MIGHT THINK ABOUT > THE IDEA PRIOR TO WRITTING TESTS TO IT. > > CMSes integrating with OVN often uses the nb_cfg mechanism as a way to > check the health status of

Re: [ovs-dev] [PATCH] conntrack: Fix conntrack new state

Hi Yi-Hung, >From the man page, it looks like the +est is the result of committing action >and not related to the TCP state machine itself. I'm aware that this is not how it works in kernel conntrack, if you want to align both , the description might need an update. new (0x01)