Hi Ales,
On 3/16/23 19:25, Ales Musil wrote:
> The CT flush was enabled by default for every LB, add
> config option called "ct_flush_enabled" that allows
> users to enable/disable the CT flush. The CT flush is
> remaining enabled by default.
>
> Reported-at: https://bugzilla.redhat.com/2178962
The CT flush was enabled by default for every LB, add
config option called "ct_flush_enabled" that allows
users to enable/disable the CT flush. The CT flush is
remaining enabled by default.
Reported-at: https://bugzilla.redhat.com/2178962
Signed-off-by: Ales Musil
---
NEWS
On 3/16/23 20:44, Dumitru Ceara wrote:
>> diff --git a/ovn-nb.xml b/ovn-nb.xml
>> index 73f707aa0..c5dbebd1d 100644
>> --- a/ovn-nb.xml
>> +++ b/ovn-nb.xml
>> @@ -2041,6 +2041,13 @@ or
>> the affinity timeslot. Max supported affinity_timeout is 65535
>> seconds.
>>
>> +
On 3/16/23 19:25, Ales Musil wrote:
> The CT flush was enabled by default for every LB, add
> config option called "ct_flush_enabled" that allows
> users to enable/disable the CT flush. The CT flush is
> remaining enabled by default.
Quick comment: '_enabled' part in the option name seems
> From: Aaron Conole
> Date: Thursday, 16 March 2023 at 13:00
> To: d...@openvswitch.org
> Cc: Robin Jarry , Gaetan Rivet , Ilya
> Maximets , Eli Britstein , Maxime
> Coquelin , Jason Gunthorpe ,
> Majd Dibbiny , David Marchand march...@redhat.com>, Simon Horman , Flavio
> Leitner
>
Signed-off-by: Naveen Yerramneni
Reviewed-by: Simon Horman
---
Notes:
v1 -> v2
- Fix memory leak and added logs
v2 -> v3
- Addressed nits
NEWS | 2 ++
include/openflow/nicira-ext.h | 10 ++
include/openvswitch/ofp-msgs.h | 4
lib/ofp-bundle.c
On 3/16/2023 11:37 AM, Chris Mi via dev wrote:
On 3/16/2023 12:40 AM, Eelco Chaudron wrote:
On 15 Mar 2023, at 11:07, Chris Mi wrote:
On 3/15/2023 5:28 PM, Eelco Chaudron wrote:
On 15 Mar 2023, at 4:40, Chris Mi wrote:
On 3/10/2023 10:02 PM, Eelco Chaudron wrote:
On 10 Mar 2023, at
On 16 Mar 2023, at 10:24, Eelco Chaudron wrote:
> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>
>> Add two sFlow offload test caes:
>>
>> 3: sflow offloads with sampling=1 - ping between two ports - offloads
>> enabled ok
>> 4: sflow offloads with sampling=2 - ping between two ports -
On 3/16/23 12:49, Eelco Chaudron wrote:
>
>
> On 16 Mar 2023, at 12:00, Ilya Maximets wrote:
>
>> On 3/16/23 10:16, Eelco Chaudron wrote:
>>> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>>>
In thread handler 0, add netdev offload recv in normal recv upcalls.
To avoid starvation, introduce
On 16 Mar 2023, at 13:02, Ilya Maximets wrote:
> On 3/16/23 12:49, Eelco Chaudron wrote:
>>
>>
>> On 16 Mar 2023, at 12:00, Ilya Maximets wrote:
>>
>>> On 3/16/23 10:16, Eelco Chaudron wrote:
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> In thread handler 0, add netdev offload recv in
On 22 Dec 2022, at 13:32, Eelco Chaudron wrote:
> On 22 Dec 2022, at 10:26, Balazs Nemeth wrote:
>
>> The only way that stats->{n_packets,n_bytes} would decrease is due to an
>> overflow, or if there are bugs in how statistics are handled. In the
>> past, there were multiple bugs that caused a
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> Iterate each registered offload API. It's not a problem for today
> since we only have one implementation.
See some comments inline below.
//Eelco
> Signed-off-by: Chris Mi
> Reviewed-by: Roi Dayan
> ---
> lib/netdev-offload.c | 35
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> Add two sFlow offload test caes:
>
> 3: sflow offloads with sampling=1 - ping between two ports - offloads
> enabled ok
> 4: sflow offloads with sampling=2 - ping between two ports - offloads
> enabled ok
Some inline comments below. This completes
On 3/16/23 10:13, Eelco Chaudron wrote:
> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>
>> Initialize psample socket. Add sFlow recv API to receive sampled
>> packets from psample socket. Add sFow recv wait API to add psample
>> socket fd to poll list.
>
> See some comments inline below. and one
Open vSwitch generally tries to let the underlying operating system
managed the low level details of hardware, for example DMA mapping,
bus arbitration, etc. However, when using DPDK, the underlying
operating system yields control of many of these details to userspace
for management.
In the case
On 16 Mar 2023, at 11:48, Ilya Maximets wrote:
> On 3/16/23 10:15, Eelco Chaudron wrote:
>> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>>
>>> Iterate each registered offload API. It's not a problem for today
>>> since we only have one implementation.
>>
>> See some comments inline below.
>>
>>
On 16 Mar 2023, at 12:00, Ilya Maximets wrote:
> On 3/16/23 10:16, Eelco Chaudron wrote:
>> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>>
>>> In thread handler 0, add netdev offload recv in normal recv upcalls.
>>> To avoid starvation, introduce a flag to alternate the order of
>>> receiving
On Thu, Mar 16, 2023 at 08:00:39AM -0400, Aaron Conole wrote:
> Open vSwitch generally tries to let the underlying operating system
> managed the low level details of hardware, for example DMA mapping,
> bus arbitration, etc. However, when using DPDK, the underlying
> operating system yields
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> In thread handler 0, add netdev offload recv in normal recv upcalls.
> To avoid starvation, introduce a flag to alternate the order of
> receiving normal upcalls and offload upcalls based on that flag.
>
> Add similar change for recv_wait.
See some
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> Create a unique group ID to map the sFlow info when offloading sample
> action to TC. When showing the offloaded datapath flows, translate the
> group ID from TC sample action to sFlow info using the mapping.
See some comments inline below.
//Eelco
>
On 3/16/23 10:15, Eelco Chaudron wrote:
> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>
>> Iterate each registered offload API. It's not a problem for today
>> since we only have one implementation.
>
> See some comments inline below.
>
> //Eelco
>
>> Signed-off-by: Chris Mi
>> Reviewed-by: Roi
On 16 Mar 2023, at 7:51, Chris Mi wrote:
> On 3/16/2023 11:37 AM, Chris Mi via dev wrote:
>> On 3/16/2023 12:40 AM, Eelco Chaudron wrote:
>>>
>>> On 15 Mar 2023, at 11:07, Chris Mi wrote:
>>>
On 3/15/2023 5:28 PM, Eelco Chaudron wrote:
> On 15 Mar 2023, at 4:40, Chris Mi wrote:
>
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> When offloading sample action to TC, userspace creates a unique ID
> to map sFlow action and tunnel info and passes this ID to kernel
> instead of the sFlow info. Psample will send this ID and sampled
> packet to userspace. Using the ID, userspace can
On 3/14/23 17:53, Numan Siddique wrote:
> On Thu, Mar 9, 2023 at 9:21 AM Dumitru Ceara wrote:
>>
>> On 3/8/23 15:48, Ales Musil wrote:
>>> On Wed, Mar 8, 2023 at 3:44 PM Dumitru Ceara wrote:
>>>
Chassis in remote AZs are not programmed by the local ovn-northd. So we
don't need to take
On 3/13/23 21:14, Ilya Maximets wrote:
> On 3/13/23 16:28, Dumitru Ceara wrote:
>> ATOMIC_VAR_INIT has been removed in OVS since
>> https://github.com/openvswitch/ovs/commit/71ca8393b700 because it has a
>> trivial definition and was deprecated (to be removed) in newer
>> standards.
>>
>> Stop
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> Initialize psample socket. Add sFlow recv API to receive sampled
> packets from psample socket. Add sFow recv wait API to add psample
> socket fd to poll list.
See some comments inline below. and one question for Ilya ;)
//Eelco
> Signed-off-by: Chris
On 3/16/23 10:16, Eelco Chaudron wrote:
> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>
>> In thread handler 0, add netdev offload recv in normal recv upcalls.
>> To avoid starvation, introduce a flag to alternate the order of
>> receiving normal upcalls and offload upcalls based on that flag.
>>
>>
This commit addresses several high and medium-impact Coverity defects by
fixing several possible null-pointer dereferences and potentially
uninitialized variables.
There were cases when crashes were encountered when some null pointers
were dereferenced. Null pointer checks and alternative code
28 matches
Mail list logo
