> > On 16 May 2018, at 02:38, Anand Kumar
> wrote:
> >
> > The Drop eligible indicator(DEI) is 1 bit wide and it is part of Tag
> > control information (TCI) in VLAN header, which indicates that the
> > frame can be dropped during congestion.
> >
> > Signed-off-by: Anand Kumar
> > ---
> > datapat
Thanks a lot for the series and the benchmarks 😊.
This is not an actual review. I applied the patches and ran the code analysis
and I get the following:
ovs\datapath-windows\ovsext\conntrack-nat.c(151): warning C28167: The function
'OvsNatCleanup' changes the IRQL and does not restore the IRQL bef
> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> ÃŽn numele Anand Kumar
> Trimis: Tuesday, June 19, 2018 8:33 PM
> Către: d...@openvswitch.org
> Subiect: [ovs-dev] [PATCH v4 2/3] datapath-windows: Implement locking in
> conntrack NAT.
>
> This patch prim
On 29 Jun 2018, at 07:02, Justin Pettit
mailto:jpet...@ovn.org>> wrote:
From: Andy Zhou mailto:az...@ovn.org>>
To work with kernel datapath that supports meter.
Signed-off-by: Andy Zhou mailto:az...@ovn.org>>
Signed-off-by: Justin Pettit mailto:jpet...@ovn.org>>
---
v1->v2: D'oh. Stupid typo
The incremental looks good.
Thanks,
Alin.
Sent from phone
> On 29 Jun 2018, at 20:32, Justin Pettit wrote:
>
>
>>> On Jun 29, 2018, at 7:23 AM, Alin Serdean
>>> wrote:
>>>
>>> On 29 Jun 2018, at 07:02, Justin Pettit wrote:
>>
> Subiect: Re: [ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable
> code and goto labels
>
> I think the correct fix may be as follows, do you mind rechecking it?
> Thanks.
>
> diff --git a/datapath/vport.c b/datapath/vport.c index
> 02f6b56d3243..fcf0fea0a245 100644
> --- a/datapath/
e current working directory (one
> per volume letter), so trying to make a file name absolute by just prefixing
> the current working directory for the current volume results in silliness.
>
> This patch attempts to fix the problem.
>
> Found by inspection.
>
> CC: Alin
On 3 Aug 2018, at 18:52, Ben Pfaff mailto:b...@ovn.org>> wrote:
On Fri, Aug 03, 2018 at 03:41:55PM +, Alin Serdean wrote:
abs_file_name() believed that a file name that begins with / or contains :
is absolute and that any other file name is relative. On Windows, this is
wrong in at
.
> -Original Message-
> From: Sairam Venugopal [mailto:vsai...@vmware.com]
> Sent: Friday, October 13, 2017 11:51 PM
> To: Anand Kumar ; d...@openvswitch.org
> Cc: Alin Serdean
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Remove the workaround
> in NAT for TCP
Applied to branch-2.8 as well.
Thanks!
> -Original Message-
> From: Anand Kumar [mailto:kumaran...@vmware.com]
> Sent: Monday, October 16, 2017 11:22 PM
> To: Alin Serdean ; Sairam Venugopal
> ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Rem
tch.org
> Cc: Alin Serdean ; Gurucharan Shetty
>
> Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Update
> OvsIPv4TunnelKey flags in geneve decap.
>
> Thanks for fixing this.
>
> Alin/Guru - Can we back port this to 2.8 too? This causes flow misses when
> geneve opt
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Tuesday, October 31, 2017 9:34 PM
> To: Xiao Liang ; Alin Serdean
>
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to
> include/openvswitch
>
>
names (default
> > > behavior), we shall try to define an alias to overcome dashes if the shell
> allows it.
> > >
> > > Signed-off-by: Alin Gabriel Serdean
> > > Suggested-by: Ben Pfaff
> >
> > Acked-by: Ben Pfaff
>
> I expected that y
> -Original Message-
> From: Xiao Liang [mailto:shaw.l...@gmail.com]
> Sent: Thursday, November 2, 2017 4:32 AM
> To: Alin Serdean
> Cc: Ben Pfaff ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to
> include/openvswitch
>
&g
ly squash patch 3 (the Windows version of xnanosleep)
> > >into patch 2 (the Linux version).
> >
> > I couldn't verify the functionality of windows implementation and hence
> posted it as a separate patch for now.
> > I will squash it once I receive feedback from Ali
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Wednesday, November 22, 2017 2:47 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v1] datapath-windows: Add su
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Tuesday, November 14, 2017 8:48 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v1 1/3] datapath-windows: Refa
eMemoryWithTag(ovsConntrackTable, OVS_CT_POOL_TAG);
> -ovsConntrackTable = NULL;
> -
> -return status;
> +goto freeBucketLock;
> }
>
> ObReferenceObjectByHandle(threadHandle, SYNCHRONIZE, NULL,
> KernelMode, @@ -104,13 +99,28 @@
> OvsInitCon
vember 28, 2017 3:33 PM
> To: d...@openvswitch.org; Alin Serdean
>
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in
> tunnel Decap
>
> Alin, do you think it makes sense to also apply this on 2.8?
>
> --
> Thanks,
> Shashank
&g
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Friday, December 8, 2017 11:24 PM
> To: d...@openvswitch.org
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PATCH 3/5] ovsdb-idl: Fix assertion failure on error
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Friday, December 8, 2017 11:24 PM
> To: d...@openvswitch.org
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PATCH 2/5] ovsdb-idl: Fix indentation in a couple of
t; or
> + * "update" (IDL_S_MONITORING) notifications. */
> IDL_S_MONITORING_COND,
> +IDL_S_MONITORING,
> +
> +/* Terminal error state that indicates that nothing useful can be done.
> + * The most likely reason is that the database server doesn
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Friday, December 8, 2017 11:24 PM
> To: d...@openvswitch.org
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PATCH 4/5] ovsdb-idl: Remove 'uuid' member of struct
>
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Friday, December 8, 2017 11:25 PM
> To: d...@openvswitch.org
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PATCH 5/5] ovsdb-idl: Tolerate initialization races f
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Tuesday, December 12, 2017 12:30 AM
> To: Alin Serdean
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.
>
> On Mon, Dec 11, 2017 at 08:23:44PM +
-NdisFreeRWLock(ovsConntrackLockObj);
-ovsConntrackLockObj = NULL;
+for (UINT32 i = 0; i < CT_HASH_TABLE_SIZE; i++) {
+if (ovsCtBucketLock[i] != NULL) {
[Alin Serdean] datapath-windows\ovsext\conntrack.c(154): warning C6001: Using
uninitialized memory '*ovsCtBucketLock&
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
ÃŽn numele Anand Kumar
Trimis: Monday, January 29, 2018 8:28 PM
Către: d...@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 3/3] datapath-windows: Optimize conntrac
ess: 6001)
if (ovsCtBucketLock[i] != NULL) {
NdisFreeRWLock(ovsCtBucketLock[i]);
}
and applied it on master.
Alin.
-Mesaj original-
De la: Alin Serdean
Trimis: Friday, February 2, 2018 10:52 PM
Către: Anand Kumar ; d...@openvswitch.org
Subiect:
Looks good just a small nit:
s/syn/SYN/g
s/ack/ACK/g
Also I would prefer if you drop the text `Invalid!`. Either just remove it or
expand it, i.e.:
"Invalid! ICMPhdr cannot be NULL" => "Invalid ICMP packet detected the header
cannot be NULL"
Thanks,
Alin.
-Mesaj original-
De la: ovs-de
Applied on master. Ty!
-Mesaj original-
De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
ÃŽn numele aserd...@ovn.org
Trimis: Saturday, February 3, 2018 12:48 AM
Către: 'Anand Kumar' ; d...@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Ad
Kumar
; Alin Serdean ;
d...@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile
targets
That is not consistent with how we specify the Debug/Release flag. There is no
need to do the whole configure if you specify the targets correctly. Running
multiple
Please disregard this patch. Copy/paste error 😊
> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> ÃŽn numele Alin Gabriel Serdean
> Trimis: Thursday, March 8, 2018 8:09 PM
> Către: d...@openvswitch.org
> Cc: Alin Gabriel Serdean
> Subiect: [ovs-dev] [PAT
Hi Anand,
Thanks a lot for the patch.
At first glance the code looks ok. Just a small nit pick, can you please use a
new memory pool tag instead of using `OVS_MEMORY_TAG`.
Please define a new member after
https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Util.h#L41
This w
lockObj for the entry.
> +*--
> +--
> +*/
> +NDIS_STATUS
[Alin Serdean] Another small nit pick:
Please change comments from form:
/*
*
*/
To
/*
*
*/
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
oth of you can benefit from it
later.
What do you think Sai?
Also if you pass the forwarding context I don't think you will need the
following, passing it over too multiple functions:
> +PNET_BUFFER_LIST newNbl = NULL;
[Alin Serdean] and initialize the curNbl from ovsFwdCtx with the
etDelta;
> };
> +UINT16 mru;
> };
>
> UINT64 value[MEM_ALIGN_SIZE(16) >> 3];
[Alin Serdean] Please increase the size of value to adjust for the new value
(`mru`)
diff --git a/datapath-
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Since you split the functionality on `BOOLEAN isFragment` mind just creating
new function and leaving FixSegmentHeader as is. I think it would look much
cleaner.
Thanks,
Alin.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Beh
Mind creating a function for it? You will need to add the same for
OvsTunnelPortTx as well, otherwise the packet won't be fragmented to the vif
value before sending it via a tunnel type (i.e. vxlan).
I will try to explain more on patch 0.
> -Original Message-
> From: ovs-dev-boun...@ope
Hi Yin,
I'm back sorry it took a while 😊.
When applying `OvsUpdateAddressAndPort` for some reason there still is a
problem with the checksums.
There are two aspects which apparently are hit for some reason:
1. normal packet.
2. tcp segment.
If I disable tcp/udp checksums(on the NIC) normal pac
Thanks a lot for all the hard work Anand!
The patches are in good state overall with some small nits 😊.
In the comments over the patches I said I will add an incremental for them.
I attached a diff to hopefully get you going.
Disregarding the changes to ` OvsApplySWChecksumOnNB` which I
Thanks a lot for fixing the leak Eric!
We should apply on 2.7 as well, but needs a rebase.
Is it okay if we add the function call on 2.7 as well or should we limit it too
WIN32?
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev
Thanks!
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Joe Stringer
> Sent: Thursday, April 13, 2017 12:00 AM
> To: ovs dev
> Cc: Eric Garver
> Subject: Re: [ovs-dev] [PATCH 1/3] dpif-netlink: Fix memory leak on port
Patch:
https://github.com/openvswitch/ovs/commit/0c15b76511e78a1f84dec49138d7169c2f3eedf6
introduced a version variable for the MSI itself but did not propagate it
too the driver version (used by the windows certificate tests).
This patch updates the driver version.
Signed-off-by: Alin Gabriel Se
From: Alin Serdean
When trying to uninstall/disable the OVS extension the driver will
fail to unload properly(require reboot)/hang until ovs-vswitchd is closed.
The root cause of this behavior is because the handles from ovs-vswitchd
to the kernel communication devices are still opened although
getpid()); because pid_t might
> be
> short or int or long.
[Alin Serdean] Thanks for the review Ben, I totally missed that.
Although being MSFT specific if we replace getpid with GetCurrentProcessId
(https://msdn.microsoft.com/en-us/library/windows/desktop/ms683180(v=vs.85).aspx)
and from incl
as we already have for `string.h`.
What do you think?
Thanks,
Alin.
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Saturday, April 15, 2017 6:27 AM
> To: Sairam Venugopal
> Cc: Alin Serdean ;
> d...@openvswitch.org
> Subject: Re: [ovs-dev]
es in the series are
> needed before this one can be applied, so I'll wait for the next revision of
> the
> series before applying it.
[Alin Serdean] You are correct in your assumption 😊. I will post another
revision once we clarify the rest of the reviews.
dnesday, April 19, 2017 7:55 AM
> To: Alin Serdean
> Cc: Sairam Venugopal ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 02/10] windows: add definition of getpid and
> getcwd
>
> I don't know how much risk there is. If the values actually returned in
> practi
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Wednesday, April 19, 2017 7:46 AM
> To: Alin Serdean
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 03/10] windows: add includes to daemon-
> windows
>
> On Wed, Apr 19, 201
Looks good, just one small nit: since `OvsForwardingContext` is public now
could you specify it in the commit message?
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Yin Lin
> Sent: Tu
Can you please rebase this, I get the following when trying to apply them:
$ git apply
../ovs-dev-2-4-v3-datapath-windows-Add-support-for-NAT-in-conntrack.patch
error: patch failed: datapath-windows/ovsext/Conntrack.c:751
error: datapath-windows/ovsext/Conntrack.c: patch does not apply
> -Or
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Yin Lin
> Sent: Wednesday, April 19, 2017 11:19 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] datapath-windows: Pass fwdCtx to conntra
Until now we only needed to compute software checksums on net buffer lists
containing a single net buffer.
This patch allows the software checksums to be applied on a net buffer list
with multiple net buffers. The hard assumption for this, is the net buffers are
part of the same connection. The po
).
Thanks,
Alin.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Wednesday, April 19, 2017 8:03 AM
> To: Ben Pfaff
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PA
The Windows build is failing because EPFNOSUPPORT does not exist.
An equivalent is supplied using the WinSock API: WSAEPFNOSUPPORT.
Signed-off-by: Alin Gabriel Serdean
---
include/windows/windefs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/windows/windefs.h b/include/windows
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Saturday, May 6, 2017 12:12 AM
To: Alin Serdean
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] windows: fix broken build
On 5 May 2017 at 13:20, Alin Serdean
mailto:aserd...@cloudbasesolutions.com>> wrote:
The Windows build is f
ECURITY_DESCRIPTOR psd = NULL;
> +HANDLE npipe;
> +
> +/* Disable access over network. */
> + if (!AllocateAndInitializeSid(&sia, 1, SECURITY_NETWORK_RID,
> + 0, 0, 0, 0, 0, 0, 0, &remoteAccessSid)) {
[Alin Serdean] add print error pls
ugopal [mailto:vsai...@vmware.com]
> Sent: Saturday, May 6, 2017 3:16 AM
> To: Alin Serdean ;
> d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] Windows: Secure the namedpipe
> implementation
>
> Hi Alin,
>
> I think the existing behavior requires an elevated Command
&
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 5, 2017 1:13 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v8 1/5] datapath-windows: Added a new
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 5, 2017 1:13 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v8 2/5] datapath-windows: Added Ipv4
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 5, 2017 1:13 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v8 3/5] datapath-windows: Retain MRU
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 5, 2017 1:13 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v8 4/5] datapath-windows: Updated
> O
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 5, 2017 1:13 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v8 5/5] datapath-windows: Fragment NB
Thanks a lot for the series and for integrating all the comments!
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Anand Kumar
> Sent: Friday, May 5, 2017 1:13 AM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH v8
Thanks a lot for the patch! Me and Sai talked offline and we will add the
creator (owner) user to be added in another incremental.
Could you please apply it on master, branch-2.7, branch-2.6?
Tested-by: Alin Gabriel Serdean
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: o
Thanks a lot for the patch.
I had to double look the changes.
It may be worth adding to the commit message that this impacts the way the
"ovsext.sys" product version will be generated.
At the moment, only the file version of the sys attributes will be generated
correctly. The product version is
BLOCK "VarFileInfo"
--
2.10.2.windows.1
Without the need to change the vcxproj.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Monday, May 15, 2017 11:50 PM
> To: Shashank
Sorry I cut a bit to much. Like the following (also attached):
---
datapath-windows/ovsext/ovsext.rc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/ovsext.rc
b/datapath-windows/ovsext/ovsext.rc
index a7cf0a7..20e54bf 100644
--- a/datapath-windows/ov
Just one small nit if you want to fix it (but not necessarily needed): no
newline at the end of file.
This is because editing the file via the GUI strips down eol.
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@open
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Actions.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/datapath-windows/ovsext/Actions.c
b/datapath-windows/ovsext/Actions.c
index e2eae9a..ebfb8a3 100644
--- a
When a conntrack action is applied over an IP fragment we pend the fragment
which will be consumed later. This should be transparent to the userspace.
Report that the action was applied successfully so it does not spam
the ovs-vswitchd log.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windo
Update the key used by the actions which follow up defragmentation, with
no fragment set in the IP header.
Found while testing OVN with two VMs on the same host.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Actions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapat
Found using static analysis tools.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/IpFragment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/IpFragment.c
b/datapath-windows/ovsext/IpFragment.c
index 675c32e..0874cb9 100644
--- a/dat
> -Original Message-
> From: Sairam Venugopal [mailto:vsai...@vmware.com]
> Sent: Wednesday, May 17, 2017 9:05 PM
> To: Yin Lin ; d...@openvswitch.org
> Cc: Alin Serdean
> Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module
> in conntrack
>
&
getcwd - is used in lib/util.c. getcwd is deprecated on Windows but has
_getcwd which is defined in :
https://msdn.microsoft.com/en-us/library/sf98bd4y(v=vs.120).aspx
getpid - is used in several files (i.e. lib/vlog.c). getpid
is also and deprecated and _getpid should be used:
https://msdn.microso
Gcc compiler argument -Wall contains -Wimplicit-function-declaration which
gives warnings when a function is used before declared.
Map VStudio compiler error C4013 to it.
More info on C4013:
https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx
At the moment we cannot switch to the equivalent -We
Add fatal-signal.h include since it uses: fatal_signal_atexit_handler
and fatal_signal_add_hook
Use the defined getpid() function and also include since
it is defined in include/windows/unistd.h .
Signed-off-by: Alin Gabriel Serdean
---
v2: change fprintf %d to %ld (Ben Pfaff)
---
lib/daemon-w
If the service manager issued a stop service, the control handler
registered by the running daemon should report that service changed
state.
Signed-off-by: Alin Gabriel Serdean
---
lib/daemon-windows.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/daemon-windows.c b/lib/daemon-windows.
allocate memory for all the interfaces"); @@ -
> 443,7 +443,7 @@ netdev_windows_get_next_hop(const struct in_addr
> *host,
> return ENXIO;
> }
[Alin Serdean] remove if
>
> -all_addr = (IP_ADAPTER_ADDRESSES *) malloc(buffer_length);
> +all_addr = (IP_
Branch-2.7 at least please. Branch-2.6 and branch-2.5 does not have the wmi.c
file
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Saturday, May 20, 2017 1:52 AM
> To: Guru Shetty
> Cc: ovs dev
> Sub
bably
> indicates that some .c file has forgotten it. (But the Makefile checks for
> that,
> so it is unlikely.)
>
> Thanks,
>
> Ben.
[Alin Serdean] I did a clean compile and a run of unit tests and everything was
ok.
I included for
https://github.com/openvswitch/ovs/blo
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Saturday, May 20, 2017 2:25 AM
> To: Alin Serdean
> Cc: Guru Shetty ; ovs dev
> Subject: Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc
>
> OK, I backported all the way to
From: Alin Serdean
Add fatal-signal.h include since it uses: fatal_signal_atexit_handler
and fatal_signal_add_hook
Use the defined getpid() function and also include since
it is defined in include/windows/unistd.h .
Signed-off-by: Alin Gabriel Serdean
---
v3: no change
v2: change fprintf %d
From: Alin Serdean
getcwd - is used in lib/util.c. getcwd is deprecated on Windows but has
_getcwd which is defined in :
https://msdn.microsoft.com/en-us/library/sf98bd4y(v=vs.120).aspx
getpid - is used in several files (i.e. lib/vlog.c). getpid
is also and deprecated and _getpid should be used
From: Alin Serdean
Gcc compiler argument -Wall contains -Wimplicit-function-declaration which
gives warnings when a function is used before declared.
Map VStudio compiler error C4013 to it.
More info on C4013:
https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx
At the moment we cannot switch
'multiple bridges share a controller' hangs on windows because it is
lacking the exit information (it will hang when the test has finished)
Introduce a pidfile to 'ovs-testcontroller' and end it on exit based on
the pidfile.
Signed-off-by: Alin Gabriel Serdean
---
tests/bridge.at | 3 ++-
1 fil
> -Original Message-
> From: Joe Stringer [mailto:j...@ovn.org]
> Sent: Tuesday, May 23, 2017 2:39 AM
> To: Alin Serdean
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] tests: fix hanging test on windows
>
> On 22 May 2017 at 05:18, Alin Serdean
From: Alin Serdean
'multiple bridges share a controller' hangs on windows because it is
lacking the exit information (it will hang when the test has finished)
Introduce a pidfile to 'ovs-testcontroller' and end it on exit based on
the pidfile.
Signed-off-by: Alin Gabriel S
Just one small nit on this one
> datapath-windows/ovsext/Conntrack-icmp.c \
> datapath-windows/ovsext/Conntrack-other.c \
> datapath-windows/ovsext/Conntrack-related.c \
> +datapath-windows/ovsext/Conntrack-nat.c \
[Alin Serdean] tab instead of 4 space
>
ows/ovsext/Conntrack-nat.c \
> datapath-windows/ovsext/Conntrack-tcp.c \
> -datapath-windows/ovsext/Conntrack-nat.h \
> + datapath-windows/ovsext/Conntrack-nat.h \
[Alin Serdean] Just use tab instead of 4 spaces in patch 2/4
> datapath-windows/ovsext/Conntrack.c \
>
The removal is mandatory to use the VStudio 2013 static code analyzer.
The only function that was used from the include is: 'StringCbLengthA'.
We were not checking the result of that function, nor will the
'vportGet->name' exceed the 'OVS_MAX_PORT_NAME_LENGTH' limitation.
Signed-off-by: Alin Gabr
This patch adds the new make target 'datapath_windows_analyze' (static
analysis over the windows datapath code) to the appveyor build.
Signed-off-by: Alin Gabriel Serdean
---
appveyor.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/appveyor.yml b/appveyor.yml
index edcead6..6ca1479 10064
Add two new build targets: 'Win8Analyze' and 'Win8.1Analyze'.
The new build targets have the static code analyzer (built in Visual
Studio feature).
This patch also introduces a new make target ('datapath_windows_analyze')
this can be added to the CI jobs to get a list warnings/errors issued
by the
Thanks a lot!
Alin.
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Thursday, May 25, 2017 6:52 PM
To: Alin Serdean
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 3/3] appveyor: Add new make target
On 23 May 2017 at 10:59, Alin Serdean
mailto:aserd...@cloudbasesolutions.com>>
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Shashank Ram
> Sent: Wednesday, August 2, 2017 1:08 AM
> To: Anand Kumar ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-w
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Wednesday, August 9, 2017 12:57 AM
> To: d...@openvswitch.org
> Cc: Ben Pfaff ; Alin Serdean
>
> Subject: [PATCH] m4: Add pkg.m4 from pkg-config.
>
> Thi
Thanks a lot for the patch!
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Wednesday, August 9, 2017 2:05 AM
> To: d...@openvswitch.org
> Cc: Ben Pfaff ; Alin Serdean
>
> Subject: [PATCH v2] nsh: Avoid zero-le
Acked-by: Alin Gabriel Serdean
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Wednesday, August 9, 2017 2:37 AM
> To: d...@openvswitch.org
> Cc: Ben Pfaff ; Alin Serdean
>
> Subject: [PATCH] netdev-dummy: Close pcap files when dummy device is
1:42 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code
> comparison in CT lookup
>
> - Update the CT comparison function to compare individual fields instead of
> NdisEqualMemory.
[Alin Serdean] I don't like this change
We should revisit how we do hashes and compares over the 'OVS_CT_KEY' at some
point.
As you pointed "/* icmp_id and port overlap in the union */"
You can drop the lines:
> HASH_ADD(src.port);
> HASH_ADD(dst.port);
And
> FIELD_COMPARE(src.port);
> FIELD_COMPARE(dst.port);
the o
1 - 100 of 437 matches
Mail list logo
