[ovs-dev] [DPDK:patch_v5 8/8] Update NEWS for userspace datapath NAT

2017-02-08 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index aebd99c..890549f 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@ Post-v2.7.0 - Tunnels: * Added support to set packet mark for tunnel endpoint

[ovs-dev] [DPDK:patch_v5 7/8] Enable NAT tests for userspace datapath.

2017-02-08 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f71a..6e3d468 100644 --- a/tests/system-userspace-mac

[ovs-dev] [DPDK:patch_v5 1/8] Export packet_set_ipv6_addr() for DPDK.

2017-02-08 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/packets.c | 2 +- lib/packets.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/packets.c b/lib/packets.c index fa70df6..94e7d87 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -986,7

[ovs-dev] [DPDK:patch_v5 0/8] Userspace Datapath: Introduce NAT support.

2017-02-08 Thread Darrell Ball
4 billion using internal adjustment (user visibility not required). Some cleanup of deprecated code path. Parse out some more changes as separate patches. v1->v2: Updates/fixes that were missed in v1 patches. Darrell Ball (8): Export packet_set_ipv6_addr() for DPDK.

[ovs-dev] [DPDK:patch_v5 3/8] Remove batch sorting in userspace conntrack.

2017-02-08 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 49 ++--- 1 file changed, 10 insertions(+), 39 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 0a611a2..ee515a0 100644 --- a/lib/conntrack.c +++ b/lib/connt

Re: [ovs-dev] [patch_v4 4/6] Unset CS_NEW for established connections.

2017-02-07 Thread Darrell Ball
On 1/27/17, 5:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele Di Proietto" <ovs-dev-boun...@openvswitch.org on behalf of diproiet...@ovn.org> wrote: 2017-01-24 20:40 GMT-08:00 Darrell Ball <dlu...@gmail.com>: > Signed-off-by: Darre

Re: [ovs-dev] [patch_v4 1/6] Export packet_set_ipv6_addr()fordpdkdatapath.

2017-02-07 Thread Darrell Ball
On 1/27/17, 5:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele Di Proietto" <ovs-dev-boun...@openvswitch.org on behalf of diproiet...@ovn.org> wrote: 2017-01-24 20:40 GMT-08:00 Darrell Ball <dlu...@gmail.com>: > Signed-off-by: Darrell Ball <dlu

[ovs-dev] [patch_v1 3/3] Enable NAT tests for userspace datapath

2017-01-22 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f71a..6e3d468 100644 --- a/tests/system-userspace-mac

[ovs-dev] [patch_v1 1/3] Export packet_set_ipv6_addr() for dpdk datapath

2017-01-22 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/packets.c | 2 +- lib/packets.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/packets.c b/lib/packets.c index fa70df6..94e7d87 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -986,7

[ovs-dev] [patch_v1 0/3] Userspace Datapath: introduce NAT support.

2017-01-22 Thread Darrell Ball
(). alg and fragmentation support are not included here but are being worked on. NEWS is not updated in this series yet, until confirmation of release. I realize patch 2 is big. It may be clearer and easier to keep as a single patch, so I have done that after some discussion. Darrell Ball (3

[ovs-dev] [patch_v3 2/5] Parse NAT netlink for userspace datapath.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 9 -- lib/conntrack.c | 3 +- lib/conntrack.h | 31 +- lib/dpif-netdev.c | 85 ++--- tests/test-conntrack.c | 8 +++-- 5

[ovs-dev] [patch_v3 1/5] Export packet_set_ipv6_addr() fordpdkdatapath.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/packets.c | 2 +- lib/packets.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/packets.c b/lib/packets.c index fa70df6..94e7d87 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -986,7

[ovs-dev] [patch_v3 4/5] unset CS_NEW for established connections

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/conntrack.c b/lib/conntrack.c index c629541..d618f24 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -441,6 +441,7 @@ conn_update_state(struct conntrack *ct,

[ovs-dev] [patch_v3 5/5] Enable NAT tests for userspace datapath.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f71a..6e3d468 100644 --- a/tests/system-userspace-mac

[ovs-dev] [patch_v3 0/5] Userspace Datapath: introduce NAT support.

2017-01-24 Thread Darrell Ball
ome cleanup of deprecated code path. Parse out some more changes as separate patches. v1->v2: Updates/fixes that were missed in v1 patches. Darrell Ball (5): Export packet_set_ipv6_addr() fordpdkdatapath. Parse NAT netlink for userspace datapath. Userspace Datapath Con

[ovs-dev] [patch_v4 2/6] Parse NAT netlink for userspace datapath.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 9 -- lib/conntrack.c | 3 +- lib/conntrack.h | 29 - lib/dpif-netdev.c | 85 ++--- tests/test-conntrack.c | 8 +++-- 5

[ovs-dev] [patch_v4 0/6] Userspace Datapath: Introduce NAT support.

2017-01-24 Thread Darrell Ball
e path. Parse out some more changes as separate patches. v1->v2: Updates/fixes that were missed in v1 patches. Darrell Ball (6): Export packet_set_ipv6_addr()fordpdkdatapath. Parse NAT netlink for userspace datapath. Userspace Datapath: Introduce NAT support. Uns

[ovs-dev] [patch_v4 1/6] Export packet_set_ipv6_addr()fordpdkdatapath.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/packets.c | 2 +- lib/packets.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/packets.c b/lib/packets.c index fa70df6..94e7d87 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -986,7

[ovs-dev] [patch_v4 4/6] Unset CS_NEW for established connections.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/conntrack.c b/lib/conntrack.c index 34728a6..aaecb00 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -443,6 +443,7 @@ conn_update_state(struct conntrack *ct,

[ovs-dev] [patch_v4 3/6] Userspace Datapath: Introduce NAT support.

2017-01-24 Thread Darrell Ball
be further optimized, if the need becomes clear. Some NAT options with limited utility (persistent, random) are not supported yet, but will be supported in a later patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 16 +- lib/conntrack.c

[ovs-dev] [patch_v4 6/6] Enhance V6 NAT test.

2017-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 29dd6d6..a15e059 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2

Re: [ovs-dev] [patch_v6 4/8] dpdk: Userspace Datapath: Introduce NAT Support.

2017-02-21 Thread Darrell Ball
On 2/21/17, 1:12 PM, "ovs-dev-boun...@openvswitch.org on behalf of Flavio Leitner" <ovs-dev-boun...@openvswitch.org on behalf of f...@sysclose.org> wrote: On Thu, Feb 16, 2017 at 12:47:35AM -0800, Darrell Ball wrote: > This patch introduces NAT support for the

[ovs-dev] [patch_v6 3/8] dpdk: Remove batch sorting in userspace conntrack.

2017-02-16 Thread Darrell Ball
clarity. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 49 +++-- 1 file changed, 11 insertions(+), 38 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 0a611a2..d0e106f 100644 --- a/lib/conntrack.c +++ b/lib/connt

[ovs-dev] [patch_v6 5/8] dpdk: Enhance V6 NAT test.

2017-02-16 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-traffic.at | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 29dd6d6..a15e059 100644 --- a/

[ovs-dev] [patch_v6 0/8] Userspace Datapath: Introduce NAT support.

2017-02-16 Thread Darrell Ball
stment (user visibility not required). Some cleanup of deprecated code path. Parse out some more changes as separate patches. v1->v2: Updates/fixes that were missed in v1 patches. Darrell Ball (8): dpdk: Export packet_set_ipv6_addr() for DPDK. dpdk: Parse NAT netlink for use

[ovs-dev] [patch_v6 6/8] dpdk: Add missing CHECK_CONNTRACK_ALG guards.

2017-02-16 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-traffic.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index a15e059..e97a45d 100644 --- a/tests/system-traffic.at

[ovs-dev] [patch_v6 4/8] dpdk: Userspace Datapath: Introduce NAT Support.

2017-02-16 Thread Darrell Ball
be further optimized, if the need becomes clear. Some NAT options with limited utility (persistent, random) are not supported yet, but will be supported in a later patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 16 +- lib/conntrack.c

[ovs-dev] [patch_v6 7/8] dpdk: Enable NAT tests for userspace datapath.

2017-02-16 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f

[ovs-dev] [patch_v6 8/8] dpdk: Update feature alert documentation

2017-02-16 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- Documentation/faq/releases.rst | 2 +- NEWS | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 319c2d7..eb9187c

[ovs-dev] [patch_v6 2/8] dpdk: Parse NAT netlink for userspace datapath.

2017-02-16 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 9 -- lib/conntrack.c | 3 +- lib/conntrack.h | 29 - lib/dpif-netdev.c | 83 +++-- tests/test-conntrack.c | 8 +++-- 5

[ovs-dev] [patch_v6 1/8] dpdk: Export packet_set_ipv6_addr() for DPDK.

2017-02-16 Thread Darrell Ball
The NAT changes in this series need both packet_set_ipv4_addr() and packet_set_ipv6_addr() exporting, however, the ipv4 api was exported with an unrelated patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- lib/packets.c | 2 +- l

[ovs-dev] [patch_v2 1/3] Export packet_set_ipv6_addr() for dpdkdatapath.

2017-01-23 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/packets.c | 2 +- lib/packets.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/packets.c b/lib/packets.c index fa70df6..94e7d87 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -986,7

[ovs-dev] [patch_v2 2/3] Userspace Datapath: Introduce NAT support.

2017-01-23 Thread Darrell Ball
. Some NAT options with limited utility (persistent, random) are not supported yet, but will be supported in a later patch. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 25 +- lib/conntrack.c | 724 ++-

[ovs-dev] [patch_v2 3/3] Enable NAT tests for userspace datapath.

2017-01-23 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f71a..6e3d468 100644 --- a/tests/system-userspace-mac

[ovs-dev] [patch_v2 0/3] Userspace Datapath: introduce NAT support.

2017-01-23 Thread Darrell Ball
of release. I realize patch 2 is big. It may be clearer and easier to keep as a single patch, so I have done that after some discussion. v1->v2: Updates/fixes that were missed in v1 patches. Darrell Ball (3): Export packet_set_ipv6_addr() for dpdkdatapath. Userspace Datapath: Introduce NAT supp

Re: [ovs-dev] conditional monitoring

2016-11-10 Thread Darrell Ball
Hi Ben The V6 rebase went to the mailing list on Nov. 4, labelled [patch_v6] ovn: Add datapaths of interest filtering. I don’t see it in patchwork, but I guess that is expected, at that moment. In the interim, the following conflicting commit went in: "Add support for specifying SSL

[ovs-dev] [patch_v7] ovn: Add datapaths of interest filtering.

2016-11-11 Thread Darrell Ball
gt; CC: Liran Schour <lir...@il.ibm.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> --- v6->v7: Rebase v5->v6: Rebase; fix stale handling. v4->v5: Correct cleanup of monitors. Fix warning. v3->v4: Refactor after incremental processing backout. Li

[ovs-dev] [patch_v13] ovn: Add datapaths of interest filtering.

2016-12-09 Thread Darrell Ball
Pfaff <b...@ovn.org> CC: Liran Schour <lir...@il.ibm.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> --- v12->v13: Add mac binding and multicast group monitoring to always handle referential checks in the db client idl on deletes. Due to above, e

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-09 Thread Darrell Ball
From: Mickey Spiegel <mickeys@gmail.com> Date: Wednesday, December 7, 2016 at 3:50 PM To: Darrell Ball <db...@vmware.com> Cc: Darrell Ball <dlu...@gmail.com>, ovs dev <d...@openvswitch.org> Subject: Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filterin

Re: [ovs-dev] [PATCH] ovn-controller: Fix duplicated flows in table 32.

2016-12-13 Thread Darrell Ball
From: Han Zhou <zhou...@gmail.com> Date: Tuesday, December 13, 2016 at 10:28 PM To: Darrell Ball <db...@vmware.com> Cc: "d...@openvswitch.org" <d...@openvswitch.org> Subject: Re: [ovs-dev] [PATCH] ovn-controller: Fix duplicated flows in table 32. Hi Darrell, The d

Re: [ovs-dev] [PATCH] ovn-controller: Fix duplicated flows in table 32.

2016-12-13 Thread Darrell Ball
On 12/13/16, 8:18 PM, "ovs-dev-boun...@openvswitch.org on behalf of Han Zhou" wrote: In commit 475f0a2c it introduced a priority 150 flow for skipping VXLAN traffic. However, it added the flow for every remote port

Re: [ovs-dev] [PATCH] FAQ: Document the necessity of ct(alg=ftp).

2016-12-12 Thread Darrell Ball
On 12/12/16, 11:16 AM, "ovs-dev-boun...@openvswitch.org on behalf of Joe Stringer" wrote: Automatic helper assignment was disabled in Linux 4.7 or later, in upstream commit 3bb398d925ec ("netfilter: nf_ct_helper: disable

Re: [ovs-dev] [patch_v11] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
The commit message was a bit stale, so I sent a v12. On 12/6/16, 9:06 PM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell Ball" <ovs-dev-boun...@openvswitch.org on behalf of dlu...@gmail.com> wrote: This patch adds datapaths of interest support where only datapa

[ovs-dev] [patch_v12] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
this patch though sharing of concepts through code review work. Ben Pfaff suggested that northd could be used to pre-populate related datapaths for ovn-controller to use. That idea is used as part of this patch. CC: Ben Pfaff <b...@ovn.org> CC: Liran Schour <lir...@il.ibm.com> Signed-off

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
500, Russell Bryant wrote: > > On Mon, Dec 5, 2016 at 2:22 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Sun, Dec 04, 2016 at 04:13:44PM -0800, Darrell Ball wrote: > > > > This patch adds datapaths of interest support where only datapaths o

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
On 12/4/16, 9:48 PM, "ovs-dev-boun...@openvswitch.org on behalf of Mickey Spiegel" <ovs-dev-boun...@openvswitch.org on behalf of mickeys@gmail.com> wrote: On Sun, Dec 4, 2016 at 4:13 PM, Darrell Ball <dlu...@gmail.com> wrote: > This patch adds data

[ovs-dev] [patch_v11] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
this patch though sharing of concepts through code review work. Ben Pfaff suggested that northd could be used to pre-populate related datapaths for ovn-controller to use. That idea is used as part of this patch. CC: Ben Pfaff <b...@ovn.org> CC: Liran Schour <lir...@il.ibm.com> Signed-off

Re: [ovs-dev] [patch_v10] ovn: Add datapaths of interest filtering.

2016-12-06 Thread Darrell Ball
On 12/6/16, 2:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Russell Bryant" <ovs-dev-boun...@openvswitch.org on behalf of russ...@ovn.org> wrote: On Sun, Dec 4, 2016 at 7:13 PM, Darrell Ball <dlu...@gmail.com> wrote: > This patch adds datapaths

Re: [ovs-dev] [PATCH v2] ovn-controller: Fix duplicated flows in table 32.

2016-12-14 Thread Darrell Ball
From: Han Zhou <zhou...@gmail.com> Date: Wednesday, December 14, 2016 at 11:53 AM To: Darrell Ball <db...@vmware.com> Cc: "d...@openvswitch.org" <d...@openvswitch.org> Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: Fix duplicated flows in table 32. On Wed, Dec

Re: [ovs-dev] [patch_v8] ovn: Add datapaths of interest filtering.

2016-12-04 Thread Darrell Ball
On 12/1/16, 8:50 PM, "ovs-dev-boun...@openvswitch.org on behalf of Mickey Spiegel" <ovs-dev-boun...@openvswitch.org on behalf of mickeys@gmail.com> wrote: On Sun, Nov 27, 2016 at 1:08 PM, Darrell Ball <dlu...@gmail.com> wrote: > This patch adds data

Re: [ovs-dev] [patch_v8] ovn: Add datapaths of interest filtering.

2016-12-01 Thread Darrell Ball
On 11/30/16, 3:07 AM, "ovs-dev-boun...@openvswitch.org on behalf of Liran Schour" <ovs-dev-boun...@openvswitch.org on behalf of lir...@il.ibm.com> wrote: Darrell Ball <dlu...@gmail.com> wrote on 30/11/2016 02:29:01 AM: > On Tue, Nov 29, 2016 at 4

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Return NEW for IPv6 ND packets without tracking.

2017-01-03 Thread Darrell Ball
On 12/23/16, 5:31 PM, "Daniele Di Proietto" <diproiet...@vmware.com> wrote: On 22/12/2016 21:20, "Darrell Ball" <db...@vmware.com> wrote: >Some comments inline Thanks for the review, I've sent a v3 >

Re: [ovs-dev] [PATCH 2/2] conntrack: Return NEW for IPv6 ND packets without tracking.

2016-12-20 Thread Darrell Ball
On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele Di Proietto" wrote: The userspace connection tracker treats Neighbor Discovery packets as invalid, because they're not checked against any

Re: [ovs-dev] [PATCH 2/2] conntrack: Return NEW for IPv6 ND packets without tracking.

2016-12-20 Thread Darrell Ball
On 12/20/16, 5:37 PM, "Daniele Di Proietto" <diproiet...@vmware.com> wrote: On 20/12/2016 14:46, "Darrell Ball" <db...@vmware.com> wrote: > > >On 12/20/16, 12:25 PM, "ovs-dev-boun...@openvswitch.org on

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Return NEW for IPv6 ND packets without tracking.

2016-12-22 Thread Darrell Ball
Some comments inline On 12/22/16, 6:36 PM, "Daniele Di Proietto" wrote: The userspace connection tracker treats Neighbor Discovery packets as invalid, because they're not checked against any connection. This in inconsistent with the kernel connection

Re: [ovs-dev] [PATCH v2 3/3] conntrack: Use 'maybe_related' insted of 'related'.

2016-12-22 Thread Darrell Ball
Suggested-by: Darrell Ball <db...@vmware.com> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> --- lib/conntrack.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) Acked-by: Darrell Ball <

Re: [ovs-dev] [PATCH v3] ovn-controller: Fix duplicated flow add attempts in table 32.

2016-12-21 Thread Darrell Ball
There is another comment about the test below From: Han Zhou <zhou...@gmail.com> Date: Wednesday, December 21, 2016 at 1:50 PM To: Darrell Ball <db...@vmware.com> Cc: "d...@openvswitch.org" <d...@openvswitch.org> Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Fix d

Re: [ovs-dev] [PATCH 1/2] conntrack: Do not create new connections from ICMP errors.

2016-12-22 Thread Darrell Ball
I tested an alternative diff for conntrack.c part below In summary: 1) I think the outermost selection should be based on the “conn” check in process_one. This is the main decision point. This is also makes it easier to modify going forward. The change boils down to a check in “conn is not

Re: [ovs-dev] [PATCH 1/2] conntrack: Do not create new connections from ICMP errors.

2016-12-22 Thread Darrell Ball
I am reviewing this. Thanks Darrell On 12/22/16, 9:38 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: Who is the right person to review this? Darrell, are you planning to review it? Thanks,

[ovs-dev] [patch_v7 0/9] Userspace Datapath: Introduce NAT support.

2017-03-24 Thread Darrell Ball
cated code path. Parse out some more changes as separate patches. v1->v2: Updates/fixes that were missed in v1 patches. Darrell Ball (9): dpdk: Parse NAT netlink for userspace datapath. dpdk: Remove batch sorting in userspace conntrack. dpdk: Userspace Datapath: Introduce NAT Support

[ovs-dev] [patch_v7 4/9] dpdk: Add more ICMP Related NAT support.

2017-03-24 Thread Darrell Ball
This patch includes more complete support for icmp4 and icmp6 related NAT handling. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 99 +++-- lib/packets.h | 7 2 files changed, 104 insertions(+), 2 del

[ovs-dev] [patch_v7 1/9] dpdk: Parse NAT netlink for userspace datapath.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- lib/conntrack-private.h | 9 -- lib/conntrack.c | 3 +- lib/conntrack.h | 29 - lib/dpif-netdev.

[ovs-dev] [patch_v7 2/9] dpdk: Remove batch sorting in userspace conntrack.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- lib/conntrack.c | 58 +++-- 1 file changed, 11 insertions(+), 47 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 4f49

[ovs-dev] [patch_v7 6/9] System Tests: Enhance NAT tests.

2017-03-24 Thread Darrell Ball
Two new tests are added and two other tests were enhanced. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/atlocal.in| 3 ++ tests/system-traffic.at | 109 +++- 2 files changed, 110 insertions(+), 2 deletions(-) diff --git a

[ovs-dev] [patch_v7 7/9] Add some system test fixes

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 59eae7e..8ade448 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -

[ovs-dev] [patch_v7 3/9] dpdk: Userspace Datapath: Introduce NAT Support.

2017-03-24 Thread Darrell Ball
is introduced to support create/delete handling. The create/delete events may be further optimized, if the need becomes clear. Some NAT options with limited utility (persistent, random) are not supported yet, but will be supported in a later patch. Signed-off-by: Darrell Ball <dlu...@gmail.

[ovs-dev] [patch_v7 5/9] dpdk: Add orig tuple context recovery.

2017-03-24 Thread Darrell Ball
This patch adds orig tuple checking and context recovery; NAT interactions are factored in. Orig tuple support exists to better handle policy changes. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack.c | 69 + 1 file c

[ovs-dev] [patch_v7 9/9] dpdk: Update feature alert documentation.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- Documentation/faq/releases.rst | 2 +- NEWS | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/releases.rst b/Docum

[ovs-dev] [patch_v7 8/9] dpdk: Enable NAT tests for userspace datapath.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> Acked-by: Flavio Leitner <f...@sysclose.org> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f

Re: [ovs-dev] How does ovs userpsace+dpdk handle the original data packet when it needs ARP request and waits for ARP reply?

2017-03-27 Thread Darrell Ball
On 3/22/17, 3:42 AM, "ovs-dev-boun...@openvswitch.org on behalf of Joo Kim" wrote: Hello, In OVS2.6 userspace datapath code, when there is no ARP cache, looks like it sends ARP request on the fly (via

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-03-29 Thread Darrell Ball
I see there is warning log added for the non-local case. I wonder if during setup, there will be no issues with basic connectivity seen. Then some long time later at high PPS usage, unexpected low performance will be seen. I am not sure whether the log will be immediately consulted to check for

Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet?

2017-03-27 Thread Darrell Ball
On 3/23/17, 2:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Joo Kim" wrote: Folks, Anybody knows about this ARP behavior in ovs2.6? -thanks- -- Forwarded message --

Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet?

2017-03-31 Thread Darrell Ball
From: Joo Kim <itsolut...@gmail.com> Date: Thursday, March 30, 2017 at 5:09 PM To: Darrell Ball <db...@vmware.com> Cc: "ovs-dev@openvswitch.org" <ovs-dev@openvswitch.org> Subject: Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet? T

[ovs-dev] [patch_v1] ovs build: Fix memset with zero size warning.

2017-03-19 Thread Darrell Ball
(); ^ cc1: all warnings being treated as errors make[2]: *** [lib/flow.lo] Error 1 Fixes: f0fb825a3785 ("Add support for 802.1ad (QinQ tunneling)") Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

Re: [ovs-dev] [patch_v2] build: Fix memset with zero size warning.

2017-03-20 Thread Darrell Ball
On 3/20/17, 12:32 PM, "ovs-dev-boun...@openvswitch.org on behalf of Eric Garver" <ovs-dev-boun...@openvswitch.org on behalf of e...@erig.me> wrote: On Mon, Mar 20, 2017 at 11:24:49AM -0700, Darrell Ball wrote: > In file included from /usr/inc

[ovs-dev] [patch_v2] build: Fix memset with zero size warning.

2017-03-20 Thread Darrell Ball
(); ^ cc1: all warnings being treated as errors make[2]: *** [lib/flow.lo] Error 1 At the same time, fix some similar bounds checks related to the same commit. Signed-off-by: Darrell Ball <dlu...@gmail.com> Fixes: f0fb825a3785 ("Add support for 802.1ad (QinQ tunneling)

Re: [ovs-dev] [PATCH v5] netdev-dpdk: fix ifindex assignment for DPDK ports

2017-04-03 Thread Darrell Ball
On 4/3/17, 5:27 AM, "ovs-dev-boun...@openvswitch.org on behalf of Przemyslaw Lal" wrote: In current implementation port_id is used as an ifindex for all netdev-dpdk interfaces. For physical DPDK

Re: [ovs-dev] [PATCH v5] netdev-dpdk: fix ifindex assignment for DPDK ports

2017-04-04 Thread Darrell Ball
On 4/4/17, 3:09 AM, "Lal, PrzemyslawX" <przemyslawx@intel.com> wrote: On 04/04/2017 06:14, Darrell Ball wrote: > > On 4/3/17, 5:27 AM, "ovs-dev-boun...@openvswitch.org on behalf of Przemyslaw Lal" <ovs-dev-boun...@openvswitch.org on b

Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet?

2017-04-02 Thread Darrell Ball
From: Joo Kim <itsolut...@gmail.com> Date: Friday, March 31, 2017 at 6:36 PM To: Darrell Ball <db...@vmware.com> Cc: "ovs-dev@openvswitch.org" <ovs-dev@openvswitch.org> Subject: Re: [ovs-dev] Fwd: In OVS2.6 userspace datapath, ARP handling for non-tunnel packet? Wh

Re: [ovs-dev] [PATCH] doc: Link to release FAQ from DPDK install guide

2017-04-11 Thread Darrell Ball
On 4/10/17, 7:10 AM, "Stephen Finucane" <step...@that.guru> wrote: On Fri, 2017-04-07 at 15:28 +0000, Darrell Ball wrote: > > On 4/7/17, 6:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of > Stephen Finucane" <ovs-dev-boun...@open

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

2017-04-05 Thread Darrell Ball
On 4/3/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya Maximets" wrote: Currently, signed integer is used for 'port_id' variable and '-1' as identifier of bad or uninitialized 'port_id'.

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-04-10 Thread Darrell Ball
On 4/5/17, 7:52 AM, "ovs-dev-boun...@openvswitch.org on behalf of O Mahony, Billy" wrote: > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, April 5, 2017 2:58

Re: [ovs-dev] [PATCH v3] netdev-dpdk: leverage the mempool offload support

2017-04-10 Thread Darrell Ball
One minor comment On 3/24/17, 12:27 AM, "Hemant Agrawal" wrote: DPDK 16.07 introduced the support for mempool offload support. rte_pktmbuf_pool_create is the recommended method for creating pktmbuf pools. Buffer pools created with rte_mempool_create may not

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fix device leak on port deletion.

2017-04-12 Thread Darrell Ball
On 4/3/17, 8:04 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya Maximets" wrote: Currently, once created device in dpdk will exist forever even after del-port operation untill we manually call 'ovs-appctl

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-04-14 Thread Darrell Ball
Acked-by: Darrell Ball <dlu...@gmail.com> On 4/10/17, 4:21 AM, "Kevin Traynor" <ktray...@redhat.com> wrote: On 04/10/2017 08:03 AM, Darrell Ball wrote: > > > On 4/5/17, 7:52 AM, "ovs-dev-boun...@openvswitch.org on behalf of O Mahony, Bil

Re: [ovs-dev] [PATCH v4] netdev-dpdk: leverage the mempool offload support

2017-04-14 Thread Darrell Ball
Acked-by: Darrell Ball <dlu...@gmail.com> On 4/12/17, 10:31 PM, "Hemant Agrawal" <hemant.agra...@nxp.com> wrote: DPDK 16.07 introduced the support for mempool offload support. rte_pktmbuf_pool_create is the recommended method for creating pktmbuf pools

Re: [ovs-dev] [patch_v6 4/8] dpdk: Userspace Datapath: Introduce NAT Support.

2017-03-09 Thread Darrell Ball
On 3/8/17, 6:14 PM, "ovs-dev-boun...@openvswitch.org on behalf of Daniele Di Proietto" <ovs-dev-boun...@openvswitch.org on behalf of diproiet...@ovn.org> wrote: 2017-02-16 0:47 GMT-08:00 Darrell Ball <dlu...@gmail.com>: > This patch introduces NAT support f

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

2017-03-08 Thread Darrell Ball
On 3/8/17, 1:30 PM, "Ben Pfaff" <b...@ovn.org> wrote: On Wed, Mar 08, 2017 at 08:58:05PM +0000, Darrell Ball wrote: > > > On 3/7/17, 3:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitc

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

2017-03-08 Thread Darrell Ball
On 3/7/17, 3:03 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote: On Thu, Mar 02, 2017 at 08:01:42PM -0800, Darrell Ball wrote: > Some code-block directives are not understood using &g

[ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

2017-03-02 Thread Darrell Ball
f150a8bafbf2 ("doc: Document various language bindings") Suggested-by: Daniele Di Proietto <diproiet...@vmware.com> Signed-off-by: Darrell Ball <dlu...@gmail.com> CC: Stephen Finucane <step...@that.guru> --- .../internals/contributing/documentation-style.rst | 2 +-

Re: [ovs-dev] [PATCH] doc: Link to release FAQ from DPDK install guide

2017-04-07 Thread Darrell Ball
On 4/7/17, 6:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of Stephen Finucane" wrote: I wanted to find the mappings of DPDK versions to OVS versions. This was a little more difficult than expected. Resolve the issue

Re: [ovs-dev] [patch_v1] dpdk: Fix device cleanup.

2017-07-28 Thread Darrell Ball
-Original Message- From: <ovs-dev-boun...@openvswitch.org> on behalf of Ilya Maximets <i.maxim...@samsung.com> Date: Friday, July 28, 2017 at 7:00 AM To: Darrell Ball <dlu...@gmail.com>, "d...@openvswitch.org" <d...@openvswitch.org> Subject: Re: [ov

Re: [ovs-dev] [PATCH RFC v2 4/4] dpif-netdev: Time based output batching.

2017-07-31 Thread Darrell Ball
-Original Message- From: Ilya Maximets <i.maxim...@samsung.com> Date: Monday, July 31, 2017 at 8:37 AM To: Darrell Ball <db...@vmware.com>, "ovs-dev@openvswitch.org" <ovs-dev@openvswitch.org>, Bhanuprakash Bodireddy <bhanuprakash.bodire...@inte

Re: [ovs-dev] Multiple ARP cache entries for one same dest IP?

2017-08-02 Thread Darrell Ball
On Wed, Aug 2, 2017 at 3:51 PM, Joo Kim wrote: > Hello, > > In OVS userspace implementation(See below), looks like, given a dest IP, > multiple ARP entries are allowed as long as bridge-names are different for > the same dest IP. > But, is there real scenario where multiple

Re: [ovs-dev] [patch_v6 0/5] Userspace Datapath: Add ALG support.

2017-08-03 Thread Darrell Ball
-Original Message- From: <ovs-dev-boun...@openvswitch.org> on behalf of Ben Pfaff <b...@ovn.org> Date: Thursday, August 3, 2017 at 9:58 AM To: Darrell Ball <dlu...@gmail.com> Cc: "d...@openvswitch.org" <d...@openvswitch.org> Subject: Re: [ovs-dev] [pat

[ovs-dev] [patch_v7 0/6] Userspace Datapath: Add ALG support.

2017-08-03 Thread Darrell Ball
citly flag packet as invalid. Seq number overflow and underflow checks added. Darrell Ball (6): string: Implement strcasestr if it is missing. Userspace Datapath: Add ALG infra and FTP. Userspace Datapath: Add TFTP support. System tests: Enable ALGs for userspace. System tests: Add 4 ne

[ovs-dev] [patch_v7 2/6] Userspace Datapath: Add ALG infra and FTP.

2017-08-03 Thread Darrell Ball
ALG infra and FTP (both V4 and V6) support is added to the userspace datapath. Also, NAT support is included. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- lib/conntrack-private.h | 35 +- lib/conntrack.c | 1055 +++ lib/connt

[ovs-dev] [patch_v7 4/6] System tests: Enable ALGs for userspace.

2017-08-03 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 3fc4ef9..f3337f0 100644 --- a/tests/system-userspace-mac

[ovs-dev] [patch_v7 5/6] System tests: Add 4 new ftp and tftp tests.

2017-08-03 Thread Darrell Ball
Signed-off-by: Darrell Ball <dlu...@gmail.com> --- tests/system-traffic.at | 242 1 file changed, 242 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 8145515..707f88f 100644 --- a/tests/system-traffic.at

[ovs-dev] [patch_v7 3/6] Userspace Datapath: Add TFTP support.

2017-08-03 Thread Darrell Ball
Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball <dlu...@gmail.com> --- include/sparse/netinet/in.h | 1 + lib/conntrack.c | 39 ++- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/i

  1   2   3   4   5   6   7   8   9   10   >