On 1/2/2019 6:02 PM, Ben Pfaff wrote:
> On Wed, Jan 02, 2019 at 03:23:14PM +0000, Eli Britstein wrote:
>> Hello,
>>
>>
>>
>> Simple bridge, with 2 ports:
>>
>>
>>
>> ovs-vsctl show
>>
>> 66abf37d-391e-45ba-b740
On 1/2/2019 6:04 PM, Ben Pfaff wrote:
> On Wed, Jan 02, 2019 at 02:58:48PM +0000, Eli Britstein wrote:
>> Hello,
>>
>> Simple bridge, with 2 ports:
>>
>> ovs-vsctl show
>> 66abf37d-391e-45ba-b740-d2d0f414cd15
>> Bridge "br1"
ping
-Original Message-
From: Eli Britstein
Sent: Monday, January 21, 2019 2:14 PM
To: Roi Dayan
Cc: Simon Horman ; Jarno Rajahalme ;
Ben Pfaff ; William Tu ; Andy Zhou
Subject: Re: [PATCH V2 0/2] Do not rewrite fields with the same values as
ping
On 1/13/2019 9:27 AM, Eli
On 1/23/2019 2:14 AM, Ben Pfaff wrote:
> On Fri, Jan 11, 2019 at 08:28:57AM +0200, Eli Britstein wrote:
>> Hi
>>
>> This patch set avoids unnecessary rewrite actions to fields with the
>> same values as matched on.
>>
>> Patch 1 is a pre-step by defining o
Add support for IPv6 hlimit field.
Signed-off-by: Eli Britstein
Reviewed-by: Paul Blakey
---
lib/netdev-tc-offloads.c | 4
lib/tc.c | 5 +
lib/tc.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc
For non UDP tunnels as GRE there is no UDP port, i.e initialized to 0.
Do not set the port attribute in such case.
Signed-off-by: Eli Britstein
Reviewed-by: Paul Blakey
---
lib/netdev-tc-offloads.c | 6 --
lib/tc.c | 8 ++--
2 files changed, 10 insertions(+), 4
Add support for IPv6 htlimit field.
Signed-off-by: Eli Britstein
Reviewed-by: Paul Blakey
---
lib/netdev-tc-offloads.c | 4
lib/tc.c | 5 +
lib/tc.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc
For non UDP tunnels as GRE there is no UDP port, i.e initialized to 0.
Do not set the port attribute in such case.
Signed-off-by: Eli Britstein
---
lib/netdev-tc-offloads.c | 6 --
lib/tc.c | 8 ++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib
/477699710
Appvoyer link:
https://ci.appveyor.com/project/roidayan/ovs/builds/21515073
Thanks,
Eli
Eli Britstein (2):
datapath: Declare ovs key structures using macros
odp-util: Do not rewrite fields with the same values as matched
build-aux/extract-odp-netlink-h | 3
Declare ovs key structures using macros as a pre-step of retrieving
field information, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
build-aux/extract-odp-netlink-h | 3 +-
datapath/linux/compat/include/linux/openvswitch.h | 102
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 110 +-
tests/mpls-xlate.at
; i++)
+if (memcmp(pkey0, pkey1, size) == 0)
+memset(pmask, 0, size);
+else
+differ = true;
Thanks,
Yifeng
On Thu, Jan 10, 2019 at 12:52 AM Eli Britstein
mailto:el...@mellanox.com>> wrote:
To improve performance and avoid wasting resources for HW offloaded
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 109 +-
tests/mpls-xlate.at
Declare ovs key structures using macros as a pre-step of retrieving
field information, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
build-aux/extract-odp-netlink-h | 3 +-
datapath/linux/compat/include/linux/openvswitch.h | 102
/477699710
Appvoyer link:
https://ci.appveyor.com/project/roidayan/ovs/builds/21515073
Thanks,
Eli
Eli Britstein (2):
datapath: Declare ovs key structures using macros
odp-util: Do not rewrite fields with the same values as matched
build-aux/extract-odp-netlink-h | 3
Hello,
Simple bridge, with 2 ports:
ovs-vsctl show
66abf37d-391e-45ba-b740-d2d0f414cd15
Bridge "br1"
Port "enp4s0f0_1"
Interface "enp4s0f0_1"
Port "enp4s0f0_0"
Interface "enp4s0f0_0"
Port "br1"
Interface "br1"
Hello,
Simple bridge, with 2 ports:
ovs-vsctl show
66abf37d-391e-45ba-b740-d2d0f414cd15
Bridge "br1"
Port "enp4s0f0_1"
Interface "enp4s0f0_1"
Port "enp4s0f0_0"
Interface "enp4s0f0_0"
Port "br1"
Interface "br1"
type:
On 1/27/2019 1:04 AM, David Miller wrote:
> From: Eli Britstein
> Date: Thu, 24 Jan 2019 11:46:47 +0200
>
>> Declare ovs key structures using macros to enable retrieving fields
>> information, with no functional change.
>>
>> Signed-off-by: Eli Britstein
>
Packet parsing and rule matching introduce a large processing overhead
for simple port-to-port forwarding scenarios. Accelerate port-to-port
forwarding by bypassing the datapath packet processing if a peer-port
property is defined.
Signed-off-by: Eli Britstein
Reviewed-by: Oz Shlomo
---
lib
Introduce peer name property for dpdk ports, as a pre-step towards
accelarating peer port forwarding.
Signed-off-by: Eli Britstein
Reviewed-by: Oz Shlomo
---
lib/netdev-dpdk.c | 55 ---
1 file changed, 52 insertions(+), 3 deletions(-)
diff --git
Replace specific patch port API for retreiving peer port name with the
generic netdev API.
Signed-off-by: Eli Britstein
Reviewed-by: Oz Shlomo
---
lib/netdev-vport.c | 40
lib/netdev-vport.h | 2 --
ofproto/ofproto-dpif.c | 6 +++---
3 files
Use peer port as a generic netdev property instead of a specific
patch-port property.
Signed-off-by: Eli Britstein
Reviewed-by: Oz Shlomo
---
ofproto/ofproto-dpif.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index
Currently peer port is defined as a patch port property. However, peer
ports can be used as generic netdevice property to accelerate peer ports
forwarding. Introduce a generic method for retreiving peer port name.
Signed-off-by: Eli Britstein
Reviewed-by: Oz Shlomo
---
lib/netdev-provider.h
Adding the elaboration on each patch. I'll add it in V2 cover-letter if needed.
On 4/2/2019 5:57 PM, Eli Britstein wrote:
Current HW offloading solutions use embedded switches to offload OVS DP
rules while using SRIOV pass-through interfaces to the guest VMs. This
architecture requires the VM
the packets that are received by
the port to its specified peer.
This optimization effectively bypasses the packet parsing and rule
matching logic, thus increasing the forwarding performance by more than
2X.
Eli Britstein (6):
netdev: Introduce peer port name as a netdevice class property
netdev
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 93 +--
tests/mpls-xlate.at | 2
This patch set avoids unnecessary rewrite actions to fields with the
same values as matched on.
Patch 1 is a pre-step of generating ovs key fields macros
Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly
Differences from V6:
Remove bash dependency.
Thanks,
Eli
Eli
Generate datapath ovs key fields offset and size array macros as a
pre-step for bit-wise comparing fields, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
.gitignore | 1 +
build-aux/extract-odp-netlink-macros-h | 60
On 2/22/2019 6:42 PM, Ben Pfaff wrote:
> On Sun, Feb 17, 2019 at 09:18:46AM +0000, Eli Britstein wrote:
>> This patch set avoids unnecessary rewrite actions to fields with the
>> same values as matched on.
>>
>> Patch 1 is a pre-step of generating ovs key fiel
On 2/25/2019 7:31 PM, Ben Pfaff wrote:
> On Sun, Feb 24, 2019 at 09:45:21AM +0000, Eli Britstein wrote:
>> On 2/22/2019 6:42 PM, Ben Pfaff wrote:
>>> On Sun, Feb 17, 2019 at 09:18:46AM +0000, Eli Britstein wrote:
>>>> This patch set avoids unnecessary rewrite action
.
Fixes: d8b9605d2697 ("net: sched: fix skb->protocol use in case of accelerated
vlan path")
Signed-off-by: Eli Britstein
---
net/sched/act_csum.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_csum.c b/net/sched/act
sum is not calculated. Furthermore, VLAN may not be
>> stripped so csum is not calculated in this case too. Calculate the
>> csum for those cases.
>>
>> Fixes: d8b9605d2697 ("net: sched: fix skb->protocol use in case of
>> accelerated vlan path")
>> Signed
ping
On 2/25/2019 9:42 PM, Eli Britstein wrote:
>
> On 2/25/2019 7:31 PM, Ben Pfaff wrote:
>> On Sun, Feb 24, 2019 at 09:45:21AM +, Eli Britstein wrote:
>>> On 2/22/2019 6:42 PM, Ben Pfaff wrote:
>>>> On Sun, Feb 17, 2019 at 09:18:46AM +, Eli Britstein w
ping
On 2/17/2019 11:18 AM, Eli Britstein wrote:
> This patch set avoids unnecessary rewrite actions to fields with the
> same values as matched on.
>
> Patch 1 is a pre-step of generating ovs key fields macros
> Patch 2 avoids the unnecessary rewrites and adapts the te
I would really want it to get merged.
how do you suggest to progress?
On 3/1/2019 7:40 AM, Eli Britstein wrote:
> ping
>
> On 2/25/2019 9:42 PM, Eli Britstein wrote:
>>
>> On 2/25/2019 7:31 PM, Ben Pfaff wrote:
>>> On Sun, Feb 24, 2019 at 09:45:21AM +, Eli Brit
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 93 +--
tests/mpls-xlate.at | 2
instead of indirection macros.
Thanks,
Eli
Eli Britstein (2):
Makefiles: Generate datapath ovs key fields macros
odp-util: Do not rewrite fields with the same values as matched
.gitignore | 1 +
build-aux/extract-odp-netlink-macros-h | 55 +++
include
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 110 +-
tests/mpls-xlate.at
Generate datapath ovs key fields macros as a pre-step of retrieving
field information, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
.gitignore | 1 +
build-aux/extract-odp-netlink-xmacros-h | 55
/490090058
Appvoyer link:
https://ci.appveyor.com/project/roidayan/ovs/builds/22198603
Thanks,
Eli
Eli Britstein (2):
Makefiles: Generate datapath ovs key fields macros
odp-util: Do not rewrite fields with the same values as matched
.gitignore | 1 +
build-aux/extract
On 2/8/2019 9:59 AM, Simon Horman wrote:
> On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote:
>> From: Gregory Rose
>> Date: Mon, 4 Feb 2019 11:41:29 -0800
>>
>>> On 2/3/2019 1:12 AM, Eli Britstein wrote:
>>>> Declare ovs key str
ping
On 2/11/2019 1:31 PM, Eli Britstein wrote:
> This patch set automatically links with the necessary libraries for
> MLX4/5 DPDK PMDs.
>
> Patch 1 automatically links with the necessary libraries for MLX5 PMD
>
> Patch 2 automatically links with the necessary libraries for ML
__OVS_KEY_FIELDS_END
Tests 1219-1220 failed because I had OVS running with VXLAN and GRE
configured. Shutting it down and the tests pass.
Thanks,
Eli
Eli Britstein (2):
Makefiles: Generate datapath ovs key fields macros
odp-util: Do not rewrite fields with the same values as matched
.gitignore
Generate datapath ovs key fields macros as a pre-step of retrieving
field information, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
.gitignore | 1 +
build-aux/extract-odp-netlink-xmacros-h | 53
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 122 +-
tests/mpls-xlate.at | 2
To improve performance and avoid wasting resources for HW offloaded
flows, do not rewrite fields that are matched with the same value.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
lib/odp-util.c| 122 +-
tests/mpls-xlate.at | 2
Generate datapath ovs key fields macros as a pre-step of retrieving
field information, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
.gitignore | 1 +
build-aux/extract-odp-netlink-xmacros-h | 56
.
The difference from V3 is rebasing, adding struct ovs_key_nd_extensions
support.
Thanks,
Eli
Eli Britstein (2):
Makefiles: Generate datapath ovs key fields macros
odp-util: Do not rewrite fields with the same values as matched
.gitignore | 1 +
build-aux/extract
ping
On 2/7/2019 6:44 PM, Eli Britstein wrote:
> Hi
>
> This patch set avoids unnecessary rewrite actions to fields with the
> same values as matched on.
>
> Patch 1 is a pre-step of generating ovs key fields macros
>
> Patch 2 avoids the unnecessary rewrites and adap
link libmnl
Eli Britstein (3):
acinclude: Include libverbs and libmlx5 when needed
acinclude: Include libverbs and libmlx4 when needed
acinclude: Omit unnecessary define
acinclude.m4 | 42 --
1 file changed, 40 insertions(+), 2 deletions
Commit fc3b425fa02f ("acinclude: Include libmnl when needed") added
unnecessary include of DPDK_MNL. Omit it.
Fixes: fc3b425fa02f ("acinclude: Include libmnl when needed")
Signed-off-by: Eli Britstein
---
acinclude.m4 | 3 +--
1 file changed, 1 insertion(+), 2 dele
DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Shahaf Shuler
Reviewed-by: Asaf Penso
---
acinclude.m4 | 24
1 file
On 2/5/2019 10:23 PM, Ben Pfaff wrote:
> On Tue, Feb 05, 2019 at 10:22:09AM -0800, Gregory Rose wrote:
>> On 2/5/2019 4:02 AM, Eli Britstein wrote:
>>> On 2/4/2019 10:07 PM, David Miller wrote:
>>>> From: Yi-Hung Wei
>>>> Date: Mon, 4 Feb 2019 10:47:1
DPDK 18.11 uses libverbs and libmlx4 when MLX4 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx4 when MLX4 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Asaf Penso
---
acinclude.m4 | 15 +++
1 file changed, 15 insertions(+)
diff --git
DPDK 18.11 uses libverbs and libmlx4 when MLX4 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx4 when MLX4 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Asaf Penso
---
acinclude.m4 | 14 ++
1 file changed, 14 insertions(+)
diff --git
DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Shahaf Shuler
Reviewed-by: Asaf Penso
---
acinclude.m4 | 22 ++
1 file changed
link libmnl
Eli Britstein (3):
acinclude: Include libverbs and libmlx5 when needed
acinclude: Include libverbs and libmlx4 when needed
acinclude: Omit unnecessary define
acinclude.m4 | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
--
2.14.5
Declare ovs key structures using macros to enable retrieving fields
information, with no functional change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
include/uapi/linux/openvswitch.h | 102 ++-
1 file changed, 69 insertions(+), 33 deletions
nal change.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
include/uapi/linux/openvswitch.h | 102 ++-
1 file changed, 69 insertions(+), 33 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
index dbe0cbe4f1b7..dc
ping
for the using patch, i put below the v1 of it. here is v2:
https://patchwork.ozlabs.org/patch/1023406/
On 1/27/2019 8:37 AM, Eli Britstein wrote:
>
> On 1/27/2019 1:04 AM, David Miller wrote:
>> From: Eli Britstein
>> Date: Thu, 24 Jan 2019 11:46:47 +0200
>
On 2/4/2019 10:07 PM, David Miller wrote:
> From: Yi-Hung Wei
> Date: Mon, 4 Feb 2019 10:47:18 -0800
>
>> For example, to see how 'struct ovs_key_ipv6' is defined, now we need
>> to trace how OVS_KEY_IPV6_FIELDS is defined, and how OVS_KEY_FIELD_ARR
>> and OVS_KEY_FIELD defined. I think it
DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Shahaf Shuler
Reviewed-by: Asaf Penso
---
acinclude.m4 | 26 ++
1 file
This patch set automatically links with the necessary libraries for
MLX4/5 DPDK PMDs.
Patch 1 automatically links with the necessary libraries for MLX5 PMD
Patch 2 automatically links with the necessary libraries for MLX4 PMD
Eli Britstein (2):
acinclude: Include libverbs and libmlx5 when
DPDK 18.11 uses libverbs and libmlx4 when MLX4 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx4 when MLX4 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Asaf Penso
---
acinclude.m4 | 18 +-
1 file changed, 17 insertions(+), 1 deletion
DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled.
This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is
enabled on DPDK.
Signed-off-by: Eli Britstein
Reviewed-by: Shahaf Shuler
Reviewed-by: Asaf Penso
---
acinclude.m4 | 26 ++
1 file
Ping
From: Eli Britstein
Sent: Tuesday, May 21, 2019 3:11:51 PM
To: d...@openvswitch.org; Simon Horman
Cc: Roi Dayan; Paul Blakey; Eli Cohen; Eli Britstein
Subject: [PATCH 1/1] netdev-tc-offloads: Support match on priority tags
The logic by which a TC rule has
On 6/14/2019 5:40 PM, Louis Peens wrote:
On Wed, Jun 12, 2019 at 11:53 AM Eli Britstein
mailto:el...@mellanox.com>> wrote:
On 6/11/2019 2:21 PM, Ilya Maximets wrote:
>> On Mon, Jun 3, 2019 at 4:42 PM Simon Horman > netronome.com<https://eur03.safelinks.protection.outlook.c
On 6/11/2019 2:21 PM, Ilya Maximets wrote:
>> On Mon, Jun 3, 2019 at 4:42 PM Simon Horman
>> wrote:
>>
>>> On Fri, May 31, 2019 at 02:45:25PM +0200, Simon Horman wrote:
>>>> Sorry Eli,
>>>>
>>>> I had missed this but I have it no
On 6/21/2019 8:47 PM, William Tu wrote:
> The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE
> tunnel over IPv6, carrying inner ethernet packets and encap with GRE header
> with outer IPv6 header. Encapsulation of layer 3 packet over IPv6 GRE,
> ip6gre,
> is not
Signed-off-by: Eli Britstein
---
vswitchd/vswitch.xml | 32
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index bf4b6f8dc..b7d81cdaa 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
A documentation suggestion to be squashed with
https://patchwork.ozlabs.org/patch/1120457/
Eli Britstein (1):
ip6gretap documentation
vswitchd/vswitch.xml | 32
1 file changed, 20 insertions(+), 12 deletions(-)
--
2.17.2
On 6/25/2019 7:12 PM, William Tu wrote:
> On Sat, Jun 22, 2019 at 8:44 AM Eli Britstein wrote:
>>
>> On 6/21/2019 8:47 PM, William Tu wrote:
>>> The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE
>>> tunnel over IPv6, carrying inner et
On 6/20/2019 6:55 PM, William Tu wrote:
> The patch adds ip6gretap support. Tunnel type ip6gretap is a layer 2 GRE
> tunnel over IPv6, carrying inner ethernet packets and encap with GRE header
> with outer IPv6 header. I tested it by running:
># make check-kernel
> under kernel 5.2 and for
On 6/20/2019 9:19 PM, William Tu wrote:
>> I'll be working on clarifying the documentation. And we need to clarify
>> that we will not be supporting ip6gre because it
>> requires ARPHRD_IP6GRE. OVS only works with ARPHRD_ETHER so it can only
>> support ip6gretap.
>>
>>> Alternatively, we can
ude-non-zero",
equivalent to previously "true". "true" is still supported for backwards
compatibility.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
ofproto/ofproto-dpif-xlate.c | 9 +
ofproto/ofproto-dpif-xlate.h | 2 +-
ofproto/ofproto-dpif.c
Configure "include-non-zero" priority tags to retain the 802.1Q header
when the VLAN ID is zero, except both the VLAN ID and priority are zero.
Add a "include" configuration option to retain the 802.1Q header in such
frames as well.
Signed-off-by: Eli Britstein
Reviewed-by:
d "include" mode for priority-tags configuration
V2 changes:
- Added NEWS item.
- A bit changed documentation.
Eli Britstein (2):
ofproto-dpif-xlate: Change priority tags from boolean to enum
ofproto-dpif-xlate: Add include mode to priority tags
NEWS | 4
ping
On 5/12/2019 8:50 AM, Eli Britstein wrote:
> Setting priority-tags to "true" Open vSwitch still omits the
> 802.1Q header on output if both the VLAN ID and priority would be zero.
> Add an option to retain the 8021Q header in such frames as well.
>
> Patch #1: change
The logic by which a TC rule has a VLAN match is by the VLAN TCI field,
either the VID, PCP or CFI are non-zero. For priority-tag packets
there is a VLAN tag header with a zero VLAN TCI. Match on existence of
VLAN header (TPID) regardless of TCI matching.
Signed-off-by: Eli Britstein
Reviewed
ude-non-zero",
equivalent to previously "true". "true" is still supported for backwards
compatibility.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
ofproto/ofproto-dpif-xlate.c | 9 +
ofproto/ofproto-dpif-xlate.h | 2 +-
ofproto/ofproto-dpif.c
Configure "include-non-zero" priority tags to keep the 802.1Q header
when the VLAN ID is zero, except both the VLAN ID and priority are zero.
Add a "include" configuration option to keep it for such frames as well.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
d "include" mode for priority-tags configuration
Eli Britstein (2):
ofproto-dpif-xlate: Change priority tags from boolean to enum
ofproto-dpif-xlate: Add include mode to priority tags
ofproto/ofproto-dpif-xlate.c | 20
ofproto/ofproto-dpif-xlate.h | 2 +-
of
Ethernet type 0x1234 is used for testing and not being offloadable. For
testing offloadable features, log about using this value.
Signed-off-by: Eli Britstein
Acked-by: Roi Dayan
Signed-off-by: Eli Britstein
---
lib/dpif-netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif
Enable TC datapath on ip6gretap interface.
It will work once https://patchwork.ozlabs.org/patch/1120457/ is merged.
Eli Britstein (1):
netdev-vport: Make ip6gretap netdev type to use TC rules
lib/netdev-vport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.17.2
The offload api functions already assigned to every tunnel class.
For ip6gretap tunnel class only need to also assign the get_ifindex
function, similarly as done in commit 5e63eaa969a3 ("netdev-vport: Make
gre netdev type to use TC rules").
Signed-off-by: Eli Britstein
Reviewed-by:
.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fgvrose8192%2Fovs-experimental%2Fbuilds%2F552977116data=02%7C01%7Celibr%40mellanox.com%7Cbf32e197198b4b90f2ee08d6ffcf8d0c%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636977664222635681sdata=ql1lx2EU18Fk%2BWIdTEzdlthtZb%2FazsOOT05TZc3t5f0%3Dreserved=0
&g
The offload api functions already assigned to every tunnel class.
For ip6gre tunnel class only need to also assign the get_ifindex
function, similarly as done in commit 5e63eaa969a3 ("netdev-vport: Make
gre netdev type to use TC rules").
Signed-off-by: Eli Britstein
Reviewed-by:
This patch breaks ovs-dpctl dump-flows, when using TC offloads (kernel).
I added a print in netdev_flow_dump_create, and flow_api is NULL when
invoking ovs-dpctl dump-flows.
I think new netdev objects are created to the ports (netdev_open), but
not properly initialized.
Could you please have
Ethernet type 0x1234 is used for testing and not being offloadable. For
testing offloadable features, warn about using this value.
Signed-off-by: Eli Britstein
---
lib/dpif-netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index ba80a0079
Ack
On 7/1/2019 1:52 PM, Ilya Maximets wrote:
> NEWS update was missed while updating docs for dynamic Flow API.
> Since this is a user visible change, it should be mentioned here.
>
> Fixes: d74ca2269e36 ("dpctl: Update docs about dump-flows and HW offloading.")
> Signed-off-by: Ilya Maximets
>
On 7/1/2019 1:13 PM, Ilya Maximets wrote:
> On 30.06.2019 7:47, Eli Britstein wrote:
>> This patch breaks ovs-dpctl dump-flows, when using TC offloads (kernel).
>>
>> I added a print in netdev_flow_dump_create, and flow_api is NULL when
>> invoking ovs-dpctl dump-flow
On 7/1/2019 1:46 PM, Ilya Maximets wrote:
> On 01.07.2019 13:24, Eli Britstein wrote:
>> On 7/1/2019 1:13 PM, Ilya Maximets wrote:
>>> On 30.06.2019 7:47, Eli Britstein wrote:
>>>> This patch breaks ovs-dpctl dump-flows, when using TC offloads (kern
On 7/1/2019 2:21 PM, Ilya Maximets wrote:
> Hi, Eli.
> Did you have a chance to test this?
Yes, sorry for the delay. It works fine (though didn't test QinQ. only
native/single-tagged).
Reviewed-by: Eli Britstein
> Best regards, Ilya Maximets.
>
> On 19.06.2019 12:16, Ilya
On 7/30/2019 1:10 PM, Ilya Maximets wrote:
> On 03.07.2019 7:58, Eli Britstein wrote:
>> Ethernet type 0x1234 is used for testing and not being offloadable. For
>> testing offloadable features, log about using this value.
>>
>> Signed-off-by: Eli Britstein
>> A
ping
On 7/11/2019 4:11 PM, Roi Dayan wrote:
>
> On 2019-07-03 9:11 PM, Ben Pfaff wrote:
>> On Wed, Jul 03, 2019 at 04:58:06AM +, Eli Britstein wrote:
>>> Ethernet type 0x1234 is used for testing and not being offloadable. For
>>> testing offloadable featur
etap'
>>> under kernel 5.2 and for userspace:
>>> # make check TESTSUITEFLAGS='-k ip6gretap'
>>>
>>> Signed-off-by: William Tu
>>> Signed-off-by: Eli Britstein
>>> Co-authored-by: Eli Britstein
>>> Tested-by: Greg Rose
&
On 12/4/2019 5:16 PM, Ilya Maximets wrote:
> On 02.12.2019 09:41, Eli Britstein wrote:
>> From: Ophir Munk
>>
>> Use netdev dump flow next API in order to update the statistics of fully
>> offloaded flows.
>>
>> Co-authored-by: Eli Britstein
>>
On 12/3/2019 5:19 PM, Sriharsha Basavapatna wrote:
> On Wed, Nov 20, 2019 at 9:07 PM Eli Britstein wrote:
>> Signed-off-by: Eli Britstein
>> Reviewed-by: Oz Shlomo
>> ---
>> NEWS | 2 +
>> li
On 12/2/2019 4:25 PM, Ilya Maximets wrote:
> On 01.12.2019 9:29, Eli Britstein wrote:
>> On 11/30/2019 1:59 PM, Ilya Maximets wrote:
>>> On 24.11.2019 14:22, Eli Britstein wrote:
>>>> On 11/22/2019 6:19 PM, Ilya Maximets wrote:
>>>>> On 20.11.2019
On 12/4/2019 5:42 PM, Ilya Maximets wrote:
> On 04.12.2019 16:25, Eli Britstein wrote:
>> On 12/3/2019 5:19 PM, Sriharsha Basavapatna wrote:
>>> On Wed, Nov 20, 2019 at 9:07 PM Eli Britstein wrote:
>>>> Signed-off-by: Eli Britstein
>>>> Rev
1 - 100 of 791 matches
Mail list logo
