Hi Vlad,
We’re actually using the rhel6 spec file to build RPMs to be installed on
RHEL 7.2,7.3,and 7.4 in production.
Martin
On Fri, Jul 6, 2018 at 10:31 AM Odintsov Vladislav
wrote:
> Hi all,
>
>
> I'm trying to understand the needs to have openvswitch-kmod-fedora.spec
> and openvswitch-kmo
This patch only affects rhel6 spec file.
RHEL 7.4 introduced backward incompatible changes in the kernel. As
a result, prebuilt PRM packages against kernels newer than 693.17.1
will cannot be used on systems with older kernels, vice versa.
This patch allows multiple kernel version numbers delimit
Adding Ben.
On Tue, Jul 10, 2018 at 3:54 PM Gregory Rose wrote:
> On 7/10/2018 3:42 PM, Martin Xu wrote:
> > This patch only affects rhel6 spec file.
> >
> > RHEL 7.4 introduced backward incompatible changes in the kernel. As
> > a result, prebuilt PRM packages
c to
match the built package name kmod-openvswitch.
This patch also removes the openvswitch-kmod package.
Signed-off-by: Martin Xu
Signed-off-by: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Aaron Conole
---
Documentation/intro/install/rhel.rst | 7 +-
poc/playbook-centos-b
On Wed, Jul 11, 2018 at 4:35 PM, Flavio Leitner wrote:
> On Wed, Jul 11, 2018 at 03:30:08PM -0700, Martin Xu wrote:
> > This patch only affects rhel6 spec file.
> >
> > RHEL 7.4 introduced backward incompatible changes in the kernel. As
> > a result, prebuilt PRM pac
the resulted
kmod-openvswitch-.rpm, which is the real package with
kernel module files.
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Aaron Conole
---
Documentation/intro/install/rhel.rst | 7 +++
poc/playbook-centos-builder.yml
effectively removes the redudant
openvswitch-kmod package from the build.
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Aaron Conole
---
rhel/automake.mk| 1 -
rhel/kmod-openvswitch-rhel6.spec.in | 32
rhel
vswitch is installed.
Signed-off-by: Martin Xu
Co-authored-by: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Aaron Conole
---
rhel/automake.mk | 1 +
rhel/kmod-openvswitch-rhel6.spec.in| 87 +-
...sr_share_openvswitch_s
On Thu, Jul 12, 2018 at 12:23 PM, Flavio Leitner wrote:
> On Thu, Jul 12, 2018 at 10:35:55AM -0700, Martin Xu wrote:
> > This patch only affects rhel6 spec file.
> >
> > Previouly the kernel_module_package macro is used to generate spec file
> > template to build kmo
the resulted
kmod-openvswitch-.rpm, which is the real package with
kernel module files.
Signed-off-by: Martin Xu
Reviewed-by: Flavio Leitner
CC: Greg Rose
CC: Ben Pfaff
CC: Aaron Conole
---
v1->v2: fix improperly generated patch
v2->v3: split from one patch into three patches
v3->v4
vswitch is installed.
Signed-off-by: Martin Xu
Co-authored-by: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Aaron Conole
---
v1->v2: fix improperly generated patch
v2->v3: split from one patch into three patches
v3->v4: add paragraphs to explain the usage of new script ovs-km
effectively removes the redudant
openvswitch-kmod package from the build.
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Aaron Conole
---
v1->v2: fix improperly generated patch
v2->v3: split from one patch into three patches
v3->v4: rewrite the macro to
te the weak-update symlinks
if the system kernel version is upgraded or downgraded after
openvswitch-kmod is installed.
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Flavio Leitner
---
rhel/openvswitch-kmod-fedora.spec.in | 86 +++-
1 file changed, 55 insertions(+),
t 03:24:53PM -0700, Martin Xu wrote:
> > This patch ports changes from kmod rhel6 spec file to fedora spec file,
> > to support packaging kernel modules built against multiple versions of
> > kernel sources.
> >
> > RHEL 7.4 introduced backward incompatible changes in th
Previous patch removed the if condition for postun script by
mistake. The weak-update symlinks should be removed only for
uninstallation not upgrade.
VMware-BZ: #2169383
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
---
rhel/kmod-openvswitch-rhel6.spec.in | 10
te the weak-update symlinks
if the system kernel version is upgraded or downgraded after
openvswitch-kmod is installed.
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Flavio Leitner
---
v1->v2: fix a bug in v1. v1 removed the if condition (erase but not upgrade)
in postun section by mistake. With
:02:57AM -0700, Martin Xu wrote:
> > Previous patch removed the if condition for postun script by
> > mistake. The weak-update symlinks should be removed only for
> > uninstallation not upgrade.
> >
> > VMware-BZ: #2169383
> >
> > Signed-off-by: Martin Xu
Thanks, Ben!
On Mon, Jul 30, 2018 at 4:17 PM, Ben Pfaff wrote:
> OK, I spent some time staring at 89dd5819cf18 and finally got it. I
> applied this to master and branch-2.10. I added an appropriate Fixes
> tag to the commit.
>
> On Mon, Jul 30, 2018 at 01:34:19PM -0700,
vs-vswitchd: server
returned an error", which is harmless but potentially shows up as "FAILED."
Add an if condition to check whether datapath exists before running the
conntrack flush command.
VMware-BZ: #2170402
Fixes: 265d70310c69 ("utilities: Fix conntrack flush command
This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch
build against multiple kernels, rhel6) to support building kmod RPMs
with multiple minor revisions within 3.10.0-327 kernels. It was
discovered for RHEL 7.2 that 41.3 minor revision introduced backward
incompatible changes.
VMw
.
VMware-BZ: #2170334
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Yi-Hung Wei
---
v1->v2: added author sign-off signature
rhel/kmod-openvswitch-rhel6.spec.in| 7 +++--
...sr_share_openvswitch_scripts_ovs-kmod-manage.sh |
kmod-openvswitch build against
multiple kernels, rhel6)
VMware-BZ: #2170334
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Yi-Hung Wei
---
rhel/kmod-openvswitch-rhel6.spec.in| 13 ++---
...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 67
kmod-openvswitch build against
multiple kernels, rhel6)
VMware-BZ: #2170334
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Yi-Hung Wei
---
v1->v2: added author sign-off signature
v2->v3: instead of using hard coded versions for openvswitch kernel m
kmod-openvswitch build against
multiple kernels, rhel6)
VMware-BZ: #2170334
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Yi-Hung Wei
---
v1->v2: added author sign-off signature
v2->v3: instead of using hard coded versions for openvswitch kernel m
with any POSIX
> shell (bash, dash, busybox sh, etc).
>
> CC: Martin Xu
> Fixes: 9763d17fbd05 ("utilities: check datapath exists before conntrack
> flush")
>
> Signed-off-by: Timothy Redaelli
> ---
> utilities/ovs-lib.in | 2 +-
> 1 file changed, 1 ins
.
VMware-BZ: #2170334
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Yi-Hung Wei
---
v1->v2: added author sign-off signature
v2->v3: instead of using hard coded versions for openvswitch kernel modules,
retrieve the information from kmod package
v3->
: support kmod-openvswitch build against
multiple kernels, rhel6)
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Ben Pfaff
CC: Flavio Leitner
CC: Yi-Hung Wei
---
v5->v6: bug fix separated to its own patch
rhel/kmod-openvswitch-rhel6.spec.in | 6 ++
1 file changed, 2 insertions(+)
Thanks for the review. I've separated them into two patches in v6.
Martin
On Wed, Aug 1, 2018 at 3:48 PM, Yi-Hung Wei wrote:
> On Wed, Aug 1, 2018 at 2:26 PM, Martin Xu wrote:
> > This patch extends commit 89dd5819cf18 (rhel: support kmod-openvswitch
> > build against mul
te the weak-update symlinks
if the system kernel version is upgraded or downgraded after
openvswitch-kmod is installed.
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Flavio Leitner
---
v1->v2: fix a bug in v1. v1 removed the if condition (erase but not upgrade)
in postun section by mistake. With
Thanks for the suggestions. I removed the "obseletes" from the patch, so we
can go either way for the kmod RPM naming. A new patch is sent out.
Martin
On Mon, Jul 30, 2018 at 12:18 PM Flavio Leitner wrote:
> On Fri, Jul 27, 2018 at 11:19:58AM -0700, Martin Xu wrote:
Patch 22c33c303932 used /usr/src/linux/ as path of the
linux headers, which does not work for SLES. Use /lib/modules//build instead.
Fixes 22c33c303932 (rhel: support kmod build against mulitple kernel versions,
fedora)
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Markos Chandras
---
rhel
Fixes 22c33c303932 (rhel: support kmod build against mulitple kernel versions,
fedora)
Fixes c8cd1307b248 (rhel: support kmod build against multiple 7.2
kernels, rhel6)
Signed-off-by: Martin Xu
CC: Greg Rose
---
datapath/linux/Makefile.main.in | 2 +-
rhel/kmod-openvswitch-rhel6.spec.in
Add "--with/without allow_unsupported_modules" flag for rpmbuild. With
this flag on, OVS kmod RPM sets allow_unsupported_modules to 1 if needed
in /etc/modprobe.d/10-unsupported-modules.conf during post-install.
Post-uninstall resets allow_unsupported_modules.
Signed-off-by: Martin Xu
l= LDFLAGS=\"\${LDFLAGS} -Xlinker
-rpath=\""'
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Flavio Leitner
---
rhel/openvswitch-kmod-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-kmod-fedora.spec.in
b/rhel/openvswitch-kmod-
Extends 22c33c303932 (rhel: support kmod build against mulitple kernel
versions, fedora) to kernel version 4.4.x, x>=73 for SLES 12 SP3
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Markos Chandras
---
rhel/openvswitch-kmod-fedora.spec.in |
Hi Ben,
Yes, please. We'll brainstorm on what to do for the purpose of patch 3
separately. Thanks!
Martin
On Wed, Sep 5, 2018 at 2:04 PM Ben Pfaff wrote:
> Martin, I see that all of the patches in this series have been acked by
> appropriate people, except for patch 3. Should I apply the acke
Extends 22c33c303932 (rhel: support kmod build against mulitple kernel
versions, fedora) to kernel version 4.4.x, x>=73 for SLES 12 SP3
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Markos Chandras
CC: Ben Pfaff
Reviewed-by: Greg Rose
Tested-by: Greg Rose
---
v1->v2: added acks and r
; is specified, the openvswith RPM is packaged with the
shared library files. These files are always packaged for the RPM built
with rhel6 spec file.
VMware-BZ: #2036847
Signed-off-by: Martin Xu
CC: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 10 ++
1 file changed, 10 in
This patch extends 4886d4d2495b (debian, rhel: Ship ovs shared libraries
and header files) to fedora, by packaging the shared libraries in
openvswitch RPM. These files are always packaged in the RPM built with
rhel6 spec file.
VMware-BZ: #2036847
Signed-off-by: Martin Xu
CC: Flavio Leitner
:
> > > On Mon, Sep 10, 2018 at 06:46:51PM -0300, Flavio Leitner wrote:
> > > > On Mon, Sep 10, 2018 at 01:33:31PM -0700, Martin Xu wrote:
> > > > > This patches extends 4886d4d2495b (debian, rhel: Ship ovs shared
> > > > > libraries and header files)
to using fedora spec files. I guess
whoever is currently using he fedora spec file might not need the shared
libraries, so better make it optional than always. So that was the v1 patch.
Martin
On Tue, Sep 11, 2018 at 12:14 PM Flavio Leitner wrote:
> On Tue, Sep 11, 2018 at 11:44:59AM -0700, Ma
t 12:58 PM Flavio Leitner wrote:
> On Tue, Sep 11, 2018 at 12:33:06PM -0700, Martin Xu wrote:
> > Hi Flavio,
> >
> > I must have misread the suggestions there. The intention of the v1 patch
> > was to package the shared libraries in openvswitch RPM. The rhel6 spec
> file
Add a symmetric_l3 hash method that uses both network destination
address and network source address.
VMware-BZ: #2112940
Signed-off-by: Martin Xu
CC: Ben Pfaff
---
include/openflow/nicira-ext.h | 4 +++-
lib/bundle.c | 2 ++
lib/flow.c| 44
Add a symmetric_l3 hash method that uses both network destination
address and network source address.
VMware-BZ: #2112940
Signed-off-by: Martin Xu
CC: Ben Pfaff
---
include/openflow/nicira-ext.h | 4 +++-
lib/bundle.c | 2 ++
lib/flow.c| 44
This patch extends 4886d4d2495b (debian, rhel: Ship ovs shared libraries
and header files) to fedora, by packaging the shared libraries in
openvswitch and openvswitch-dvel RPM. These files are always packaged in
the RPMs built with rhel6 spec file.
VMware-BZ: #2036847
Signed-off-by: Martin Xu
Thanks for the clarification. Sorry I was confused for a bit. Sent out the
v3 patch.
Martin
On Tue, Sep 11, 2018 at 3:04 PM Flavio Leitner wrote:
> On Tue, Sep 11, 2018 at 02:40:05PM -0700, Martin Xu wrote:
> > Hi Flavio,
> >
> > I don't see the lib*.so packaged in e
OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the
config file. This variable is replaced by OPTIONS in systemd service
files. This patch addes $OVS_CTL_OPTS back to be passed along with $OPTIONS
for backward compatibility.
VMware-BZ: #2036847
Signed-off-by: Martin Xu
CC: Aaron
This patch fixes the path for ovs-kmod-manage.sh script in the
openvswitch-kmod RPM in fedora spec file. Currently the path prefix is
hard coded to /usr/share. Use %{_datadir} instead.
Fixes 22c33c303932 (rhel: support kmod build against mulitple kernel
versions, fedora)
Signed-off-by: Martin Xu
)
Signed-off-by: Martin Xu
CC: Greg Rose
CC: Flavio Leitner
---
rhel/openvswitch-kmod-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-kmod-fedora.spec.in
b/rhel/openvswitch-kmod-fedora.spec.in
index 464d537..8d54fd7 100644
--- a/rhel
Thanks for the review!
Martin
On Fri, Sep 21, 2018 at 5:24 AM Flavio Leitner wrote:
> On Thu, Sep 20, 2018 at 12:19:29PM -0700, Martin Xu wrote:
> > This patch fixes the path for ovs-kmod-manage.sh script in the
> > openvswitch-kmod RPM in fedora spec file. Currently the
Hi Ben,
Flavio acked this patch as well. I received the email with no problem.
Martin
On Tue, Sep 25, 2018 at 3:25 PM Ben Pfaff wrote:
> On Thu, Sep 20, 2018 at 12:19:30PM -0700, Martin Xu wrote:
> > In post-install in kmod fedora spec file, the variables storing
> > different
Add a symmetric_l3 hash method that uses both network destination
address and network source address.
VMware-BZ: #2112940
Signed-off-by: Martin Xu
CC: Ben Pfaff
---
v1->v2: add eth_type as part of the hash fields;
added unit tests in multipath, bundle, oss-fuzz, ovs-of
Add a symmetric_l3 hash method that uses both network destination
address and network source address.
VMware-BZ: #2112940
Signed-off-by: Martin Xu
CC: Ben Pfaff
---
v1->v2: add eth_type as part of the hash fields;
added unit tests in multipath, bundle, oss-fuzz, ovs-ofctl
v2->v
Hi all,
That commit was only to get the shared libraries. It doesn't need the
static libraries.
Martin
On Mon, Nov 12, 2018 at 2:22 PM Flavio Leitner wrote:
> On Sun, Nov 11, 2018 at 11:04:01AM -0800, Ben Pfaff wrote:
> > On Sun, Nov 11, 2018 at 04:32:40PM +0100, Timothy Redaelli wrote:
> > >
The variable equivalent to RHEL's 'SYSTEMCTL_SKIP_REDIRECT=yes' on SLES
12 is 'SYSTEMD_NO_WRAP=yes'
VMware-BZ: #2245358
Signed-off-by: Martin Xu
CC: Markos Chandras
CC: Ansis Atteka
CC: Ben Pfaff
---
rhel/etc_init.d_openvswitch | 1 +
1 file changed, 1 insert
-off-by: Martin Xu
CC: Flavio Leitner
CC: Zak Whittington
CC: Ben Pfaff
---
rhel/openvswitch-kmod-fedora.spec.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/rhel/openvswitch-kmod-fedora.spec.in
b/rhel/openvswitch-kmod-fedora.spec.in
index 8d54fd734..915b5f677 100644
--- a/rhel/openvswitch
he fedora site, that uses both "Provides" and "Obsoletes."
I understand this means we will be declaring openvswitch-kmod is being
replaced. We can't go either way anymore. Is there a better solution?
Thanks.
Martin
On Thu, Dec 13, 2018 at 2:44 PM Martin Xu wrote:
grade path from kmod-openvswitch to
openvswitch-kmod.
Fixes: 22c33c3039 (rhel: support kmod build against mulitple kernel
versions, fedora)
VMware-BZ: #2249788
Signed-off-by: Martin Xu
CC: Flavio Leitner
CC: Yi-Hung Wei
CC: Yifeng Sun
CC: Zak Whittington
CC: Ben Pfaff
---
v1->v2: adds
58 matches
Mail list logo