Re: [ovs-dev] [PATCH v3 0/6] dpif-netdev: Combine CD and DFC patch for datapath refactor

2018-06-22 Thread O Mahony, Billy
M > To: d...@openvswitch.org > Cc: b...@ovn.org; jan.scheur...@ericsson.com; u9012...@gmail.com; Stokes, > Ian ; O Mahony, Billy ; > Wang, Yipeng1 ; Gobriel, Sameh > ; Tai, Charlie > Subject: [PATCH v3 0/6] dpif-netdev: Combine CD and DFC patch for datapath > refactor > > This p

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-04 Thread O Mahony, Billy
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 6:53 PM > To: d...@openvswitch.org > Cc: Wang, Yipeng1 ; jan.scheur...@ericsson.com; > Stokes, Ian ; O Mahony, Billy > ; Loftus, Ciara > Subject: [PATCH v4 1/2] dpif-netdev: Add SMC cache

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-05 Thread O Mahony, Billy
n.com; > Stokes, Ian ; O Mahony, Billy > ; Loftus, Ciara > Subject: [PATCH v4 1/2] dpif-netdev: Add SMC cache after EMC cache > > This patch adds a signature match cache (SMC) after exact match cache (EMC). > The difference between SMC and EMC is SMC only stores a signature

Re: [ovs-dev] [PATCH v5 1/2] dpif-netdev: Add SMC cache after EMC cache

2018-07-11 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Wang, Yipeng1 > Sent: Tuesday, July 10, 2018 11:14 AM > To: d...@openvswitch.org; jan.scheur...@ericsson.com; O Mahony, Billy > > Cc: Wang, Yipeng1 ; Stokes, Ian > ; b...@ovn.org > Subject: [PATCH v5 1/

Re: [ovs-dev] [PATCH v5 2/2] tests: Fix unit test case caused by SMC cache.

2018-07-11 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Wang, Yipeng1 > Sent: Tuesday, July 10, 2018 11:14 AM > To: d...@openvswitch.org; jan.scheur...@ericsson.com; O Mahony, Billy > > Cc: Wang, Yipeng1 ; Stokes, Ian > ; b...@ovn.org > Subject: [PATCH v5 2

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with negative vid.

2017-10-13 Thread O Mahony, Billy
Hi Ilya, > Issue can be reproduced by stopping DPDK application (testpmd) inside guest > while heavy traffic flows to this VM. > I tried both quitting testpmd without stopping the forwarding task and simply killing testpmd without crashing vswitch in the host. What versions of dpdk are you usi

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with negative vid.

2017-10-13 Thread O Mahony, Billy
Ok, I'll try with something closer to that configuration... But still x86 :) > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, October 13, 2017 1:06 PM > To: O Mahony, Billy ; ovs-dev@openvswitch.org > Cc: Maxime Coquelin ; Hee

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with negative vid.

2017-10-13 Thread O Mahony, Billy
nal Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, October 13, 2017 1:06 PM > To: O Mahony, Billy ; ovs-dev@openvswitch.org > Cc: Maxime Coquelin ; Heetae Ahn > > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with > negati

Re: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic

2017-10-17 Thread O Mahony, Billy
h [mailto:jan.scheur...@ericsson.com] > Sent: Friday, September 22, 2017 12:37 PM > To: O Mahony, Billy ; Kevin Traynor > ; d...@openvswitch.org > Cc: Mechthild Buescher ; Venkatesan > Pradeep > Subject: RE: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic > > Hi

Re: [ovs-dev] [RFC PATCH v2 09/10] Docs: Add userspace-ipsec how to guide.

2017-10-18 Thread O Mahony, Billy
Hi Ian, > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ian Stokes > Sent: Friday, August 25, 2017 5:41 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [RFC PATCH v2 09/10] Docs: Add userspace-ipsec how to > guide. >

Re: [ovs-dev] [RFC PATCH v2 08/10] vswitch.xml: Detail vxlanipsec user interface.

2017-10-18 Thread O Mahony, Billy
Hi Ian, > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ian Stokes > Sent: Friday, August 25, 2017 5:41 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [RFC PATCH v2 08/10] vswitch.xml: Detail vxlanipsec user > interf

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2017-11-21 Thread O Mahony, Billy
Hi Jan, Thanks, that's a really interesting patch. Currently does not apply to head of master - what rev can I apply it to? Some more below - including one way down in the code. Thanks, /Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@open

Re: [ovs-dev] [RFC PATCH v2] dpif-netdev: Add port/queue tiebreaker to rxq_cycle_sort.

2017-11-23 Thread O Mahony, Billy
Hi Kevin, My 2c below.. /Billy > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Kevin Traynor > Sent: Wednesday, November 22, 2017 7:11 PM > To: d...@openvswitch.org; aserd...@ovn.org > Subject: [ovs-dev] [RFC PATCH v2]

Re: [ovs-dev] [RFC PATCH v3 8/8] netdev-dpdk: support multi-segment jumbo frames

2017-11-23 Thread O Mahony, Billy
Hi Mark, Just one comment below. /Billy > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Mark Kavanagh > Sent: Tuesday, November 21, 2017 6:29 PM > To: d...@openvswitch.org; qiud...@chinac.com > Subject: [ovs-dev] [RFC

Re: [ovs-dev] [PATCH v4 2/3] dpif-netdev: Rename rxq_cycle_sort to compare_rxq_cycles.

2017-11-24 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, November 23, 2017 7:42 PM > To: d...@openvswitch.org; aserd...@ovn.org; i.maxim...@samsung.com; O > Mahony, Billy ; Stokes, Ian > Cc: Kevin Traynor &

Re: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist DPDK physical ports.

2017-12-06 Thread O Mahony, Billy
Hi Sugesh, This is definitely a very useful feature. I'm looking forward to running trex on the same DUT as my ovs-dpdk. However I'd suggest adding an sscanf or some such to verify that the domain is also specified for each whitelist member. And either add the default of '' or complain lou

Re: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist DPDK physical ports.

2017-12-07 Thread O Mahony, Billy
Hi Sugesh, > -Original Message- > From: Chandran, Sugesh > Sent: Wednesday, December 6, 2017 6:23 PM > To: O Mahony, Billy ; d...@openvswitch.org; > b...@ovn.org > Subject: RE: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist > DPDK physical ports. >

Re: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist DPDK physical ports.

2017-12-08 Thread O Mahony, Billy
r 7, 2017 5:53 PM > To: Chandran, Sugesh ; O Mahony, Billy > ; d...@openvswitch.org; b...@ovn.org > Cc: Mooney, Sean K > Subject: RE: [ovs-dev] [PATCH 2/2] Adding configuration option to whitelist > DPDK physical ports. > > > > > -Original Message- &g

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-08 Thread O Mahony, Billy
Hi Jan, I had problems applying later patches in this series so just reviewing this one for now. I tried several revisions to apply them. The second patch ([ovs-dev,v3,2/3] dpif-netdev: Detailed performance stats for PMDs ) fails with fatal: patch fragment without header at line 708: @@ -1073,

Re: [ovs-dev] [ovs-dev, v5, 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2018-01-09 Thread O Mahony, Billy
Hi All, I know a v6 is under preparation so I just wanted to give some initial thoughts early before I review further. /Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ilya Maximets > Sent: Tuesday, January 9,

Re: [ovs-dev] [PATCH v5 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2018-01-09 Thread O Mahony, Billy
Hi Jan, Thanks these patches are really very useful. I haven't finished trying them out but thought you'd prefer to get initial comments earlier. I'll continue to try to them out and revert with any further other comments later. Regards, Billy. > -Original Message- > From: ovs-dev-

Re: [ovs-dev] [PATCH v5 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-01-09 Thread O Mahony, Billy
Hi Jan, Thanks these patches are really very useful. I haven't finished trying them out but thought you'd prefer to get initial comments earlier. I'll continue to try to them out and revert with any further other comments later. Regards, Billy. > -Original Message- > From: ovs-dev-bou

Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-01-09 Thread O Mahony, Billy
Hi Jan, Thanks these patches are really very useful. I haven't finished trying them out but thought you'd prefer to get initial comments earlier. I'll continue to try to them out and revert with any further other comments later. Regards, Billy. > -Original Message- > From: ovs-dev-bou

Re: [ovs-dev] [PATCH v9 2/2] dpif-netdev: Refactor cycle counting

2018-01-13 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Jan Scheurich > Sent: Friday, January 12, 2018 12:39 AM > To: d...@openvswitch.org > Cc: i.maxim...@samsung.com > Subject: [ovs-dev] [PATCH v9 2/2

Re: [ovs-dev] [PATCH v9 1/2] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2018-01-13 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Jan Scheurich > Sent: Friday, January 12, 2018 12:39 AM > To: d...@openvswitch.org > Cc: i.maxim...@samsung.com > Subject: [ovs-dev] [PATCH v9 1/2

Re: [ovs-dev] [PATCH v7 1/3] netdev: Add rxq callback function rxq_length()

2018-01-18 Thread O Mahony, Billy
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Thursday, January 18, 2018 6:18 AM > To: Jan Scheurich ; d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; O Mahony, > Billy > Subject: Re: [PATCH v7 1/3] netdev: Add

Re: [ovs-dev] [PATCH v7 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-01-18 Thread O Mahony, Billy
; d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; O Mahony, > Billy > Subject: RE: [PATCH v7 2/3] dpif-netdev: Detailed performance stats for > PMDs > > Hi Ilya, > > Thanks for your in-depth review and comments. Please find my answers > below. > &

Re: [ovs-dev] [PATCH v7 1/3] netdev: Add rxq callback function rxq_length()

2018-01-19 Thread O Mahony, Billy
> -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Thursday, January 18, 2018 4:59 PM > To: Ilya Maximets ; O Mahony, Billy > ; d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian > Subject: RE: [PATCH v7 1/3] netdev: Add

Re: [ovs-dev] [PATCH v7 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-01-19 Thread O Mahony, Billy
hat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; > Jan Scheurich > Subject: [PATCH v7 3/3] dpif-netdev: Detection and logging of suspicious > PMD iterations > > This patch enhances dpif-netdev-perf to detect iterations with suspicious > statistics according to the f

Re: [ovs-dev] [PATCH v7 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-01-19 Thread O Mahony, Billy
ricsson.com] > Sent: Tuesday, January 16, 2018 1:51 AM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; > Jan Scheurich > Subject: [PATCH v7 2/3] dpif-netdev: Detailed performance stats for PMDs > > This patch inst

Re: [ovs-dev] [PATCH v7 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-01-19 Thread O Mahony, Billy
> -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Tuesday, January 16, 2018 1:51 AM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; > Jan Scheurich > Subject: [P

Re: [ovs-dev] [PATCH v8 1/3] netdev: Add optional qfill output parameter to rxq_recv()

2018-01-26 Thread O Mahony, Billy
LGTM but one thing I don't understand down below... > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Friday, January 26, 2018 12:20 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsu

Re: [ovs-dev] [PATCH v8 0/3] dpif-netdev: Detailed PMD performance metrics and supervision

2018-02-15 Thread O Mahony, Billy
; Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy > Subject: RE: [PATCH v8 0/3] dpif-netdev: Detailed PMD performance metrics and > supervision > > Gentle reminder to review this series which unfortunately missed the 2.9 > deadline. > > I chec

Re: [ovs-dev] [RFC 0/2] Ingress Scheduling

2018-02-20 Thread O Mahony, Billy
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, February 20, 2018 2:55 PM > To: ovs-dev@openvswitch.org; O Mahony, Billy > Subject: Re: Re: [ovs-dev] [RFC 0/2] Ingress Scheduling > > > This patch set implements the &#x

Re: [ovs-dev] [RFC 2/2] ingress scheduling: Provide per interface ingress priority

2018-02-20 Thread O Mahony, Billy
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, February 20, 2018 3:10 PM > To: ovs-dev@openvswitch.org; O Mahony, Billy > Subject: Re: [ovs-dev] [RFC 2/2] ingress scheduling: Provide per interface > ingress > priority &

Re: [ovs-dev] [PATCH 0/3] dpif-netdev: Combine CD and DFC patch for datapath refactor

2018-03-08 Thread O Mahony, Billy
Hi All, I have run some tests using a more realistic distribution of flows - see below - to what we normally test with. This is a phy to phy test with just port forwarding but I think that is the best way to test the EMC as it avoids noise from other mechanisms e.g. vhost and dpcls lookup. It us

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-03-30 Thread O Mahony, Billy
Hi Darrell, > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Wednesday, March 29, 2017 6:35 PM > To: O Mahony, Billy ; Jan Scheurich > ; Ilya Maximets ; > d...@openvswitch.org > Subject: Re: [ovs-dev] dpif-netdev: Assign ports to pmds on

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-03-30 Thread O Mahony, Billy
heers, Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of O Mahony, Billy > Sent: Thursday, March 30, 2017 10:11 AM > To: Darrell Ball ; Jan Scheurich > ; Ilya Maximets ; > d...@openvswitch.org &g

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-04-05 Thread O Mahony, Billy
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, April 5, 2017 2:58 PM > To: O Mahony, Billy ; Maxime Coquelin > ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on > DPDK vHostUser. >

Re: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-04-25 Thread O Mahony, Billy
Thanks Ian, I'll incorporate these suggestions in a new patch version. Cheers, Billy. > -Original Message- > From: Stokes, Ian > Sent: Monday, April 24, 2017 5:33 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v2] dpif-netdev: Ass

Re: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-05-03 Thread O Mahony, Billy
Hi Ian, Sorry for delay responding. Some comment below. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of O Mahony, Billy > Sent: Tuesday, April 25, 2017 11:15 AM > To: Stokes, Ian ; d...@openvswitch.or

Re: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-05-04 Thread O Mahony, Billy
Hi Ian, > -Original Message- > From: Stokes, Ian > Sent: Thursday, May 4, 2017 2:19 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v2] dpif-netdev: Assign ports to pmds on non- > local numa node. > > > Hi Ian, > > >

Re: [ovs-dev] [PATCH v4] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-05-10 Thread O Mahony, Billy
Hi Ian, I'll send a new patch shortly. One comment below. Thanks for reviewing, /Billy. > -Original Message- > From: Stokes, Ian > Sent: Wednesday, May 10, 2017 1:19 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v4] dpif-netdev:

Re: [ovs-dev] [PATCH] dpif-netdev: emc comments

2017-05-15 Thread O Mahony, Billy
2017 8:33 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] dpif-netdev: emc comments > > Thanks for the patch Billy > > On 3/30/17, 3:20 AM, "ovs-dev-boun...@openvswitch.org on behalf of Billy > O'Mahony" billy.o.mah...@intel.c

Re: [ovs-dev] [PATCH v4 1/3] netdev-dpdk: Fix double attaching of virtual devices.

2017-05-26 Thread O Mahony, Billy
Tested-by: Billy O'Mahony Acked-by: Billy O'Mahony > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ilya Maximets > Sent: Friday, May 19, 2017 2:38 PM > To: d...@openvswitch.org; Daniele Di Proietto ; > Darrell Ball >

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Increase pmd thread priority

2017-05-26 Thread O Mahony, Billy
Hi Bhanu, This patch no longer applies cleanly. $git apply ... error: Documentation/intro/install/dpdk-advanced.rst: No such file or directory error: patch failed: lib/ovs-numa.h:56 error: lib/ovs-numa.h: patch does not apply Also some more information on the rationale behind such a change woul

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

2017-05-26 Thread O Mahony, Billy
Hi Ilya, This patch does not apply to head of master, currently "c899576 build-windows: cccl fail compilation on Wimplicit-function-declaration". I'll don't have any comments on the code right now but if you can tell me the commit it's based on I'll check it out. Thanks, Billy > -Orig

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

2017-05-26 Thread O Mahony, Billy
Oops the patch series is probably the reason. > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, May 26, 2017 2:51 PM > To: O Mahony, Billy ; d...@openvswitch.org; > Daniele Di Proietto ; Darrell Ball > > Cc: Heetae Ahn &g

Re: [ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

2017-05-30 Thread O Mahony, Billy
Hi All, This patch looks good to me. I've also tested this with deleting and re-adding dpdk ports of various types (physical , vhostuser, net_pcap) and no device id exhaustion occurs (I checked to beyond the limit of RTE_MAX_ETHPORTS (32) ). Acked-by: Billy O'Mahony > -Original Messag

Re: [ovs-dev] [PATCH v2 1/5] dpif-netdev: move pkt metadata init out of emc_processing.

2017-07-31 Thread O Mahony, Billy
Hi Antionio, This looks like a reasonable change to me. Can you add some performance statistics for when dealing with re-circulated packets? /Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of antonio.fische...@i

Re: [ovs-dev] [PATCH v2 1/5] dpif-netdev: move pkt metadata init out of emc_processing.

2017-07-31 Thread O Mahony, Billy
There is also a reference to md_is_valid is the comments of emc_processing that needs to be removed. > -Original Message- > From: O Mahony, Billy > Sent: Monday, July 31, 2017 4:04 PM > To: 'antonio.fische...@intel.com' ; > d...@openvswitch.org > Subject:

Re: [ovs-dev] [PATCH v2 2/5] dpif-netdev: Avoid reading RSS hash when EMC is disabled.

2017-07-31 Thread O Mahony, Billy
Hi Antonio, This is patch is definitely simpler than the original. However on the original patch I suggested: "If so it would be less disturbing to the existing code to just add a bool arg to dpif_netdev_packet_get_rss_hash() called do_not_check_recirc_depth and use that to return early (bef

Re: [ovs-dev] [PATCH v2 3/5] dpif-netdev: Skip EMC lookup/insert for recirc packets.

2017-08-01 Thread O Mahony, Billy
Hi Antonio, Unfortunately I think the performance deltas of this here probably need to be re-worked given the bug discovered & fixed in EMC Insertion algorithm here which according to the patch notes will significantly reduce EMC contention for a given number of flows. https://mail.openvswitch

[ovs-dev] Proposal: EMC load-shedding

2017-08-01 Thread O Mahony, Billy
Hi All, This proposal is an attempt to make a more general solution to the same issue of EMC thrashing addressed by https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335940.html. That patch proposes that when the EMC is overloaded that recirculated packets are neither inserted into the EMC

Re: [ovs-dev] [PATCH v2 5/5] dp-packet: Use memcpy on dp_packet elements.

2017-08-01 Thread O Mahony, Billy
Hi Antonio, > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of antonio.fische...@intel.com > Sent: Wednesday, July 19, 2017 5:05 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v2 5/5] dp-packet: Use memcpy on dp_

Re: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev api

2017-08-16 Thread O Mahony, Billy
Hi Mark, I'm continuing with rework/rebase. Some comments below. > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, August 4, 2017 3:49 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to net

Re: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev api

2017-08-16 Thread O Mahony, Billy
Hi Mark, > -Original Message- > From: O Mahony, Billy > Sent: Wednesday, August 16, 2017 4:53 PM > To: Kavanagh, Mark B ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev > api > > Hi Mark, > > I'm

Re: [ovs-dev] [PATCH 2/4] netdev-dpdk: Apply ingress_sched config to dpdk phy ports

2017-08-17 Thread O Mahony, Billy
Hi Mark, Thanks for the very useful review comments. I'll send a rev'd patch set shortly. /Billy > -Original Message- > From: Kavanagh, Mark B > Sent: Friday, August 4, 2017 4:14 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATC

Re: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic

2017-08-17 Thread O Mahony, Billy
Hi Kevin, Thanks for the comments - more inline. Billy. > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, August 17, 2017 3:37 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/4] prioritizing la

Re: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic

2017-08-17 Thread O Mahony, Billy
Hi All, > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Thursday, August 17, 2017 5:22 PM > To: O Mahony, Billy ; Kevin Traynor > ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic &g

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

2017-08-24 Thread O Mahony, Billy
Hi Gao, Thanks for working on this. Lack of checksum offload is big difference between ovs and ovs-dpdk when using linux stack in the guest. The thing that struck me was that rather than immediately calculating the L4 checksum in the host on vhost rx that the calculation should be delayed unti

Re: [ovs-dev] [PATCH v4] dpif-netdev: Avoid reading RSS hash when EMC is disabled

2017-09-01 Thread O Mahony, Billy
Hi Antonio, Sorry for the late follow up on this version of this patch. I'm not sure if you are withdrawing the v4 of this patch. But I think my comments are valid for both v4 and v3 versions. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvs

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-06 Thread O Mahony, Billy
isc...@openvswitch.org; ovs- > d...@openvswitch.org; O Mahony, Billy ; Kevin > Traynor > Subject: Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for > physical port > > Adding Billy and Kevin > > > On 9/6/17, 12:22 AM, "Darrell Ball" wrote: >

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-06 Thread O Mahony, Billy
Hi Wang, If you create several PMDs on the NUMA of the physical port does that have the same performance characteristic? /Billy > -Original Message- > From: 王志克 [mailto:wangzh...@jd.com] > Sent: Wednesday, September 6, 2017 10:20 AM > To: O Mahony, Billy ; Darrell Ball

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-06 Thread O Mahony, Billy
o the correct rxq. /Billy. > -Original Message- > From: 王志克 [mailto:wangzh...@jd.com] > Sent: Wednesday, September 6, 2017 11:41 AM > To: O Mahony, Billy ; Darrell Ball > ; ovs-disc...@openvswitch.org; ovs- > d...@openvswitch.org; Kevin Traynor > Subject: RE: [

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-06 Thread O Mahony, Billy
: Wednesday, September 6, 2017 12:50 PM > To: O Mahony, Billy ; Darrell Ball > ; ovs-disc...@openvswitch.org; ovs- > d...@openvswitch.org; Kevin Traynor > Subject: RE: [ovs-dev] OVS DPDK NUMA pmd assignment question for > physical port > > Hi Billy, > > See my reply in lin

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-06 Thread O Mahony, Billy
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, September 6, 2017 2:50 PM > To: Jan Scheurich ; O Mahony, Billy > ; wangzh...@jd.com; Darrell Ball > ; ovs-disc...@openvswitch.org; ovs- > d...@openvswitch.org > Subject

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-06 Thread O Mahony, Billy
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, September 6, 2017 3:02 PM > To: Jan Scheurich ; O Mahony, Billy > ; wangzh...@jd.com; Darrell Ball > ; ovs-disc...@openvswitch.org; ovs- > d...@openvswitch.org > Subject

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc packets

2017-09-06 Thread O Mahony, Billy
Hi All, On the "“RSS hash threshold method” for EMC load shedding I hope to have time to do an RFC to illustrate in the next week or so give a better idea of what I mean. Thanks, Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-08 Thread O Mahony, Billy
the pmd stats after you start your traffic and then measure after a short duration. Regards, Billy. From: 王志克 [mailto:wangzh...@jd.com] Sent: Friday, September 8, 2017 8:01 AM To: Jan Scheurich ; O Mahony, Billy ; Darrell Ball ; ovs-disc...@openvswitch.org; ovs-dev@openvswitch.org; Kevin

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-08 Thread O Mahony, Billy
克 [mailto:wangzh...@jd.com] > Sent: Friday, September 8, 2017 11:48 AM > To: ovs-dev@openvswitch.org; Jan Scheurich > ; O Mahony, Billy > ; Darrell Ball ; ovs- > disc...@openvswitch.org; Kevin Traynor > Subject: Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for > physical por

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

2017-09-11 Thread O Mahony, Billy
results were potentially affected by this issue. Regards, /Billy. > -Original Message- > From: 王志克 [mailto:wangzh...@jd.com] > Sent: Monday, September 11, 2017 3:00 AM > To: O Mahony, Billy ; ovs- > d...@openvswitch.org; Jan Scheurich ; Darrell > Ball ; ovs-disc.

Re: [ovs-dev] [PATCH] dpif-netdev: Simplify emc replacement policy.

2017-09-12 Thread O Mahony, Billy
Hi Darrell, > The effect here is highly data dependent and in fact dominated by the packet > distribution which will not be random or rather pseudo-random. I had done > my own testing with pseudo random flows, fwiw. > I did not see any thrashing with even at 4000 flows and saw one alive/alive > ch

Re: [ovs-dev] [PATCH v5] dpif-netdev: Avoid reading RSS hash when EMC is disabled

2017-09-13 Thread O Mahony, Billy
, 2017 6:32 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Cc: O Mahony, Billy > Subject: Re: [PATCH v5] dpif-netdev: Avoid reading RSS hash when EMC is > disabled > > These results look more clear: 2-3 % improvement for no EMC cases. > Maybe others have comments? >

Re: [ovs-dev] [PATCH v5] dpif-netdev: Avoid reading RSS hash when EMC is disabled

2017-09-19 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Fischetti, Antonio > Sent: Tuesday, September 12, 2017 5:34 PM > To: d...@openvswitch.org > Cc: Darrell Ball ; O Mahony, Billy > ; Fischetti, Antonio > > Subject: [PATCH v5] dpif-netdev: Avoid reading RS

Re: [ovs-dev] ovs_dpdk: dpdk-socket-mem usage question

2017-09-19 Thread O Mahony, Billy
Hi Wang, Typically I reserve between 512M and 1G on each Numa. There is no formula I am aware of for how much memory is actually required. Fundamentally this will be determined by the maximum number and size of packets in-flight at any given time. Which is determined by the ingress packet rate,

Re: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic

2017-09-22 Thread O Mahony, Billy
Hi Jan, Kevin, > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Thursday, September 21, 2017 4:12 PM > To: Kevin Traynor ; O Mahony, Billy > ; d...@openvswitch.org > Cc: Mechthild Buescher ; Venkatesan > Pradeep > Subject:

Re: [ovs-dev] [PATCH 0/4] prioritizing latency sensitive traffic

2017-09-22 Thread O Mahony, Billy
Hi Jan, > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Friday, September 22, 2017 12:37 PM > To: O Mahony, Billy ; Kevin Traynor > ; d...@openvswitch.org > Cc: Mechthild Buescher ; Venkatesan > Pradeep > Subject:

Re: [ovs-dev] [RFC 0/2] EMC load-shedding

2017-09-25 Thread O Mahony, Billy
Hi Darrell, Some more information below. I'll hold off on a v2 for now to give others time to comment. Thanks, Billy. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Friday, September 22, 2017 7:20 PM > To: O Mahony, Billy ; d...@ope

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-02-28 Thread O Mahony, Billy
Billy > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, February 28, 2017 11:21 AM > To: O Mahony, Billy ; d...@openvswitch.org > Cc: Daniele Di Proietto > Subject: Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa >

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-02-28 Thread O Mahony, Billy
Hi Ilya, Comments below. BR, Billy. > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, February 28, 2017 12:49 PM > To: O Mahony, Billy ; d...@openvswitch.org > Cc: Daniele Di Proietto > Subject: Re: [ovs-dev] dpif-netdev: As

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

2017-03-09 Thread O Mahony, Billy
I'd be interested to hear any other comments from the community on this patch. Regards, /Billy > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Monday, March 6, 2017 8:25 AM > To: O Mahony, Billy ; Ilya Maximets > ; d...@open

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-03-20 Thread O Mahony, Billy
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, March 17, 2017 9:48 AM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on > DPDK vHostUser. > &

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-03-20 Thread O Mahony, Billy
Hi Kevin, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, March 16, 2017 6:35 PM > To: O Mahony, Billy ; d...@openvswitch.org > Cc: Loftus, Ciara ; Maxime Coquelin > > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Enable IN

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

2017-03-21 Thread O Mahony, Billy
Hi Kevin, Thanks for running that test. Cheers, Billy. > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, March 21, 2017 10:58 AM > To: O Mahony, Billy ; d...@openvswitch.org > Cc: Loftus, Ciara ; Maxime Coquelin > > Subject:

Re: [ovs-dev] [PATCH v8 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-03-12 Thread O Mahony, Billy
i.maxim...@samsung.com; O Mahony, Billy ; Jan > Scheurich > Subject: [PATCH v8 3/3] dpif-netdev: Detection and logging of suspicious PMD > iterations > > This patch enhances dpif-netdev-perf to detect iterations with suspicious > statistics according to the following criteria:

Re: [ovs-dev] [PATCH v8 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-03-12 Thread O Mahony, Billy
i.maxim...@samsung.com; O Mahony, Billy ; Jan > Scheurich > Subject: [PATCH v8 2/3] dpif-netdev: Detailed performance stats for PMDs > > This patch instruments the dpif-netdev datapath to record detailed > statistics of what is happening in every iteration of a PMD thread. > &g

Re: [ovs-dev] [PATCH v10 1/3] netdev: Add optional qfill output parameter to rxq_recv()

2018-03-18 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Sunday, March 18, 2018 5:55 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; Jan

Re: [ovs-dev] [PATCH v10 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-03-18 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Sunday, March 18, 2018 5:55 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; Jan

Re: [ovs-dev] [PATCH v10 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-03-18 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Sunday, March 18, 2018 5:55 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; Jan

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove 'error' from non error log.

2018-03-23 Thread O Mahony, Billy
Sounds like a job for VLOG_WARN ? > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Thursday, March 22, 2018 2:52 PM > To: Kevin Traynor ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev-d

Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs

2018-04-03 Thread O Mahony, Billy
Hi Ben, > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Sunday, April 1, 2018 1:27 AM > To: O Mahony, Billy > Cc: d...@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs > > On We

Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs

2018-04-04 Thread O Mahony, Billy
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, April 3, 2018 6:54 PM > To: O Mahony, Billy > Cc: d...@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs > > On Tue, Ap

Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs

2018-04-05 Thread O Mahony, Billy
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, April 4, 2018 6:00 PM > To: O Mahony, Billy > Cc: d...@openvswitch.org; i.maxim...@samsung.com > Subject: Re: [ovs-dev] [RFC v2 1/2] ingress scheduling: schema and docs > > On We

Re: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example

2018-04-11 Thread O Mahony, Billy
Hi Marcelo, I haven't used the specific cards referred to in the surrounding documentation but I don't think the 'mac' address format is a typo. The notation is specific to some vendor NICs that have several Ethernet devices sharing a single PCI bus:device.function address. In that case the PCI

Re: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example

2018-04-12 Thread O Mahony, Billy
Hi Marcelo, Apologies. It wasn't clear that you had actually hands on experience of the issue. Regards, Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of O Mahony, Billy > Sent: Wednesday, Apr

Re: [ovs-dev] [PATCH v12 1/3] netdev: Add optional qfill output parameter to rxq_recv()

2018-04-20 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Thursday, April 19, 2018 6:41 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; Jan

Re: [ovs-dev] [PATCH v12 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-04-20 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Thursday, April 19, 2018 6:41 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; Jan

Re: [ovs-dev] [PATCH v12 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-04-20 Thread O Mahony, Billy
Acked-by: Billy O'Mahony > -Original Message- > From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] > Sent: Thursday, April 19, 2018 6:41 PM > To: d...@openvswitch.org > Cc: ktray...@redhat.com; Stokes, Ian ; > i.maxim...@samsung.com; O Mahony, Billy ; Jan

Re: [ovs-dev] [PATCH v2] OVS-DPDK: Change "dpdk-socket-mem" default value.

2018-05-09 Thread O Mahony, Billy
Thanks, Aaron. Will do. > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, May 8, 2018 8:35 PM > To: O Mahony, Billy > Cc: d...@openvswitch.org; Rybka, MarcinX > Subject: Re: [ovs-dev] [PATCH v2] OVS-DPDK: Change "dpdk-sock

  1   2   >