Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-26 Thread Ben Pfaff
On Mon, Feb 26, 2018 at 11:47:08AM +0100, Jakub Sitnicki wrote: > On Fri, Feb 23, 2018 at 09:05 PM GMT, Ben Pfaff wrote: > > On Thu, Feb 22, 2018 at 10:54:05PM +0100, Jakub Sitnicki wrote: > >> Use the logical switch/router UUID as hash input, instead of the UUID of > >> the Datapath_Binding row, w

Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-26 Thread Jakub Sitnicki
On Fri, Feb 23, 2018 at 09:05 PM GMT, Ben Pfaff wrote: > On Thu, Feb 22, 2018 at 10:54:05PM +0100, Jakub Sitnicki wrote: >> Use the logical switch/router UUID as hash input, instead of the UUID of >> the Datapath_Binding row, when calculating the hash value for lflows in >> the SBDB. >> >> Otherwis

Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-23 Thread Ben Pfaff
On Thu, Feb 22, 2018 at 10:54:05PM +0100, Jakub Sitnicki wrote: > Use the logical switch/router UUID as hash input, instead of the UUID of > the Datapath_Binding row, when calculating the hash value for lflows in > the SBDB. > > Otherwise the hash value will never match the one computed from NBDB

Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-23 Thread Mark Michelson
Jakub and I discussed this patch offline and I am now on board with this patch. Acked-By: Mark Michelson Tested-By: Mark Michelson On 02/23/2018 08:42 AM, Mark Michelson wrote: Hi Jakub, This patch fixes the issue. However, I think the resulting code can lead to some confusion. The name of

Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-23 Thread Mark Michelson
Hi Jakub, This patch fixes the issue. However, I think the resulting code can lead to some confusion. The name of the first parameter given to ovn_logical_flow_hash() is called "logical_datapath". The result of your patch is that the actual first parameter passed to that function is either a

Re: [ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-23 Thread Numan Siddique
On Fri, Feb 23, 2018 at 3:24 AM, Jakub Sitnicki wrote: > Use the logical switch/router UUID as hash input, instead of the UUID of > the Datapath_Binding row, when calculating the hash value for lflows in > the SBDB. > > Otherwise the hash value will never match the one computed from NBDB > conten

[ovs-dev] [PATCH] Use the correct logical datapath UUID as input for logical flow hash.

2018-02-22 Thread Jakub Sitnicki
Use the logical switch/router UUID as hash input, instead of the UUID of the Datapath_Binding row, when calculating the hash value for lflows in the SBDB. Otherwise the hash value will never match the one computed from NBDB contents, which will force ovn-northd to constantly drop and attempt to re