Re: [ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

2018-04-13 Thread Ben Pfaff
OVS_FORCE does not affect Clang, only sparse. On Fri, Apr 13, 2018 at 11:43:24AM +, Gabor Halász wrote: > Hi Ben, > Indeed there was some problem with that line. > Instead of using the eth_addr_to_uint64() func, I have added OVS_FORCE > compiler flag to keep the logic more visible. > +

Re: [ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

2018-04-13 Thread Gabor Halász
Hi Ben, Indeed there was some problem with that line. Instead of using the eth_addr_to_uint64() func, I have added OVS_FORCE compiler flag to keep the logic more visible. +hash = hash_add64(hash, *((OVS_FORCE uint64_t *) &flow->dl_dst)); +hash = hash_add(hash, (OVS_FORCE uint32_t)

Re: [ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

2018-04-06 Thread Ben Pfaff
On Thu, Apr 05, 2018 at 09:02:22AM +, Gabor Halász wrote: > In real-world vSwitch deployments, handling a few thousand flows, > EMC is quickly saturated, so it's optimal usage is critical to > reach the highest packet forwarding speed of the vSwitch. > > EMC lookup is initiated based on the ha

Re: [ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

2018-04-05 Thread Gabor Halász
bond if there is no valid rss. Please comment on the above ones! Best Regards, Gabor > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Gabor Halász > Sent: 2018. április 5. 11:02 > To: dev > Subject: [ovs-dev] [P

[ovs-dev] [PATCH] flow: Extend 5-tuple hash calculation for non-IP packets

2018-04-05 Thread Gabor Halász
In real-world vSwitch deployments, handling a few thousand flows, EMC is quickly saturated, so it's optimal usage is critical to reach the highest packet forwarding speed of the vSwitch. EMC lookup is initiated based on the hash value of the packet. In case the packet does not already have a store