Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-06 Thread Alin Serdean
m Venugopal [mailto:vsai...@vmware.com] > Sent: Tuesday, December 6, 2016 9:08 PM > To: Alin Serdean ; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable > FTP support > > I feel that these additional threads that are spawned for the l

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-06 Thread Sairam Venugopal
I feel that these additional threads that are spawned for the lifetime of the driver ought to be visible in the Driver load/unload functions. This will be beneficial for both debugging and lifecycle management. I agree that encapsulating it under Conntrack.c will make the code contained, but might

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-05 Thread Alin Serdean
Thanks for the patch. I think OvsInitCtRelated/ OvsCleanupCtRelated would make more sense to be inside OvsInitConntrack/OvsCleanupConntrack since the functionality are tied together. One small nit. Thanks, Alin. > +ctAttr = NlAttrFindNested(a, OVS_CT_ATTR_HELPER); > +if (ctAttr) { > +

[ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-01 Thread Sairam Venugopal
Enable the support for tracking FTP connections in the Connection tracker. This checks an incoming ftp control connection to extract the related data connection. When a matching data connection arrives, it would then update the connection entry to point to the original control connection. Signed-o