Thanks for the patch.
I think OvsInitCtRelated/ OvsCleanupCtRelated would make more sense to be
inside OvsInitConntrack/OvsCleanupConntrack since the functionality are tied
together.
One small nit.
Thanks,
Alin.
> + ctAttr = NlAttrFindNested(a, OVS_CT_ATTR_HELPER);
> + if (ctAttr) {
> + helper = NlAttrGet(ctAttr);
> + if (!memchr(helper, '\0', 16)) {
[Alin Serdean] We must be careful here, because the size may differ(i.e. a
message could be forged). I think we should add
https://github.com/openvswitch/ovs/blob/master/lib/netlink.c#L649 to the
windows datapath and use it.
> + OVS_LOG_ERROR("Invalid CT_ATTR_HELPER:%s", helper);
> + return NDIS_STATUS_INVALID_PARAMETER;
> + }
> + if (strcmp("ftp", helper) != 0) {
> + /* Only support FTP */
> + return NDIS_STATUS_NOT_SUPPORTED;
> + }
> + }
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
