Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-15 Thread Darrell Ball
-Original Message- From: "Chandran, Sugesh" Date: Sunday, August 13, 2017 at 8:06 AM To: Darrell Ball , Ben Pfaff Cc: "d...@openvswitch.org" Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-13 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Thursday, August 10, 2017 5:15 PM > To: Chandran, Sugesh ; Ben Pfaff > > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL che

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-10 Thread Darrell Ball
-Original Message- From: Darrell Ball Date: Wednesday, August 9, 2017 at 1:38 PM To: "Chandran, Sugesh" , Ben Pfaff Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init. -Original M

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: "Chandran, Sugesh" Date: Wednesday, August 9, 2017 at 12:55 PM To: Darrell Ball , Ben Pfaff Cc: "d...@openvswitch.org" Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Chandran, Sugesh
Regards _Sugesh > > > > > > Correct, I reused reset_dp_packet_checksum_ol_flags() to do the > > initialization as well > > > I could also have created a separate function. > > > > > > In case a DPDK dev is used, those flags will be managed by DPDK. >

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: "Chandran, Sugesh" Date: Wednesday, August 9, 2017 at 11:17 AM To: Darrell Ball , Ben Pfaff Cc: "d...@openvswitch.org" Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init. Hi Darrel, I rev

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Chandran, Sugesh
t: Wednesday, August 9, 2017 6:58 PM > To: Ben Pfaff > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum > flags on init. > > > > -Original Message- > From: Ben Pfaff > Date: Wednesday, August 9, 2017 at 10:40 AM &

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: Ben Pfaff Date: Wednesday, August 9, 2017 at 10:40 AM To: Darrell Ball Cc: Darrell Ball , "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init. On Wed, Aug 09, 2017 at 05:32:02PM +, Da

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 05:32:02PM +, Darrell Ball wrote: > > > -Original Message- > From: on behalf of Ben Pfaff > Date: Wednesday, August 9, 2017 at 10:15 AM > To: Darrell Ball > Cc: "d...@openvswitch.org" > Subject: Re: [ovs-dev] [patch_v5] d

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: on behalf of Ben Pfaff Date: Wednesday, August 9, 2017 at 10:15 AM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init. On Tue, Aug 08, 2017 at 06:54:46PM -0700, Da

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Ben Pfaff
On Tue, Aug 08, 2017 at 06:54:46PM -0700, Darrell Ball wrote: > Reset the DPDK HWOL checksum flags in dp_packet_init_. > The new HWOL bad checksum flag is uninitialized for non-dpdk ports and > this is noticed as test failures using netdev-dummy ports, when built with > the --with-dpdk flag set. He

[ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-08 Thread Darrell Ball
Reset the DPDK HWOL checksum flags in dp_packet_init_. The new HWOL bad checksum flag is uninitialized for non-dpdk ports and this is noticed as test failures using netdev-dummy ports, when built with the --with-dpdk flag set. Hence, in this case, packets may be marked as having a bad checksum. Re