Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-08-02 Thread Ben Pfaff
On Thu, Jul 13, 2017 at 11:44:51PM -0700, Han Zhou wrote: > This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. > > The commit introduced a problem that "File exists" will be reported > when trying to open br0. Earlier today I applied Eelco's additional fix (appended below). I hope tha

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-18 Thread nickcooper-zhangtonghao
> On Jul 19, 2017, at 7:32 AM, Justin Pettit wrote: > >> >> On Jul 18, 2017, at 4:15 AM, Eelco Chaudron wrote: >> >> On 18/07/17 08:28, Justin Pettit wrote: On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: >

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-18 Thread Justin Pettit
> On Jul 18, 2017, at 4:15 AM, Eelco Chaudron wrote: > > On 18/07/17 08:28, Justin Pettit wrote: >>> On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: >>> >>> On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: >>> On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > O

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-18 Thread Eelco Chaudron
On 18/07/17 08:28, Justin Pettit wrote: On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: On 17 July 2017 at 12:51, Justin Pettit wrote: On Jul 17, 2017, at 7:49 AM, Eelco Chaudron

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: > > On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: > > > On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > > > > > >> > >> On 17 July 2017 at 12:51, Justin Pettit wrote: > >> > >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrot

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Numan Siddique
On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: > > > On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > > > > > >> > >> On 17 July 2017 at 12:51, Justin Pettit wrote: > >> > >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron > wrote: > >> > > >> > On 17/07/17 11:10, Numan Siddique wrote: >

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > > >> >> On 17 July 2017 at 12:51, Justin Pettit wrote: >> >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: >> > >> > On 17/07/17 11:10, Numan Siddique wrote: >> >> >> >> >> >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > >>

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Guru Shetty
On 17 July 2017 at 12:51, Justin Pettit wrote: > > > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > > > On 17/07/17 11:10, Numan Siddique wrote: > >> > >> > >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > wrote: > >> > >>Assuming we can get the patch

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Han Zhou
On Mon, Jul 17, 2017 at 12:51 PM, Justin Pettit wrote: > > > > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > > > On 17/07/17 11:10, Numan Siddique wrote: > >> > >> > >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron mailto:echau...@redhat.com>> wrote: > >> > >>Assuming we can get th

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > On 17/07/17 11:10, Numan Siddique wrote: >> >> >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > > wrote: >> >>Assuming we can get the patch in before the next release, there >>should be no need to

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 12:34:44PM +0530, Numan Siddique wrote: > Hi Han, > > I think I am seeing a similar issue here [1]. Can you please check and see > if it's the same issue hit here which this patch fixes. > > [1] uses OVS 2.7.1 for tripleo and the upgrage job updates OVS 2.6.1 to > OVS 2.7

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Eelco Chaudron
On 17/07/17 11:10, Numan Siddique wrote: On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > wrote: On 14/07/17 18:59, Han Zhou wrote: On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron mailto:echau...@redhat.com>

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Numan Siddique
On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron wrote: > On 14/07/17 18:59, Han Zhou wrote: > >> >> >> On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron > > wrote: >> > >> > On 14/07/17 08:44, Han Zhou wrote: >> >> >> >> This reverts commit 67ac844b55d4c5f6bbfa01773c82b3

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Eelco Chaudron
On 14/07/17 18:59, Han Zhou wrote: On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron > wrote: > > On 14/07/17 08:44, Han Zhou wrote: >> >> This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. >> >> The commit introduced a problem that "File exists" will be re

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-14 Thread Han Zhou
On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron wrote: > > On 14/07/17 08:44, Han Zhou wrote: >> >> This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. >> >> The commit introduced a problem that "File exists" will be reported >> when trying to open br0. >> >> The operation that adds eth0

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-14 Thread Eelco Chaudron
On 14/07/17 08:44, Han Zhou wrote: This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. The commit introduced a problem that "File exists" will be reported when trying to open br0. The operation that adds eth0 to br0 while moving IP address from eth0 to bridge internal interface br0 re

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-14 Thread Numan Siddique
On Fri, Jul 14, 2017 at 12:14 PM, Han Zhou wrote: > This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. > > The commit introduced a problem that "File exists" will be reported > when trying to open br0. > > The operation that adds eth0 to br0 while moving IP address from > eth0 to bridg