Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-06 Thread Alin Serdean
ugopal [mailto:vsai...@vmware.com] > Sent: Tuesday, December 6, 2016 9:08 PM > To: Alin Serdean <aserd...@cloudbasesolutions.com>; > d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable > FTP support > > I feel that these ad

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

2016-12-05 Thread Alin Serdean
Thanks for the patch. I think OvsInitCtRelated/ OvsCleanupCtRelated would make more sense to be inside OvsInitConntrack/OvsCleanupConntrack since the functionality are tied together. One small nit. Thanks, Alin. > +ctAttr = NlAttrFindNested(a, OVS_CT_ATTR_HELPER); > +if (ctAttr) { > +