[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454810305 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -111,6 +110,10 @@

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-658561325 Thanks @bharatviswa504 for the review. I have updated the patch based on your comments. > When deleting a bucket, we check bucket is empty or not. Do we need to

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454807157 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadAbortRequest.java ## @@

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454807058 ## File path: hadoop-ozone/dist/src/main/compose/ozone/test.sh ## @@ -26,24 +26,24 @@ source "$COMPOSE_DIR/../testlib.sh" start_docker_env

[GitHub] [hadoop-ozone] runitao commented on pull request #1201: HDDS-3798. Display more accurate timestamp in recon Web

2020-07-14 Thread GitBox
runitao commented on pull request #1201: URL: https://github.com/apache/hadoop-ozone/pull/1201#issuecomment-658555039 Thanks @vivekratnavel for review. I have changed the timestamp format.

[jira] [Updated] (HDDS-3961) Improve efficiency by batching refreshPipeline calls to save RPC traffic

2020-07-14 Thread Rakesh Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Radhakrishnan updated HDDS-3961: --- Labels: performance (was: ) > Improve efficiency by batching refreshPipeline calls

[jira] [Updated] (HDDS-3961) Improve efficiency by batching refreshPipeline calls to save RPC traffic

2020-07-14 Thread Rakesh Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh Radhakrishnan updated HDDS-3961: --- Component/s: SCM Ozone Manager > Improve efficiency by batching

[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #1201: HDDS-3798. Display more accurate timestamp in recon Web

2020-07-14 Thread GitBox
vivekratnavel commented on a change in pull request #1201: URL: https://github.com/apache/hadoop-ozone/pull/1201#discussion_r454789270 ## File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx ## @@ -197,7 +197,7 @@

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1164: HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK

2020-07-14 Thread GitBox
rakeshadr commented on a change in pull request #1164: URL: https://github.com/apache/hadoop-ozone/pull/1164#discussion_r454789813 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2083,6 +2092,11 @@ private void

[jira] [Created] (HDDS-3961) Improve efficiency by batching refreshPipeline calls to save RPC traffic

2020-07-14 Thread Rakesh Radhakrishnan (Jira)
Rakesh Radhakrishnan created HDDS-3961: -- Summary: Improve efficiency by batching refreshPipeline calls to save RPC traffic Key: HDDS-3961 URL: https://issues.apache.org/jira/browse/HDDS-3961

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454782738 ## File path: hadoop-ozone/dist/src/main/smoketest/basic/links.robot ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454782295 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java ## @@ -85,10 +87,11 @@

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454781508 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ## @@ -3314,4 +3396,59 @@ private void

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454781348 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -88,21 +88,20 @@

[GitHub] [hadoop-ozone] runitao opened a new pull request #1201: HDDS-3798. Display more accurate timestamp in recon Web

2020-07-14 Thread GitBox
runitao opened a new pull request #1201: URL: https://github.com/apache/hadoop-ozone/pull/1201 ## What changes were proposed in this pull request? Display more accurate timestamp in recon Web. Currently the web only show timestamp in minutes. ## What is the link to the Apache

[jira] [Updated] (HDDS-3960) Display more accurate timestamp in recon Web

2020-07-14 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-3960: - Target Version/s: 0.7.0 (was: 0.6.0) > Display more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: Currently this web only show minute in timestamp. I think we should display more accurate

[jira] [Updated] (HDDS-3937) Update jquery to v3.5.1

2020-07-14 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-3937: - Resolution: Fixed Status: Resolved (was: Patch Available) > Update jquery to v3.5.1 >

[jira] [Updated] (HDDS-3937) Update jquery to v3.5.1

2020-07-14 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-3937: - Fix Version/s: (was: 0.7.0) 0.6.0 > Update jquery to v3.5.1 >

[jira] [Updated] (HDDS-3960) Display more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: Currently this web only show minute in timestamp. I think we should display more accurate

[jira] [Updated] (HDDS-3960) Display more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Summary: Display more accurate timestamp in recon Web (was: Show more accurate timestamp in recon Web) >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: !image-2020-07-15-11-23-45-037.png|width=797,height=253! (was:

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: (was: image-2020-07-15-11-23-06-152.png) > Show more accurate timestamp in recon Web >

[jira] [Resolved] (HDDS-3885) Create Datanode home page

2020-07-14 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen resolved HDDS-3885. -- Fix Version/s: 0.6.0 Resolution: Fixed > Create Datanode home page > - >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: !image-2020-07-15-11-23-45-037.png! (was: !image-2020-07-15-11-23-06-152.png!) > Show more

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: !image-2020-07-15-11-23-06-152.png! > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: image-2020-07-15-11-23-45-037.png > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: image-2020-07-15-11-23-06-152.png > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: image-2020-07-15-11-22-11-715.png > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: (was: image-2020-07-15-11-22-11-715.png) > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: (was: datanodes-web.png) > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: (was: !datanodes-web.png!) > Show more accurate timestamp in recon Web >

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Attachment: datanodes-web.png > Show more accurate timestamp in recon Web >

[jira] [Created] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
HuangTao created HDDS-3960: -- Summary: Show more accurate timestamp in recon Web Key: HDDS-3960 URL: https://issues.apache.org/jira/browse/HDDS-3960 Project: Hadoop Distributed Data Store Issue

[jira] [Updated] (HDDS-3960) Show more accurate timestamp in recon Web

2020-07-14 Thread HuangTao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HuangTao updated HDDS-3960: --- Description: !datanodes-web.png! > Show more accurate timestamp in recon Web >

[GitHub] [hadoop-ozone] ChenSammi merged pull request #1139: HDDS-3885. Create Datanode home page

2020-07-14 Thread GitBox
ChenSammi merged pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1139: HDDS-3885. Create Datanode home page

2020-07-14 Thread GitBox
ChenSammi commented on pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-658519947 Tested it locally. +1. Thanks @maobaolong for the contribution. This is an automated message from the

[GitHub] [hadoop-ozone] GlenGeng commented on a change in pull request #1191: HDDS-3837 Add isLeader check in SCMHAManager.

2020-07-14 Thread GitBox
GlenGeng commented on a change in pull request #1191: URL: https://github.com/apache/hadoop-ozone/pull/1191#discussion_r454752901 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java ## @@ -56,7 +69,28 @@ public void start()

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
bharatviswa504 commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r454552913 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequest.java ## @@ -88,21 +88,20 @@

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1182: HDDS-3926. OM Token Identifier table should use in-house serialization.

2020-07-14 Thread GitBox
avijayanhwx commented on a change in pull request #1182: URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454659862 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java ## @@ -77,6 +80,122 @@ public Text

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1182: HDDS-3926. OM Token Identifier table should use in-house serialization.

2020-07-14 Thread GitBox
avijayanhwx commented on a change in pull request #1182: URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454659303 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java ## @@ -77,6 +80,122 @@ public Text

[jira] [Updated] (HDDS-3925) SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-3925: Resolution: Fixed Status: Resolved (was: Patch Available) Thank you for fixing

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1197: HDDS-3925. SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread GitBox
avijayanhwx commented on pull request #1197: URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-658424073 Thank you for fixing this @fapifta. I have merged your patch. This is an automated message from the

[GitHub] [hadoop-ozone] avijayanhwx merged pull request #1197: HDDS-3925. SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread GitBox
avijayanhwx merged pull request #1197: URL: https://github.com/apache/hadoop-ozone/pull/1197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
adoroszlai commented on pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-658382641 > This patch needs a rebase. (This has been due to one of my commit only). Done. > I will take a final look at it today, and will post my comments.

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1137: HDDS-3060. /retest github comment does not work

2020-07-14 Thread GitBox
adoroszlai commented on pull request #1137: URL: https://github.com/apache/hadoop-ozone/pull/1137#issuecomment-658363335 Thanks @vivekratnavel for reviewing and committing this. This is an automated message from the Apache

[jira] [Updated] (HDDS-3060) /retest github comment does not work

2020-07-14 Thread Vivek Ratnavel Subramanian (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated HDDS-3060: - Fix Version/s: 0.6.0 Resolution: Fixed Status: Resolved

[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1137: HDDS-3060. /retest github comment does not work

2020-07-14 Thread GitBox
vivekratnavel commented on pull request #1137: URL: https://github.com/apache/hadoop-ozone/pull/1137#issuecomment-658353484 @adoroszlai Thanks for working on this! This will be very helpful. This is an automated message from

[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1137: HDDS-3060. /retest github comment does not work

2020-07-14 Thread GitBox
vivekratnavel merged pull request #1137: URL: https://github.com/apache/hadoop-ozone/pull/1137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (HDDS-3798) Display version and setupTime of DN in recon web

2020-07-14 Thread Vivek Ratnavel Subramanian (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian resolved HDDS-3798. -- Fix Version/s: 0.6.0 Resolution: Fixed > Display version and

[jira] [Updated] (HDDS-3798) Display version and setupTime of DN in recon web

2020-07-14 Thread Vivek Ratnavel Subramanian (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Ratnavel Subramanian updated HDDS-3798: - Summary: Display version and setupTime of DN in recon web (was: Collect

[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1136: HDDS-3798. Collect more info about DN in recon web

2020-07-14 Thread GitBox
vivekratnavel merged pull request #1136: URL: https://github.com/apache/hadoop-ozone/pull/1136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1136: HDDS-3798. Collect more info about DN in recon web

2020-07-14 Thread GitBox
vivekratnavel commented on pull request #1136: URL: https://github.com/apache/hadoop-ozone/pull/1136#issuecomment-658351118 @runitao Thanks for working on this! I have merged the change. This is an automated message from the

[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1200: HDDS-3958. Intermittent failure in Recon acceptance test due to mixed stdout and stderr

2020-07-14 Thread GitBox
vivekratnavel commented on pull request #1200: URL: https://github.com/apache/hadoop-ozone/pull/1200#issuecomment-658349373 @adoroszlai Thanks for working on this! This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1164: HDDS-3824: OM read requests should make SCM#refreshPipeline outside BUCKET_LOCK

2020-07-14 Thread GitBox
xiaoyuyao commented on a change in pull request #1164: URL: https://github.com/apache/hadoop-ozone/pull/1164#discussion_r454547254 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2083,6 +2092,11 @@ private void

[jira] [Resolved] (HDDS-3930) Fix OMKeyDeletesRequest

2020-07-14 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham resolved HDDS-3930. -- Fix Version/s: 0.6.0 Resolution: Fixed > Fix OMKeyDeletesRequest >

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1197: HDDS-3925. SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread GitBox
adoroszlai commented on pull request #1197: URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-658315973 `/retest` does not work (#1137) This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] fapifta commented on pull request #1197: HDDS-3925. SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread GitBox
fapifta commented on pull request #1197: URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-658315099 Thank you for the review @avijayanhwx, I haven't seen the CI checks running, so I pushed the branch once more, let's see, all failures seems irrelevant, especially after a

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1182: HDDS-3926. OM Token Identifier table should use in-house serialization.

2020-07-14 Thread GitBox
xiaoyuyao commented on pull request #1182: URL: https://github.com/apache/hadoop-ozone/pull/1182#issuecomment-658314820 +1 pending CI. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1184: HDDS-2767. security/SecuringTDE.md

2020-07-14 Thread GitBox
xiaoyuyao commented on a change in pull request #1184: URL: https://github.com/apache/hadoop-ozone/pull/1184#discussion_r453834965 ## File path: hadoop-hdds/docs/content/security/SecuringTDE.zh.md ## @@ -0,0 +1,56 @@ +--- +title: "透明数据加密" +date: "2019-April-03" +summary:

[jira] [Resolved] (HDDS-3191) Switch current pipeline interface to the new Replication based interface to write to Ratis

2020-07-14 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-3191. -- Resolution: Fixed Thanks [~glengeng] for the contribution and all for the reviews. I've merged the PR

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl

2020-07-14 Thread GitBox
xiaoyuyao merged pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl

2020-07-14 Thread GitBox
xiaoyuyao commented on pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#issuecomment-658313263 +1, I will merge it shortly. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl

2020-07-14 Thread GitBox
xiaoyuyao commented on a change in pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#discussion_r454525325 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java ## @@ -78,7 +78,7 @@ description

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1179: HDDS-3765. Fluentd writing to secure Ozone S3 API fails with 500 Error.

2020-07-14 Thread GitBox
avijayanhwx commented on pull request #1179: URL: https://github.com/apache/hadoop-ozone/pull/1179#issuecomment-658304243 Working with @bharatviswa504 to hash out details in another related JIRA (HDDS-3955). Based on what is decided, this PR may have some changes. Hoping to get this to a

[jira] [Assigned] (HDDS-3955) Unable to list intermediate paths on keys created using S3G.

2020-07-14 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan reassigned HDDS-3955: --- Assignee: Bharat Viswanadham > Unable to list intermediate paths on keys created

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1197: HDDS-3925. SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread GitBox
avijayanhwx commented on pull request #1197: URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-658298859 /retest This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1197: HDDS-3925. SCM Pipeline DB should directly use UUID bytes for key rather than rely on proto serialization for key.

2020-07-14 Thread GitBox
avijayanhwx commented on a change in pull request #1197: URL: https://github.com/apache/hadoop-ozone/pull/1197#discussion_r454505312 ## File path: hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBStoreIterator.java ## @@ -0,0 +1,224 @@ +/* + *

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-07-14 Thread GitBox
bharatviswa504 commented on pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-658282794 @adoroszlai This patch needs a rebase. (This has been due to one of my commit only). I will take a final look at it today, and will post my comments.

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #1195: HDDS-3930. Fix OMKeyDeletesRequest.

2020-07-14 Thread GitBox
bharatviswa504 merged pull request #1195: URL: https://github.com/apache/hadoop-ozone/pull/1195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1195: HDDS-3930. Fix OMKeyDeletesRequest.

2020-07-14 Thread GitBox
bharatviswa504 commented on pull request #1195: URL: https://github.com/apache/hadoop-ozone/pull/1195#issuecomment-658278048 Thank You @adoroszlai @xiaoyuyao and @smengcl for the review. This is an automated message from

[jira] [Resolved] (HDDS-3957) Fix mixed use of Longs.toByteArray and Ints.fromByteArray

2020-07-14 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanisha Koneru resolved HDDS-3957. -- Fix Version/s: 0.6.0 Resolution: Fixed > Fix mixed use of Longs.toByteArray and

[GitHub] [hadoop-ozone] hanishakoneru merged pull request #1199: HDDS-3957. Fix mixed use of Longs.toByteArray and Ints.fromByteArray

2020-07-14 Thread GitBox
hanishakoneru merged pull request #1199: URL: https://github.com/apache/hadoop-ozone/pull/1199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] hanishakoneru commented on pull request #1199: HDDS-3957. Fix mixed use of Longs.toByteArray and Ints.fromByteArray

2020-07-14 Thread GitBox
hanishakoneru commented on pull request #1199: URL: https://github.com/apache/hadoop-ozone/pull/1199#issuecomment-658275864 Thanks @runzhiwang for fixing this and @adoroszlai for reviewing it. +1. Will merge the PR. This

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1182: HDDS-3926. OM Token Identifier table should use in-house serialization.

2020-07-14 Thread GitBox
xiaoyuyao commented on a change in pull request #1182: URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454474255 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java ## @@ -77,6 +81,57 @@ public Text

[jira] [Updated] (HDDS-3354) OM HA replay optimization

2020-07-14 Thread Arpit Agarwal (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HDDS-3354: Resolution: Done Status: Resolved (was: Patch Available) Resolving as all the sub-tasks

[jira] [Created] (HDDS-3959) Avoid HddsProtos.PipelineID#toString

2020-07-14 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-3959: -- Summary: Avoid HddsProtos.PipelineID#toString Key: HDDS-3959 URL: https://issues.apache.org/jira/browse/HDDS-3959 Project: Hadoop Distributed Data Store

[jira] [Updated] (HDDS-3958) Intermittent failure in Recon acceptance test due to mixed stdout and stderr

2020-07-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3958: --- Status: Patch Available (was: In Progress) > Intermittent failure in Recon acceptance test

[jira] [Updated] (HDDS-3958) Intermittent failure in Recon acceptance test due to mixed stdout and stderr

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3958: - Labels: pull-request-available (was: ) > Intermittent failure in Recon acceptance test due to

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1200: HDDS-3958. Intermittent failure in Recon acceptance test due to mixed stdout and stderr

2020-07-14 Thread GitBox
adoroszlai opened a new pull request #1200: URL: https://github.com/apache/hadoop-ozone/pull/1200 ## What changes were proposed in this pull request? Make `curl` less verbose to avoid connection-related messages being mixed into the response from Recon.

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1194: HDDS-3062. Fix TestOzoneRpcClientAbstract.testListVolume.

2020-07-14 Thread GitBox
adoroszlai commented on pull request #1194: URL: https://github.com/apache/hadoop-ozone/pull/1194#issuecomment-658176259 Thanks @lokeshj1703 for the fix. This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (HDDS-3062) Fix TestOzoneRpcClientAbstract.testListVolume

2020-07-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-3062. Fix Version/s: 0.7.0 Resolution: Fixed > Fix

[jira] [Updated] (HDDS-3062) Fix TestOzoneRpcClientAbstract.testListVolume

2020-07-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3062: --- Labels: (was: TriagePending pull-request-available) > Fix

[jira] [Updated] (HDDS-3062) Fix TestOzoneRpcClientAbstract.testListVolume

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3062: - Labels: pull-request-available (was: ) > Fix TestOzoneRpcClientAbstract.testListVolume >

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1194: HDDS-3062. Fix TestOzoneRpcClientAbstract.testListVolume.

2020-07-14 Thread GitBox
adoroszlai merged pull request #1194: URL: https://github.com/apache/hadoop-ozone/pull/1194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page

2020-07-14 Thread GitBox
maobaolong commented on pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-658159855 @ChenSammi Thank you for correct me, PTAL. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1139: HDDS-3885. Create Datanode home page

2020-07-14 Thread GitBox
maobaolong commented on a change in pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#discussion_r454330718 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java ## @@ -22,13 +22,11 @@ import

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1139: HDDS-3885. Create Datanode home page

2020-07-14 Thread GitBox
ChenSammi commented on a change in pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#discussion_r454326825 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java ## @@ -22,13 +22,11 @@ import

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-14 Thread GitBox
captainzmc commented on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-658150187 > Thanks @captainzmc for updating the PR based on #1195. I would like to suggest waiting until that PR is merged before updating this one again, to avoid having to

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-14 Thread GitBox
captainzmc commented on a change in pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#discussion_r454315354 ## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java ## @@ -750,6 +751,25 @@ public void

[GitHub] [hadoop-ozone] iamabug commented on a change in pull request #1184: HDDS-2767. security/SecuringTDE.md

2020-07-14 Thread GitBox
iamabug commented on a change in pull request #1184: URL: https://github.com/apache/hadoop-ozone/pull/1184#discussion_r454306212 ## File path: hadoop-hdds/docs/content/security/SecuringTDE.zh.md ## @@ -0,0 +1,56 @@ +--- +title: "透明数据加密" +date: "2019-April-03" +summary:

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1041: HDDS-3725. Ozone sh volume client support quota option

2020-07-14 Thread GitBox
captainzmc commented on a change in pull request #1041: URL: https://github.com/apache/hadoop-ozone/pull/1041#discussion_r454306051 ## File path: hadoop-hdds/docs/content/shell/VolumeCommands.md ## @@ -42,7 +42,7 @@ assign it to a user. | Uri | The

[jira] [Created] (HDDS-3958) Intermittent failure in Recon acceptance test due to mixed stdout and stderr

2020-07-14 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-3958: -- Summary: Intermittent failure in Recon acceptance test due to mixed stdout and stderr Key: HDDS-3958 URL: https://issues.apache.org/jira/browse/HDDS-3958

[jira] [Updated] (HDDS-3789) Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR

2020-07-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3789: - Labels: pull-request-available (was: ) > Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR >

[jira] [Resolved] (HDDS-3789) Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR

2020-07-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-3789. Fix Version/s: 0.7.0 Resolution: Fixed > Fix

[jira] [Updated] (HDDS-3789) Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR

2020-07-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-3789: --- Labels: (was: pull-request-available) > Fix

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1198: HDDS-3789. Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR.

2020-07-14 Thread GitBox
adoroszlai commented on pull request #1198: URL: https://github.com/apache/hadoop-ozone/pull/1198#issuecomment-658117846 Thanks @lokeshj1703 for the fix. This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1198: HDDS-3789. Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR.

2020-07-14 Thread GitBox
adoroszlai merged pull request #1198: URL: https://github.com/apache/hadoop-ozone/pull/1198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #1194: HDDS-3062. Fix TestOzoneRpcClientAbstract.testListVolume.

2020-07-14 Thread GitBox
lokeshj1703 commented on pull request #1194: URL: https://github.com/apache/hadoop-ozone/pull/1194#issuecomment-658103461 @adoroszlai Thanks for reviewing the PR! I agree. The appendEntries timeout issue will affect all the ratis client related tests that is why we see failures in

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-07-14 Thread GitBox
adoroszlai commented on a change in pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#discussion_r454240450 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysRenameRequest.java ## @@ -0,0 +1,360 @@ +/**

  1   2   >