[GitHub] [hadoop-ozone] elek commented on pull request #1012: HDDS-3658. Stop to persist container related pipeline info of each ke…

2020-06-30 Thread GitBox
elek commented on pull request #1012: URL: https://github.com/apache/hadoop-ozone/pull/1012#issuecomment-651596050 As there is no other objection / comment I will merge this after a green build. This is an automated message

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-06-30 Thread GitBox
adoroszlai commented on a change in pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#discussion_r447453885 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java ## @@ -174,6 +175,12

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-06-30 Thread GitBox
codecov-commenter commented on pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-651585829 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1104?src=pr=h1) Report > Merging

[jira] [Updated] (HDDS-3831) Enhance Recon ContainerEndPoint to report on difference unhealty container states

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3831: - Labels: pull-request-available (was: ) > Enhance Recon ContainerEndPoint to report on difference

[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1148: HDDS-3831. Enhance Recon ContainerEndPoint to report on difference unhealty container states

2020-06-30 Thread GitBox
vivekratnavel commented on pull request #1148: URL: https://github.com/apache/hadoop-ozone/pull/1148#issuecomment-651591817 @sodonnel For some reason, there are no CI checks for the commit. Can you please try to trigger CI checks by pushing an empty commit? Thanks!

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1104: HDDS-3612. Allow mounting bucket under other volume

2020-06-30 Thread GitBox
adoroszlai commented on pull request #1104: URL: https://github.com/apache/hadoop-ozone/pull/1104#issuecomment-651590619 Thanks @bharatviswa504 for the review. I have updated the patch based on your code comments. This is

[GitHub] [hadoop-ozone] elek commented on pull request #1131: HDDS-3876. Display summary of failures as a separate job step

2020-06-30 Thread GitBox
elek commented on pull request #1131: URL: https://github.com/apache/hadoop-ozone/pull/1131#issuecomment-651595292 Good idea. What about adding the same for PR builds? This is an automated message from the Apache Git

[jira] [Resolved] (HDDS-3770) Improve getPipelines performance

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3770. --- Fix Version/s: 0.6.0 Resolution: Fixed > Improve getPipelines performance >

[jira] [Resolved] (HDDS-3782) Remove podAntiAffinity from datanode-statefulset

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3782. --- Fix Version/s: 0.6.0 Resolution: Fixed > Remove podAntiAffinity from datanode-statefulset >

[GitHub] [hadoop-ozone] elek commented on pull request #1131: HDDS-3876. Display summary of failures as a separate job step

2020-06-30 Thread GitBox
elek commented on pull request #1131: URL: https://github.com/apache/hadoop-ozone/pull/1131#issuecomment-651704654 > We no longer have separate workflow for push and PR, so this change applies to PRs, too. Ups, thanks the info. I missed that PR, but like it (if it's not too late

[GitHub] [hadoop-ozone] elek merged pull request #1066: HDDS-3770. Improve getPipelines performance

2020-06-30 Thread GitBox
elek merged pull request #1066: URL: https://github.com/apache/hadoop-ozone/pull/1066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] elek commented on pull request #1066: HDDS-3770. Improve getPipelines performance

2020-06-30 Thread GitBox
elek commented on pull request #1066: URL: https://github.com/apache/hadoop-ozone/pull/1066#issuecomment-651674170 Merging this as it has green build + comments from @xiaoyuyao addressed and @dineshchitlangia also approved it. (thanks the reviews). Thanks the contribution

[GitHub] [hadoop-ozone] elek merged pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset

2020-06-30 Thread GitBox
elek merged pull request #1057: URL: https://github.com/apache/hadoop-ozone/pull/1057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1139: HDDS-3885. Create Datanode home page

2020-06-30 Thread GitBox
adoroszlai commented on pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-651743270 Thanks @maobaolong for updating the patch. Let's wait for others to take a look. This is an automated

[GitHub] [hadoop-ozone] elek commented on pull request #1041: HDDS-3725. Ozone sh volume client support quota option

2020-06-30 Thread GitBox
elek commented on pull request #1041: URL: https://github.com/apache/hadoop-ozone/pull/1041#issuecomment-651672572 Adding a few paragraphs to the jira (or to the PR) would help to understand the goal. It seems to introduce new type of quota (count based instead of byte based) which is not

[GitHub] [hadoop-ozone] elek commented on pull request #1041: HDDS-3725. Ozone sh volume client support quota option

2020-06-30 Thread GitBox
elek commented on pull request #1041: URL: https://github.com/apache/hadoop-ozone/pull/1041#issuecomment-651672160 /pending comments from @timmylicheng are not addressed. This is an automated message from the Apache Git

[GitHub] [hadoop-ozone] elek commented on pull request #1110: HDDS-3843. Throw the specific exception other than NPE.

2020-06-30 Thread GitBox
elek commented on pull request #1110: URL: https://github.com/apache/hadoop-ozone/pull/1110#issuecomment-651683723 > So, you mean, we should keep s3g's behavior consistent with aws s3? Yes, I think we should follow the behavior of AWS. There are so many s3 tools: doing exactly the

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1131: HDDS-3876. Display summary of failures as a separate job step

2020-06-30 Thread GitBox
adoroszlai commented on pull request #1131: URL: https://github.com/apache/hadoop-ozone/pull/1131#issuecomment-651707810 Thanks @elek for reviewing and committing it. This is an automated message from the Apache Git Service.

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1133: HDDS-3875. Package classpath files to the jar files instead of uploading them as artifacts

2020-06-30 Thread GitBox
elek commented on a change in pull request #1133: URL: https://github.com/apache/hadoop-ozone/pull/1133#discussion_r447600314 ## File path: hadoop-ozone/dist/pom.xml ## @@ -41,103 +41,13 @@ copy-classpath-files prepare-package -

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page

2020-06-30 Thread GitBox
maobaolong commented on pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-651742566 @adoroszlai Thanks for your review. AFAIK, the reason why Rpc Metrics page is empty for datanode is that datanode has no rpc service.PTAL.

[GitHub] [hadoop-ozone] elek commented on pull request #912: WIP Patch - HDDS-2949: store dir/key entries in separate tables - first patch onl…

2020-06-30 Thread GitBox
elek commented on pull request #912: URL: https://github.com/apache/hadoop-ozone/pull/912#issuecomment-651679104 /pending WIP This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (HDDS-2949) mkdir : store directory entries in a separate table

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2949: - Labels: backward-incompatible pull-request-available (was: backward-incompatible) > mkdir :

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1128: HDDS-3862. Prepare checks for running some tests multiple times

2020-06-30 Thread GitBox
elek commented on a change in pull request #1128: URL: https://github.com/apache/hadoop-ozone/pull/1128#discussion_r447558463 ## File path: hadoop-ozone/dev-support/checks/junit.sh ## @@ -0,0 +1,63 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (HDDS-2978) Intermittent failure in TestResourceLimitCache

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2978: - Labels: pull-request-available (was: ) > Intermittent failure in TestResourceLimitCache >

[jira] [Resolved] (HDDS-2978) Intermittent failure in TestResourceLimitCache

2020-06-30 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-2978. Fix Version/s: 0.6.0 Resolution: Fixed > Intermittent failure in

[jira] [Updated] (HDDS-2978) Intermittent failure in TestResourceLimitCache

2020-06-30 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2978: --- Labels: (was: pull-request-available) > Intermittent failure in TestResourceLimitCache >

[jira] [Updated] (HDDS-2978) Intermittent failure in TestResourceLimitCache

2020-06-30 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2978: --- Labels: (was: pull-request-available) > Intermittent failure in TestResourceLimitCache >

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1139: HDDS-3885. Create Datanode home page

2020-06-30 Thread GitBox
adoroszlai commented on a change in pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#discussion_r447421484 ## File path: hadoop-hdds/container-service/src/main/resources/webapps/hddsDatanode/dn-overview.html ## @@ -0,0 +1,22 @@ + +Node counts Review

[GitHub] [hadoop-ozone] runzhiwang commented on a change in pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-06-30 Thread GitBox
runzhiwang commented on a change in pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053#discussion_r447544624 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java ## @@ -301,14 +306,21 @@ public static Pipeline

[GitHub] [hadoop-ozone] elek commented on pull request #1127: HDDS-3421. Enabling TestStorageContainerManager.

2020-06-30 Thread GitBox
elek commented on pull request #1127: URL: https://github.com/apache/hadoop-ozone/pull/1127#issuecomment-651701000 > CI check is failing for "TestBlockOutputStreamWithFailuresFlushDelay" which is an unrelated failure. Please take a look. I agree, but I prefer to merge only green

[GitHub] [hadoop-ozone] elek merged pull request #1131: HDDS-3876. Display summary of failures as a separate job step

2020-06-30 Thread GitBox
elek merged pull request #1131: URL: https://github.com/apache/hadoop-ozone/pull/1131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HDDS-3246) Include OM hostname info in "getserviceroles" subcommand of OM CLI

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3246. --- Fix Version/s: 0.6.0 Resolution: Fixed > Include OM hostname info in "getserviceroles"

[GitHub] [hadoop-ozone] elek commented on pull request #706: HDDS-3246. Include OM hostname info in getserviceroles subcommand of OM CLI

2020-06-30 Thread GitBox
elek commented on pull request #706: URL: https://github.com/apache/hadoop-ozone/pull/706#issuecomment-651705520 88347c5 is also green. I am merging it now. Thanks @nilotpalnandi the contribution. This is an automated

[GitHub] [hadoop-ozone] elek merged pull request #706: HDDS-3246. Include OM hostname info in getserviceroles subcommand of OM CLI

2020-06-30 Thread GitBox
elek merged pull request #706: URL: https://github.com/apache/hadoop-ozone/pull/706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HDDS-3876) Display summary of failures as a separate job step

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3876: -- Fix Version/s: 0.6.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1115: HDDS-3632. starter scripts can't manage Ozone and HDFS datandodes on the same machine

2020-06-30 Thread GitBox
elek commented on a change in pull request #1115: URL: https://github.com/apache/hadoop-ozone/pull/1115#discussion_r447582657 ## File path: hadoop-ozone/dist/src/shell/hdds/hadoop-functions.sh ## @@ -2702,11 +2702,11 @@ function hadoop_generic_java_subcmd_handler

[jira] [Updated] (HDDS-2978) Intermittent failure in TestResourceLimitCache

2020-06-30 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-2978: --- Target Version/s: (was: 0.7.0) > Intermittent failure in TestResourceLimitCache >

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1146: HDDS-2978. Intermittent failure in TestResourceLimitCache

2020-06-30 Thread GitBox
adoroszlai commented on pull request #1146: URL: https://github.com/apache/hadoop-ozone/pull/1146#issuecomment-651746203 Thanks @cku328 for the fix and @lokeshj1703 for the review. This is an automated message from the

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1146: HDDS-2978. Intermittent failure in TestResourceLimitCache

2020-06-30 Thread GitBox
adoroszlai merged pull request #1146: URL: https://github.com/apache/hadoop-ozone/pull/1146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1131: HDDS-3876. Display summary of failures as a separate job step

2020-06-30 Thread GitBox
adoroszlai commented on pull request #1131: URL: https://github.com/apache/hadoop-ozone/pull/1131#issuecomment-651608814 > What about adding the same for PR builds? We no longer have separate workflow for push and PR, so this change applies to PRs, too.

[GitHub] [hadoop-ozone] elek commented on pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-06-30 Thread GitBox
elek commented on pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053#issuecomment-651668950 /pending @runzhiwang can you please add answer to the comment? This is an automated message from the Apache

[GitHub] [hadoop-ozone] runzhiwang commented on a change in pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-06-30 Thread GitBox
runzhiwang commented on a change in pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053#discussion_r447544624 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java ## @@ -301,14 +306,21 @@ public static Pipeline

[GitHub] [hadoop-ozone] runzhiwang commented on a change in pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-06-30 Thread GitBox
runzhiwang commented on a change in pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053#discussion_r447544624 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java ## @@ -301,14 +306,21 @@ public static Pipeline

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #1121: HDDS-3432. Enable TestBlockDeletion test cases.

2020-06-30 Thread GitBox
lokeshj1703 commented on pull request #1121: URL: https://github.com/apache/hadoop-ozone/pull/1121#issuecomment-651706881 @adoroszlai The workflow is now green. There were 2 failures in around 70 runs. One where cluster start timed out at waitForClusterToBeReady and another with

[GitHub] [hadoop-ozone] lokeshj1703 edited a comment on pull request #1121: HDDS-3432. Enable TestBlockDeletion test cases.

2020-06-30 Thread GitBox
lokeshj1703 edited a comment on pull request #1121: URL: https://github.com/apache/hadoop-ozone/pull/1121#issuecomment-651706881 @adoroszlai The workflow is now green. There were 2 failures in around 70 runs. One where cluster start timed out at waitForClusterToBeReady and another with

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1128: HDDS-3862. Prepare checks for running some tests multiple times

2020-06-30 Thread GitBox
adoroszlai commented on a change in pull request #1128: URL: https://github.com/apache/hadoop-ozone/pull/1128#discussion_r447618921 ## File path: hadoop-ozone/dev-support/checks/junit.sh ## @@ -0,0 +1,63 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1128: HDDS-3862. Prepare checks for running some tests multiple times

2020-06-30 Thread GitBox
adoroszlai commented on a change in pull request #1128: URL: https://github.com/apache/hadoop-ozone/pull/1128#discussion_r447618921 ## File path: hadoop-ozone/dev-support/checks/junit.sh ## @@ -0,0 +1,63 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation

[jira] [Resolved] (HDDS-3699) Change write chunk failure logging to ERROR level in BlockOutputStream

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3699. --- Fix Version/s: 0.6.0 Resolution: Fixed > Change write chunk failure logging to ERROR level in

[GitHub] [hadoop-ozone] elek commented on pull request #1006: HDDS-3699. Change write chunk failure logging level to ERROR in BlockOutputStream.

2020-06-30 Thread GitBox
elek commented on pull request #1006: URL: https://github.com/apache/hadoop-ozone/pull/1006#issuecomment-651669592 Ups, we got green build, but we forgot to merge it. Sorry for that. Doing it now. Thanks for the contribution.

[GitHub] [hadoop-ozone] elek merged pull request #1006: HDDS-3699. Change write chunk failure logging level to ERROR in BlockOutputStream.

2020-06-30 Thread GitBox
elek merged pull request #1006: URL: https://github.com/apache/hadoop-ozone/pull/1006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1133: HDDS-3875. Package classpath files to the jar files instead of uploading them as artifacts

2020-06-30 Thread GitBox
adoroszlai commented on a change in pull request #1133: URL: https://github.com/apache/hadoop-ozone/pull/1133#discussion_r447559058 ## File path: hadoop-ozone/dist/pom.xml ## @@ -41,103 +41,13 @@ copy-classpath-files prepare-package -

[GitHub] [hadoop-ozone] elek commented on pull request #1127: HDDS-3421. Enabling TestStorageContainerManager.

2020-06-30 Thread GitBox
elek commented on pull request #1127: URL: https://github.com/apache/hadoop-ozone/pull/1127#issuecomment-651699418 +1 Thanks the fix. If it's passed 20/20 the problem can be the too short timeout. Let's merge it and monitor the state in the next master builds. "Sors bona,

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

2020-06-30 Thread GitBox
runzhiwang edited a comment on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-651703240 > Without write lock the container might be removed from ownerMap and not from the typeMap, which can cause inconsistency. @elek I think this case can not

[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

2020-06-30 Thread GitBox
runzhiwang commented on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-651703240 > Without write lock the container might be removed from ownerMap and not from the typeMap, which can cause inconsistency. I think this case can not be avoided by

[GitHub] [hadoop-ozone] elek commented on pull request #983: HDDS-3584. Support write 2 replication

2020-06-30 Thread GitBox
elek commented on pull request #983: URL: https://github.com/apache/hadoop-ozone/pull/983#issuecomment-651606953 What is the plan with this PR. @arp7 do you have any concerns? Do we need more discussion? This is an

[GitHub] [hadoop-ozone] elek commented on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

2020-06-30 Thread GitBox
elek commented on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-651659061 It's not just about the `updateState` method, but (for example) the `removeContainer` method. Without write lock the container might be removed from `ownerMap` and not

[GitHub] [hadoop-ozone] elek commented on pull request #1033: HDDS-3667. If we gracefully stop datanode it would be better to notify scm and r…

2020-06-30 Thread GitBox
elek commented on pull request #1033: URL: https://github.com/apache/hadoop-ozone/pull/1033#issuecomment-651667340 /pending See questions from @maobaolong This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1107: HDDS-3807. Propagate raft log disks info to SCM from datanode.

2020-06-30 Thread GitBox
elek commented on a change in pull request #1107: URL: https://github.com/apache/hadoop-ozone/pull/1107#discussion_r447545366 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerSpi.java ## @@ -83,4

[GitHub] [hadoop-ozone] elek commented on pull request #1107: HDDS-3807. Propagate raft log disks info to SCM from datanode.

2020-06-30 Thread GitBox
elek commented on pull request #1107: URL: https://github.com/apache/hadoop-ozone/pull/1107#issuecomment-651678810 Checkstyle violation seems to be reported. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] elek merged pull request #812: HDDS-3161. Block illegal characters when creating keys.

2020-06-30 Thread GitBox
elek merged pull request #812: URL: https://github.com/apache/hadoop-ozone/pull/812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop-ozone] elek commented on pull request #812: HDDS-3161. Block illegal characters when creating keys.

2020-06-30 Thread GitBox
elek commented on pull request #812: URL: https://github.com/apache/hadoop-ozone/pull/812#issuecomment-651693879 :musical_note: Green build, green build, tada-tada-tada... :musical_note: Merging it right now, tada-tada-tada :musical_note: Thanks the patch @cku328 (and sorry for

[jira] [Resolved] (HDDS-3161) we need to block illegal characters when creating keys

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3161. --- Fix Version/s: 0.6.0 Resolution: Fixed > we need to block illegal characters when creating

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1115: HDDS-3632. starter scripts can't manage Ozone and HDFS datandodes on the same machine

2020-06-30 Thread GitBox
elek commented on a change in pull request #1115: URL: https://github.com/apache/hadoop-ozone/pull/1115#discussion_r447581743 ## File path: hadoop-ozone/dist/src/shell/hdds/hadoop-functions.sh ## @@ -2702,11 +2702,11 @@ function hadoop_generic_java_subcmd_handler

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-06-30 Thread GitBox
captainzmc commented on pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150#issuecomment-651846590 Hi @xiaoyuyao,This PR implementation is consistent with HDDS-3286 batchDelete. And I split batchRename into two subtasks. This one, mainly OM side implementation. Could

[jira] [Updated] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3902: -- Priority: Blocker (was: Major) > OM HA client failover switcher to a wrong OM server >

[jira] [Commented] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148727#comment-17148727 ] Marton Elek commented on HDDS-3902: --- Seems to be a freon/validation problem. omServiceId is null, but

[jira] [Updated] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3902: -- Issue Type: Bug (was: Improvement) > OM HA client failover switcher to a wrong OM server >

[jira] [Updated] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3902: -- Labels: 0.7.0 (was: ) > OM HA client failover switcher to a wrong OM server >

[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-06-30 Thread GitBox
runzhiwang commented on pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053#issuecomment-651802478 /ready This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop-ozone] runzhiwang commented on a change in pull request #1053: HDDS-3737. Avoid serialization between UUID and String

2020-06-30 Thread GitBox
runzhiwang commented on a change in pull request #1053: URL: https://github.com/apache/hadoop-ozone/pull/1053#discussion_r447697031 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java ## @@ -301,14 +306,21 @@ public static Pipeline

[jira] [Created] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
Marton Elek created HDDS-3902: - Summary: OM HA client failover switcher to a wrong OM server Key: HDDS-3902 URL: https://issues.apache.org/jira/browse/HDDS-3902 Project: Hadoop Distributed Data Store

[jira] [Created] (HDDS-3904) BasicOzoneFileSystem support batchRename folder.

2020-06-30 Thread mingchao zhao (Jira)
mingchao zhao created HDDS-3904: --- Summary: BasicOzoneFileSystem support batchRename folder. Key: HDDS-3904 URL: https://issues.apache.org/jira/browse/HDDS-3904 Project: Hadoop Distributed Data Store

[jira] [Updated] (HDDS-3903) OzoneRpcClient support batch rename keys.

2020-06-30 Thread mingchao zhao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingchao zhao updated HDDS-3903: Component/s: Ozone Manager > OzoneRpcClient support batch rename keys. >

[GitHub] [hadoop-ozone] elek opened a new pull request #1149: Hdds 3878

2020-06-30 Thread GitBox
elek opened a new pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149 ## What changes were proposed in this pull request? _emphasized text_om.serviceId is required on case of OM.HA in all the client parameters even if there is only one om.serviceId and it can

[jira] [Created] (HDDS-3903) OzoneRpcClient support batch rename keys.

2020-06-30 Thread mingchao zhao (Jira)
mingchao zhao created HDDS-3903: --- Summary: OzoneRpcClient support batch rename keys. Key: HDDS-3903 URL: https://issues.apache.org/jira/browse/HDDS-3903 Project: Hadoop Distributed Data Store

[jira] [Updated] (HDDS-3903) OzoneRpcClient support batch rename keys.

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-3903: - Labels: pull-request-available (was: ) > OzoneRpcClient support batch rename keys. >

[GitHub] [hadoop-ozone] captainzmc opened a new pull request #1150: HDDS-3903. OzoneRpcClient support batch rename keys.

2020-06-30 Thread GitBox
captainzmc opened a new pull request #1150: URL: https://github.com/apache/hadoop-ozone/pull/1150 ## What changes were proposed in this pull request? Currently rename folder is to get all the keys, and then rename them one by one. This makes for poor performance. HDDS-2939

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1149: Hdds 3878

2020-06-30 Thread GitBox
codecov-commenter commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-651845990 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1149?src=pr=h1) Report > Merging

[jira] [Updated] (HDDS-2978) Intermittent failure in TestResourceLimitCache

2020-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-2978: - Labels: pull-request-available (was: ) > Intermittent failure in TestResourceLimitCache >

[GitHub] [hadoop-ozone] cku328 commented on pull request #1146: HDDS-2978. Intermittent failure in TestResourceLimitCache

2020-06-30 Thread GitBox
cku328 commented on pull request #1146: URL: https://github.com/apache/hadoop-ozone/pull/1146#issuecomment-651774937 Thanks @adoroszlai @lokeshj1703 for the review. This is an automated message from the Apache Git Service.

[jira] [Updated] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3902: -- Target Version/s: (was: 0.6.0) > OM HA client failover switcher to a wrong OM server >

[jira] [Updated] (HDDS-3902) OM HA client failover switcher to a wrong OM server

2020-06-30 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-3902: -- Priority: Major (was: Blocker) > OM HA client failover switcher to a wrong OM server >

[jira] [Commented] (HDDS-3894) Noisy log at OM when the requested sequence is not written into DB

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148855#comment-17148855 ] Aravindan Vijayan commented on HDDS-3894: - [~rakeshr] Thanks for tracking this issue. Since Recon

[jira] [Updated] (HDDS-3894) Noisy log at OM when the requested sequence is not written into DB

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan updated HDDS-3894: Component/s: Ozone Recon > Noisy log at OM when the requested sequence is not written into

[jira] [Assigned] (HDDS-1261) Add robot tests for Recon Server

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan reassigned HDDS-1261: --- Assignee: Aravindan Vijayan (was: Vivek Ratnavel Subramanian) > Add robot tests for

[jira] [Resolved] (HDDS-1261) Add robot tests for Recon Server

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan resolved HDDS-1261. - Resolution: Fixed Fixed through the patch for HDDS-3117. > Add robot tests for Recon

[jira] [Updated] (HDDS-3868) Implement getTrashRoot and getTrashRoots in o3fs

2020-06-30 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3868: - Resolution: Fixed Status: Resolved (was: Patch Available) > Implement getTrashRoot and

[jira] [Updated] (HDDS-3803) [OFS] Add User Guide

2020-06-30 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3803: - Resolution: Fixed Status: Resolved (was: Patch Available) > [OFS] Add User Guide >

[jira] [Commented] (HDDS-3402) Use proper acls for sub directories created during CreateDirectory operation

2020-06-30 Thread Rakesh Radhakrishnan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148843#comment-17148843 ] Rakesh Radhakrishnan commented on HDDS-3402: Thanks [~Sammi] for the interest. I am checking

[GitHub] [hadoop-ozone] smengcl commented on pull request #1089: [WIP] HDDS-3705. [OFS] Implement getTrashRoots for trash cleanup

2020-06-30 Thread GitBox
smengcl commented on pull request #1089: URL: https://github.com/apache/hadoop-ozone/pull/1089#issuecomment-651985170 I'm rebasing the branch since the last update is a while ago. Also there were some flaky ozone-recon robot test in the [first

[GitHub] [hadoop-ozone] smengcl merged pull request #1144: HDDS-3803. [OFS] Add User Guide

2020-06-30 Thread GitBox
smengcl merged pull request #1144: URL: https://github.com/apache/hadoop-ozone/pull/1144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] hanishakoneru commented on pull request #1129: HDDS-3741. Reload old OM state if Install Snapshot from Leader fails

2020-06-30 Thread GitBox
hanishakoneru commented on pull request #1129: URL: https://github.com/apache/hadoop-ozone/pull/1129#issuecomment-651991144 Thanks @arp7 for the review. Addressed your review comments. This is an automated message from the

[jira] [Assigned] (HDDS-3832) Enhance Recon UI to display the different unhealthy container states

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan reassigned HDDS-3832: --- Assignee: Vivek Ratnavel Subramanian > Enhance Recon UI to display the different

[jira] [Commented] (HDDS-3873) Intermittent failure in Recon acceptance test due to too many pipelines

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148857#comment-17148857 ] Aravindan Vijayan commented on HDDS-3873: - [~adoroszlai] We may be ok to loosen the pipelines

[jira] [Comment Edited] (HDDS-3894) Noisy log at OM when the requested sequence is not written into DB

2020-06-30 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148855#comment-17148855 ] Aravindan Vijayan edited comment on HDDS-3894 at 6/30/20, 5:48 PM: ---

[jira] [Updated] (HDDS-3705) [OFS] Implement getTrashRoots for trash cleanup

2020-06-30 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-3705: - Description: We need to override {{getTrashRoots()}} as well in order to allow for easier future OM

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1106: HDDS-2413. Set configuration variables from annotated java objects

2020-06-30 Thread GitBox
elek commented on a change in pull request #1106: URL: https://github.com/apache/hadoop-ozone/pull/1106#discussion_r447520786 ## File path: hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigurationSource.java ## @@ -37,9 +39,6 @@ char[]

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1023: HDDS-3718: Improve OmKeyLocationInfoGroup internal data structure

2020-06-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1023: URL: https://github.com/apache/hadoop-ozone/pull/1023#discussion_r448011359 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyLocationInfoGroup.java ## @@ -30,12 +30,23 @@ */

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1023: HDDS-3718: Improve OmKeyLocationInfoGroup internal data structure

2020-06-30 Thread GitBox
xiaoyuyao commented on a change in pull request #1023: URL: https://github.com/apache/hadoop-ozone/pull/1023#discussion_r448010316 ## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyLocationInfoGroup.java ## @@ -30,12 +30,23 @@ */

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1139: HDDS-3885. Create Datanode home page

2020-06-30 Thread GitBox
maobaolong commented on pull request #1139: URL: https://github.com/apache/hadoop-ozone/pull/1139#issuecomment-652122430 @adoroszlai Thank you for your review. This is an automated message from the Apache Git Service. To

  1   2   >