ChenSammi commented on pull request #1185:
URL: https://github.com/apache/hadoop-ozone/pull/1185#issuecomment-657437337
Don't find any unit tests here. Would you please add some? @runzhiwang
This is an automated message
[
https://issues.apache.org/jira/browse/HDDS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-3789:
-
Labels: pull-request-available (was: )
> Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR
>
lokeshj1703 opened a new pull request #1198:
URL: https://github.com/apache/hadoop-ozone/pull/1198
## What changes were proposed in this pull request?
Enables TestOzoneRpcClientAbstract#testDeletedKeyForGDPR.
## What is the link to the Apache JIRA
codecov-commenter commented on pull request #1198:
URL: https://github.com/apache/hadoop-ozone/pull/1198#issuecomment-657510256
#
[Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1198?src=pr=h1)
Report
> Merging
ChenSammi commented on pull request #1186:
URL: https://github.com/apache/hadoop-ozone/pull/1186#issuecomment-657388589
The patch looks good to me. + 1.
This is an automated message from the Apache Git Service.
To respond
adoroszlai commented on pull request #1177:
URL: https://github.com/apache/hadoop-ozone/pull/1177#issuecomment-657388082
Thanks @vivekratnavel for the upgrade and @bharatviswa504 for reviewing it.
This is an automated
[
https://issues.apache.org/jira/browse/HDDS-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-3937:
---
Fix Version/s: 0.7.0
> Update jquery to v3.5.1
>
>
>
timmylicheng closed pull request #1191:
URL: https://github.com/apache/hadoop-ozone/pull/1191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ChenSammi commented on pull request #1162:
URL: https://github.com/apache/hadoop-ozone/pull/1162#issuecomment-657387772
Thanks @sodonnel and @xiaoyuyao for the review.
This is an automated message from the Apache Git
maobaolong commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657397401
@ChenSammi Thanks for your suggestion，I have addressed your comment，PTAL
This is an automated message
[
https://issues.apache.org/jira/browse/HDDS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lokesh Jain reassigned HDDS-3789:
-
Assignee: Lokesh Jain
> Fix TestOzoneRpcClientAbstract#testDeletedKeyForGDPR
>
ChenSammi merged pull request #1163:
URL: https://github.com/apache/hadoop-ozone/pull/1163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HDDS-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156509#comment-17156509
]
Attila Doroszlai commented on HDDS-3937:
CC [~Sammi] for cherry-pick to 0.6.0.
> Update jquery to
ChenSammi merged pull request #1186:
URL: https://github.com/apache/hadoop-ozone/pull/1186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ChenSammi commented on pull request #1163:
URL: https://github.com/apache/hadoop-ozone/pull/1163#issuecomment-657391415
Thanks @xiaoyuyao for the review.
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/HDDS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen resolved HDDS-3920.
--
Resolution: Fixed
> Too many redudant replications due to fail to get node's ancestor in
>
ChenSammi commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657389570
@maobaolong, suggest change from " per disk" to " per volume" to be
consistent with other datanode property naming style.
[
https://issues.apache.org/jira/browse/HDDS-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156517#comment-17156517
]
Sammi Chen commented on HDDS-3509:
--
Hi [~nanda], do you plan to fix this issue in 0.6.0, or move to
arp7 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r453761889
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##
@@ -239,4 +239,11 @@ private OMConfigKeys() {
arp7 commented on pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#issuecomment-657658582
Can you update the PR template a bit to describe the high-level approach
(was fix made in OM or S3G)?
arp7 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r453761889
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##
@@ -239,4 +239,11 @@ private OMConfigKeys() {
[
https://issues.apache.org/jira/browse/HDDS-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh reassigned HDDS-3509:
---
Assignee: Lokesh Jain (was: Nanda kumar)
> Closing container with unhealthy replica
arp7 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r453775722
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##
@@ -221,8 +233,45 @@ public
arp7 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r453775722
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##
@@ -221,8 +233,45 @@ public
[
https://issues.apache.org/jira/browse/HDDS-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-3955:
Description:
Keys created via the S3 Gateway currently use the createKey OM API to create
bharatviswa504 commented on pull request #1195:
URL: https://github.com/apache/hadoop-ozone/pull/1195#issuecomment-657670868
Thank You @adoroszlai for the review.
I have addressed review comments.
This is an automated
bharatviswa504 commented on a change in pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082#discussion_r453806643
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/exceptions/OMException.java
##
@@ -223,6 +223,6 @@ public String
arp7 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r453774238
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##
@@ -221,8 +233,45 @@ public
xiaoyuyao commented on pull request #1162:
URL: https://github.com/apache/hadoop-ozone/pull/1162#issuecomment-657697063
LGTM, +1. Thanks @ChenSammi for the contribution and all for the reviews. I
will merge the PR shortly.
prashantpogde commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r453829216
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
mukul1987 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r453779672
##
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java
##
@@ -328,6 +342,73 @@
bharatviswa504 commented on pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082#issuecomment-657686679
Thank You @hanishakoneru for the review.
OMKeysDeleteRequest will be fixed by HDDS-3930.
This is
avijayanhwx commented on a change in pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082#discussion_r453811018
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/exceptions/OMException.java
##
@@ -223,6 +223,6 @@ public String
[
https://issues.apache.org/jira/browse/HDDS-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoyu Yao reassigned HDDS-3907:
Assignee: Xiaoyu Yao
> Topology related acceptance test is flaky
>
[
https://issues.apache.org/jira/browse/HDDS-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-3925:
Status: Patch Available (was: Open)
> SCM Pipeline DB should directly use UUID bytes for
arp7 commented on pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#issuecomment-657661338
The approach looks really good. It is surprisingly concise and elegant
because I was expecting it to be a lot more code! Added a few review comments.
[
https://issues.apache.org/jira/browse/HDDS-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-3955:
Target Version/s: 0.6.0
> Unable to list intermediate paths on keys created using S3G.
>
[
https://issues.apache.org/jira/browse/HDDS-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-3955:
Component/s: Ozone Manager
> Unable to list intermediate paths on keys created using S3G.
>
Aravindan Vijayan created HDDS-3955:
---
Summary: Unable to list intermediate paths on keys created using
S3G.
Key: HDDS-3955
URL: https://issues.apache.org/jira/browse/HDDS-3955
Project: Hadoop
xiaoyuyao commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657701542
LGTM, +1. Thanks @maobaolong for the contribution and all for the reviews.
This is an automated
xiaoyuyao merged pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HDDS-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoyu Yao resolved HDDS-3951.
--
Fix Version/s: 0.6.0
Resolution: Fixed
> Rename the num.write.chunk.thread key
>
xiaoyuyao commented on a change in pull request #1184:
URL: https://github.com/apache/hadoop-ozone/pull/1184#discussion_r453834375
##
File path: hadoop-hdds/docs/content/security/SecuringTDE.zh.md
##
@@ -0,0 +1,56 @@
+---
+title: "透明数据加密"
+date: "2019-April-03"
+summary:
avijayanhwx commented on pull request #1197:
URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-657780236
Thank you working on this pifta. The patch looks good to me. I have verified
the working using docker based testing. Can we add a unit test for to verify
that
avijayanhwx edited a comment on pull request #1197:
URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-657780236
Thank you working on this pifta. I have verified the working using docker
based testing.
LGTM +1.
Can we add a unit test for to verify that
avijayanhwx edited a comment on pull request #1197:
URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-657780236
Thank you working on this pifta. The patch looks good to me. I have verified
the working using docker based testing.
Can we add a unit test for to verify
xiaoyuyao commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454011179
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
xiaoyuyao commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454009691
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
fapifta commented on pull request #1197:
URL: https://github.com/apache/hadoop-ozone/pull/1197#issuecomment-657903257
Hi @avijayanhwx,
thank you for the review, I have pushed the requested test, and a bit more.
At the end of the day, I have added tests to verify the behaviour
xiaoyuyao commented on a change in pull request #1164:
URL: https://github.com/apache/hadoop-ozone/pull/1164#discussion_r453918089
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -1877,26 +1897,18 @@ public OmKeyInfo
hanishakoneru commented on pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082#issuecomment-657824863
Thanks @bharatviswa504 for working on this.
+1 pending CI.
This is an automated message from the
bharatviswa504 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r454001878
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##
@@ -221,8 +233,45
bharatviswa504 merged pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bharatviswa504 commented on pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082#issuecomment-657898158
Thank You @hanishakoneru for the review.
This is an automated message from the Apache Git Service.
bharatviswa504 edited a comment on pull request #1082:
URL: https://github.com/apache/hadoop-ozone/pull/1082#issuecomment-657898158
Thank You @hanishakoneru for the review and @avijayanhwx for the
confirmation on proto changes.
[
https://issues.apache.org/jira/browse/HDDS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyao Meng updated HDDS-3903:
-
Status: Patch Available (was: Open)
> OzoneRpcClient support batch rename keys.
>
xiaoyuyao commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454011791
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
[
https://issues.apache.org/jira/browse/HDDS-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-3685:
-
Fix Version/s: 0.6.0
Resolution: Fixed
Status: Resolved (was: Patch
runzhiwang commented on pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#issuecomment-657909810
@adoroszlai Could you help merge it ? The comment is just about the
message of reason, I have updated it, I think it does not matter. But if
without this PR, the
runzhiwang edited a comment on pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122#issuecomment-657909810
@adoroszlai Could you help merge it ? The comment is just about the
message of reason, I have updated it, I think it does not matter. But if
without this PR,
bharatviswa504 commented on pull request #1193:
URL: https://github.com/apache/hadoop-ozone/pull/1193#issuecomment-657929043
This is the parent Jira https://issues.apache.org/jira/browse/HDDS-2353 for
the cleanup.
This is
Bharat Viswanadham created HDDS-3956:
Summary: Cleanup old write-path of MPU requests in OM
Key: HDDS-3956
URL: https://issues.apache.org/jira/browse/HDDS-3956
Project: Hadoop Distributed Data
rakeshadr commented on a change in pull request #1164:
URL: https://github.com/apache/hadoop-ozone/pull/1164#discussion_r454104113
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -1877,26 +1897,18 @@ public OmKeyInfo
rakeshadr commented on a change in pull request #1164:
URL: https://github.com/apache/hadoop-ozone/pull/1164#discussion_r454104041
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -1877,26 +1897,18 @@ public OmKeyInfo
bharatviswa504 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r454102550
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##
@@ -221,8 +233,45
prashantpogde commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454107185
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
[
https://issues.apache.org/jira/browse/HDDS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-3957:
-
Labels: pull-request-available (was: )
> Fix mixed use of Longs.toByteArray and
runzhiwang opened a new pull request #1199:
URL: https://github.com/apache/hadoop-ozone/pull/1199
## What changes were proposed in this pull request?
**What's the problem ?**
When write `DB_PENDING_DELETE_BLOCK_COUNT_KEY` to rocksdb, most code convert
value to byte array by
[
https://issues.apache.org/jira/browse/HDDS-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157113#comment-17157113
]
Sammi Chen commented on HDDS-3953:
--
Close this JIRA as it will be covered by HDDS-2353.
> Audit LOG
bharatviswa504 commented on a change in pull request #1196:
URL: https://github.com/apache/hadoop-ozone/pull/1196#discussion_r454102604
##
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCreateRequest.java
##
@@ -328,6
prashantpogde commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454107032
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
prashantpogde commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454106592
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
prashantpogde commented on a change in pull request #1182:
URL: https://github.com/apache/hadoop-ozone/pull/1182#discussion_r454106901
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneTokenIdentifier.java
##
@@ -77,6 +80,122 @@ public Text
maobaolong commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657919706
@ChenSammi @xiaoyuyao Thank you for your review.
This is an automated message from the Apache Git
ChenSammi closed pull request #1193:
URL: https://github.com/apache/hadoop-ozone/pull/1193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ChenSammi commented on pull request #1193:
URL: https://github.com/apache/hadoop-ozone/pull/1193#issuecomment-657941211
Thanks @bharatviswa504 . Close this MR.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HDDS-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sammi Chen resolved HDDS-3953.
--
Resolution: Duplicate
> Audit LOG action misused in OzoneManager.commitMultipartUploadPart
>
runzhiwang created HDDS-3957:
Summary: Fix error use Longs.toByteArray and Ints.fromByteArray of
DB_PENDING_DELETE_BLOCK_COUNT_KEY
Key: HDDS-3957
URL: https://issues.apache.org/jira/browse/HDDS-3957
rakeshadr commented on pull request #1164:
URL: https://github.com/apache/hadoop-ozone/pull/1164#issuecomment-657969627
Thanks @xiaoyuyao for the comments. I have updated PR, kindly review it
again.
This is an automated
[
https://issues.apache.org/jira/browse/HDDS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashikant Banerjee resolved HDDS-3861.
---
Fix Version/s: 0.6.0
Resolution: Fixed
> Fix handlePipelineFailure throw
bshashikant merged pull request #1122:
URL: https://github.com/apache/hadoop-ozone/pull/1122
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HDDS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
runzhiwang updated HDDS-3957:
-
Summary: Fix mixed use of Longs.toByteArray and Ints.fromByteArray (was:
Fix error use Longs.toByteArray
82 matches
Mail list logo
