https://bugzilla.redhat.com/show_bug.cgi?id=2126785
Björn Persson changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2107911
Davide Cavalca changed:
What|Removed |Added
Flags|needinfo?(dav...@cavalca.na |
|me)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #21 from Frank Crawford ---
(In reply to Benson Muite from comment #20)
> Based on the discussion https://github.com/c-icap/c-icap-server/issues/43
> Maybe it is easier to make a pull request? It seems changes are needed in
> 2
https://bugzilla.redhat.com/show_bug.cgi?id=758472
Benson Muite changed:
What|Removed |Added
CC||benson_mu...@emailplus.org
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Benson Muite changed:
What|Removed |Added
CC||benson_mu...@emailplus.org
---
https://bugzilla.redhat.com/show_bug.cgi?id=2156603
--- Comment #4 from Carl George 鸞 ---
> This is not a normal desktop file, and is not installed in
> /usr/share/applications, so it doesn't qualify for validation, IMO.
The guidelines don't list the path as a criteria for requiring
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2156603
--- Comment #3 from Neal Gompa ---
(In reply to Neal Gompa from comment #2)
> (In reply to Carl George 鸞 from comment #1)
> > This appears to be a C++ application. It must build require gcc-c++.
> >
> >
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #102 from Benson Muite ---
For undefined weak symbols, maybe check the makefile links the library
libaubit4gl, it should
have -laubit4gl if there are circular dependencies, may need to add them
several times for
example -laubit4gl
https://bugzilla.redhat.com/show_bug.cgi?id=2156603
--- Comment #2 from Neal Gompa ---
(In reply to Carl George 鸞 from comment #1)
> This appears to be a C++ application. It must build require gcc-c++.
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
>
https://bugzilla.redhat.com/show_bug.cgi?id=2156603
Carl George 鸞 changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Carl
https://bugzilla.redhat.com/show_bug.cgi?id=2107911
Troy Curtis changed:
What|Removed |Added
Flags||needinfo?(dav...@cavalca.na
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #101 from Stansoft ---
The libraries giving the undefined weak symbols warning need LD_LIBRARY_PATH
set to the location of libaubit4gl.so.1, but since that is in /usr/lib64 why
doesn't the system see it? All those functions are in
https://bugzilla.redhat.com/show_bug.cgi?id=2156603
Carl George 鸞 changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #100 from Stansoft ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-37-x86_64/05183839-aubit4gl/aubit4gl.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
Neal Gompa changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
--- Comment #30 from Alessandro Astone ---
Done.
Spec URL:
https://download.copr.fedorainfracloud.org/results/aleasto/waydroid/fedora-rawhide-x86_64/05183827-waydroid/waydroid.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=2156603
Bug ID: 2156603
Summary: Review Request: ffmpegthumbs - KDE ffmpegthumbnailer
service
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #99 from Stansoft ---
> d) libaubit4gl.so should link to libaubit4gl.so.1 not directly to
> libaubit4gl.so.1.5.3
Is there a standard defined somewhere for how the links should be setup? I can
find it done both ways on Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
--- Comment #29 from Alessandro Astone ---
(In reply to Neal Gompa from comment #28)
> > - systemd_post is invoked in %post, systemd_preun in %preun, and
> > systemd_postun in %postun for Systemd service files.
> > Note: Systemd service
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
--- Comment #28 from Neal Gompa ---
Issues:
===
> - Package installs a %{name}.desktop using desktop-file-install or desktop-
> file-validate if there is such a file.
I think this is not having desktop-file-validate and appstream-util
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
--- Comment #27 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
https://bugzilla.redhat.com/show_bug.cgi?id=2121585
--- Comment #41 from Benson Muite ---
f) Perhaps ask on Fedora security list:
https://lists.fedoraproject.org/admin/lists/security.lists.fedoraproject.org/
Current version fails to build:
In file included from /usr/include/curl/curl.h:3195,
https://bugzilla.redhat.com/show_bug.cgi?id=2156237
--- Comment #2 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Dist tag is present.
= MUST items =
C/C++:
https://bugzilla.redhat.com/show_bug.cgi?id=2156234
--- Comment #4 from Benson Muite ---
Perhaps try use what is in Fedora for tests as this would better represent use
of
these header files:
https://packages.fedoraproject.org/pkgs/cli11/cli11-devel
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #98 from Benson Muite ---
What you have done follows:
https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/#_private_libraries
but maybe something more is required for debuginfo libraries?
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #97 from Benson Muite ---
d) Tried
ls -l /usr/lib64/libgdm*
lrwxrwxrwx. 1 root root 11 Apr 13 2022 /usr/lib64/libgdm.so -> libgdm.so.1
lrwxrwxrwx. 1 root root 15 Apr 13 2022 /usr/lib64/libgdm.so.1 ->
libgdm.so.1.0.0
https://bugzilla.redhat.com/show_bug.cgi?id=2156234
--- Comment #3 from Troy Curtis ---
(In reply to Benson Muite from comment #2)
> Comments:
> a) If the bundled packages are only used for tests and examples, should they
> be listed as being provided? Could any of these which are packaged in
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #96 from Stansoft ---
> f) Why does the debuginfo package list internal private libraries as being
> provided?
This is excluding the private libraries from being provided in the main rpm
package, why doesn't this also apply to
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #95 from Stansoft ---
> d) libaubit4gl.so should link to libaubit4gl.so.1 not directly to
> libaubit4gl.so.1.5.3
Are you sure, looking at some of the other system libraries, libxml2 is not
linked this way.
ls -l libxml2*
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford changed:
What|Removed |Added
Flags||needinfo?(negativo17@gmail.
https://bugzilla.redhat.com/show_bug.cgi?id=2156234
--- Comment #2 from Benson Muite ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Dist tag is present.
= MUST items =
C/C++:
https://bugzilla.redhat.com/show_bug.cgi?id=2119494
--- Comment #94 from Benson Muite ---
Looks good. Minor points:
a) Still get warnings for undefined weak symbols:
https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-37-x86_64/05178189-aubit4gl/fedora-review/review.txt
33 matches
Mail list logo
