[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 Petr Pisar changed: What|Removed |Added Status|MODIFIED|CLOSED CC|

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 PnT Account Manager changed: What|Removed |Added Assignee|macer...@redhat.com |nob...@fedoraproject.org --

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #22 from Frank Crawford --- (In reply to Marek Cermak from comment #21) > Great, thanks, Frank. Thanks Marek. -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 Marek Cermak changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 Marek Cermak changed: What|Removed |Added Status|ASSIGNED|MODIFIED ---

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #20 from Frank Crawford --- (In reply to Marek Cermak from comment #19) > Thanks Frank, > > If I am not mistaken, you've forgotten to update the changelog to the newest > release. Could you correct

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #19 from Marek Cermak --- Thanks Frank, If I am not mistaken, you've forgotten to update the changelog to the newest release. Could you correct that, please? -- You are receiving this mail because: You are

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #18 from Frank Crawford --- (In reply to Frank Crawford from comment #14) > (In reply to Marek Cermak from comment #13) > > NOTES > > - > > sysusage.src:101: W: rpm-buildroot-usage %build

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #17 from Frank Crawford --- (In reply to Jaroslav Škarvada from comment #16) Jaroslav, thanks for the clarification. -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #16 from Jaroslav Škarvada --- (In reply to Frank Crawford from comment #15) > (In reply to Jaroslav Škarvada from comment #12) > > Created attachment 1299753 [details] > > Drop buildroot from build > > > >

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #15 from Frank Crawford --- (In reply to Jaroslav Škarvada from comment #12) > Created attachment 1299753 [details] > Drop buildroot from build > > Thanks, could you apply the attached patch? It removes

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #14 from Frank Crawford --- (In reply to Marek Cermak from comment #13) > NOTES > - > sysusage.src:101: W: rpm-buildroot-usage %build DESTDIR=%{buildroot} -- see > the comment above from Jaroslav

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #13 from Marek Cermak --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package does not use a name

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #12 from Jaroslav Škarvada --- Created attachment 1299753 --> https://bugzilla.redhat.com/attachment.cgi?id=1299753=edit Drop buildroot from build Thanks, could you apply the attached patch? It removes the

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #11 from Frank Crawford --- Okay, I believe I've updated the spec file for all the issues raised, and here is the new spec file and updated SRPM. Spec URL:

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #10 from Marek Cermak --- Thanks, Frank, for quick response and Jaroslav, for addressing another issues and additional comments. (In reply to Jaroslav Škarvada from comment #2) > (In reply to Marek Cermak

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #9 from Frank Crawford --- (In reply to Jaroslav Škarvada from comment #8) > (In reply to Frank Crawford from comment #6) > > Will review and fix up. > > > Great, please also address comment 3 and

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #8 from Jaroslav Škarvada --- (In reply to Frank Crawford from comment #6) > Will review and fix up. > Great, please also address comment 3 and comment 5. -- You are receiving this mail because: You are on

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #7 from Jaroslav Škarvada --- (In reply to Marek Cermak from comment #1) > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in >

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #6 from Frank Crawford --- (In reply to Marek Cermak from comment #1) Marek, thanks for that. I've made a couple of comments below. > Package Review > == ... > > NOTES > - > -

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #5 from Jaroslav Škarvada --- Also please remove trailing whitespaces in %description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #4 from Jaroslav Škarvada --- (In reply to Marek Cermak from comment #1) > file /etc/cron.d is not owned by any package False positive, the package requires crontabs which requires /etc/cron.d, which is

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #3 from Jaroslav Škarvada --- Also I think the license tag should be GPLv3+, not GPLv3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 Jaroslav Škarvada changed: What|Removed |Added CC|

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 Marek Cermak changed: What|Removed |Added Status|NEW |ASSIGNED ---

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

https://bugzilla.redhat.com/show_bug.cgi?id=1421413 Marek Cermak changed: What|Removed |Added CC||macer...@redhat.com