[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Fedora Update System changed: What|Removed |Added Status|ON_QA

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Fedora Update System changed: What|Removed |Added Status|POST

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #24 from Fedora Update System --- danmaq-0.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-29f2713379 -- You are receiving this mail because:

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #23 from Ralph Bean --- (fedrepo-req-admin): Apologies for the delay! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #22 from Ralph Bean --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/danmaq -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #21 from Zamir SUN --- SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/danmaq/danmaq.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/danmaq/danmaq-0.2-1.fc26.src.rpm -- You are receiving this mail

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #20 from Zamir SUN --- (In reply to Zamir SUN from comment #19) > (In reply to Zamir SUN from comment #16) > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #15) > > > ... that said, if you strongly

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Zamir SUN changed: What|Removed |Added Alias|danmaQ |danmaq -- You are

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Zamir SUN changed: What|Removed |Added Summary|Review Request: danmaQ - A |Review Request: danmaq -

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #19 from Zamir SUN --- (In reply to Zamir SUN from comment #16) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #15) > > ... that said, if you strongly prefer "danmaQ", then just go ahead — the > >

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #18 from Zamir SUN --- (In reply to sensor.wen from comment #17) > - "_" prefix in macro names is not necessary. > > %{_commit} -> %{commit} Oh, thanks. Will change it when packaging into repo -- You are

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 sensor@gmail.com changed: What|Removed |Added CC||sensor@gmail.com ---

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #16 from Zamir SUN --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #15) > ... that said, if you strongly prefer "danmaQ", then just go ahead — the > guidelines (the old and the new) allow camelCased

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #15 from Zbigniew Jędrzejewski-Szmek --- ... that said, if you strongly prefer "danmaQ", then just go ahead — the guidelines (the old and the new) allow camelCased names when there's good justification. -- You

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #14 from Zbigniew Jędrzejewski-Szmek --- https://pagure.io/packaging-committee/issue/703 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #13 from Zbigniew Jędrzejewski-Szmek --- That's a typical case of Packaging Guidelines being internally inconsistent. The rules were changed to prefer lowercase names recently (1-2 years ago), and that bit of

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #12 from Zamir SUN --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #11) > One issue: the package should be called "danmaq". See > https://fedoraproject.org/wiki/Packaging:Naming: > > Package names

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC|

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Felix Yan changed: What|Removed |Added Status|ASSIGNED|POST -- You

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Felix Yan changed: What|Removed |Added Status|NEW |ASSIGNED --

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #10 from Felix Yan --- Looks good to me. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = C/C++: [ ]: Package does not

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Felix Yan changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Felix Yan changed: What|Removed |Added CC|

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Robert-André Mauchin changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com |

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Zamir SUN changed: What|Removed |Added Flags|

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #7 from Zamir SUN --- (In reply to Robert-André Mauchin from comment #6) > Ah indeed, I compiled locally insted of fedora-review and it passed fine. > > Just one thing: you should use desktop-file-validate in

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #6 from Robert-André Mauchin --- Ah indeed, I compiled locally insted of fedora-review and it passed fine. Just one thing: you should use desktop-file-validate in %check. -- You are receiving this mail

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #5 from Zamir SUN --- Updated. Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm > danmaQ-debuginfo.x86_64:

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Robert-André Mauchin changed: What|Removed |Added CC|

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #3 from Zamir SUN --- Upstream tagged. Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/ SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ-0.2-1.fc26.src.rpm -- You are receiving this mail

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #2 from Zamir SUN --- I just realized the release is too long. Updated Spec URL: https://zsun.fedorapeople.org/pub/pkgs/danmaQ/danmaQ.spec SRPM URL:

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 --- Comment #1 from Zamir SUN --- The server side is https://dm.tuna.moe/?lang=en It is open source as well but I am not packaging it at the moment. https://github.com/tuna/gdanmaku-server > danmaQ.x86_64: W:

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

https://bugzilla.redhat.com/show_bug.cgi?id=1471806 Zamir SUN changed: What|Removed |Added Alias||danmaQ -- You are