[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Martin Wolf changed: What|Removed |Added CC||mw...@adiumentum.com --- Comment #29

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 j...@kcore.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|---

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #27 from

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #26 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/notepadqq -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #25 from j...@kcore.org --- Thanks a lot! I'll go ahead and read through the documentation you linked, I'm happy to help out the Fedora project :) -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Ben Rosser changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #24 from Ben

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #23 from j...@kcore.org --- Spec URL: https://raw.githubusercontent.com/jdeluyck/notepadqq-packaging/master/Fedora/notepadqq.spec SRPM URL: https://kcore.org/tmp/notepadqq-1.4.8-3.fc28.src.rpm Changelog: - Removed bundled MathJax

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #22 from Ben Rosser --- No worries, it happens sometime-- just wanted to make sure you were aware. :) Anyway, I'm sorry, but it looks like there are (now?) more bundled dependencies under src/editor/libs that I seem to have

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #21 from j...@kcore.org --- In all honesty, this was a major fsck'up on my end. I've repushed the correct file (I thought I hadn't pushed it out, but appareantely I did). In the future I'll work on branches, not on master ;) --

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #20 from Ben Rosser --- Just a heads up; https://raw.githubusercontent.com/jdeluyck/notepadqq-packaging/master/Fedora/notepadqq.spec seems to have git merge conflict markers in it... e.g.: === >>> upstream/master The

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #19 from j...@kcore.org --- Spec URL: https://raw.githubusercontent.com/jdeluyck/notepadqq-packaging/master/Fedora/notepadqq.spec SRPM URL: https://kcore.org/tmp/notepadqq-1.4.8-2.fc28.src.rpm Changelog: - Corrected date and

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #18 from Ben Rosser --- Two hopefully final comments: 1. Please don't forget to add "%license COPYING" to include the license file in the package, under the %files section. This will automatically include the license. 2. >

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #17 from j...@kcore.org --- Spec URL: https://raw.githubusercontent.com/jdeluyck/notepadqq-packaging/master/Fedora/notepadqq.spec SRPM URL: https://kcore.org/tmp/notepadqq-1.4.8-1.fc28.src.rpm Changelog: - Bumped to 1.4.8 --

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #16 from j...@kcore.org --- Spec URL: https://raw.githubusercontent.com/jdeluyck/notepadqq-packaging/master/Fedora/notepadqq.spec SRPM URL: https://kcore.org/tmp/notepadqq-1.4.0-1.fc28.src.rpm -- You are receiving this mail

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #15 from Andrea Musuruane --- (In reply to jan from comment #14) > I've updated the SPEC file, but I'm a bit stuck on what to do with the > appdata.xml. > > I've added a patch to make it valid (I'll take this upstream), but >

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #14 from j...@kcore.org --- (In reply to Ben Rosser from comment #12) > Oh, actually, I missed one thing. > > notepadqq appears to have recently gained an appstream metadata file: > >

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #13 from Ben Rosser --- The nodejs-archiver issue was fixed last week, so notepadqq should be able to install on Rawhide again. So you should be able to proceed. :) -- You are receiving this mail because: You are on the CC list

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #12 from Ben Rosser --- Oh, actually, I missed one thing. notepadqq appears to have recently gained an appstream metadata file:

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Ben Rosser changed: What|Removed |Added Flags||fedora-review?

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #10 from j...@kcore.org --- Spec URL: https://raw.githubusercontent.com/jdeluyck/notepadqq-packaging/master/Fedora/notepadqq.spec SRPM URL: https://kcore.org/tmp/notepadqq-1.3.6-1.fc27.src.rpm Updates: - Removed nodejs-shelljs

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #9 from Ben Rosser --- When updating a package submission, it is really helpful to link to both the spec and SRPM in the following form: Spec URL: [link to latest spec] SRPM URL: [link to latest SRPM] Don't

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #8 from j...@kcore.org --- I'm sorry - I seem to have pasted the wrong koji url. This one is correct for the latest build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26312199 -- You are receiving this mail because: You

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #7 from j...@kcore.org --- Added the Provides: in build https://koji.fedoraproject.org/koji/taskinfo?taskID=26311309 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #6 from j...@kcore.org --- I've submitted a new build to koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26311309 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #5 from j...@kcore.org --- (In reply to Ben Rosser from comment #4) > I'm really sorry for letting this sit for several months! > > Can you upload the SRPM to a more permanent place than koji, and I'll take > another look? Your

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #4 from Ben Rosser --- I'm really sorry for letting this sit for several months! Can you upload the SRPM to a more permanent place than koji, and I'll take another look? Your build was deleted. But

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 --- Comment #3 from j...@kcore.org --- (In reply to Ben Rosser from comment #2) > I took a look at the patches and they all seem reasonable. It'd be good to > include comments directly in the spec explaining what they are for, though. Done.

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Ben Rosser changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rosser@gmail.com

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Ben Rosser changed: What|Removed |Added CC||rosser@gmail.com

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Raphael Groner changed: What|Removed |Added Blocks||201449

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Raphael Groner changed: What|Removed |Added CC|

[Bug 1519785] Review Request: notepadqq - An advanced text editor for developers

https://bugzilla.redhat.com/show_bug.cgi?id=1519785 Robert-André Mauchin changed: What|Removed |Added CC|