[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Alain V. changed: What|Removed |Added Status|POST|CLOSED Resolution|---

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Robert-André Mauchin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs:

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #16 from Alain V. --- Upstream releases a new version. I changed the .spec file, generate a srpm file, then perform again $ fedpgk import This creates a tar.gz file in my git dir, and I did commit this file.

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pcb-rnd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #13 from Robert-André Mauchin --- No need for Copr, just show me the updated SPEC. The next step for you is to find a sponsor, introduce yourself to the devel mailing list and do informait reviews to show that you understand the

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #12 from Robert-André Mauchin --- Yes, rpmlint is not a perfect tool, sometimes it says there are errors when it is in fact acceptable. -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #11 from Alain V. --- I would have done so if only a warning was generated. I thought an error was not negligible, and made every effort to have no error, no warning with rpmlint. You say: better have an error, but use %{_prefix}

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #10 from Robert-André Mauchin --- > then rpmlint complains with an error: pcb-rnd.spec:3: E: > hardcoded-library-path in %{_prefix}/lib/%{name}/plugins The rpmlint error doesn't matter, we can choose to ignore it. -- You are

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #9 from Alain V. --- Sorry, I went too fast, did not mention the issue arises due to rpmlint error, so please, rewind: pcb-rnd.spec file, line 3, if I change %{_usr} to become %{_prefix}, line 3 reads now: %global plugindir

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #8 from Robert-André Mauchin --- (In reply to Alain V. from comment #7) > I propose those modifications in .spec file: > > 1. licenses breakdown: Add this comment line before the License: tag > # For a license breakdown info,

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #7 from Alain V. --- I propose those modifications in .spec file: 1. licenses breakdown: Add this comment line before the License: tag # For a license breakdown info, please refer to

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #6 from Robert-André Mauchin --- Still not fixed: - Add a comment explaining the licenses breakdown: [!]: If the package is under multiple licenses, the licensing breakdown - Use %{_prefix} instead of %{_usr} - Shouldn't

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #5 from Alain V. --- Thank you very much for this detailed analysis, Robert-Andre. Today, a new pcb-rnd release is available [1], and I successfully built Fedora packages [2] (+RHEL + Mageia) with a modified .spec file, following

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #4 from Robert-André Mauchin --- Using SPEC URL: https://copr-be.cloud.fedoraproject.org/results/avigne/pcb-rnd/fedora-rawhide-x86_64/00763485-pcb-rnd/pcb-rnd.spec SRPM URL:

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #3 from Robert-André Mauchin --- Yes on the devel list. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 --- Comment #2 from Alain V. --- Than you so much Robert-André for this valuable feed-back. I implemented most of your proposals, 2 of them I can't at the moment: 1. ./configure is NOT the autotool configure binary we might all expect.

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment

[Bug 1581240] Review Request: pcb-rnd - Printed Circuit Board (PCB) editor

https://bugzilla.redhat.com/show_bug.cgi?id=1581240 Alain V. changed: What|Removed |Added Blocks||177841