https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Richard W.M. Jones changed:
What|Removed |Added
Status|MODIFIED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #25 from Richard W.M. Jones ---
Build failed because of https://bugzilla.redhat.com/show_bug.cgi?id=1778517.
Since that bug is now fixed I have to go and rebuild nbdkit first.
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Richard W.M. Jones changed:
What|Removed |Added
Status|NEW |MODIFIED
Fixed In Version|
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #23 from Richard W.M. Jones ---
Ignore previous comment. The unretire request was:
https://pagure.io/releng/issue/9072
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Richard W.M. Jones changed:
What|Removed |Added
Keywords||Reopened
--- Comment #22 from
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Kashyap Chamarthy changed:
What|Removed |Added
Flags|fedora-review- |fedora-review+
--- Comment #21
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #20 from Kashyap Chamarthy ---
Created attachment 1641380
--> https://bugzilla.redhat.com/attachment.cgi?id=1641380=edit
Successful `mock` build log from 'fedora-review` (with virt-v2v-1.41.8-4)
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #19 from Richard W.M. Jones ---
Spec URL: http://oirase.annexia.org/reviews/virt-v2v/virt-v2v.spec
SRPM URL:
http://oirase.annexia.org/reviews/virt-v2v/virt-v2v-1.41.8-4.fc31.src.rpm
Description: Convert a virtual machine to run
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Kashyap Chamarthy changed:
What|Removed |Added
Flags|fedora-review+ |fedora-review-
--- Comment #18
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #17 from Richard W.M. Jones ---
This happens because of the addition of %{?_isa} to the noarch
packages. I'll correct those.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #16 from Kashyap Chamarthy ---
(In reply to Kashyap Chamarthy from comment #15)
[...]
> Also kicked off a new scratch build with v3 SRPM
> (virt-v2v-1.41.8-3.fc31.src.rpm)
>
>
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Kashyap Chamarthy changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #15
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Kashyap Chamarthy changed:
What|Removed |Added
Keywords|Reopened|
--- Comment #14 from Kashyap
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Richard W.M. Jones changed:
What|Removed |Added
Status|CLOSED |NEW
Resolution|EOL
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Ben Cotton changed:
What|Removed |Added
Status|NEW |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #12 from Richard W.M. Jones ---
Spec URL: http://oirase.annexia.org/reviews/virt-v2v/virt-v2v.spec
SRPM URL:
http://oirase.annexia.org/reviews/virt-v2v/virt-v2v-1.41.8-3.fc31.src.rpm
Description: Convert a virtual machine to run
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #11 from Kashyap Chamarthy ---
The Long Version
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #10 from Kashyap Chamarthy ---
==
Review
==
(NB: My comments in the longer review are prefixed with [kashyapc].)
tl;dr
=
Needs Fixing
(1) '%license' macro is missing.
(2) License file is not included
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #9 from Kashyap Chamarthy ---
Created attachment 1640050
--> https://bugzilla.redhat.com/attachment.cgi?id=1640050=edit
Successful `mock` build log from 'fedora-review'
Now, with new Spec/SRPM from comment#8, the `mock` build
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #8 from Richard W.M. Jones ---
Spec URL: http://oirase.annexia.org/reviews/virt-v2v/virt-v2v.spec
SRPM URL:
http://oirase.annexia.org/reviews/virt-v2v/virt-v2v-1.41.8-2.fc31.src.rpm
Description: Convert a virtual machine to run on
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #7 from Richard W.M. Jones ---
This is OK, the test was skipped:
test-v2v-i-ova-as-root.sh: use 'sudo make check-root' to run this test
SKIP test-v2v-i-ova-as-root.sh (exit status: 77)
This is bad:
./test-v2v-oa-option.sh: test
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #6 from Kashyap Chamarthy ---
Rich, I think we'd need a new build with 'test-v2v-i-ova-as-root.sh' disabled?
$> less
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #5 from Kashyap Chamarthy ---
Created attachment 1639903
--> https://bugzilla.redhat.com/attachment.cgi?id=1639903=edit
Failed `mock` build log from 'fedora-review'
Although local `mock` run succeeds (as evidence in comment#4),
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #4 from Kashyap Chamarthy ---
Created attachment 1639775
--> https://bugzilla.redhat.com/attachment.cgi?id=1639775=edit
Successful local `mock` build
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #3 from Richard W.M. Jones ---
The signature thing is something to do with either gpg or NFS. I use an
NFS directory to sign things, and running gpg sets the permissions on the
final file to 0777 for unknown reasons, eg:
$ gpg
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #2 from Kashyap Chamarthy ---
To allow pipelining, posting things I checked so far:
(a) A small quibble from `rpmlint` on "strange-permssion" (after the
"spelling-error" noise):
$> rpmlint virt-v2v.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
Kashyap Chamarthy changed:
What|Removed |Added
CC||kcham...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1774713
--- Comment #1 from Richard W.M. Jones ---
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39137855
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this
28 matches
Mail list logo
