[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|---

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #32 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dm-zoned-tools -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co | |m)

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #29 from Neal Gompa --- I've now sponsored you into the packager group. Congratulations on becoming a Fedora packager! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Neal Gompa changed: What|Removed |Added Flags||fedora-review+ --- Comment #28 from

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #27 from Damien Le Moal --- (In reply to Neal Gompa from comment #26) > Issues: > === > - Sources used to build the package match the upstream source, as provided > in the spec URL. > Note: Upstream MD5sum check error,

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #26 from Neal Gompa --- Issues: === - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/ngompa/1964787-dm- zoned-tools/diff.txt

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #25 from Neal Gompa --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - Sources used to build the package match the upstream source, as provided in the

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #24 from Damien Le Moal --- I added "BuildRequires: gcc". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #23 from Neal Gompa --- fedora-review has noticed an issue: - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Neal Gompa changed: What|Removed |Added Flags|needinfo?(dcava...@fb.com) | -- You are receiving this mail

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Flags||needinfo?(dcava...@fb.com) ---

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #21 from Davide Cavalca --- Yes, once this is approved you can request branches for f34 and f33 and build the package for those releases as well. -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #20 from Damien Le Moal --- Neal, I fixed the spec file as you suggested. Thanks for the review. Question: I saw that you changed the target version from f34 to rawhide. I am OK with that, but since the dm-zoned module is

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Neal Gompa changed: What|Removed |Added Version|34 |rawhide -- You are receiving this

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co | |m)

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Priority|unspecified |medium Version|rawhide

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Richard W.M. Jones changed: What|Removed |Added Flags|needinfo?(rjo...@redhat.com | |)

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #15 from Damien Le Moal --- I updated the spec file to use %make_install -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #14 from Damien Le Moal --- Running ./configure directly does not generate the error "checking command to parse /usr/bin/nm -B output from gcc object...". But I do get it if configure is run through rpmbuild. Googling around, it

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #13 from Damien Le Moal --- Weird... I do not see this with local builds. I may be missing one dependency ? Will check the build log in more details. -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #12 from David Abdurachmanov --- Looking at the build log it seem fine, maybe just one nitpick. checking command to parse /usr/bin/nm -B output from gcc object... ./configure: line 6775: -e 's/^T .* \(.*\)$/extern int \1();/p'

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #11 from Damien Le Moal --- Oops. I thought I had done that too. Done now. Re-running koji scratch build. Will update once finished. Thanks ! -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 David Abdurachmanov changed: What|Removed |Added Flags|needinfo?(david.abdurachman |

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #9 from Damien Le Moal --- Hi Neal, I updated the spec file and source RPM. Koji scratch build pass (https://koji.fedoraproject.org/koji/taskinfo?taskID=68831679). One thing I did not change is the License entry in the spec file.

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Flags||needinfo?(ngomp...@gmail.co

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #7 from Neal Gompa --- I will also sponsor Damien once I've approved this review. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 --- Comment #5 from Richard W.M. Jones --- Yeah ignore the Doc Type field, it's just something that Bugzilla decided to alter randomly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Flags||needinfo?(david.abdurachman

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 David Abdurachmanov changed: What|Removed |Added CC||david.abdurachmanov@gmail.c

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Damien Le Moal changed: What|Removed |Added Flags|needinfo?(damien.lemoal@wdc |needinfo?(rjo...@redhat.com

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Richard W.M. Jones changed: What|Removed |Added Flags||needinfo?(damien.lemoal@wdc

[Bug 1964787] Review Request: dm-zoned-tools - manage dm-zoned device mapper targets

https://bugzilla.redhat.com/show_bug.cgi?id=1964787 Richard W.M. Jones changed: What|Removed |Added CC||rjo...@redhat.com Doc