[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #37 from Brad Smith --- The fedora kubernetes team will work on the needed updates to kubernetes. For F34 I will update kubernetes to 1.21.x since the current kubernetes rpm version (1.20.x) is no longer maintained upstream. The

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #36 from Neal Gompa --- Kubernetes needs to be upgraded to 1.23.x in F36+, since the major version (1.23) has to match for Kubernetes and CRI-O. For F34 and F35, you should ship crio builds matching those k8s releases. -- You

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #35 from Petr Pisar --- If you want to get it into F36, you also need push the build into Bodhi system as an update. I think you should put the package into all Fedoras where the module

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #34 from Peter Hunt --- Okay finally had a moment to address this. I have built cri-o 1.23.2 for rawhide and f36. do I need to build for f35/f34 as well? -- You are receiving this mail because: You are always notified about

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #33 from Petr Pisar --- I see. Unretired ,

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #32 from Neal Gompa --- (In reply to Petr Pisar from comment #31) > What's point of this review? The rpms/cri-o repository exists since 2017. > Can this review be closed? I can see 1.21 built in Koji >

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com --- Comment #31 from

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #29 from Peter Hunt --- Spec URL: https://haircommander.fedorapeople.org/cri-o.spec SRPM URL: https://haircommander.fedorapeople.org/cri-o-1.21.2-1.fc32.src.rpm (note, I ended up dropping the ln -sf from the spec, as the Makefile

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #28 from Neal Gompa --- > # sometimes users specify crio, not cri-o > ln -sr %{buildroot}%{_unitdir}/%{service_name}.service > %{buildroot}%{_unitdir}/%{name}.service You have this placed in the spec file below the %check

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #27 from Peter Hunt --- I like the alias idea, I've opened a PR upstream to do so https://github.com/cri-o/cri-o/pull/5179 in the meantime, I've updated the gist with the buildroot change -- You are receiving this mail because:

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #26 from Neal Gompa --- > # sometimes users specify crio, not cri-o > ln -sf %{_unitdir}/%{service_name}.service %{_unitdir}/%{name}.service This should be in the %install section like so: > # sometimes users specify crio, not

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #25 from Peter Hunt --- Hm, there seems to be some automation overwriting my changes to what is upstream. not sure what's going on. Here is the current version of the spec file:

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #24 from Neal Gompa --- (In reply to Peter Hunt from comment #23) > Thanks for the tips, y'all; I have updated > https://gitlab.com/rhcontainerbot/rpms/cri-o/-/raw/1.21/cri-o.spec It looks like everything I asked you to change

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #23 from Peter Hunt --- Thanks for the tips, y'all; I have updated https://gitlab.com/rhcontainerbot/rpms/cri-o/-/raw/1.21/cri-o.spec -- You are receiving this mail because: You are always notified about changes to this product

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #22 from Neal Gompa --- (In reply to Dusty Mabe from comment #20) > Can you just create the symlink in %install and list it in %files and from > the %post and %postun stuff? > > Neal, would that address the concerns? Yeah. The

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #21 from Dusty Mabe --- correction.. "and remove the %post and %postun stuff?". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug.

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Dusty Mabe changed: What|Removed |Added CC||dustym...@redhat.com --- Comment #20

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #19 from Peter Hunt --- Interesting, how is creating a symlink from %{_unitdir}/%{service_name}.service to %{_unitdir}/%{name}.service different from creating %{_unitdir}/%{service_name}.service in the first place? I definitely

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #18 from Neal Gompa --- (In reply to Peter Hunt from comment #15) > just to check, is the issue just the `rm -f` or is the `ln -sf` also > problematic? Both, this is not allowed in Fedora, especially messing around with

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #17 from Neal Gompa --- (In reply to Peter Hunt from comment #16) > (problematic as in WRT "Why is this being done?", not the %_unitdir typo... The former, as this is basically not allowed in Fedora. -- You are receiving this

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #16 from Peter Hunt --- (problematic as in WRT "Why is this being done?", not the %_unitdir typo... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #15 from Peter Hunt --- just to check, is the issue just the `rm -f` or is the `ln -sf` also problematic? -- You are receiving this mail because: You are always notified about changes to this product and component You are on

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #14 from Neal Gompa --- >%post > [...] > ln -sf %{_unitdir}/%{service_name}.service {_unitdir}/%{name}.service > [...] > %postun > rm -f %{_unitdir}/%{name}.service This is a problem. These symlinks should just be included in the

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #13 from Peter Hunt --- oops, sorry, the URL I had previously posted was still out of date, I've updated the spec at https://gitlab.com/rhcontainerbot/rpms/cri-o/-/raw/1.21/cri-o.spec to reflect the current state -- You are

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #12 from Neal Gompa --- (In reply to Neal Gompa from comment #11) > > > Version: 1.21.0 > > You have a %built_tag_strip variable that you should probably have using > this value What I mean here is that Version should be

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Neal Gompa changed: What|Removed |Added Flags|needinfo?(ngomp...@gmail.co | |m)

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Peter Hunt changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Fabiano Fidêncio changed: What|Removed |Added Blocks||1977567 Referenced Bugs:

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #9 from Peter Hunt --- some small tweaks, here's a diff with explanations inline ``` # duplicated with the declaration at the top needed for gometa 34a35,36 > # https://github.com/cri-o/cri-o > %global goipath

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #8 from Neal Gompa --- What about what Robert proposed didn't work in OBS? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #7 from Peter Hunt --- sorry for the delay, but I've gotten around to updating the rpm I have updated https://gitlab.com/rhcontainerbot/rpms/cri-o/-/raw/1.21/cri-o.spec to adapt to your changes, but also fit the rest of my needs

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #6 from Robert-André Mauchin  --- Right, I've just took the original conditions but you're right. Some of them looks erroneous too like: %if 0%{?centos} <= 7 || 0%{?rhel} <= 7 which would evaluate to true on fedora since

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #5 from Neal Gompa --- Also note that CentOS defines %rhel, so you should only need to use %rhel across the board. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #4 from Neal Gompa --- > %if 0%{?fedora} || 0%{?centos} >= 8 > Recommends: runc >= 1.0.0-16 > %else > Requires: runc >= 1.0.0-16 > %endif What's up with this conditional? Shouldn't this be something like: %if 0%{?rhel}

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Robert-André Mauchin  changed: What|Removed |Added CC||zebo...@gmail.com ---

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Neal Gompa changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Neal Gompa changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited

[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers

https://bugzilla.redhat.com/show_bug.cgi?id=1970050 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com