[Bug 1331818] Review Request: singularity - Portable application stack packaging and runtime utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331818



--- Comment #42 from Fedora Update System  ---
singularity-2.2.1-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3623ac0133

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1331818] Review Request: singularity - Portable application stack packaging and runtime utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331818

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #41 from Fedora Update System  ---
singularity-2.2.1-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8ba47646ac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420931] Review Request: tripleo-repos - repo management tool for tripleo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420931



--- Comment #3 from Alan Pevec  ---
> I'll send patches to the openstack/tripleo-repos to correct this
> misconception.

https://review.openstack.org/466416

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420931] Review Request: tripleo-repos - repo management tool for tripleo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420931

Alan Pevec  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ape...@redhat.com



--- Comment #2 from Alan Pevec  ---
./tripleo-repos/.testr.conf: *No copyright* UNKNOWN
./tripleo-repos/LICENSE: *No copyright* Apache (v2.0)
./tripleo-repos/README.rst: *No copyright* UNKNOWN
./tripleo-repos/requirements.txt: *No copyright* UNKNOWN
./tripleo-repos/setup.cfg: *No copyright* Apache
./tripleo-repos/setup.py: Apache (v2.0) GENERATED FILE
./tripleo-repos/test-requirements.txt: *No copyright* UNKNOWN
./tripleo-repos/tox.ini: *No copyright* UNKNOWN

License is ASL 2.0, good for the step 2. in
https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445506

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Athos Ribeiro  ---
The link for the new srpm is broken (I believe you uploaded the binary package
to your server instead of the srpm.

Since I already reviewed most of the package, I completed the review based on
the new spec file.

Requires and provides look good now, package approved!

Requires

python2-fedmsg-rabbitmq-serializer (rpmlib, GLIBC filtered):
python(abi)
python-moksha-hub
python2-fedmsg-consumers
python2-fedmsg-meta-fedora-infrastructure
python2-pika



Provides

python2-fedmsg-rabbitmq-serializer:
python-fedmsg-rabbitmq-serializer
python2-fedmsg-rabbitmq-serializer
python2.7dist(fedmsg-rabbitmq-serializer)
python2dist(fedmsg-rabbitmq-serializer)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447089] Review Request: python-XStatic-Patternfly-Bootstrap-Treeview - Patternfly Bootstrap Treeview CSS /JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447089

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #3 from Fedora Update System  ---
python-XStatic-Patternfly-Bootstrap-Treeview-2.1.3.2-1.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-592fbf6607

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445506



--- Comment #8 from Adam Miller  ---
Spec URL:
https://maxamillion.fedorapeople.org/python-fedmsg-rabbitmq-serializer.spec
SRPM URL:
https://maxamillion.fedorapeople.org/python-fedmsg-rabbitmq-serializer-0.0.5-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445506



--- Comment #7 from Adam Miller  ---
A ok, sorry. I misunderstood. I'll fix up the nice to haves also.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #5 from Jeremy Cline  ---
Thanks, I believe I covered everything except updating to the latest version
since it introduces new dependencies that I need to package before upgrading.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19629006

SRPM URL: https://jcline.fedorapeople.org/matrix-synapse-0.19.3-3.fc27.src.rpm
Spec URL: https://jcline.fedorapeople.org/matrix-synapse.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634
Bug 1427634 depends on bug 1438089, which changed state.

Bug 1438089 Summary: Review Request: golang-github-xtaci-kcp-go - 
Production-Grade Reliable-UDP Library for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1438089

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089

Fabio Valentini  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-05-19 15:03:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451075] Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451075



--- Comment #3 from Fedora Update System  ---
python-pankoclient-0.3.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1f2f1e0b5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451075] Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451075

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439253] Review Request: python-pydispatcher - Multi-producer-multi-consumer signal dispatching mechanism

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439253



--- Comment #4 from Fedora Update System  ---
python-pydispatcher-2.0.5-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-40f69ad1fd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439253] Review Request: python-pydispatcher - Multi-producer-multi-consumer signal dispatching mechanism

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439253

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #14 from Fedora Update System  ---
certbot-0.14.1-3.fc25 python-acme-0.14.1-1.fc25
python-certbot-apache-0.14.1-1.fc25 python-certbot-nginx-0.14.1-1.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1071b956e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #13 from Fedora Update System  ---
certbot-0.14.1-3.fc25 python-acme-0.14.1-1.fc25
python-certbot-apache-0.14.1-1.fc25 python-certbot-nginx-0.14.1-1.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1071b956e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #12 from Fedora Update System  ---
certbot-0.14.1-3.fc24 python-acme-0.14.1-1.fc24
python-certbot-apache-0.14.1-1.fc24 python-certbot-nginx-0.14.1-1.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c651872919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #11 from Fedora Update System  ---
certbot-0.14.1-3.fc24 python-acme-0.14.1-1.fc24
python-certbot-apache-0.14.1-1.fc24 python-certbot-nginx-0.14.1-1.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c651872919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #10 from Fedora Update System  ---
certbot-0.14.1-3.fc26 python-acme-0.14.1-1.fc26
python-certbot-apache-0.14.1-1.fc26 python-certbot-nginx-0.14.1-1.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64270716a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #9 from Fedora Update System  ---
certbot-0.14.1-3.fc26 python-acme-0.14.1-1.fc26
python-certbot-apache-0.14.1-1.fc26 python-certbot-nginx-0.14.1-1.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64270716a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #8 from Fedora Update System  ---
certbot-0.14.1-3.el7 python-acme-0.14.1-1.el7
python-certbot-apache-0.14.1-1.el7 python-certbot-nginx-0.14.1-1.el7 has been
submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-acdfbe8cfa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #7 from Fedora Update System  ---
certbot-0.14.1-3.el7 python-acme-0.14.1-1.el7
python-certbot-apache-0.14.1-1.el7 python-certbot-nginx-0.14.1-1.el7 has been
submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-acdfbe8cfa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #22 from Fedora Update System  ---
keepassxc-2.1.4-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-08aacd9ce3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #23 from Fedora Update System  ---
keepassxc-2.1.4-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-13541d4d31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557



--- Comment #23 from Fedora Update System  ---
hidviz-0.1.4-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4a4632fd4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557



--- Comment #22 from Fedora Update System  ---
hidviz-0.1.4-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b51fe482b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-05-19 11:08:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414004



--- Comment #11 from Fedora Update System  ---
rubygem-rspec-pending_for-0.1.5-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557



--- Comment #21 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/hidviz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #21 from Germano Massullo  ---
Thank you Mukundan, very good review, I will keep it as model for future review
requests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #10 from Richard W.M. Jones  ---
A few problems still.  See my comments inline below.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: laby : /usr/share/laby/mods/c/lib/robot.h laby :
  /usr/share/laby/mods/cpp/lib/robot.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

This is explained in the spec file and is not a problem.

- Package contains BR: python2-devel or python3-devel

I think this is bogus and can be ignored.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 97 files have unknown license. Detailed output of
 licensecheck in /home/rjones/1450679-laby/licensecheck.txt

I checked the licenses and is does appear that the author intends
GPLv3+.

I guess you could ask upstream to use proper per-file GPL headers
instead of ones they appear to have made up, but it's not urgent.

There does not appear to be any problematic content.

[x]: License file installed when any subpackage combination is installed.

Yes, in /usr/share/licenses/laby/gpl-3.0.txt

[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.

OCaml package, so not applicable.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required

Please remove rm -rf %{buildroot} at the beginning of the %install section.

[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package

See comment in source about the header file.

[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.

The Requires lines should be removed.  The final binary will
contain statically-linked copies of ocaml-lablgtk and gtksourceview2.
It dynamically links to the C libs gtk etc.  There is no need to pull in
those packages at runtime at all.

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in laby
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: 

[Bug 1330833] Review Request: python-bitstring - Simple construction, analysis and modification of binary data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330833



--- Comment #4 from Julien Enselme  ---
Any updates on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365805] Review Request: python-django-graphos - Django app to provide a JS agnostic way to work with charts.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365805



--- Comment #2 from Julien Enselme  ---
Any updates on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #9 from Richard W.M. Jones  ---
(In reply to Sandro Bonazzola from comment #8)
> Updated addressing your comments to my best. I may need help about the debug
> symbols, looks like the generated debug rpm is missing sources.

It has actually included the sources in the debuginfo file,
and also ‘-g’ is being passed to each invocation of ‘ocamlopt’,
so everything seems fine to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #8 from Sandro Bonazzola  ---
Updated addressing your comments to my best. I may need help about the debug
symbols, looks like the generated debug rpm is missing sources.
Spec URL:
https://raw.githubusercontent.com/sandrobonazzola/laby/33014dae825b35f10e65752821ef42a3518f27f8/packaging/laby.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/Laby/fedora-rawhide-x86_64/00554044-laby/laby-0.6.4-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #46 from Jonny Heggheim  ---
It looks like most the the license issues is from the web mobule that we do not
package.

The fxpackager module is licensed BSD

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #45 from Jonny Heggheim  ---
(In reply to Michal Vala from comment #44)
> >  * Added comments why tests are disabled
> do you know why those tests are failing? Can't be just excluded instead of
> not run all tests?

Maybe it is not able to lookup the native library.. We can delete the test file
as the first attempt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1452649] New: Review Request: python-exabgp - Package review request for ExaBGP spec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1452649

Bug ID: 1452649
   Summary: Review Request: python-exabgp - Package review request
for ExaBGP  spec
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lhi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/lukehinds/ExaBGP-Packaging/master/python-exabgp.spec
SRPM URL:
https://github.com/lukehinds/ExaBGP-Packaging/raw/master/python-exabgp-4.0.0-1.fc25.src.rpm
Description: ExaBGP provides a convenient way to implement Software Defined
Networking by transforming BGP messages into friendly plain text or JSON, which
can then be easily handled by simple scripts or your BSS/OSS.
Fedora Account System Username:lhinds


This is my first package to Fedora so I need a sponsor. I am familiar with
maintaining packages in the RDO project where I maintain the bagpipe-bgp
package.

The package has been successfully built with rpmbuild on a Fedora 25 system,
and installed to insure functionality.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #20 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/keepassxc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448660] Review Request: nodejs-is-text-path - Check if a filepath is a text file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448660



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-is-text-path

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448876] Review Request: nodejs-get-pkg-repo - Get normalized repository from package json data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448876



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-get-pkg-repo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1452644] New: Review Request: python-mmtf - A decoding library for the macromolecular transmission format (MMTF)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1452644

Bug ID: 1452644
   Summary: Review Request: python-mmtf - A decoding library for
the macromolecular transmission format (MMTF)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: domi...@greysector.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rathann.fedorapeople.org/review/python-mmtf/python-mmtf.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-mmtf/python-mmtf-1.0.5-1.fc27.src.rpm
Description:
The Macromolecular Transmission Format (MMTF) is a new compact binary format to
transmit and store biomolecular structures for fast 3D visualization and
analysis.

Bradley AR, Rose AS, Pavelka A, Valasatava Y, Duarte JM, Prlić A, Rose PW
(2017)
MMTF - an efficient file format for the transmission, visualization, and
analysis of macromolecular structures. bioRxiv 122689. doi: 10.1101/122689

Valasatava Y, Bradley AR, Rose AS, Duarte JM, Prlić A, Rose PW (2017) Towards
an
efficient compression of 3D coordinates of macromolecular structures. PLOS ONE
12(3): e0174846. doi: 10.1371/journal.pone.01748464

Rose AS, Bradley AR, Valasatava Y, Duarte JM, Prlić A, Rose PW (2016) Web-based
molecular graphics for large complexes. In Proceedings of the 21st
International
Conference on Web3D Technology (Web3D '16). ACM, New York, NY, USA, 185-186.
doi: 10.1145/2945292.2945324

Fedora Account System Username: rathann

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #44 from Michal Vala  ---
(In reply to Jonny Heggheim from comment #42)
> A quick update:
> 
> Spec URL: https://jonny.fedorapeople.org/openjfx.spec
> SRPM URL: https://jonny.fedorapeople.org/openjfx-8.0.152-8.b03.fc25.src.rpm
> Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19610005
> 
> Changes:
>  * Requires on javapackages-tools (owns /usr/lib/jvm)
>  * Added requires on parent package for devel and src
>  * Moved /usr/share/man/ja_JP.UTF-8/man1 to /usr/share/man/ja_JP/man1 (which
> is owned by the filesystem package)
>  * Added %dir %{openjfxdir} in %files for parent package
thanks, looks good

>  * Added comments why tests are disabled
do you know why those tests are failing? Can't be just excluded instead of not
run all tests?

> 
> 
> I have not looked into any of the license issues, it would be great if other
> have time to help me.
Here is output from licensecheck
https://michalvala.fedorapeople.org/openjfx/licensecheck.txt
Looks like openjfx include sources of several libs. I'm not sure how to solve
that technically neither "legally".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557

Zdenek Dohnal  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #20 from Zdenek Dohnal  ---
The newest srpm fixed flaws discussed above, giving + and ACCEPT.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1331818] Review Request: singularity - Portable application stack packaging and runtime utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331818



--- Comment #40 from Fedora Update System  ---
singularity-2.2.1-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8ba47646ac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1331818] Review Request: singularity - Portable application stack packaging and runtime utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331818



--- Comment #39 from Fedora Update System  ---
singularity-2.2.1-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3623ac0133

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1331818] Review Request: singularity - Portable application stack packaging and runtime utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331818

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451298] Review Request: vertex-theme - Vertex is a theme for GTK 3, GTK 2, Gnome-Shell and Cinnamon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451298



--- Comment #2 from Thanos Apostolou  ---
Thx Iwicki Artur. Fedora has really long documentation. I keep reading it, but
I still have a lot to learn :P

I upgraded the package.

SPEC URL (same as before):
http://copr-dist-git.fedorainfracloud.org/cgit/thanosapostolou/vertex-theme/vertex-theme.git/tree/vertex-theme.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/thanosapostolou/vertex-theme/fedora-rawhide-x86_64/00553988-vertex-theme/vertex-theme-20170128-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #43 from jiri vanek  ---
> 
> I have not looked into any of the license issues, it would be great if other
> have time to help me.

I did.  Whole fx project should really be GPL2:
Thanx to Mario for pointing out
http://hg.openjdk.java.net/openjfx/10/rt/file/48902e8e83a9/LICENSE

On other side, it claims to have same license as openjdk;
http://pkgs.fedoraproject.org/cgit/rpms/java-1.8.0-openjdk.git/tree/java-1.8.0-openjdk.spec#n811

That is a bit contradiction, so maybe I have bad license in jdk package.

Your statement of:
License:GPL v2 with exceptions and BSD and LGPL v2+ and (LGPL v2+ or
BSD)
seems to be reflecting major of what review tool is saying. Hoowever I would go
with simple GPL-2 with Classpath exception (/me  a bit afraid of BSD in license
field)

The incorrect-fsf-address is actually patch for upstream, so we do not need to
bother with it rigt now.

I will try to find some lawyer around, but with "GPL-2 with Classpath
exception" I think we are ok to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557



--- Comment #19 from Jaroslav Škarvada  ---
New version:
Spec URL: https://jskarvad.fedorapeople.org/hidviz/hidviz.spec
SRPM URL: https://jskarvad.fedorapeople.org/hidviz/hidviz-0.1.4-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #7 from Severin Gehwolf  ---
New scratch build for F26 x86_64 as old built artifacts expired:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19617138

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447213] Review Request: gimp-wavelet-decompose - Decomposing image plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447213



--- Comment #12 from Fedora Update System  ---
gimp-wavelet-decompose-0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org