[Bug 1752864] Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides
https://bugzilla.redhat.com/show_bug.cgi?id=1752864 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- breezy-3.0.1-1.fc31, python-launchpadlib-1.10.7-1.fc31, python-lazr-restfulclient-0.14.2-1.fc31, python-lazr-uri-1.0.3-1.fc31, python-sphinx-epytext-0.0.4-1.fc31, python-wadllib-1.3.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752859] Review Request: python-lazr-uri - Parsing and dealing with URIs
https://bugzilla.redhat.com/show_bug.cgi?id=1752859 --- Comment #4 from Fedora Update System --- breezy-3.0.1-1.fc31, python-launchpadlib-1.10.7-1.fc31, python-lazr-restfulclient-0.14.2-1.fc31, python-lazr-uri-1.0.3-1.fc31, python-sphinx-epytext-0.0.4-1.fc31, python-wadllib-1.3.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752872] Review Request: python-lazr-restfulclient - Programmable client library for lazr.restful web services
https://bugzilla.redhat.com/show_bug.cgi?id=1752872 --- Comment #4 from Fedora Update System --- breezy-3.0.1-1.fc31, python-launchpadlib-1.10.7-1.fc31, python-lazr-restfulclient-0.14.2-1.fc31, python-lazr-uri-1.0.3-1.fc31, python-sphinx-epytext-0.0.4-1.fc31, python-wadllib-1.3.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1753633] Review Request: python-launchpadlib - Script Launchpad through its web services interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1753633 --- Comment #5 from Fedora Update System --- breezy-3.0.1-1.fc31, python-launchpadlib-1.10.7-1.fc31, python-lazr-restfulclient-0.14.2-1.fc31, python-lazr-uri-1.0.3-1.fc31, python-sphinx-epytext-0.0.4-1.fc31, python-wadllib-1.3.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1754964] Review Request: breezy - Friendly distributed version control system
https://bugzilla.redhat.com/show_bug.cgi?id=1754964 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- breezy-3.0.1-1.fc31, python-launchpadlib-1.10.7-1.fc31, python-lazr-restfulclient-0.14.2-1.fc31, python-lazr-uri-1.0.3-1.fc31, python-sphinx-epytext-0.0.4-1.fc31, python-wadllib-1.3.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1760115] New: Review Request: maven-osgi - Library for Maven-OSGi integration
https://bugzilla.redhat.com/show_bug.cgi?id=1760115 Bug ID: 1760115 Summary: Review Request: maven-osgi - Library for Maven-OSGi integration Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://decathorpe.fedorapeople.org/packages/maven-osgi.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/maven-osgi-0.2.0-18.fc30.src.rpm Description: Library for Maven-OSGi integration. This is a replacement package for maven-shared-osgi. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=38184774 NOTE: This is a package re-review request for an unretirement after more than 8 weeks. It's still required by some dependencies of the PKI stack. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Kentaro Hayashi changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #8 from Kentaro Hayashi --- Because of sentence piece package is approved, I've tried to request fedpkg request-repo [1], but it was failed. Here is the error log: $ fedpkg request-repo sentencepiece 1758036 Could not execute request_repo: The following error occurred while creating a new issue in Pagure: Invalid or expired token. Please visit https://pagure.io/settings#nav-api-tab to get or renew your API token. For invalid or expired token refer to "fedpkg request-repo -h" to set a token in your user configuration. Before requesting fedpkg request-repo, I've set up ~/config/rpkg/fedpkg.conf (fedpkg request-repo -h explains about pague API token) Even though full ACLs are checked (Fork a project,Modify an existing project,Comment on a pull-request,Open a new pull-request,Merge a pull-request,Update the watch status on a project), fedpkg request-repo fails. What am I missing to do next steps? [1] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #7 from Raphael Groner --- Sorry for the delay. f-r is running currently and I'll returm with new results asap. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196 --- Comment #9 from Raphael Groner --- > [?]: Binary eggs must be removed in %prep > Note: Cannot find any build in BUILD directory (--prebuilt option?) Maybe better try to build from source instead of using pypi provides binaries only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-dijitso-2019.1.0-1.f ||c32 Resolution|--- |RAWHIDE Last Closed||2019-10-09 22:13:01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759715] Review Request: python-ffc - Compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=1759715 Bug 1759715 depends on bug 1759687, which changed state. Bug 1759687 Summary: Review Request: python-dijitso - Distributed just-in-time building of shared libraries https://bugzilla.redhat.com/show_bug.cgi?id=1759687 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759883] Review Request: dolfin - FEniCS computational backend and problem solving environment
https://bugzilla.redhat.com/show_bug.cgi?id=1759883 Bug 1759883 depends on bug 1759687, which changed state. Bug 1759687 Summary: Review Request: python-dijitso - Distributed just-in-time building of shared libraries https://bugzilla.redhat.com/show_bug.cgi?id=1759687 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1753195] Review Request: python-sphinx-epytext - Sphinx epytext extension
https://bugzilla.redhat.com/show_bug.cgi?id=1753195 --- Comment #4 from Fedora Update System --- breezy-3.0.1-1.fc31, python-launchpadlib-1.10.7-1.fc31, python-lazr-restfulclient-0.14.2-1.fc31, python-lazr-uri-1.0.3-1.fc31, python-sphinx-epytext-0.0.4-1.fc31, python-wadllib-1.3.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1652588] Review Request: python-pytest-metadata - Pytest plugin that provides access to test session metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1652588 --- Comment #16 from Fedora Update System --- python-pytest-metadata-1.7.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab34aeed16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709037] Review Request: python-javabridge - Python wrapper for the Java Native Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1709037
--- Comment #10 from Raphael Groner ---
Thanks for your advice. Though, I don't see any blockers to approve, otherwise
please guide me in our official packaging guidelines.
https://docs.fedoraproject.org/en-US/packaging-guidelines/
> Also, having a description for the binary package which does not get created
> is strange.
It's suggested in the official python sample. No idea if rpmbuild accepts an
empty main description.
> → maybe add BR: python%{python3_pkgversion}-coverage to avoid the warning?
No, coverage is not relevant for the package build, that seems to be a feature
for upstream only.
> It seems unversioned python is being called.
I fail to see for what step of the build task this counts.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752196] Review Request: python-pytest-harvest - Store data created during test execution and retrieve it at the end
https://bugzilla.redhat.com/show_bug.cgi?id=1752196
--- Comment #8 from Raphael Groner ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[?]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
=> Please explain why you use BSD.
[!]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
=> Empty licensecheck.txt generated, why?
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
=> See issue about python version.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[?]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[!]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[?]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[Bug 1757674] Review Request: chatty - XMPP and SMS messaging
https://bugzilla.redhat.com/show_bug.cgi?id=1757674 --- Comment #2 from Lubomir Rintel --- Thanks for the response and the suggestion. Fixed the Rawhide build now: SPEC: http://v3.sk/~lkundrak/SPECS/chatty.spec SRPM: http://v3.sk/~lkundrak/SRPMS/chatty-0.0.8-0.1.20181001gitef94134.fc31.src.rpm mock (f32): https://koji.fedoraproject.org/koji/taskinfo?taskID=38167201 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757675] Review Request: calls - Phone dialer and call handler
https://bugzilla.redhat.com/show_bug.cgi?id=1757675 --- Comment #2 from Lubomir Rintel --- Thanks for the response and the suggestion. Fixed the Rawhide build now: SPEC: http://v3.sk/~lkundrak/SPECS/calls.spec SRPM: http://v3.sk/~lkundrak/SRPMS/calls-0.1.0-1.fc31.src.rpm mock (f32): https://koji.fedoraproject.org/koji/taskinfo?taskID=38167199 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757673] Review Request: phoc - Display compositor designed for phones
https://bugzilla.redhat.com/show_bug.cgi?id=1757673 --- Comment #2 from Lubomir Rintel --- Thanks for the response and the suggestion. Fixed the Rawhide build now: SPEC: http://v3.sk/~lkundrak/SPECS/phoc.spec SRPM: http://v3.sk/~lkundrak/SRPMS/phoc-0.1.0-2.fc31.src.rpm mock (f32): https://koji.fedoraproject.org/koji/taskinfo?taskID=38167194 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1759883 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1759883 [Bug 1759883] Review Request: dolfin - FEniCS computational backend and problem solving environment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759883] Review Request: dolfin - FEniCS computational backend and problem solving environment
https://bugzilla.redhat.com/show_bug.cgi?id=1759883 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Depends On||1759687, 1759715, 1739798 --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- Also needs https://src.fedoraproject.org/rpms/python-fiat/pull-request/1 to go in first. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1739798 [Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra https://bugzilla.redhat.com/show_bug.cgi?id=1759687 [Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries https://bugzilla.redhat.com/show_bug.cgi?id=1759715 [Bug 1759715] Review Request: python-ffc - Compiler for finite element variational forms -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1739798] Review Request: python-fiat - Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra
https://bugzilla.redhat.com/show_bug.cgi?id=1739798 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1759883 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1759883 [Bug 1759883] Review Request: dolfin - FEniCS computational backend and problem solving environment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1652588] Review Request: python-pytest-metadata - Pytest plugin that provides access to test session metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1652588 --- Comment #14 from Fedora Update System --- FEDORA-2019-ab34aeed16 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab34aeed16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759715] Review Request: python-ffc - Compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=1759715 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1759883 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1759883 [Bug 1759883] Review Request: dolfin - FEniCS computational backend and problem solving environment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1652588] Review Request: python-pytest-metadata - Pytest plugin that provides access to test session metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1652588 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #13 from Fedora Update System --- FEDORA-2019-23ba87d561 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-23ba87d561 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759883] New: Review Request: dolfin - FEniCS computational backend and problem solving environment
https://bugzilla.redhat.com/show_bug.cgi?id=1759883 Bug ID: 1759883 Summary: Review Request: dolfin - FEniCS computational backend and problem solving environment Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: zbys...@in.waw.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://in.waw.pl/~zbyszek/fedora/dolfin.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/dolfin-2019.1.0.post0-1.fc32.src.rpm Description: DOLFIN is the computational backend of FEniCS and implements the FEniCS Problem Solving Environment. Fedora Account System Username: zbyszek -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758499] Review Request: procdump - Process coredumps based on performance triggers
https://bugzilla.redhat.com/show_bug.cgi?id=1758499
--- Comment #11 from Matej Grabovsky ---
(In reply to Neal Gompa from comment #10)
> That said, if it always works now, just make sure you change it to the
> following:
>
> > %make_build CFLAGS="%{optflags}"
Thanks. I've now updated the spec file to reflect the suggested changes.
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/mgrabovs/procdump/fedora-31-x86_64/01051412-procdump/procdump.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mgrabovs/procdump/fedora-31-x86_64/01051412-procdump/procdump-1.0.1-1.fc31.src.rpm
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=38166862(In reply to
Neal Gompa from comment #10)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats (required for `samtools`)
https://bugzilla.redhat.com/show_bug.cgi?id=1326504 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #48 from Zbigniew Jędrzejewski-Szmek --- Jan: I think you should open a new review ticket and close this one as DEAD-REVIEW. Sam's review request from 3 years ago is not enough for be sponsored as a packager. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759928] New: Review Request: libresample - A real-time library for audio sampling rate conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1759928 Bug ID: 1759928 Summary: Review Request: libresample - A real-time library for audio sampling rate conversion Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews) Target Milestone: --- Classification: Fedora Spec URL: https://jsmith.fedorapeople.org/Packaging/libresample/libresample.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/libresample/libresample-0.1.3-32.fc31.src.rpm Description: A real-time library for audio sampling rate conversion Fedora Account System Username: jsmith Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759928] Review Request: libresample - A real-time library for audio sampling rate conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1759928 --- Comment #2 from J. Scheurich --- $ fedora-review -n libresample ... ... INFO: Install command returned error code 30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1590425] Review Request: kata-runtime - Kata runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1590425
Cole Robinson changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|crobi...@redhat.com
Flags||needinfo?(dinechin@redhat.c
||om)
--- Comment #10 from Cole Robinson ---
Using the SRPM URL: and Spec URL: format in Comment #3 helps simplify the
review process, fedora-review tool can just be pointed at the bug. So for next
posting please provide that as well
* The kata-runtime binary should be in /usr/bin, which is where upstream puts
it. I don't see any reason to deviate
* godocs/golicense/files: only a single LICENSE file ends up in the rpm. I
don't think the godocs/golicense stuff is
playing well with the %files section, but I'm not sure. either way, I don't
think we need to put anything more
than the top level LICENSE and README.md into the RPM. The LICENSEs are all
the same apache version, and most of
of the other docs seem fine to just exist in upstream git.
* The BuildRequires: compiler(go-compiler) is not required, go-rpm-macros
does that for us
* The comment about a 'rediculous' name from goname is not necessary. IMO it's
self evident why
goname does not apply here, it doesn't need the commentary
Trimmed fedora-review output below, with some comments.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/defaults
* Yes, seems like this should be a %dir in the %files list. This is
a non-standard FHS directory I believe, but it will take work with
kata upstream to correct it, so it should stay for now IMO>
[ ]: %build honors applicable compiler flags or justifies otherwise.
* We talked about this offline. Use of %gobuild is not easy in this
package because 'make' handles a bunch of other stuff. So distro
go build flags aren't making it into the build. Next release
of go-rpm-macros should have a %gobuildflags macro that will help
here, but it isn't available yet. Christophe, please add a comment
to that effect in the spec, so we don't forget, and optionally
link to the go-rpm-macros commit:
https://pagure.io/go-rpm-macros/c/67b4fbbbfce0986ac46cd1329bf85a18ea7a43d2?branch=master
[ ]: Package is not known to require an ExcludeArch tag.
* ExcludeArch is necessary as dependent kata components do not build on
32 bit archs. This is a known issue that isn't kata-runtimes fault.
Doesn't block this review
[!]: Reviewer should test that the package builds in mock.
* worked fine for me
[!]: Uses parallel make %{?_smp_mflags} macro.
* indeed, spec should use %make_build and %make_install macros in place of the
direct
'make' calls. But if this causes build issues, just drop them and mention it
in
the next submission
Rpmlint
---
Checking: kata-runtime-1.8.2-2.fc32.x86_64.rpm
kata-runtime-debuginfo-1.8.2-2.fc32.x86_64.rpm
kata-runtime-debugsource-1.8.2-2.fc32.x86_64.rpm
kata-runtime-1.8.2-2.fc32.src.rpm
kata-runtime.x86_64: W: no-manual-page-for-binary kata-collect-data.sh
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
* This issue can be safely ignored. I think we may not want to ship this
script, or move it elsewhere, but we can figure it out after package import
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759416] Review Request: libretro-mgba - mGBA Game Boy Advance Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1759416 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-mgba -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats (required for `samtools`)
https://bugzilla.redhat.com/show_bug.cgi?id=1326504 Jun Aruga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE Last Closed||2019-10-09 13:17:59 --- Comment #50 from Jun Aruga --- I close following ticket, as I can request the dist-git repository by my account that has packager "user" role on Fedora. https://bugzilla.redhat.com/show_bug.cgi?id=1759940 *** This bug has been marked as a duplicate of bug 1759940 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) CC||samstud...@gmail.com --- Comment #2 from Jun Aruga --- *** Bug 1326504 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759407] Review Request: libretro-beetle-ngp - Standalone port of Mednafen NGP to the libretro API, itself a fork of Neopop
https://bugzilla.redhat.com/show_bug.cgi?id=1759407 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 14:05:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759928] Review Request: libresample - A real-time library for audio sampling rate conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1759928 J. Scheurich changed: What|Removed |Added CC||muft...@web.de --- Comment #1 from J. Scheurich --- Minor problem ? $ fedora-review -n libresample ... INFO: No upstream for (Source1): libresample.pc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- Yeah, it didn't fail for me either. I'll add %_openmpi_unload. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759414] Review Request: libretro-beetle-vb - Standalone port of Mednafen VB to libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759414 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-beetle-vb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759407] Review Request: libretro-beetle-ngp - Standalone port of Mednafen NGP to the libretro API, itself a fork of Neopop
https://bugzilla.redhat.com/show_bug.cgi?id=1759407 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-beetle-ngp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759413] Review Request: libretro-beetle-pce-fast - Standalone port of Mednafen PCE Fast to libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759413 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-beetle-pce-fast -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687
--- Comment #3 from Ankur Sinha (FranciscoD) ---
Mock builds fail here:
+ module load mpi/openmpi-x86_64
+ _module_raw load mpi/openmpi-x86_64
+ unset _mlshdbg
+ '[' 0 = 1 ']'
+ unset _mlre _mlIFS
+ '[' -n x ']'
+ _mlIFS='
'
+ IFS=' '
+ for _mlv in ${MODULES_RUN_QUARANTINE:-}
+ '[' LD_LIBRARY_PATH = LD_LIBRARY_PATH -a LD_LIBRARY_PATH = LD_LIBRARY_PATH
']'
++ eval 'echo ${LD_LIBRARY_PATH+x}'
+++ echo x
+ '[' -n x ']'
++ eval 'echo ${LD_LIBRARY_PATH}'
+++ echo /usr/lib64/mpich/lib
+ _mlre='LD_LIBRARY_PATH_modquar='\''/usr/lib64/mpich/lib'\'' '
+ _mlrv=MODULES_RUNENV_LD_LIBRARY_PATH
++ eval 'echo ${MODULES_RUNENV_LD_LIBRARY_PATH:-}'
+++ echo
+ _mlre='LD_LIBRARY_PATH_modquar='\''/usr/lib64/mpich/lib'\''
LD_LIBRARY_PATH='\'''\'' '
+ '[' -n 'LD_LIBRARY_PATH_modquar='\''/usr/lib64/mpich/lib'\''
LD_LIBRARY_PATH='\'''\'' ' ']'
++ eval 'LD_LIBRARY_PATH_modquar='\''/usr/lib64/mpich/lib'\'''
'LD_LIBRARY_PATH='\'''\''' /usr/bin/tclsh
/usr/share/Modules/libexec/modulecmd.tcl sh '"$@"'
+++ LD_LIBRARY_PATH_modquar=/usr/lib64/mpich/lib
+++ LD_LIBRARY_PATH=
+++ /usr/bin/tclsh /usr/share/Modules/libexec/modulecmd.tcl sh load
mpi/openmpi-x86_64
[?1h=
Loading mpi/openmpi-x86_64
ERROR: mpi/openmpi-x86_64 cannot be loaded due to a conflict.
HINT: Might try "module unload mpi" first.
I think we need %_mpich_unload after the tests have run with mpich, before
%_openmpi_load?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- Updated in place. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] New: Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Bug ID: 1759940 Summary: Review Request: htslib - C library for high-throughput sequencing data formats Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jar...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/junaruga/htslib-pkg/hotfix/review/htslib.spec SRPM URL: https://github.com/junaruga/htslib-pkg/blob/hotfix/review/htslib-1.9-1.fc32.src.rpm?raw=true Description: C library for high-throughput sequencing data formats Fedora Account System Username: jaruga -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga changed: What|Removed |Added CC||zebo...@gmail.com Link ID||Red Hat Bugzilla 1326504 Blocks||177841 (FE-NEEDSPONSOR), ||1131121, 1738176 Flags||fedora-review? ||needinfo?(zebo...@gmail.com ||) --- Comment #1 from Jun Aruga --- This is an inheritance ticket from https://bugzilla.redhat.com/show_bug.cgi?id=1326504 . The ticket is created to request the Fedora dist-git repository by my account. The Spec URL and SRPM URL and the contents are same as the last ones of the ticket https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c26 * Koji scratch build: ok https://koji.fedoraproject.org/koji/taskinfo?taskID=38010659 * Test to install RPMs: ok * rpmlint: ok Robert, can I ask you to change "fedora-review+" again like following comment? https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c34 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1131121 [Bug 1131121] samtools-1.9 is available https://bugzilla.redhat.com/show_bug.cgi?id=1738176 [Bug 1738176] samtools depends on Python 2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats (required for `samtools`)
https://bugzilla.redhat.com/show_bug.cgi?id=1326504 Sam Nicholls changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) --- Comment #49 from Sam Nicholls --- Jun and I have discussed this off-thread and think this is likely the best way forward. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats (required for `samtools`)
https://bugzilla.redhat.com/show_bug.cgi?id=1326504 Jun Aruga changed: What|Removed |Added Resolution|DUPLICATE |WONTFIX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759417] Review Request: libretro-nestopia - Nestopia emulator with libretro interface
https://bugzilla.redhat.com/show_bug.cgi?id=1759417 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-nestopia -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Flags||fedora-review? --- Comment #2 from Ankur Sinha (FranciscoD) --- Thanks---putting it through fedora-review now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687 --- Comment #4 from Ankur Sinha (FranciscoD) --- Weird how it didn't fail on koji, though. Mock is using the rawhide chroot here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR),| |201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758499] Review Request: procdump - Process coredumps based on performance triggers
https://bugzilla.redhat.com/show_bug.cgi?id=1758499 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/procdump -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759415] Review Request: libretro-beetle-wswan - Standalone port of Mednafen WonderSwan to libretro, itself a fork of Cygne
https://bugzilla.redhat.com/show_bug.cgi?id=1759415 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-beetle-wswan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759390] Review Request: libretro-bsnes-mercury - Fork of bsnes with various performance improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1759390 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-bsnes-mercury -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759928] Review Request: libresample - A real-time library for audio sampling rate conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1759928
--- Comment #3 from J. Scheurich ---
This is only a informal review. i am not in the packager group
[!]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
libresample-devel
Rpmlint
---
...
libresample.x86_64: E: incorrect-fsf-address
/usr/share/doc/libresample/LICENSE.txt
...
libresample-devel.x86_64: E: incorrect-fsf-address
/usr/share/licenses/libresample
...
libresample.x86_64: W: invalid-url URL:
http://ccrma.stanford.edu/~jos/resample/Free_Resampling_Software.html
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/libresample
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[-]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv,
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags|fedora-review? |fedora-review+ |needinfo?(zebo...@gmail.com | |) | --- Comment #3 from Zbigniew Jędrzejewski-Szmek --- Review was done in https://bugzilla.redhat.com/show_bug.cgi?id=1326504#c34. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759928] Review Request: libresample - A real-time library for audio sampling rate conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1759928
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
CC||zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #4 from Zbigniew Jędrzejewski-Szmek ---
I'd put Summary below Name and Version... Looks strange to have it as the
first thing.
"providing several useful features relative to resample-1.7" — I don't think
most
users can make any use of this comparison.
make VERBOSE=1 %{?_smp_mflags} → %make_build VERBOSE=1
%{_libdir}/libresample.so.* → a specific pattern would be better. The
guidelines
changed on this recently
[https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files]
But since the project is dead upstream, this doesn't really matter.
rpmlint:
libresample.x86_64: W: no-soname /usr/lib64/libresample.so.0
libresample.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libresample.so.0 /lib64/libsamplerate.so.0
libresample.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libresample.so.0 /lib64/libsndfile.so.1
... (other warnings omitted)
5 packages and 0 specfiles checked; 2 errors, 14 warnings.
+ name is OK
+ license is (still) OK
+ builds and installs OK
+ latest version ;)
Package is RE-APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759687] Review Request: python-dijitso - Distributed just-in-time building of shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1759687
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #7 from Ankur Sinha (FranciscoD) ---
Looks good. A few notes, but none of them are blockers: X APPROVED X
- /usr/bin -> %{_bindir} in %files
- you've downloaded the gpg signature, were you planning to verify the source?
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_verifying_signatures
- the tar does seem to include the docs---please consider generating them and
adding a -doc sub package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 2 files have
unknown license. Detailed output of licensecheck in
/home/asinha/dump/fedora-reviews/1759687-python-
dijitso/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a
[Bug 1759416] Review Request: libretro-mgba - mGBA Game Boy Advance Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1759416 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 14:59:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #4 from Jun Aruga --- Zbigniew, thanks for your review again! Now I am requesting the repository. ``` $ fedpkg request-repo htslib 1759940 https://pagure.io/releng/fedora-scm-requests/issue/18058 ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758487] Review Request: fasttext - Efficient learning of word representations and sentence classification
https://bugzilla.redhat.com/show_bug.cgi?id=1758487 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #6 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1753633] Review Request: python-launchpadlib - Script Launchpad through its web services interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1753633 --- Comment #4 from Fedora Update System --- FEDORA-2019-7fb253a20a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1754964] Review Request: breezy - Friendly distributed version control system
https://bugzilla.redhat.com/show_bug.cgi?id=1754964 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #15 from Fedora Update System --- FEDORA-2019-7fb253a20a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752864] Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides
https://bugzilla.redhat.com/show_bug.cgi?id=1752864 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2019-7fb253a20a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752872] Review Request: python-lazr-restfulclient - Programmable client library for lazr.restful web services
https://bugzilla.redhat.com/show_bug.cgi?id=1752872 --- Comment #3 from Fedora Update System --- FEDORA-2019-7fb253a20a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1753195] Review Request: python-sphinx-epytext - Sphinx epytext extension
https://bugzilla.redhat.com/show_bug.cgi?id=1753195 --- Comment #3 from Fedora Update System --- FEDORA-2019-7fb253a20a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752859] Review Request: python-lazr-uri - Parsing and dealing with URIs
https://bugzilla.redhat.com/show_bug.cgi?id=1752859 --- Comment #3 from Fedora Update System --- FEDORA-2019-7fb253a20a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fb253a20a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757674] Review Request: chatty - XMPP and SMS messaging
https://bugzilla.redhat.com/show_bug.cgi?id=1757674
--- Comment #3 from Robert-André Mauchin ---
- You shouldn't own %{_datadir}/icons/hicolor but depends on Requires:
hicolor-icon-theme and be more specific if %files:
Requires: hicolor-icon-theme
[…]
%{_datadir}/icons/hicolor/*/apps/*.svg
- Changelog entry has incorrect Release info:
chatty.x86_64: W: incoherent-version-in-changelog 0.1.0-1 ['0.1.0-2.fc32',
'0.1.0-2']
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)". 95 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/chatty/review-chatty/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor(pdfmod, tuxanci, xchm, qmmp, fedora-logos,
qtl866, freedroidrpg, mono-tools, qucs, redeclipse, vacuum-im, nedit,
android-file-transfer, massif-visualizer, kgraphviewer, hicolor-icon-
theme, wesnoth-data, system-config-httpd, autokey-common),
/usr/share/icons/hicolor/scalable(autokey-common, dxf2gcode, pdfmod,
tuxanci, qmmp, lxqt-powermanagement, fedora-logos, keepassx, massif-
visualizer, qucs, hicolor-icon-theme, qtl866, freedroidrpg, eom),
/usr/share/icons/hicolor/scalable/apps(autokey-common, dxf2gcode,
pdfmod, tuxanci, gtatool-gui, qmmp, fedora-logos, keepassx, massif-
visualizer, qucs, hicolor-icon-theme, qtl866, freedroidrpg, eom),
/usr/share/icons/hicolor/symbolic(hicolor-icon-theme),
/usr/share/icons/hicolor/symbolic/apps(hicolor-icon-theme)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build
[Bug 1758036] Review Request: sentencepiece - unsupervised text tokenizer for Neural Network-based text generation
https://bugzilla.redhat.com/show_bug.cgi?id=1758036 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/htslib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759414] Review Request: libretro-beetle-vb - Standalone port of Mednafen VB to libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759414 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 14:30:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759415] Review Request: libretro-beetle-wswan - Standalone port of Mednafen WonderSwan to libretro, itself a fork of Cygne
https://bugzilla.redhat.com/show_bug.cgi?id=1759415 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 14:42:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1747552] Review Request: libdfp - Decimal Floating Point library
https://bugzilla.redhat.com/show_bug.cgi?id=1747552
--- Comment #5 from Robert-André Mauchin ---
You haven't addressed the follozwing:
- Missing isa in %package devel
Requires: %{name}%{?_isa} = %{version}-%{release}
- It seems it should be:
%prep
%autosetup -p1 -n %{name}-%{version}
- Not needed: %defattr(-,root,root,-) in %files devel
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759390] Review Request: libretro-bsnes-mercury - Fork of bsnes with various performance improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1759390 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 16:03:23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759413] Review Request: libretro-beetle-pce-fast - Standalone port of Mednafen PCE Fast to libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759413 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 16:03:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759417] Review Request: libretro-nestopia - Nestopia emulator with libretro interface
https://bugzilla.redhat.com/show_bug.cgi?id=1759417 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 15:28:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759387] Review Request: libretro-handy - Atari Lynx emulator Handy for libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759387 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Robert-André Mauchin changed: What|Removed |Added Flags||fedora-review+ --- Comment #5 from Robert-André Mauchin --- Re-request now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review+ | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759387] Review Request: libretro-handy - Atari Lynx emulator Handy for libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759387 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libretro-handy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757673] Review Request: phoc - Display compositor designed for phones
https://bugzilla.redhat.com/show_bug.cgi?id=1757673
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #3 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v2.1 or later) GNU Lesser General
Public License (v2.1 or later)", "NTP License (legal disclaimer)". 62
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/phoc/review-phoc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #6 from Jun Aruga --- Sure, I did it now again. ``` $ fedpkg request-repo htslib 1759940 https://pagure.io/releng/fedora-scm-requests/issue/18061 ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759387] Review Request: libretro-handy - Atari Lynx emulator Handy for libretro
https://bugzilla.redhat.com/show_bug.cgi?id=1759387 Artem changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-09 16:28:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1747552] Review Request: libdfp - Decimal Floating Point library
https://bugzilla.redhat.com/show_bug.cgi?id=1747552
--- Comment #7 from Robert-André Mauchin ---
(In reply to Tulio Magno Quites Machado Filho from comment #6)
> (In reply to Robert-André Mauchin from comment #5)
> > You haven't addressed the follozwing:
> >
> > - Missing isa in %package devel
> >
> > Requires: %{name}%{?_isa} = %{version}-%{release}
>
> I can't find this line:
> $ git grep -En '^Requires:'
> libdfp.spec:41:Requires:%{name} = %{version}-%{release}
>
> What am I missing?
Line 41 Add %{?_isa} after %{name}
>
> > - It seems it should be:
> >
> > %prep
> > %autosetup -p1 -n %{name}-%{version}
> >
> >
> > - Not needed: %defattr(-,root,root,-) in %files devel
>
> Oops. Sorry. I fixed both issues now.
> I decided to drop -n completely because the current package from upstream
> conforms to the %{name}-%{version} as expected by RPM. Is that OK?
>
It's good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750179] Review Request: git-remote-gcrypt - GNU Privacy Guard-encrypted git remote
https://bugzilla.redhat.com/show_bug.cgi?id=1750179 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-10-09 16:52:51 --- Comment #12 from Fedora Update System --- git-remote-gcrypt-1.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Robert-André Mauchin changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com | |) | --- Comment #9 from Robert-André Mauchin --- (In reply to Jun Aruga from comment #8) > Thank you, Robert and Gwyn! > > Robert, I appreciate your continuous work. > Do you know why comment 4's "fedpkg request-repo" is failed, and you needed > to update "fedora-review+"? Because the Assignee was me and the person who set the fedora-review+ flag was Zbigniew Jędrzejewski-Szmek: both need to be the same in order to fedpkg request-repo to work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759715] Review Request: python-ffc - Compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=1759715 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- - AUTHORS should be in docs, not license DEBUG util.py:595: No matching package to install: 'python3dist(fenics-fiat) >= 2019.1' https://src.fedoraproject.org/rpms/python-fiat/pull-request/1 → You need to build https://src.fedoraproject.org/rpms/python-pytest-cases in Rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1735762] Review Request: fctxpd - This daemon adds FC network intelligence in host and host intelligence in FC network
https://bugzilla.redhat.com/show_bug.cgi?id=1735762 --- Comment #25 from Fedora Update System --- fctxpd-0.1-1.20190813gitc195e67.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1756901] Review Request: python-spdx - SPDX license list database
https://bugzilla.redhat.com/show_bug.cgi?id=1756901 --- Comment #8 from Fedora Update System --- python-spdx-2.5.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-aa51d4a2e7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1756906] Review Request: python-upt-fedora - Fedora backend for upt
https://bugzilla.redhat.com/show_bug.cgi?id=1756906 --- Comment #8 from Fedora Update System --- python-upt-fedora-0.3-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a2ebfe164 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1756905] Review Request: python-spdx-lookup - A tool to query the SPDX license list
https://bugzilla.redhat.com/show_bug.cgi?id=1756905 --- Comment #8 from Fedora Update System --- python-spdx-lookup-0.3.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0119828cfa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1756908] Review Request: python-upt-rubygems - RubyGems front-end for upt
https://bugzilla.redhat.com/show_bug.cgi?id=1756908 --- Comment #8 from Fedora Update System --- python-upt-rubygems-0.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0e2d342b89 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714001] Review Request: python-pyshark - Python packet parsing using wireshark dissectors
https://bugzilla.redhat.com/show_bug.cgi?id=1714001 --- Comment #9 from Fedora Update System --- python-pyshark-0.4.2.3-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b0d67ad9e6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750541] Review Request: python-json5 - A Python implementation of the JSON5 data format
https://bugzilla.redhat.com/show_bug.cgi?id=1750541 --- Comment #10 from Fedora Update System --- python-json5-0.8.5-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3a619bd1e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759206] Review Request: xpanes - Awesome tmux-based terminal divider
https://bugzilla.redhat.com/show_bug.cgi?id=1759206 --- Comment #8 from Fedora Update System --- xpanes-4.1.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c577a0f3cd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757675] Review Request: calls - Phone dialer and call handler
https://bugzilla.redhat.com/show_bug.cgi?id=1757675
--- Comment #3 from Robert-André Mauchin ---
- Don't own %{_datadir}/icons/hicolor, instead Requires: hicolor-icon-theme
and be more specific:
Requires: hicolor-icon-theme
[…]
%{_datadir}/icons/hicolor/*/apps/*.svg
- X11 → MIT
calls.x86_64: W: invalid-license X11
License:GPLv3+ and MIT
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GNU General Public
License (v3)", "GPL (v3 or later)", "NTP License (legal disclaimer)
GPL (v3 or later)", "NTP License (legal disclaimer)". 64 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/calls/review-calls/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor(wesnoth-data, autokey-common, system-config-
httpd, tuxanci, pdfmod, xchm, redeclipse, vacuum-im, freedroidrpg,
android-file-transfer, qmmp, massif-visualizer, nedit, qucs, fedora-
logos, qtl866, kgraphviewer, hicolor-icon-theme, mono-tools),
/usr/share/icons/hicolor/scalable(dxf2gcode, lxqt-powermanagement,
qucs, fedora-logos, eom, autokey-common, keepassx, massif-visualizer,
qtl866, tuxanci, hicolor-icon-theme, freedroidrpg, pdfmod, qmmp),
/usr/share/icons/hicolor/scalable/apps(dxf2gcode, qucs, fedora-logos,
eom, autokey-common, keepassx, massif-visualizer, qtl866, gtatool-gui,
tuxanci, hicolor-icon-theme, freedroidrpg, pdfmod, qmmp),
/usr/share/icons/hicolor/symbolic(hicolor-icon-theme),
/usr/share/icons/hicolor/symbolic/apps(hicolor-icon-theme)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]:
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Jun Aruga changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com ||) --- Comment #8 from Jun Aruga --- Thank you, Robert and Gwyn! Robert, I appreciate your continuous work. Do you know why comment 4's "fedpkg request-repo" is failed, and you needed to update "fedora-review+"? Now I am requesting the branches. ``` $ fedpkg request-branch --repo htslib f31 https://pagure.io/releng/fedora-scm-requests/issue/18062 $ fedpkg request-branch --repo htslib f30 https://pagure.io/releng/fedora-scm-requests/issue/18063 $ fedpkg request-branch --repo htslib f29 https://pagure.io/releng/fedora-scm-requests/issue/18064 ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1747552] Review Request: libdfp - Decimal Floating Point library
https://bugzilla.redhat.com/show_bug.cgi?id=1747552
--- Comment #6 from Tulio Magno Quites Machado Filho ---
(In reply to Robert-André Mauchin from comment #5)
> You haven't addressed the follozwing:
>
> - Missing isa in %package devel
>
> Requires: %{name}%{?_isa} = %{version}-%{release}
I can't find this line:
$ git grep -En '^Requires:'
libdfp.spec:41:Requires:%{name} = %{version}-%{release}
What am I missing?
> - It seems it should be:
>
> %prep
> %autosetup -p1 -n %{name}-%{version}
>
>
> - Not needed: %defattr(-,root,root,-) in %files devel
Oops. Sorry. I fixed both issues now.
I decided to drop -n completely because the current package from upstream
conforms to the %{name}-%{version} as expected by RPM. Is that OK?
Spec URL: https://pagure.io/libdfp/raw/master/f/libdfp.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tuliom/libdfp/fedora-31-ppc64le/01051662-libdfp/libdfp-1.0.14-6.fc31.src.rpm
Results of the tests are available at:
https://copr.fedorainfracloud.org/coprs/tuliom/libdfp/build/1051662/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758007] Review Request: octave-jnifti - Fast NIfTI-1/2 reader and NIfTI-to-JNIfTI converter for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758007 --- Comment #12 from Fedora Update System --- octave-jnifti-0.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7965616639 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1758626] Review Request: octave-iso2mesh - A 3D surface and volumetric mesh generator for MATLAB/Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1758626 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System --- octave-iso2mesh-1.9.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-79f3a89b27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1652588] Review Request: python-pytest-metadata - Pytest plugin that provides access to test session metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1652588 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- python-pytest-metadata-1.7.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-23ba87d561 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
