[Bug 1140495] New: Review Request: golang-github-kr-text - Go package for manipulating paragraphs of text
https://bugzilla.redhat.com/show_bug.cgi?id=1140495 Bug ID: 1140495 Summary: Review Request: golang-github-kr-text - Go package for manipulating paragraphs of text Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://lsm5.fedorapeople.org/golang-github-kr-text/golang-github-kr-text.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-kr-text/SRPMS/golang-github-kr-text-0-0.2.git6807e77.fc22.src.rpm Description: Go package for manipulating paragraphs of text Fedora Account System Username: lsm5 (thanks to Adam for initial packaging work) Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7566784 $ rpmlint golang-github-kr-text.spec SRPMS/golang-github-kr-text-0-0.2.git6807e77.fc22.src.rpm RPMS/noarch/golang-github-kr-text-devel-0-0.2.git6807e77.fc22.noarch.rpm golang-github-kr-text.spec:34: W: setup-not-quiet golang-github-kr-text.src:34: W: setup-not-quiet 2 packages and 1 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140403] Review Request: dreamchess - open source chess game
https://bugzilla.redhat.com/show_bug.cgi?id=1140403 Christian Dersch chrisder...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||chrisder...@gmail.com Assignee|nob...@fedoraproject.org|chrisder...@gmail.com Flags||fedora-review? --- Comment #2 from Christian Dersch chrisder...@gmail.com --- Taken :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120857] Review Request: golang-github-mreiferson-go-httpclient
https://bugzilla.redhat.com/show_bug.cgi?id=1120857 --- Comment #5 from Jan Chaloupka jchal...@redhat.com --- $ rpmlint golang-github-mreiferson-go-httpclient.spec golang-github-mreiferson-go-httpclient.spec:30: W: setup-not-quiet 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Patch + rpmlint warnings applied. Pull request created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1134912] Review Request: python-XStatic-JQuery-TableSorter - JQuery-TableSorter (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1134912 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1134912] Review Request: python-XStatic-JQuery-TableSorter - JQuery-TableSorter (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1134912 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-JQuery-TableSorter-2.14.5.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-XStatic-JQuery-TableSorter-2.14.5.1-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 Christian Dersch chrisder...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #25 from Christian Dersch chrisder...@gmail.com --- Taken, a detailed review will follow on friday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1134912] Review Request: python-XStatic-JQuery-TableSorter - JQuery-TableSorter (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1134912 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-JQuery-TableSorter-2.14.5.1-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-XStatic-JQuery-TableSorter-2.14.5.1-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1134912] Review Request: python-XStatic-JQuery-TableSorter - JQuery-TableSorter (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1134912 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-JQuery-TableSorter-2.14.5.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-XStatic-JQuery-TableSorter-2.14.5.1-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111691] Review Request: qore - multithreaded programming/scripting language
https://bugzilla.redhat.com/show_bug.cgi?id=691 Adam Williamson (Red Hat) awill...@redhat.com changed: What|Removed |Added CC||awill...@redhat.com --- Comment #33 from Adam Williamson (Red Hat) awill...@redhat.com --- I'm not a sponsor, but the package looks good to me, I see no errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140339] Review Request: virtme - Virtualize the running distro or a simple rootfs
https://bugzilla.redhat.com/show_bug.cgi?id=1140339 Yanko Kaneti yan...@declera.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||yan...@declera.com Assignee|nob...@fedoraproject.org|yan...@declera.com Flags||fedora-review+ --- Comment #2 from Yanko Kaneti yan...@declera.com --- Name matches Source matches License matches Doesn't clash with anything existing rpmlint errors already fixed in upstream master Builds in mock Works ok here. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111691] Review Request: qore - multithreaded programming/scripting language
https://bugzilla.redhat.com/show_bug.cgi?id=691 --- Comment #34 from David Nichols da...@qore.org --- (In reply to Adam Williamson (Red Hat) from comment #33) I'm not a sponsor, but the package looks good to me, I see no errors. thanks Adam, I appreciate you taking a look at it. If I understand correctly, I should email sponsors individually and ask them if they would care to sponsor this package and me as a maintainer, is that correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120865] Review Request: golang-github-BurntSushi-toml
https://bugzilla.redhat.com/show_bug.cgi?id=1120865 --- Comment #7 from Jan Chaloupka jchal...@redhat.com --- Pushed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120867] Review Request: golang-github-rcrowley-go-metrics-package
https://bugzilla.redhat.com/show_bug.cgi?id=1120867 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added CC||jchal...@redhat.com --- Comment #2 from Jan Chaloupka jchal...@redhat.com --- Applied, pull request created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120882] Review Request: golang-googlecode-gogoprotobuf
https://bugzilla.redhat.com/show_bug.cgi?id=1120882
Jan Chaloupka jchal...@redhat.com changed:
What|Removed |Added
CC||jchal...@redhat.com,
||walt...@redhat.com
Flags||needinfo?(walt...@redhat.co
||m)
--- Comment #5 from Jan Chaloupka jchal...@redhat.com ---
Hi, Colin,
from spec file:13
# I produced this tarball with git archive
Source0:%{name}-%{commit}.tar.gz
can you give a rationale for this? Eventually a sequence of commands used to
create this archive?
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140222] Review Request: perl-Scalar-Util-LooksLikeNumber - Access to looks_like_number() perl API function
https://bugzilla.redhat.com/show_bug.cgi?id=1140222 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Scalar-Util-LooksLikeNumber-1.39.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140222] Review Request: perl-Scalar-Util-LooksLikeNumber - Access to looks_like_number() perl API function
https://bugzilla.redhat.com/show_bug.cgi?id=1140222 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140222] Review Request: perl-Scalar-Util-LooksLikeNumber - Access to looks_like_number() perl API function
https://bugzilla.redhat.com/show_bug.cgi?id=1140222 --- Comment #5 from Petr Ĺ abata psab...@redhat.com --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135457] Review Request: python-XStatic-Rickshaw - Rickshaw (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1135457 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-Rickshaw-1.5.0.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-XStatic-Rickshaw-1.5.0.0-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135457] Review Request: python-XStatic-Rickshaw - Rickshaw (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1135457 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135457] Review Request: python-XStatic-Rickshaw - Rickshaw (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1135457 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-Rickshaw-1.5.0.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-XStatic-Rickshaw-1.5.0.0-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140002] Review Request: python-pymemcache - A comprehensive, fast, pure Python memcached client
https://bugzilla.redhat.com/show_bug.cgi?id=1140002 Nejc Saje ns...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-09-11 05:17:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1091479] Review Request: pam-kwallet - PAM module for KWallet
https://bugzilla.redhat.com/show_bug.cgi?id=1091479 Wei-Lun Chao blue...@member.fsf.org changed: What|Removed |Added CC||blue...@member.fsf.org --- Comment #10 from Wei-Lun Chao blue...@member.fsf.org --- Would pam_kwallet be a better package name? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135457] Review Request: python-XStatic-Rickshaw - Rickshaw (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1135457 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-Rickshaw-1.5.0.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-XStatic-Rickshaw-1.5.0.0-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140136] Review Request: python-tooz - Coordination library for distributed systems
https://bugzilla.redhat.com/show_bug.cgi?id=1140136 Bug 1140136 depends on bug 1140002, which changed state. Bug 1140002 Summary: Review Request: python-pymemcache - A comprehensive, fast, pure Python memcached client https://bugzilla.redhat.com/show_bug.cgi?id=1140002 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140577] New: Review Request: python-dill - Serialize all of Python
https://bugzilla.redhat.com/show_bug.cgi?id=1140577 Bug ID: 1140577 Summary: Review Request: python-dill - Serialize all of Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sergio.pa...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-dill.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-dill-0.2.1-1.fc20.src.rpm Description: Dill extends python's 'pickle' module for serializing and de-serializing python objects to the majority of the built-in python types. Dill provides the user the same interface as the 'pickle' module, and also includes some additional features. In addition to pickling python objects, dill provides the ability to save the state of an interpreter session in a single command. Fedora Account System Username: sergiopr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 494148] Review Request: soci - The database access library for C++ programmers
https://bugzilla.redhat.com/show_bug.cgi?id=494148 --- Comment #36 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Package Change Request == Package Name: soci New Branches: el7 Owners: denisarnaud -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 494148] Review Request: soci - The database access library for C++ programmers
https://bugzilla.redhat.com/show_bug.cgi?id=494148 Denis Arnaud denis.arnaud_fed...@m4x.org changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135933] Review Request: ghc-monads-tf - Monad classes using type families
https://bugzilla.redhat.com/show_bug.cgi?id=1135933
Ricky Elrod rel...@redhat.com changed:
What|Removed |Added
CC||rel...@redhat.com
Assignee|nob...@fedoraproject.org|rel...@redhat.com
Flags||fedora-review+
--- Comment #3 from Ricky Elrod rel...@redhat.com ---
Looks good to me. APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 962560 bytes in 100 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Haskell:
[x]: This should never happen
...and yet it did. ;)
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor,
[Bug 902086] Review request: Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=902086 --- Comment #47 from jiri vanek jva...@redhat.com --- In meantime, gil helepd, and improved (rewrite?) my terrible specfile to: https://jvanek.fedorapeople.org/elasticsearch/v1-gil-help/elasticsearch.spec with https://jvanek.fedorapeople.org/elasticsearch/v1-gil-help/elasticsearch-1.3.2-remove-sigar-service.patch Which was close to build, now when mustche is in, and his specfile do not need my terrible mycila nor forbidenapis packages. and worned me before, merge with my original one to honour remove %pom_remove_dep io.netty:netty and need to move %if 0 # Required netty == 3.9.1.Final BuildRequires: mvn(io.netty:netty) ... %endif to # Required netty == 3.9.1.Final BuildRequires: mvn(io.netty:netty) %if 0 # Required lucene == 4.9.0 BuildRequires: mvn(org.apache.lucene:lucene-analyzers-common) ... %endif and if is possible ElasticSearch should be ported for use netty 4.x series Which I somehow forgot, and changed his original package to try to work with netty 3.6 and lucene 4.10: https://jvanek.fedorapeople.org/elasticsearch/v2-stillStrange/elasticsearch.spec https://jvanek.fedorapeople.org/elasticsearch/v2-stillStrange/elasticsearch-1.3.2-1.fc20.src.rpm My final error was same as Gil's - no-op with lucene 4.10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902086] Review request: Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=902086 --- Comment #48 from jiri vanek jva...@redhat.com --- Created attachment 936517 -- https://bugzilla.redhat.com/attachment.cgi?id=936517action=edit gil's error log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902086] Review request: Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=902086 --- Comment #49 from jiri vanek jva...@redhat.com --- Created attachment 936518 -- https://bugzilla.redhat.com/attachment.cgi?id=936518action=edit jvanek's error log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902086] Review request: Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=902086 --- Comment #50 from jiri vanek jva...@redhat.com --- Later Gil noted also this: https://github.com/elasticsearch/elasticsearch/blob/master/pom.xml ES 2.0.0-SNAPSHOT use lucene 4.10.0. if you have intention to import this release, you should create a patch from here https://github.com/elasticsearch/elasticsearch/commit/223dab892144b0c8f9d073baf1598a1e3cdfa3ed So there is hope to patch this release, or move to the snapshot version. The second is probably better. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 494148] Review Request: soci - The database access library for C++ programmers
https://bugzilla.redhat.com/show_bug.cgi?id=494148 --- Comment #37 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 494148] Review Request: soci - The database access library for C++ programmers
https://bugzilla.redhat.com/show_bug.cgi?id=494148 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135151] Review Request: sbd - storage based death for Pacemaker clusters
https://bugzilla.redhat.com/show_bug.cgi?id=1135151 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135151] Review Request: sbd - storage based death for Pacemaker clusters
https://bugzilla.redhat.com/show_bug.cgi?id=1135151 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138971] Review Request: perl-Data-Faker - Perl extension for generating fake data
https://bugzilla.redhat.com/show_bug.cgi?id=1138971 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138971] Review Request: perl-Data-Faker - Perl extension for generating fake data
https://bugzilla.redhat.com/show_bug.cgi?id=1138971 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1139009] Review Request: perl-LV - Perl module to make lvalue subroutines easy and practical
https://bugzilla.redhat.com/show_bug.cgi?id=1139009 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1139009] Review Request: perl-LV - Perl module to make lvalue subroutines easy and practical
https://bugzilla.redhat.com/show_bug.cgi?id=1139009 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 Paul Flo Williams p...@frixxon.co.uk changed: What|Removed |Added CC||p...@frixxon.co.uk --- Comment #4 from Paul Flo Williams p...@frixxon.co.uk --- If your sources are several separate files, you aren't required to create an archive; just list them as separate sources. I can see a link to download a zip or tar.gz for each revision, right there on the site. You don't have to use every file in an archive. However, for some reason, the appropriate link for your revision: https://googlefontdirectory.googlecode.com/archive/716ff965e2b03e682f7f2c1010fdf03ef2f433ae.tar.gz is currently returning a 403 error, and so are other revisions, so I'll raise that as an issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321 --- Comment #5 from Paul Flo Williams p...@frixxon.co.uk --- Ah, I'm guessing that the download archive links would, if they were working, download an archive of every font at once, so we don't want that. I'd use Source0, Source1, etc. That way, you can at least provide full persistent URLs for each resource. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140403] Review Request: dreamchess - open source chess game
https://bugzilla.redhat.com/show_bug.cgi?id=1140403 --- Comment #3 from Raphael Groner projects...@smart.ms --- From the homepage: A moderately strong chess engine is included: Dreamer. However, should this engine be too weak for you, then you can use any other XBoard-compatible chess engine, including the popular Crafty and GNU Chess. Cause of that I am thinking about moving dreamer binary and manpage into separate subpackage(s). An user could use dreamchess with GNU chess only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103554] Review Request: cppcms - a Free High Performance Web Development Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1103554 --- Comment #26 from Raphael Groner projects...@smart.ms --- The changelog is not in sync with the actual release no. Thanks to rpmdev-bumpspec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber
https://bugzilla.redhat.com/show_bug.cgi?id=1138321
--- Comment #6 from Parag AN(पराग) panem...@gmail.com ---
right I was about to say the same. I thought there is some source archive
download link I am missing but its not there and also font file in a archive is
not downloadable.
Where there is a single font its simple to pick its download link as Source0
and if there is license also available for direct download use it as Source1
so for this package it will be
Source0:
https://googlefontdirectory.googlecode.com/hg/ofl/reeniebeanie/ReenieBeanie.ttf
Source1:
https://googlefontdirectory.googlecode.com/hg/ofl/reeniebeanie/OFL.txt
Now the only problem remains how to identify its uniqueness. Generally we use
date in release tag. you should follow pre-release snapshot naming guidelines
as given on
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
so you should use release tag as
0.%{X}.%{alphatag} = 0.1.20140911hg
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1091479] Review Request: pam-kwallet - PAM module for KWallet
https://bugzilla.redhat.com/show_bug.cgi?id=1091479 --- Comment #11 from Rex Dieter rdie...@math.unl.edu --- Maybe a little, but I don't think that's significant enough to warrant renaming things now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883125] Review Request: bannergrab - A banner grabbing tool
https://bugzilla.redhat.com/show_bug.cgi?id=883125 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: bannergrab New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
https://bugzilla.redhat.com/show_bug.cgi?id=478628 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: dhcping New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478398] Review Request: httping - Ping alike tool for http requests
https://bugzilla.redhat.com/show_bug.cgi?id=478398 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #13 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: httping New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648679] Review Request: jabber-roster - A Python tool for listing your Jabber roster contacts
https://bugzilla.redhat.com/show_bug.cgi?id=648679 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: jabber-roster New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885291] Review Request: netsed - A tool to modify network packets
https://bugzilla.redhat.com/show_bug.cgi?id=885291 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: netsed New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870725] Review Request: sucrack - A su cracker
https://bugzilla.redhat.com/show_bug.cgi?id=870725 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #8 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: sucrack New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469527] Review Request: tcping - Check of TCP connection to a given IP/Port
https://bugzilla.redhat.com/show_bug.cgi?id=469527 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #19 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: tcping New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070171] Review Request: tlssled - An evaluation tool for SSL/TLS (HTTPS) web server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1070171 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: tlssled New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498805] Review Request: wavemon - Ncurses-based monitoring application for wireless network devices
https://bugzilla.redhat.com/show_bug.cgi?id=498805 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #21 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: wavemon New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1134912] Review Request: python-XStatic-JQuery-TableSorter - JQuery-TableSorter (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1134912 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-JQuery-TableSorter-2.14.5.1-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135457] Review Request: python-XStatic-Rickshaw - Rickshaw (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1135457 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-Rickshaw-1.5.0.0-3.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140577] Review Request: python-dill - Serialize all of Python
https://bugzilla.redhat.com/show_bug.cgi?id=1140577 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #1 from Jerry James loganje...@gmail.com --- I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
https://bugzilla.redhat.com/show_bug.cgi?id=477854 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #13 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: yersinia New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 481416] Review Request: viking - GPS data editor and analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=481416 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: viking New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
https://bugzilla.redhat.com/show_bug.cgi?id=477854 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 477854] Review Request: yersinia - Network protocols tester and attacker
https://bugzilla.redhat.com/show_bug.cgi?id=477854 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469527] Review Request: tcping - Check of TCP connection to a given IP/Port
https://bugzilla.redhat.com/show_bug.cgi?id=469527 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478398] Review Request: httping - Ping alike tool for http requests
https://bugzilla.redhat.com/show_bug.cgi?id=478398 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478398] Review Request: httping - Ping alike tool for http requests
https://bugzilla.redhat.com/show_bug.cgi?id=478398 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469527] Review Request: tcping - Check of TCP connection to a given IP/Port
https://bugzilla.redhat.com/show_bug.cgi?id=469527 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
https://bugzilla.redhat.com/show_bug.cgi?id=478628 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478628] Review Request: dhcping - DHCP daemon ping program
https://bugzilla.redhat.com/show_bug.cgi?id=478628 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498805] Review Request: wavemon - Ncurses-based monitoring application for wireless network devices
https://bugzilla.redhat.com/show_bug.cgi?id=498805 --- Comment #22 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648679] Review Request: jabber-roster - A Python tool for listing your Jabber roster contacts
https://bugzilla.redhat.com/show_bug.cgi?id=648679 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 481416] Review Request: viking - GPS data editor and analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=481416 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498805] Review Request: wavemon - Ncurses-based monitoring application for wireless network devices
https://bugzilla.redhat.com/show_bug.cgi?id=498805 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648679] Review Request: jabber-roster - A Python tool for listing your Jabber roster contacts
https://bugzilla.redhat.com/show_bug.cgi?id=648679 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 481416] Review Request: viking - GPS data editor and analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=481416 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870725] Review Request: sucrack - A su cracker
https://bugzilla.redhat.com/show_bug.cgi?id=870725 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 870725] Review Request: sucrack - A su cracker
https://bugzilla.redhat.com/show_bug.cgi?id=870725 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883125] Review Request: bannergrab - A banner grabbing tool
https://bugzilla.redhat.com/show_bug.cgi?id=883125 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883125] Review Request: bannergrab - A banner grabbing tool
https://bugzilla.redhat.com/show_bug.cgi?id=883125 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885291] Review Request: netsed - A tool to modify network packets
https://bugzilla.redhat.com/show_bug.cgi?id=885291 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070171] Review Request: tlssled - An evaluation tool for SSL/TLS (HTTPS) web server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1070171 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885291] Review Request: netsed - A tool to modify network packets
https://bugzilla.redhat.com/show_bug.cgi?id=885291 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070171] Review Request: tlssled - An evaluation tool for SSL/TLS (HTTPS) web server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1070171 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1132971] Review Request: python-pyvmomi - pyVmomi is the Python SDK for the VMware vSphere API that allows you to manage ESX, ESXi, and vCenter
https://bugzilla.redhat.com/show_bug.cgi?id=1132971
--- Comment #10 from Matthew Booth mbo...@redhat.com ---
Very nice. I've re-reviewed and there are no longer any blockers. My sponsor
status seems to be in limbo right now, which I'm chasing, but as soon as that's
cleared up I'll approve this.
I still have a couple of non-blocking recommendations:
This doesn't need to be in there, as the package is noarch:
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib(1)))}
You could simplify %files somewhat with:
%{python_sitelib}/*
in place of:
%{python_sitelib}/*.egg-info
%dir %{python_sitelib}/pyVmomi
%dir %{python_sitelib}/pyVim
%{python_sitelib}/pyVmomi/*
%{python_sitelib}/pyVim/*
(and the same for python3). These are equivalent in this package.
I haven't seen this incantation before:
%{!?_licensedir:%global license %%doc}
but it looks kosher. It's clearly defined, as the license is installed to
/usr/share/licenses, and for the same reason I assume that the warning about
that directory not being packaged is bogus. However, you don't need to define
it twice, which you are currently doing. You could move the declaration up to
the top and remove it from both %files sections.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950171] Review Request: librecad - Computer Assisted Design (CAD) Application
https://bugzilla.redhat.com/show_bug.cgi?id=950171 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- librecad-2.0.5-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/librecad-2.0.5-2.el7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950171] Review Request: librecad - Computer Assisted Design (CAD) Application
https://bugzilla.redhat.com/show_bug.cgi?id=950171 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- librecad-2.0.5-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/librecad-2.0.5-2.fc21 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950171] Review Request: librecad - Computer Assisted Design (CAD) Application
https://bugzilla.redhat.com/show_bug.cgi?id=950171 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- librecad-2.0.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/librecad-2.0.5-2.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 950171] Review Request: librecad - Computer Assisted Design (CAD) Application
https://bugzilla.redhat.com/show_bug.cgi?id=950171 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- librecad-2.0.5-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/librecad-2.0.5-2.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140577] Review Request: python-dill - Serialize all of Python
https://bugzilla.redhat.com/show_bug.cgi?id=1140577
--- Comment #2 from Jerry James loganje...@gmail.com ---
I only see a few issues with this package, none a MUST.
1. Please use the new %license tag; i.e., change this:
%doc LICENSE README
to this:
%license LICENSE
%doc README
2. Consider adding a %check section. It could look like this:
%check
export PYTHONPATH=%{buildroot}%{python2_sitelib}
for test in tests/test_*
do
%{__python2} $test
done
%if 0%{?with_python3}
pushd %{py3dir}
PYTHONPATH=%{buildroot}%{python3_sitelib}
for test in tests/test_*
do
%{__python3} $test
done
popd
%endif # with_python3
This will also require some new BRs, namely numpy and python3-numpy. In
fact, doing that shows that there are several types, differing between
python 2 and python 3, that are not pickled correctly. Unfortunately, the
%check step succeeds in spite of the pickling errors.
3. Finally, what is the rationale for not packaging the tools in %{_bindir}?
If there are any conceivable users of the tools, perhaps they could be
packaged in a -tools subpackage. If they are definitely not useful for the
general public, then what you have already done is fine, of course.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully
[Bug 1140324] Review Request: pjproject - Libraries for building VoIP applications
https://bugzilla.redhat.com/show_bug.cgi?id=1140324 --- Comment #6 from Kevin Kofler ke...@tigcc.ticalc.org --- Yes, that's fine to delete in %prep (as you're already doing) then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1111691] Review Request: qore - multithreaded programming/scripting language
https://bugzilla.redhat.com/show_bug.cgi?id=691 --- Comment #35 from Adam Williamson (Red Hat) awill...@redhat.com --- that would be a good way to try and find one, yeah - maybe look at their packages / reviews and see if you can find one who's interested in this general area of work. You could also ping folks on IRC. sorry for the delay in getting this approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140339] Review Request: virtme - Virtualize the running distro or a simple rootfs
https://bugzilla.redhat.com/show_bug.cgi?id=1140339 Andy Lutomirski l...@mit.edu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Andy Lutomirski l...@mit.edu --- New Package SCM Request === Package Name: virtme Short Description: Virtualize the running distro or a simple rootfs Upstream URL: https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git/ Owners: amluto Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582974] Review Request: dnsenum - DNSenum is a penetration testing tool created to enumerate DNS info about domains
https://bugzilla.redhat.com/show_bug.cgi?id=582974 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added CC||m...@fabian-affolter.ch Flags|fedora-cvs+ |fedora-cvs? --- Comment #21 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: dnsenum New Branches: el6 epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140403] Review Request: dreamchess - open source chess game
https://bugzilla.redhat.com/show_bug.cgi?id=1140403
--- Comment #4 from Christian Dersch chrisder...@gmail.com ---
First review done. There are some things to fix, have a look at the review
below ;)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
== You can remove rm -rf $RPM_BUILD_ROOT for current Fedora releases (but
required for EPEL5)
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (3 clause), GPL (v2 or later), GPL (v3 or later), Unknown or
generated. 4 files have unknown license. Detailed output of licensecheck
in /home/review/1140403-dreamchess/licensecheck.txt
== Please check this, licensecheck.txt is below, but BSD license is also
mentioned in COPYRIGHT file
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/dreamchess
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/dreamchess
== Please check this
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 5 files.
[!]: Package complies to the Packaging Guidelines
== You are packaging RC1, not the final version! Please add this information
in release tag
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and
[Bug 1119004] Review Request: python-characteristic - Say 'yes' to types but 'no' to typing!
https://bugzilla.redhat.com/show_bug.cgi?id=1119004 --- Comment #4 from Tom Prince tom.pri...@ualberta.net --- Spect URL: http://data.hybridcluster.net/fedora-scratch/python-characteristic.spec SRPM URL:http://data.hybridcluster.net/fedora-scratch/python-characteristic-14.1.0-1.fc20.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=7568684 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474737] Review Request: irclog2html - Script to convert IRC logs to HTML and other formats
https://bugzilla.redhat.com/show_bug.cgi?id=474737 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added CC||m...@fabian-affolter.ch Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: irclog2html New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883512] Review Request: libforensic1394 - A library for performing live memory forensics over firewire
https://bugzilla.redhat.com/show_bug.cgi?id=883512 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #24 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: libforensic1394 New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 883514] Review Request: inception - A fireWire physical memory manipulation tool
https://bugzilla.redhat.com/show_bug.cgi?id=883514 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #16 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: inception New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 496677] Review Request: nfoview - Viewer for NFO files
https://bugzilla.redhat.com/show_bug.cgi?id=496677 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #24 from Fabian Affolter m...@fabian-affolter.ch --- Package Change Request == Package Name: nfoview New Branches: epel7 Owners: fab InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1140324] Review Request: pjproject - Libraries for building VoIP applications
https://bugzilla.redhat.com/show_bug.cgi?id=1140324 Raphael Groner projects...@smart.ms changed: What|Removed |Added CC||projects...@smart.ms --- Comment #7 from Raphael Groner projects...@smart.ms --- Is there a package that will depend on pjproject? Otherwise what example / application could be used to test the library? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474737] Review Request: irclog2html - Script to convert IRC logs to HTML and other formats
https://bugzilla.redhat.com/show_bug.cgi?id=474737 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
