[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #5 from Björn "besser82" Esser  ---
Thank you for the review!  =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-02 23:50:30



--- Comment #11 from Fedora Update System  ---
python-filelock-2.0.6-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-02 23:50:25



--- Comment #6 from Fedora Update System  ---
gap-pkg-lpres-0.3.1-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378028] Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378028
Bug 1378028 depends on bug 1378014, which changed state.

Bug 1378014 Summary: Review Request: perl-IO-FDPass - Pass a file descriptor 
over a socket
https://bugzilla.redhat.com/show_bug.cgi?id=1378014

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-02 23:50:20



--- Comment #11 from Fedora Update System  ---
perl-IO-FDPass-1.1-3.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373666] Review Request: hddfancontrol - Control system fan speed by monitoring hard drive temperature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373666

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-02 23:50:18



--- Comment #5 from Fedora Update System  ---
hddfancontrol-1.2.4-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327981



--- Comment #8 from Mukundan Ragavan  ---
I can review this if Zbigniew does not object ..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379096



--- Comment #4 from Mukundan Ragavan  ---
Thank you very much for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379174



--- Comment #2 from Mukundan Ragavan  ---

Please see detailed comments below.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1379174-vmod-
  querystring/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL


---> Source tarball should be the same as upstream. Please see checksums below.


- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


---> No license installed. Source tarball includes license file. Please use
%license macro to install license.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or
 generated". 14 files have unknown license. Detailed output of
 licensecheck in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1379174
 -vmod-querystring/licensecheck.txt

GPL (v3 or later)
-
vmod-querystring-1.0.1/LICENSE
vmod-querystring-1.0.1/debian/copyright
vmod-querystring-1.0.1/src/vmod_querystring.c

MIT/X11 (BSD like)
--
vmod-querystring-1.0.1/build-aux/install-sh

Unknown or generated

vmod-querystring-1.0.1/CHANGELOG
vmod-querystring-1.0.1/CONTRIBUTORS
vmod-querystring-1.0.1/build-aux/ar-lib
vmod-querystring-1.0.1/build-aux/compile
vmod-querystring-1.0.1/build-aux/depcomp
vmod-querystring-1.0.1/build-aux/ltmain.sh
vmod-querystring-1.0.1/build-aux/missing
vmod-querystring-1.0.1/build-aux/test-driver
vmod-querystring-1.0.1/configure
vmod-querystring-1.0.1/debian/changelog
vmod-querystring-1.0.1/debian/compat
vmod-querystring-1.0.1/debian/control
vmod-querystring-1.0.1/debian/rules
vmod-querystring-1.0.1/debian/source/format

---> GPLv3+ is correct license for installed binary.


GPL (v3 or later)
-
vmod-querystring-1.0.1/LICENSE
vmod-querystring-1.0.1/debian/copyright
vmod-querystring-1.0.1/src/vmod_querystring.c

MIT/X11 (BSD like)
--
vmod-querystring-1.0.1/build-aux/install-sh

Unknown or generated

vmod-querystring-1.0.1/CHANGELOG
vmod-querystring-1.0.1/CONTRIBUTORS
vmod-querystring-1.0.1/build-aux/ar-lib
vmod-querystring-1.0.1/build-aux/compile
vmod-querystring-1.0.1/build-aux/depcomp
vmod-querystring-1.0.1/build-aux/ltmain.sh
vmod-querystring-1.0.1/build-aux/missing
vmod-querystring-1.0.1/build-aux/test-driver
vmod-querystring-1.0.1/configure
vmod-querystring-1.0.1/debian/changelog
vmod-querystring-1.0.1/debian/compat
vmod-querystring-1.0.1/debian/control
vmod-querystring-1.0.1/debian/rules
vmod-querystring-1.0.1/debian/source/format

These files can be ignored.


[!]: License file installed when any subpackage combination is installed.

---> This needs to be fixed.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to 

[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379096

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379174

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||nonamed...@gmail.com
   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379095
Bug 1379095 depends on bug 1379094, which changed state.

Bug 1379094 Summary: Review Request: python-flit - Simplified packaging of 
Python modules
https://bugzilla.redhat.com/show_bug.cgi?id=1379094

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379094] Review Request: python-flit - Simplified packaging of Python modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379094

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-02 20:09:24



--- Comment #15 from Mukundan Ragavan  ---
built on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379093] Review Request: python-pickleshare - Tiny 'shelve' -like database with concurrency support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379093

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-02 20:08:49



--- Comment #7 from Mukundan Ragavan  ---
built on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-02 20:08:19



--- Comment #10 from Mukundan Ragavan  ---
built on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-02 20:07:54



--- Comment #16 from Mukundan Ragavan  ---
built on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379096



--- Comment #3 from Mukundan Ragavan  ---
1/ Fixed license

2/ Fixed rpmlint messages

3/ bundling - 

bootstrap is not bundled here. No other library is bundled with nbconvert.

The css file included is based on this -
https://github.com/necolas/normalize.css/blob/master/normalize.css

and greatly extended.


Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-nbconvert/python-nbconvert.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-nbconvert/python-nbconvert-4.2.0-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379095



--- Comment #7 from Mukundan Ragavan  ---
(In reply to gil cattaneo from comment #6)
> is not enough add a single %files -n python-%{srcname}-doc package ?

True! I will fix this before import.

Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379095

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from gil cattaneo  ---
is not enough add a single %files -n python-%{srcname}-doc package ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379095



--- Comment #5 from Mukundan Ragavan  ---
1/ Source URL fixed.

2/ -doc subpackage added.

3/ license clarification issue opened upstream and link added to spec.
https://github.com/takluyver/entrypoints/issues/10



Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-entrypoints/python-entrypoints.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-entrypoints/python-entrypoints-0.2.2-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087

Sergio Pascual  changed:

   What|Removed |Added

 Blocks||1379686




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1379686
[Bug 1379686] pandas.io.data is deprecated
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381087] New: Review Request: python-pandas-datareader - Data readers from the pandas codebase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381087

Bug ID: 1381087
   Summary: Review Request: python-pandas-datareader  - Data
readers from the pandas codebase
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sergio.pa...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://guaix.fis.ucm.es/~spr/fedora/python-pandas-datareader.spec
SRPM URL:
https://guaix.fis.ucm.es/~spr/fedora/python-pandas-datareader-0.2.1-1.fc24.src.rpm
Description: Data readers extracted from the pandas codebase, should be
compatible with recent pandas versions.
Fedora Account System Username: sergiopr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #27 from Fedora Update System  ---
libXfont2-2.0.1-2.fc25, xorg-x11-drivers-7.7-18.fc25,
xorg-x11-drv-amdgpu-1.1.2-3.20160929git97d7386c.fc25,
xorg-x11-drv-armsoc-1.4.0-3.20160929.fc25,
xorg-x11-drv-ati-7.7.1-1.20160928git3fc839ff.fc25,
xorg-x11-drv-dummy-0.3.6-26.fc25, xorg-x11-drv-evdev-2.10.3-2.fc25,
xorg-x11-drv-fbdev-0.4.3-25.fc25, xorg-x11-drv-fbturbo-0.5.1-0.8.20150221.fc25,
xorg-x11-drv-freedreno-1.4.0-3.20160929.fc25,
xorg-x11-drv-geode-2.11.18-2.fc25,
xorg-x11-drv-intel-2.99.917-26.20160929.fc25,
xorg-x11-drv-ivtv-1.2.0-0.22.fc25,
xorg-x11-drv-libinput-0.19.1-2.20160929.fc25,
xorg-x11-drv-nouveau-1.0.13-1.fc25, xorg-x11-drv-omap-0.4.4-3.fc25,
xorg-x11-drv-openchrome-0.5.0-2.fc25, xorg-x11-drv-opentegra-0.7.0-8.fc25,
xorg-x11-drv-qxl-0.1.4-9.20160929gite13d28ee.fc25,
xorg-x11-drv-sisusb-0.9.6-24.fc25,
xorg-x11-drv-synaptics-1.8.99.1-2.20160929git48632211.fc25,
xorg-x11-drv-v4l-0.2.0-47.fc25, xorg-x11-drv-vesa-2.3.2-25.fc25,
xorg-x11-drv-vmware-13.0.2-12.20150211git8f0cf7c.fc25,
xorg-x11-drv-voodoo-1.2.5-25.fc25,
xorg-x11-drv-wacom-0.33.0-2.20160929gitb61d1711.fc25,
xorg-x11-font-utils-7.5-32.fc25, xorg-x11-proto-devel-7.7-20.fc25,
xorg-x11-server-1.19.0-0.1.20160929.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5c3ebe67a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #10 from Scott K Logan  ---
Thanks, Tuomo. I'll have that fixed ASAP.

--scott

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #5 from Christoph Junghans  ---
(In reply to Dridi Boukelmoune from comment #4)
> > > URL:  http://libslz.org/
> > Seems to be dead?
> 
> Quite the opposite, the web site isn't born yet. Upstream's working on it
> but I put it ahead of time. This is not a widely used project, although it
> will have its use in Fedora and EPEL with haproxy. I plan to open a bug for
> that next.
I would prefer a url, which works now. You can always change in the next
release.

> 
> If that's a problem, I'll change the URL and update once it's ready.
> 
> > > Source:   libslz-1.1.0.tar.gz
> > Fix url
> When I initially submitted this package, archives generated from upstream's
> git-web were non-deterministic and would conflict with our tooling.
> 
> Also, once libslz.org is up, source tarball should be published just like I
> did: a `%{name}-%{version}.tar.gz` archive containing the source tree inside
> a `%{name}-%{version}/` directory.
Actually URL
http://git.1wt.eu/web?p=%{name}.git;a=snapshot;h=v%{version};sf=tgz#/%{name}-%{version}.tar.gz
will work with
%setup -q -n %{name}

> 
> > Are there any consumers of the static libs, which cannot use shared? 
> > Otherwise drop.
> 
> Although I'm against bundling in general, I don't see a reason not to ship
> the static lib in the devel subpackage. I actually asked haproxy's author
> (same author) not to expect a static libslz when building against it when we
> were working on making libslz package-able (there used to be no shared lib).
The guideline says "In general, packagers are strongly encouraged not to ship
static libs unless a compelling reason exists.", so drop it if haproxy works
with shared libs.

> 
> I will submit a new spec tomorrow, thanks for reviewing!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942



--- Comment #3 from gil cattaneo  ---
Maybe could work:

- return ((XmlPage) page).getContent(); 
+ return ((SgmlPage) page).getWebResponse().getContentAsString();

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #2 from gil cattaneo  ---
(In reply to Raphael Groner from comment #1)
> FTBFS with htmlunit 2.23 as currently in rawhide, but builds with htmlunit
> 2.20 as in Fedora 25.
> 
> https://github.com/JWebUnit/jwebunit/issues/4
> 
> Fedora 25: http://koji.fedoraproject.org/koji/taskinfo?taskID=15896976
> There are errors 505 Service unavailable. Though, local mock works.

Deprecated: method getContent()
location: class com.gargoylesoftware.htmlunit.xml.XmlPage
as of 2.18, please use
com.gargoylesoftware.htmlunit.SgmlPage.getWebResponse().getContentAsString()

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 969271] Review Request: cometd - A scalable HTTP-based event routing bus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=969271



--- Comment #9 from gil cattaneo  ---
(In reply to Raphael Groner from comment #8)
> Please, take some time to look into bug #1380942.

Please stop, i dont care now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202231] Review Request: jbehave - Behavior-Driven Development framework for Java and Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202231



--- Comment #10 from gil cattaneo  ---
(In reply to Raphael Groner from comment #9)
> FTBFS
> 
> Start: build setup for jbehave-3.9.5-1.fc20.src.rpm
> ERROR:
> Exception(/home/builder/fedora-review/1202231-jbehave/srpm/jbehave-3.9.5-1.
> fc20.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 30 seconds
> INFO: Results and/or logs in:
> /home/builder/fedora-review/1202231-jbehave/results
> ERROR: Command failed: 
>  # /usr/bin/dnf builddep --installroot
> /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 26
> /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/jbehave-3.9.5-
> 1.fc26.src.rpm --setopt=tsflags=nocontexts
> Last metadata expiration check: 0:00:19 ago on Sun Oct  2 21:55:12 2016.
> No matching package to install: 'mvn(com.sun.jersey:jersey-client)'
> Not all dependencies satisfied
> Error: Some packages could not be found.

Please stop, i dont care now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202231] Review Request: jbehave - Behavior-Driven Development framework for Java and Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202231

gil cattaneo  changed:

   What|Removed |Added

   Assignee|projects...@smart.ms|nob...@fedoraproject.org
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517

Raphael Groner  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|projects...@smart.ms
 Whiteboard|AwaitingSubmitter   |
  Flags||fedora-review?



--- Comment #7 from Raphael Groner  ---
I can look into a full review later. Are you interested in a review swap?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202231] Review Request: jbehave - Behavior-Driven Development framework for Java and Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202231



--- Comment #9 from Raphael Groner  ---
FTBFS

Start: build setup for jbehave-3.9.5-1.fc20.src.rpm
ERROR:
Exception(/home/builder/fedora-review/1202231-jbehave/srpm/jbehave-3.9.5-1.fc20.src.rpm)
Config(fedora-rawhide-x86_64) 0 minutes 30 seconds
INFO: Results and/or logs in:
/home/builder/fedora-review/1202231-jbehave/results
ERROR: Command failed: 
 # /usr/bin/dnf builddep --installroot
/var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 26
/var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/jbehave-3.9.5-1.fc26.src.rpm
--setopt=tsflags=nocontexts
Last metadata expiration check: 0:00:19 ago on Sun Oct  2 21:55:12 2016.
No matching package to install: 'mvn(com.sun.jersey:jersey-client)'
Not all dependencies satisfied
Error: Some packages could not be found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361632] Review Request: python-blowfish - Fast, efficient Blowfish cipher implementation in pure Python (3.4+)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361632

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags||fedora-review+



--- Comment #9 from Raphael Groner  ---
As of results in comment #5, I'll approve here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1227981] Review Request: budget - Your own personal financial assistant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227981

Raphael Groner  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #10 from Raphael Groner  ---
Another friendly ping.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364805

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||xsk...@gmail.com
  Flags||needinfo?(xsk...@gmail.com)



--- Comment #3 from Raphael Groner  ---
Hi Daniel,
thanks for your interest in this package. Can you continue with the review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366713

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #17 from Raphael Groner  ---
Can we close here? Packages are available as of now in Rawhide and EPEL7. Maybe
you can also build a package for F25, as you requested the branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 969271] Review Request: cometd - A scalable HTTP-based event routing bus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=969271



--- Comment #8 from Raphael Groner  ---
Please, take some time to look into bug #1380942.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202231] Review Request: jbehave - Behavior-Driven Development framework for Java and Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202231

Raphael Groner  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #8 from Raphael Groner  ---
Okay, just send the package request to can import tempus-fugit and add me as
co-maintainer, please.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #4 from Dridi Boukelmoune  ---
> > URL:http://libslz.org/
> Seems to be dead?

Quite the opposite, the web site isn't born yet. Upstream's working on it but I
put it ahead of time. This is not a widely used project, although it will have
its use in Fedora and EPEL with haproxy. I plan to open a bug for that next.

If that's a problem, I'll change the URL and update once it's ready.

> > Source: libslz-1.1.0.tar.gz
> Fix url

When I initially submitted this package, archives generated from upstream's
git-web were non-deterministic and would conflict with our tooling.

Also, once libslz.org is up, source tarball should be published just like I
did: a `%{name}-%{version}.tar.gz` archive containing the source tree inside a
`%{name}-%{version}/` directory.

> Are there any consumers of the static libs, which cannot use shared? 
> Otherwise drop.

Although I'm against bundling in general, I don't see a reason not to ship the
static lib in the devel subpackage. I actually asked haproxy's author (same
author) not to expect a static libslz when building against it when we were
working on making libslz package-able (there used to be no shared lib).

I will submit a new spec tomorrow, thanks for reviewing!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #3 from Christoph Junghans  ---
> make %{?_smp_mflags} CFLAGS="%{optflags}"
%make_build CFLAGS="%{optflags}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #2 from Christoph Junghans  ---
> URL:  http://libslz.org/
Seems to be dead? http://1wt.eu/projects/libslz/
> Source:   libslz-1.1.0.tar.gz
Fix url
http://git.1wt.eu/web?p=libslz.git;a=snapshot;h=afa04ae1f976957cf36287cc5370998d0559bc63;sf=tgz#/libslz-1.1.0.tar.gz

> %doc README LICENSE
%doc README
%license LICENSE

Are there any consumers of the static libs, which cannot use shared? Otherwise
drop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165

Christoph Junghans  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jungh...@votca.org
   Assignee|nob...@fedoraproject.org|jungh...@votca.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #10 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.206-1.fc24.src.rpm

%changelog
* Sun Oct 02 2016 Martin Gansser  - 0.9.206-1
* Update to 0.9.206

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381029] New: Review Request: more-itertools - Python library for efficient use of itertools utility in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381029

Bug ID: 1381029
   Summary: Review Request: more-itertools - Python library for
efficient use of itertools utility in python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: itsme_...@yahoo.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.public.iastate.edu/~maitra/Fedora/more-itertools.spec
SRPM URL:
http://www.public.iastate.edu/~maitra/Fedora/more-itertools-2.2-1.fc24.src.rpm
Description: more-itertools is the opensource python library that wraps around
itertools. The package also includes implementations of the recipes from the
itertools documentation. 

Please see https://pythonhosted.org/more-itertools/index.html for
documentation.

Fedora Account System Username: aarem

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378807] Review Request: mingw-podofo - MinGW Windows podofo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378807

Pavel Alexeev  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Pavel Alexeev  ---
At least there maillist - https://sourceforge.net/p/podofo/mailman/ and I
encourage you sent mail about FSF address.

Meantime it is minor "should" issue. Other seems good.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org