[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290342

Tomas Repik  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Tomas Repik  ---
Thanks you did a good job!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396748] Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748



--- Comment #10 from Fedora Update System  ---
mingw-openal-soft-1.17.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1323214] Review Request: git-evtag - Strong GPG verification of git tags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323214

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-28 02:25:13



--- Comment #14 from Fedora Update System  ---
git-evtag-2016.1-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #16 from Fedora Update System  ---
python-wcsaxes-0.9-3.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969



--- Comment #11 from Fedora Update System  ---
python-pluginbase-0.5-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949



--- Comment #3 from MartinKG  ---
(In reply to Jeremy Newton from comment #1)

> 
> Some comments:
> - I would remove "Conflicts:  wxGTK3-devel"

the build fails if wxGTK3-devel is installed !

/home/martin/rpmbuild/BUILD/bear-ac6be8bebf35cd1a4d4151773707c9ee313b154e/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:102:45:
error: 'virtual bool wxEvtHandler::ProcessEvent(wxEvent&)' is inaccessible
within this context
   m_event_handler.ProcessEvent( command );
 ^
In file included from /usr/include/wx-3.0/wx/window.h:18:0,
 from
/home/martin/rpmbuild/BUILD/bear-ac6be8bebf35cd1a4d4151773707c9ee313b154e/bear-factory/bear-editor/src/bf/../bf/accelerator_table.hpp:19,
 from
/home/martin/rpmbuild/BUILD/bear-ac6be8bebf35cd1a4d4151773707c9ee313b154e/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:14:
/usr/include/wx-3.0/wx/event.h:3355:18: note: declared here
 virtual bool ProcessEvent(wxEvent& event);
  ^~~~
bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/build.make:65:
recipe for target
'bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o'
failed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376932] Review Request: python3-markupsafe - Implements a XML/HTML/ XHTML Markup safe string for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376932

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-28 01:18:32



--- Comment #10 from Fedora Update System  ---
python3-markupsafe-0.23-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934
Bug 1376934 depends on bug 1376932, which changed state.

Bug 1376932 Summary: Review Request: python3-markupsafe - Implements a 
XML/HTML/XHTML Markup safe string for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1376932

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555



--- Comment #11 from Fedora Update System  ---
python3-pytz-2016.7-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-10-08 22:49:08 |2016-11-28 01:18:07



--- Comment #23 from Fedora Update System  ---
gasnet-1.28.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-28 01:18:03



--- Comment #9 from Fedora Update System  ---
python3-dbus-1.2.4-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336555] Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-28 00:48:15



--- Comment #10 from Fedora Update System  ---
python3-pytz-2016.7-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393021] Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-28 00:48:25



--- Comment #13 from Fedora Update System  ---
pulledpork-0.7.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358165



--- Comment #5 from Remi Collet  ---
Thanks

New package requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358164] Review Request: php-zendframework-zend-mvc-plugins - Zend Framework Mvc-Plugins component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358164



--- Comment #4 from Remi Collet  ---
Thanks

New package requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358155



--- Comment #5 from Remi Collet  ---
Thanks.

New package request open.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358153] Review Request: php-zendframework-zend-mvc-form - Zend Framework Mvc-Form component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358153



--- Comment #4 from Remi Collet  ---
Thanks.

New package request open.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358149



--- Comment #5 from Remi Collet  ---
Thanks.

New package request open.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398922

Yunying Sun  changed:

   What|Removed |Added

 CC||yunying@intel.com



--- Comment #1 from Yunying Sun  ---
An unformal review:

1. No version specified in %changelog.
changelog format:
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

2. Static libraries are discouraged. Add "--disable-static" in %configure, and
add -devel package where *.so could be included.
Refer to:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
https://fedoraproject.org/wiki/Packaging:Guidelines#DevelPackages

3. Missing %doc for README.md.

4. Use %{name} instead of fixed string "uftrace" would be better in spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-27 23:00:11



--- Comment #15 from Fedora Update System  ---
python-wcsaxes-0.9-3.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394980] Review Request: wafw00f - A tool to identifies and fingerprints Web Application Firewall (WAF)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394980
Bug 1394980 depends on bug 1394969, which changed state.

Bug 1394969 Summary: Review Request: python-pluginbase - A support library for 
building plugins systems
https://bugzilla.redhat.com/show_bug.cgi?id=1394969

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-27 23:00:21



--- Comment #10 from Fedora Update System  ---
python-pluginbase-0.5-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899



--- Comment #13 from Fedora Update System  ---
quassel-irssi-0-2.20161120gitcbd9bd7.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ed51b0769f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242



--- Comment #13 from Fedora Update System  ---
perl-Net-DAVTalk-0.12-1.fc24, perl-XML-Spice-0.05-1.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a19778f161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174



--- Comment #17 from Fedora Update System  ---
perl-Net-DAVTalk-0.12-1.fc24, perl-XML-Spice-0.05-1.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a19778f161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



[!]: Latest version is packaged.

 Version 0.2.0 packaged, version 0.3.0 available



No blockers.

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934



--- Comment #4 from Shawn Iwinski  ---
Created attachment 1225031
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225031=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1393934
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934



--- Comment #2 from Shawn Iwinski  ---
Created attachment 1225029
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225029=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934



--- Comment #3 from Shawn Iwinski  ---
Created attachment 1225030
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225030=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358165

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



No blockers.

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358165



--- Comment #3 from Shawn Iwinski  ---
Created attachment 1225028
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225028=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1358165
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358165



--- Comment #1 from Shawn Iwinski  ---
Created attachment 1225026
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225026=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358165



--- Comment #2 from Shawn Iwinski  ---
Created attachment 1225027
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225027=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358165

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358164] Review Request: php-zendframework-zend-mvc-plugins - Zend Framework Mvc-Plugins component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358164

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Shawn Iwinski  ---
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358164] Review Request: php-zendframework-zend-mvc-plugins - Zend Framework Mvc-Plugins component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358164



--- Comment #2 from Shawn Iwinski  ---
Created attachment 1225025
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225025=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1358164
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358164] Review Request: php-zendframework-zend-mvc-plugins - Zend Framework Mvc-Plugins component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358164

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358155

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).

 W: incoherent-version-in-changelog 1.1.10-1 ['1.0.0-1.fc26', '1.0.0-1']

Fix minor changelog typo after initial import.



No blockers.

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358155



--- Comment #3 from Shawn Iwinski  ---
Created attachment 1225024
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225024=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1358155
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358155



--- Comment #2 from Shawn Iwinski  ---
Created attachment 1225023
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225023=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358155



--- Comment #1 from Shawn Iwinski  ---
Created attachment 1225022
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225022=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358155

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358153] Review Request: php-zendframework-zend-mvc-form - Zend Framework Mvc-Form component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358153

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Shawn Iwinski  ---
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



No blockers.

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899



--- Comment #12 from Fedora Update System  ---
quassel-irssi-0-2.20161120gitcbd9bd7.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fa837a829b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358153] Review Request: php-zendframework-zend-mvc-form - Zend Framework Mvc-Form component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358153



--- Comment #2 from Shawn Iwinski  ---
Created attachment 1225021
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225021=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1358153
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
perl-Net-DAVTalk-0.12-1.fc25, perl-XML-Spice-0.05-1.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fb58d68c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
perl-Net-DAVTalk-0.12-1.fc25, perl-XML-Spice-0.05-1.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fb58d68c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140



--- Comment #10 from Fedora Update System  ---
mrrescue-1.02e-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-214a4a480e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358153] Review Request: php-zendframework-zend-mvc-form - Zend Framework Mvc-Form component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358153

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358149

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[!]: Buildroot is not present
 Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



Shouldn't min dependency versions match?
BuildRequires:  php-composer(%{gh_owner}/zend-json) >= 2.6.1

# Require zend-json 3.0.0 as conflicts with previous
Requires:   php-composer(%{gh_owner}/zend-json) >= 3.0.0



In %check, `if which php71` but then `php70` usage.



No blockers.

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358149



--- Comment #3 from Shawn Iwinski  ---
Created attachment 1225020
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225020=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1358149
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358149



--- Comment #1 from Shawn Iwinski  ---
Created attachment 1225018
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225018=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358149



--- Comment #2 from Shawn Iwinski  ---
Created attachment 1225019
  --> https://bugzilla.redhat.com/attachment.cgi?id=1225019=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.1 DB version 1.14.0 built Oct 17 2016 08:13:06 CEST

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358149

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1244657] Review Request: asynchbase - An alternative HBase client library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244657



--- Comment #5 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/asynchbase.spec
SRPM URL: https://gil.fedorapeople.org/asynchbase-1.7.2-1.fc24.src.rpm

- move to protobuf 3.1

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16648849

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1244657] Review Request: asynchbase - An alternative HBase client library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244657

gil cattaneo  changed:

   What|Removed |Added

  Flags|needinfo?(Marcin.Dulak@gmai |
   |l.com)  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391254] Review Request: python3-doctutils - System for processing plaintext documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391254



--- Comment #2 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-docutils.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-docutils-0.12-0.8.20140510svn7747.el7.src.rpm

* Sun Nov 27 2016 Orion Poplawski  -
0.12-0.8.20140510svn7747
- Use %%license for COPYING.txt
- Make separate doc sub-package


Can't find any manpages for the rst2* scripts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376940] Review Request: python3-urllib3 - Python 3 HTTP library with thread-safe connection pooling and file post

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376940



--- Comment #6 from Orion Poplawski  ---
* Sun Nov 27 2016 Orion Poplawski  - 1.19.1-2
- Patch to use system six
- Do not attempt change ssl handling

Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-urllib3.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-urllib3-1.19.1-2.el7.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=16648629

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #14 from Athmane Madjoudj  ---
Hi Julien, 

Pushed to f24 updates-testing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #13 from Fedora Update System  ---
python-async-timeout-1.1.0-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aea351b543

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949



--- Comment #2 from MartinKG  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/bear-0.7.0-0.2gitac6be8b.fc25.src.rpm

%changelog
* Sun Nov 27 2016 Martin Gansser  -
0.7.0-0.2gitac6be8b
- Remove Conflicts: wxGTK3-devel"
- Compressed sed command
- replace (non packaged) with (tunnel) from the descriptions
- replace (andy-super-great-park) with (asgp) from the descriptions
- run-time is the correct spelling, not runtime
- Add %%config to fix the non-conffile-in-etc warnings
- Remove desc2img.desktop due desc2img binary missing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1321013] Review request: gnome-shell-extension-taskbar - GNOME Shell Extension TaskBar

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321013



--- Comment #6 from zp...@openmailbox.org ---
Yes absolutely, I've read the relevant documentation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373641



--- Comment #11 from Fabio Alessandro Locati  ---
Sorry for the delay, but somehow I have not noticed the email from bugzilla of
your message.
Thanks to this change, the package is good :).

Only thing to fix: add a comment on Patch0.

Now, the package is approved, but please pick 1 package to review from the pile
and review it as for
https://fedoraproject.org/wiki/Package_Review_Process#Reviewer
You will not be able to approve the package, but as soon as you think the
package should be approved, I'll review your review and if everything is ok,
I'll approve you in the Packager group so that you can push this package in
Fedora and approve the review.

PS: If you sent a message and have not received any reply from my side, ping me
with an email :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373641

Fabio Alessandro Locati  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Julien Enselme  changed:

   What|Removed |Added

 CC||juj...@jujens.eu



--- Comment #12 from Julien Enselme  ---
Can you push this package to fedora 24 too? I need it in one of my program.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398965] New: Review Request: python-aioodbc - Library for accessing a ODBC databases from the asyncio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398965

Bug ID: 1398965
   Summary: Review Request: python-aioodbc - Library for accessing
a ODBC databases from the asyncio
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-aioodbc.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-aioodbc-0.0.3-1.fc26.src.rpm
Description: Library for accessing a ODBC databases from the asyncio.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398965] Review Request: python-aioodbc - Library for accessing a ODBC databases from the asyncio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398965

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-aioodbc



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398929] Review Request: brightnessctl - Read and control device brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398929

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
quassel-irssi-0-2.20161120gitcbd9bd7.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b2bb44e437

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949



--- Comment #1 from Jeremy Newton  ---
(In reply to MartinKG from comment #0)
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/bear-0.7.0-0.1gitac6be8b.fc25.
> src.rpm
> Description: Game engine and editors dedicated to creating great 2D games
> Fedora Account System Username: martinkg
> 
> %changelog
> * Sun Nov 27 2016 Martin Gansser  -
> 0.7.0-0.1gitac6be8b
> - imported package bear
> 
> 
> rpmlint -i bear.spec
> /home/martin/rpmbuild/SRPMS/bear-0.7.0-0.1gitac6be8b.fc25.src.rpm
> /home/martin/rpmbuild/RPMS/x86_64/bear-engine-0.7.0-0.1gitac6be8b.fc25.
> x86_64.rpm
> /home/martin/rpmbuild/RPMS/x86_64/bear-factory-0.7.0-0.1gitac6be8b.fc25.
> x86_64.rpm
> /home/martin/rpmbuild/RPMS/x86_64/bear-debuginfo-0.7.0-0.1gitac6be8b.fc25.
> x86_64.rpm
> bear.src: W: spelling-error %description -l en_US plee -> peel, pee, lee
> The value of this tag appears to be misspelled. Please double-check.
> 
> bear.src: W: spelling-error %description -l en_US andy -> Andy, and, any
> The value of this tag appears to be misspelled. Please double-check.
> 
> bear-engine.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time,
> Run-time, Rudiment
> The value of this tag appears to be misspelled. Please double-check.
> 
> bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel,
> pee, lee
> The value of this tag appears to be misspelled. Please double-check.
> 
> bear-engine.x86_64: W: spelling-error %description -l en_US andy -> Andy,
> and, any
> The value of this tag appears to be misspelled. Please double-check.
> 
> bear-engine.x86_64: W: spelling-error %description -l en_US runtime -> run
> time, run-time, rudiment
> The value of this tag appears to be misspelled. Please double-check.
> 
> bear-engine.x86_64: W: manual-page-warning
> /usr/share/man/man6/running-bear.6.gz 5: warning: macro `RS' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-engine.x86_64: W: manual-page-warning
> /usr/share/man/man6/running-bear.6.gz 12: warning: macro `RE' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-engine.x86_64: W: non-conffile-in-etc
> /etc/ld.so.conf.d/bear-engine-x86_64.conf
> A non-executable file in your package is being installed in /etc, but is not
> a
> configuration file. All non-executable files in /etc should be configuration
> files. Mark the file as %config in the spec file.
> 
> bear-factory.x86_64: W: manual-page-warning
> /usr/share/man/man1/bf-animation-editor.1.gz 5: warning: macro `RS' not
> defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-factory.x86_64: W: manual-page-warning
> /usr/share/man/man1/bf-animation-editor.1.gz 12: warning: macro `RE' not
> defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-factory.x86_64: W: manual-page-warning
> /usr/share/man/man1/bf-level-editor.1.gz 5: warning: macro `RS' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-factory.x86_64: W: manual-page-warning
> /usr/share/man/man1/bf-level-editor.1.gz 12: warning: macro `RE' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-factory.x86_64: W: manual-page-warning
> /usr/share/man/man1/bf-model-editor.1.gz 5: warning: macro `RS' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-factory.x86_64: W: manual-page-warning
> /usr/share/man/man1/bf-model-editor.1.gz 12: warning: macro `RE' not defined
> This man page may contain problems that can cause it not to be formatted as
> intended.
> 
> bear-factory.x86_64: W: non-conffile-in-etc
> /etc/ld.so.conf.d/bear-factory-x86_64.conf
> A non-executable file in your package is being installed in /etc, but is not
> a
> configuration file. All non-executable files in /etc should be configuration
> files. Mark the file as %config in the spec file.
> 
> bear-factory.x86_64: W: no-manual-page-for-binary image-cutter
> Each executable in standard binary directories should have a man page.
> 
> bear-factory.x86_64: W: no-manual-page-for-binary bend-image
> Each executable in standard binary directories should have a man page.
> 
> bear-factory.x86_64: W: desktopfile-without-binary
> /usr/share/applications/desc2img.desktop desc2img
> the .desktop file is for a file not present in the package. You should check
> the requires or see if this is not a error
> 
> 4 packages and 1 specfiles checked; 0 errors, 19 warnings.

Some comments:
- I would remove "Conflicts:  wxGTK3-devel"
- The sed commands can be compressed into:
# change docbook_to_man to docbook2man
sed -i -e 

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #14 from Thomas Andrejak  ---
Here are the new files

spec : https://www.prelude-siem.org/pkg/src/3.1.0/libprelude.spec

srpm :
https://copr-be.cloud.fedoraproject.org/results/totol/Prelude/fedora-rawhide-x86_64/00481802-libprelude/libprelude-3.1.0-26.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #13 from Thomas Andrejak  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> # Force default attrs because libprelude force others
> %defattr(- , root, root, 755)
> → I think you don't need this anymore.

=> Just try it, I still need this

> 
> %{python3_sitearch}/_prelude.*so
> %{python3_sitearch}/prelude.py
> → Not a packaging issue, but still something to reconsider upstream. I think
> putting a private module at the top level is rather ugly. Imaging the mess
> if everybody did that ;). Why not structure this as
> %{python3_sitearch}/prelude/__init__.py
> %{python3_sitearch}/prelude/_prelude.*so
> ? (Please note that I'm just complaining here, this review is not contingent
> on this in any way.)

Good point, I will put this upstream

> 
> BR: perl-generators is needed according to
> http://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies,
> and also R: perl(:MODULE_COMPAT), see
> http://fedoraproject.org/wiki/Packaging:
> Perl#Versioned_MODULE_COMPAT_Requires.

Done

> 
> - Provides: bundled(gnulib) in place as required.
>   Note: Bundled gnulib but no Provides: bundled(gnulib)
>   See:
>  
> http://fedoraproject.org/wiki/Packaging:
> No_Bundled_Libraries#Requirement_if_you_bundle

Done

> 
> - Note: License file LICENSE.README is not marked as %license
> Yeah, it seems reasonable to include that in %license too.
> Same goes for HACKING.README.

Done

> 
> - Large documentation must go in a -doc subpackage. Large could be size
>   (~1MB) or number of files.
>   Note: Documentation size is 5703680 bytes in 53 files.
>   See:
>   http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
> 
> I'm not sure how exactly fedora-review arrives at this number, but it seems
> that there's indeed a few MBs of documentation. You might want to split out
> libprelude-doc subpackage with /usr/share/doc/libprelude-devel/libprelude.
> (Also not that there's an extra level of directories nesting here that looks
> accidental.)

Done

> 
> rpmlint also says:
> libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/libprelude-3.1.0/src/libprelude-error/code-to-errno.h
> libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/libprelude-3.1.0/src/libprelude-error/err-sources.h
> libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/libprelude-3.1.0/src/libprelude-error/strsource.c
> libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/libprelude-3.1.0/src/libprelude-error/code-from-errno.h
> libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/libprelude-3.1.0/src/libprelude-error/err-codes.h
> libprelude-debuginfo.x86_64: E: incorrect-fsf-address
> /usr/src/debug/libprelude-3.1.0/src/libprelude-error/strerror.c
> It's not a big issue, but probably to fix upstream at some point.

I can't change this, this is not part of libprelude

> 
> libprelude.x86_64: W: crypto-policy-non-compliance-gnutls-2
> /usr/lib64/libprelude.so.23.3.0 gnutls_priority_init
> prelude-tools.x86_64: W: crypto-policy-non-compliance-gnutls-1
> /usr/bin/prelude-admin gnutls_priority_set_direct
> 
> This one is a bigger problem. It's been a while since I looked at the
> details, but basically you need to call gnutls_set_default_priority or 
> gnutls_priority_set_direct("@SYSTEM")
> [https://fedoraproject.org/wiki/Packaging:CryptoPolicies]. If this policy
> does not apply to this package for some reason, please explain in a comment
> in the spec file. Looking at ./prelude-admin/server.c, it should be easy
> enough to patch.

Done. I explain in the spec why it is OK for libprelude.so. For prelude-admin,
I made a patch to use what is required in the Wiki but I still have the warning

> 
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libprelude.so.23.3.0 /lib64/libdl.so.2
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libprelude.so.23.3.0 /lib64/libgpg-error.so.0
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpreludecpp.so.8.1.0 /lib64/libgnutls.so.30
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpreludecpp.so.8.1.0 /lib64/libgcrypt.so.20
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpreludecpp.so.8.1.0 /lib64/libdl.so.2
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpreludecpp.so.8.1.0 /lib64/libgpg-error.so.0
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpreludecpp.so.8.1.0 /lib64/libltdl.so.7
> libprelude.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpreludecpp.so.8.1.0 /lib64/libm.so.6
> 
> Overlinking? Not a big issue, because those libraries are going to be
> installed anyway, but removing it might reduce memory usage and startup time
> but some minuscule amount.

Done

> 
> And one more suggestion for upstream reconsideration:
> custom autoconf macros are horrible. 

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from Remi Collet  ---
Thanks for the review !

New package requested on pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398929] Review Request: brightnessctl - Read and control device brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398929



--- Comment #3 from Fabio Alessandro Locati  ---
Sorry, forgot to link:

SRPM: https://fale.fedorapeople.org/rpms/brightnessctl-0.1.1_p2-2.fc25.src.rpm
Spec: https://fale.fedorapeople.org/rpms/brightnessctl.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398929] Review Request: brightnessctl - Read and control device brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398929



--- Comment #2 from Fabio Alessandro Locati  ---
Thanks Igor :).

I've fixed the first three.

I'm not a fan of underscore in versions either, but as you said there is no
policy against it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949

MartinKG  changed:

   What|Removed |Added

 Blocks||1176273




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1176273
[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176273

MartinKG  changed:

   What|Removed |Added

 Depends On||1398949



--- Comment #14 from MartinKG  ---
created bear package https://bugzilla.redhat.com/show_bug.cgi?id=1398949


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1398949
[Bug 1398949] Review Request: bear - Game engine and editors dedicated to
creating great 2D games
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] New: Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949

Bug ID: 1398949
   Summary: Review Request: bear - Game engine and editors
dedicated to creating great 2D games
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mgans...@alice.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/bear-0.7.0-0.1gitac6be8b.fc25.src.rpm
Description: Game engine and editors dedicated to creating great 2D games
Fedora Account System Username: martinkg

%changelog
* Sun Nov 27 2016 Martin Gansser  -
0.7.0-0.1gitac6be8b
- imported package bear


rpmlint -i bear.spec
/home/martin/rpmbuild/SRPMS/bear-0.7.0-0.1gitac6be8b.fc25.src.rpm
/home/martin/rpmbuild/RPMS/x86_64/bear-engine-0.7.0-0.1gitac6be8b.fc25.x86_64.rpm
/home/martin/rpmbuild/RPMS/x86_64/bear-factory-0.7.0-0.1gitac6be8b.fc25.x86_64.rpm
/home/martin/rpmbuild/RPMS/x86_64/bear-debuginfo-0.7.0-0.1gitac6be8b.fc25.x86_64.rpm
bear.src: W: spelling-error %description -l en_US plee -> peel, pee, lee
The value of this tag appears to be misspelled. Please double-check.

bear.src: W: spelling-error %description -l en_US andy -> Andy, and, any
The value of this tag appears to be misspelled. Please double-check.

bear-engine.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time,
Run-time, Rudiment
The value of this tag appears to be misspelled. Please double-check.

bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee,
lee
The value of this tag appears to be misspelled. Please double-check.

bear-engine.x86_64: W: spelling-error %description -l en_US andy -> Andy, and,
any
The value of this tag appears to be misspelled. Please double-check.

bear-engine.x86_64: W: spelling-error %description -l en_US runtime -> run
time, run-time, rudiment
The value of this tag appears to be misspelled. Please double-check.

bear-engine.x86_64: W: manual-page-warning
/usr/share/man/man6/running-bear.6.gz 5: warning: macro `RS' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-engine.x86_64: W: manual-page-warning
/usr/share/man/man6/running-bear.6.gz 12: warning: macro `RE' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-engine.x86_64: W: non-conffile-in-etc
/etc/ld.so.conf.d/bear-engine-x86_64.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

bear-factory.x86_64: W: manual-page-warning
/usr/share/man/man1/bf-animation-editor.1.gz 5: warning: macro `RS' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-factory.x86_64: W: manual-page-warning
/usr/share/man/man1/bf-animation-editor.1.gz 12: warning: macro `RE' not
defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-factory.x86_64: W: manual-page-warning
/usr/share/man/man1/bf-level-editor.1.gz 5: warning: macro `RS' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-factory.x86_64: W: manual-page-warning
/usr/share/man/man1/bf-level-editor.1.gz 12: warning: macro `RE' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-factory.x86_64: W: manual-page-warning
/usr/share/man/man1/bf-model-editor.1.gz 5: warning: macro `RS' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-factory.x86_64: W: manual-page-warning
/usr/share/man/man1/bf-model-editor.1.gz 12: warning: macro `RE' not defined
This man page may contain problems that can cause it not to be formatted as
intended.

bear-factory.x86_64: W: non-conffile-in-etc
/etc/ld.so.conf.d/bear-factory-x86_64.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

bear-factory.x86_64: W: no-manual-page-for-binary image-cutter
Each executable in standard binary directories should have a man page.

bear-factory.x86_64: W: no-manual-page-for-binary bend-image
Each executable in standard binary directories should have a man page.

bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/desc2img.desktop desc2img
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error

4 packages and 1 specfiles checked; 0 errors, 19 warnings.

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799



--- Comment #2 from Johan Cwiklinski  ---
Package builds and loads, rpmlint is (almost) quiet... Everything is OK!

**APPROVED**

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799

Johan Cwiklinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799



--- Comment #1 from Johan Cwiklinski  ---
Created attachment 1224848
  --> https://bugzilla.redhat.com/attachment.cgi?id=1224848=edit
fedora review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799

Johan Cwiklinski  changed:

   What|Removed |Added

 CC||jo...@x-tnd.be
   Assignee|nob...@fedoraproject.org|jo...@x-tnd.be
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433



--- Comment #2 from Fabio Valentini  ---
I corrected some things I forgot to include in / remove from the .spec file -
additionally, I fixed some issues that rpmlint pointed out to me.

Spec URL:
https://raw.githubusercontent.com/decathorpe/fedora-packaging/f04f79b1d6f8b83e6733757f6e9cc51686c19f4e/specs/granite.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-rawhide-x86_64/00481789-granite/granite-0.4.0.1-6.fc26.src.rpm

A COPR build is available here:
https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/481789/

A koji scratch build is available here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16647475

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398929] Review Request: brightnessctl - Read and control device brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398929

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Igor Gnatenko  ---
* Source0:   
https://github.com/Hummer12007/%{name}/archive/%{version}.tar.gz
-> Source0:%{url}/archive/%{version}/%{name}-%{version}.tar.gz
* make %{?_smp_mflags}
-> %make_build
* %make_install DESTDIR=%{buildroot}/usr
-> %make_install DESTDIR=%{buildroot}%{_prefix}

! CFLAGS/LDFLAGS are not enforced !


Honestly, I don't like idea to have "_" in version, but I can't find guidelines
which prohibits this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398929] Review Request: brightnessctl - Read and control device brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398929

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398929] New: Review Request: brightnessctl - Read and control device brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398929

Bug ID: 1398929
   Summary: Review Request: brightnessctl - Read and control
device brightness
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: f...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fale.fedorapeople.org/rpms/brightnessctl.spec
SRPM URL:
https://fale.fedorapeople.org/rpms/brightnessctl-0.1.1_p2-1.fc25.src.rpm
Description: Read and control device brightness
Fedora Account System Username: fale

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398690] Review Request: perl-Module-Extract-Use - Pull out the modules a module explicitly uses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398690



--- Comment #3 from Fabio Valentini  ---
(In reply to Paul Howarth from comment #2)
> Hi Fabio,
> 
> (In reply to Fabio Valentini from comment #1)
> > =
> > | !! NON-BINDING !! |
> > |  Package Review   |
> > =
> > 
> > I did this preliminary package review as part of the process of
> > becoming a fedora packager, so a "real" review is still needed.
> > 
> > IMO, besides the unneccessary BuildRequires, the review
> > looks simple enough. Regardless, a link to a successful koji
> > scratch build would have been nice.
> 
> OK, here's a scratch build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=16647335
> 

Looks good!

> > Issues:
> > ===
> > - All build dependencies are listed in BuildRequires, except for any that
> >   are listed in the exceptions section of Packaging Guidelines.
> > 
> >   Note: These BR are not needed: coreutils make findutils
> >   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> 
> It looks like this comment is a remnant from an old version of the packaging
> guidlines, which now say:
> 
> It is important that your package list all necessary build dependencies
> using the BuildRequires: tag. You may assume that enough of an environment
> exists for RPM to function, to build packages and execute basic shell
> scripts, but you should not assume any other packages are present as RPM
> dependencies and anything brought into the buildroot by the build system may
> change over time. 
> 
> (https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#BuildRequires_2)
> 
> So I think it is safest to include everything that is explicitly used during
> the package build.

Fair point, I did assume that fedora-review was up to snuff with the latest
packaging guidelines concerning this - obviously, I was wrong.

> > Reviewer's Comment: The first 32 lines of the .spec file are not nicely
> > formatted at all (indentation with 8-space-tabs instead of simple spaces, no
> > empty lines for better readability, etc.) - although it seems that the
> > .spec file has been adapted from another package or a Perl package template,
> > because many already existing / approved perl package .specs look that way.
> 
> This one is a matter of personal taste really and there are no guidelines
> about use of tabs, unless the use resulted in the spec not being legible to
> read. I think blocking on use of regular 8-space tabs (which I find helps
> line things up easily) would be stretching things a bit.

Of course. I just wanted to mention it as "comment only", because - depending
on the text editor configuration or environment - your .spec file might not
look as intended.

> Thanks for the feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398690] Review Request: perl-Module-Extract-Use - Pull out the modules a module explicitly uses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398690



--- Comment #2 from Paul Howarth  ---
Hi Fabio,

(In reply to Fabio Valentini from comment #1)
> =
> | !! NON-BINDING !! |
> |  Package Review   |
> =
> 
> I did this preliminary package review as part of the process of
> becoming a fedora packager, so a "real" review is still needed.
> 
> IMO, besides the unneccessary BuildRequires, the review
> looks simple enough. Regardless, a link to a successful koji
> scratch build would have been nice.

OK, here's a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16647335

> Issues:
> ===
> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.
> 
>   Note: These BR are not needed: coreutils make findutils
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

It looks like this comment is a remnant from an old version of the packaging
guidlines, which now say:

It is important that your package list all necessary build dependencies using
the BuildRequires: tag. You may assume that enough of an environment exists for
RPM to function, to build packages and execute basic shell scripts, but you
should not assume any other packages are present as RPM dependencies and
anything brought into the buildroot by the build system may change over time. 

(https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRequires_2)

So I think it is safest to include everything that is explicitly used during
the package build.

> Reviewer's Comment: The first 32 lines of the .spec file are not nicely
> formatted at all (indentation with 8-space-tabs instead of simple spaces, no
> empty lines for better readability, etc.) - although it seems that the
> .spec file has been adapted from another package or a Perl package template,
> because many already existing / approved perl package .specs look that way.

This one is a matter of personal taste really and there are no guidelines about
use of tabs, unless the use resulted in the spec not being legible to read. I
think blocking on use of regular 8-space tabs (which I find helps line things
up easily) would be stretching things a bit.

Thanks for the feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398922] New: Review Request: uftrace - User-space function call tracer for C and C++ programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398922

Bug ID: 1398922
   Summary: Review Request: uftrace - User-space function call
tracer for C and C++ programs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: benjamin.kirc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/bkircher/uftrace-fedora/master/uftrace-0.6-1.fc25.src.rpm

SRPM URL:
https://raw.githubusercontent.com/bkircher/uftrace-fedora/master/uftrace.spec

Description:
The uftrace tool is used to trace and analyze the execution of a program
written in C or C++. It was heavily inspired by the ftrace framework of the
Linux kernel (especially function graph tracer) but for user-space programs. It
supports various kinds of commands and filters to help in the analysis of
program execution and performance.

Fedora Account System Username: bkircher

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391951

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #7 from Remi Collet  ---
Thanks for the review.

New package requested on pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391951

François Kooman  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from François Kooman  ---
No, the remirepo stuff can stay, I don't really mind, especially if you want to
make it available on EL5/EL6 and SC. 

Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org