[Bug 498390] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=498390



--- Comment #51 from Gerd Pokorra  ---
nqp-0.0.2017.01-2.fc25 is currently in the updates-testing repository.

dnf update --enablerepo=updates-testing nqp

The rakudo rpm release 4 can only be checked on top of this new nqp package.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625



--- Comment #7 from Fedora Update System  ---
gotun-0-0.1.gitccf43e2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-96e4cc8115

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429272] Re-Review Request: zanata-platform - Zanata the web-based translation platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429272



--- Comment #6 from Fedora Update System  ---
zanata-platform-4.1.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-91b890323f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429272] Re-Review Request: zanata-platform - Zanata the web-based translation platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429272

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429272] Re-Review Request: zanata-platform - Zanata the web-based translation platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429272



--- Comment #5 from Fedora Update System  ---
zanata-platform-4.1.1-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1981e2d1af

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424839



--- Comment #10 from Fedora Update System  ---
php-rmccue-requests-1.7.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-39d19fc2a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424839

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424839



--- Comment #9 from Fedora Update System  ---
php-rmccue-requests-1.7.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3144a999c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424839



--- Comment #8 from Fedora Update System  ---
php-rmccue-requests-1.7.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-86be5251c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424839

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||php-rmccue-requests-1.7.0-2
   ||.fc27



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413474] Review Request: python-pycdlib - Pure Python library for ISO manipulation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413474



--- Comment #8 from Chris Lalancette  ---
All right, I uploaded another version (with the same version number), but this
one has the right sha256sum.  Please take another look when you have a chance,
thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413474] Review Request: python-pycdlib - Pure Python library for ISO manipulation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413474



--- Comment #7 from Chris Lalancette  ---
It's odd that it doesn't match the upstream sha256 sum, since I created the
release just for this review.  I'll take a look and see what happened there.

By the way, pycdlib already supports python3, and this package actually exports
both a python2-pycdlib and a python3-pycdlib.  So we are good there.

Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429683] Review Request: xorgxrdp - Implementation of xrdp backend Xorg modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429683



--- Comment #7 from Itamar Reis Peixoto  ---
please consider request a branch for f26, f25 and el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429683] Review Request: xorgxrdp - Implementation of xrdp backend Xorg modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429683



--- Comment #6 from Pavel Roskin  ---
I considered both options. I think it would be better to make xrdp depend on
xorgxrdp. Users would get a degraded experience if they don't install xorgxrdp.
Even if Xvnc is already installed on the system, I would still suggest that
xorgxrdp is installed and used with xrdp.

I'm going to try "Suggests" before "Requires". If "Suggests" ensures that "dnf
install xrdp" would install xorgxrdp, I would use "Suggests".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429683] Review Request: xorgxrdp - Implementation of xrdp backend Xorg modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429683

Pavel Roskin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-03-08 19:27:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388945] Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388945



--- Comment #10 from Andrew Toskin  ---
I just noticed that the spec says it requires GNOME 3.20+, but the extension's
metadata.json file says it supports 3.16. This maybe isn't a big deal for
Fedora, since Fedora 23 reached end-of-life. But allowing GNOME 3.16 would make
your package usable in EPEL... if/when they rebase to a version of GNOME newer
than 3.14.

In any case, I think it would be better to stick with the upstream's stated
supported versions of GNOME, unless you *know* the extension does not actually
work with GNOME older than 3.20.


(In reply to mgans...@alice.de from comment #9)
> i activated it with  gnome-shell-extension-prefs

Turns out my problem with Banshee was that I needed to enable the MPRIS D-Bus
Interface extension in the Banshee preferences.
https://github.com/eonpatapon/gnome-shell-extensions-mediaplayer/issues/270

I feel like this is going to be a common point of confusion for new users, but
I'm not sure how we could avoid it. It's already noted in the packaged README,
but how many people read those? Not me, apparently :P

FYI: The method used to activate the extension shouldn't really matter.
Launching gnome-shell-extension-prefs, the GNOME Tweak Tool, or running the
gnome-shell-extension-tool command line -- it's all the same.

Also, the extension does show up in Tweak Tool now. I had reloaded GNOME Shell
(Alt+F2, r, Enter), but maybe it still needed me to logout and login for some
reason.


> I think it is a PreRelease ?

I guess that depends on whether upstream ever plans to tag releases, and what
they intend their first version number to be. Some projects use 0.1 or 1.0 for
their first official release. If they tag their first release as version 0.1,
then you're okay: You would simply bump your Release tag from a "prerelease"
number (0.x) to a regular release (1). And if they tag version 1.0, then that
will always be sorted as newer than version 0.1, so you'd still be good.

However, some developers really like to count from 0, and tag their first
release as 0.0 -- and *that* would be a problem for your package, because RPM
won't recognize the tagged version 0.0 as being newer than the version "0.1"
you've been packaging. You would have to add an Obsoletes tag or something, and
things would get messy...

So if upstream doesn't plan on ever tagging their releases, or if they are
undecided on their versioning scheme in any way, I would set the spec's Version
to plain 0. And continue with the "prerelease" Release tag you're using, unless
or until upstream formally designates an actual version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887

Olivier Lemasle  changed:

   What|Removed |Added

 Depends On||1430558




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1430558
[Bug 1430558] Review Request: golang-github-yosssi-gohtml - HTML formatter
for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430558] Review Request: golang-github-yosssi-gohtml - HTML formatter for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430558

Olivier Lemasle  changed:

   What|Removed |Added

 Blocks||1345887




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1345887
[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template
engine for Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430558] New: Review Request: golang-github-yosssi-gohtml - HTML formatter for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430558

Bug ID: 1430558
   Summary: Review Request: golang-github-yosssi-gohtml - HTML
formatter for Go
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: o.lema...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://olem.fedorapeople.org/reviews/golang-github-yosssi-gohtml.spec
SRPM URL:
https://olem.fedorapeople.org/reviews/golang-github-yosssi-gohtml-0-0.1.git1d8dc9c.fc25.src.rpm

Description: HTML formatter for Go
Fedora Account System Username: olem

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344936

Olivier Lemasle  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887

Olivier Lemasle  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #9 from VincentS  ---
Upstream updated to a new release with gcc7 supported.

Here are new spec file and srpm:
Spec URL: https://dl.casperlefantom.net/pub/review/python-gamera.spec
SRPM URL:
https://dl.casperlefantom.net/pub/review/python-gamera-3.4.3-1.fc25.src.rpm

Moreover, I build with Koji to verify if it compile for rawhide.
https://koji.fedoraproject.org/koji/taskinfo?taskID=18270494

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #9 from Olivier Lemasle  ---
Thanks, I will package golang-github-yosssi-gohtml myself and include ace
binary program; that will be an exercise ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388945] Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388945

Andrew Toskin  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|and...@tosk.in



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1252130] Review Request: gnome-shell-extension-drop-down-terminal - Drop Down Terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252130

Andrew Toskin  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|and...@tosk.in



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344936



--- Comment #10 from Olivier Lemasle  ---
Thanks Athos for your sponsorship and review.

I've created the package on pkgdb, and waiting for validation [1].

Regarding the wiki, I had actually already created a personal page [2], that
I've just updated.

[1] https://admin.fedoraproject.org/pkgdb/packager/olem/requests
[2] https://fedoraproject.org/wiki/User:Olem

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1252130] Review Request: gnome-shell-extension-drop-down-terminal - Drop Down Terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252130

Andrew Toskin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #8 from Andrew Toskin  ---
If you're still willing to work on this, then sure, I'll review it with you and
help you get it into Fedora.

It's been a while, so I assume you at least need to bump the spec to use the
latest upstream release. I'll take a look once you post the update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #38 from Mukundan Ragavan  ---
Can you post links to updated spec and srpm.

Also, please add some text to explain the patches as I indicated in a previous
comment. Comments make it much easier for someone touching the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #37 from Joël Krähemann  ---
Hi

just updated gsequencer.spec to make the docs noarch.

Bests,
Joël

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396817] Review Request: setlock - a go port of setlock ( an utility of daemontools)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396817

Tobias Florek  changed:

   What|Removed |Added

 CC||m...@ibotty.net



--- Comment #6 from Tobias Florek  ---
Re %gobuild and %gotest

I stumbled upon it today as well. You can just %define gobuild when it's not
already defined:

%if ! 0%{?gobuild:1}
function _gobuild { go build -a -ldflags "-B 0x$(head -c20 /dev/urandom|od -An
-tx1|tr -d ' \n')" -v -x "$@"; }
%global gobuild _gobuild
%endif

or maybe more elegantly ;).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430132] Review Request: golang-github-google-go-github - Go library for accessing the GitHub API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430132



--- Comment #4 from Fabio Valentini  ---
COPR doesn't support all arches that fedora itself supports (aarch64, armv7hl,
ppc64 are not available as targets in COPR, but are official arches in
rawhide), that's why a koji scratch build is preferable.


If you are packaging the old version because of compatibility issues with
pre-existing packages, mention that in a comment in the .spec file (somewhere
near the %commit variable definition). Of course, it would be preferable to
update the existing packages to compatible versions.

I see 2 possible courses of action here:

1. - package the older snapshot of this package
   - mention the reason explicitly in the .spec file
   - add package to fedora
   - create a tracking bug for bumping this package to a new version, report
bugs for packages incompatible with the new version and mark them as blockers.

2. report bugs against the incompatible packages now and mark them as blockers
for this review (which would be the cleaner approach IMO)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430132] Review Request: golang-github-google-go-github - Go library for accessing the GitHub API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430132



--- Comment #3 from Ed Marshall  ---
I'll run the next update through koji (or at least add all arches to the copr
repo); I've been using copr for my workflow for this as I've been wading
through dependencies and it makes working with a large group of packages
easier, but at the level of individual reviews, koji is probably better on a
few fronts.

Re: the older version, I'm building this as a dependency for Hashicorp Vault,
and the version I'm able to build against the dependencies in Fedora today
(specifically, Consul is pretty far out of date, and updating it is a bit
messy: #1348906) means back-dating this dependency before sweeping API change
was made (contexts were added to most of the API).

Do you see the older version as a sticking point? There's an argument to be
made for just bringing the newest version in how, with the assumption that
everything else will have caught up by the time I'm trying to package Vault,
but I've learned to be conservative when estimating the rate of updates for
golang dependencies in Fedora. ;)

Tests/provides: good catch, and you're right; I'll clean that up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426851] Review Request: golang-github-bep-inflect - Go library to perform word transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426851

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426851] Review Request: golang-github-bep-inflect - Go library to perform word transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426851



--- Comment #5 from Fedora Update System  ---
golang-github-bep-inflect-0-0.2.gitb896c45.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b90d6ec013

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #8 from Athos Ribeiro  ---
(In reply to Olivier Lemasle from comment #6)

> - Regarding the directory ownership, I think I understand better now; I'll
> fix it.
> 

OK

> - You're right, the examples directory contains code that is not part of the
> library (is not meant to be used in the code), so I'll add it to the %doc.
> 

OK

> - Regarding the "cmd/ace" package and its main.go program, I'm not sure...
> It would be interesting to include it in the main package as a binary (not
> in the -devel subpackage), but do we need it? Furthermore, it depends on
> https://github.com/yosssi/gohtml (cf. [1]) which is currently not packaged
> in Fedora. What do you think is the best?

We do not need it at the moment, but someone else may need it (it would also be
a good exercise for a new packager :). Since it would be a dependency for one
of your packages, would you be willing to package it as well? If you are too
busy with this one, let me know and I will package the dependency myself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426949] Review Request: golang-github-fsnotify-fsnotify - Cross-platform file system notifications for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426949

Frederico Lima  changed:

   What|Removed |Added

  Flags|needinfo?(fred@fredericolim |
   |a.com.br)   |



--- Comment #8 from Frederico Lima  ---
(In reply to Jan Chaloupka from comment #5)
> Frederico, think you could build the package for f25 branch as well?

sure!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344936

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Athos Ribeiro  ---
OK Olivier, your package looks good and  you already demonstrated you are able
to maintain packages and follow the guidelines.

This package is approved and you are now sponsored in the packager group.

Please follow now the instructions starting at
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

It would be nice (but not required) to create a wiki page for you at
https://fedoraproject.org/wiki/Fedora_Project_Wiki

I will follow you on bugzilla for a while. Feel free to email me with any
questions you may have.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426954] Review Request: golang-github-chaseadamsio-goorgeous - Org to HTML Parser written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426954

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #7 from Olivier Lemasle  ---
Also, following comments in your own package ticket [1], I'll remove the empty
conditionals from the SPEC.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1426851

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426954] Review Request: golang-github-chaseadamsio-goorgeous - Org to HTML Parser written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426954



--- Comment #9 from Fedora Update System  ---
golang-github-chaseadamsio-goorgeous-0-0.3.git054aba6.fc26 has been submitted
as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-43ef32dfe3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #6 from Olivier Lemasle  ---
Hello Athos,

Thank you for your review.

- Regarding the directory ownership, I think I understand better now; I'll fix
it.

- You're right, the examples directory contains code that is not part of the
library (is not meant to be used in the code), so I'll add it to the %doc.

- Regarding the "cmd/ace" package and its main.go program, I'm not sure... It
would be interesting to include it in the main package as a binary (not in the
-devel subpackage), but do we need it? Furthermore, it depends on
https://github.com/yosssi/gohtml (cf. [1]) which is currently not packaged in
Fedora. What do you think is the best?

[1] https://github.com/yosssi/ace/blob/v0.0.5/cmd/ace/main.go#L11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430481] Review Request: python-testpath - Test utilities for code working with files and commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430481

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1426799




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1426799
[Bug 1426799] ipython-5.3.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344936



--- Comment #8 from Olivier Lemasle  ---
Hello Athos,

Thank you for your review.

I've uploaded a new version to fix the description:
Spec URL:
https://olem.fedorapeople.org/reviews/golang-github-kyokomi-emoji.spec
SRPM URL:
https://olem.fedorapeople.org/reviews/golang-github-kyokomi-emoji-1.5-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430481] New: Review Request: python-testpath - Test utilities for code working with files and commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430481

Bug ID: 1430481
   Summary: Review Request: python-testpath - Test utilities for
code working with files and commands
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-testpath.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-testpath-0.3-1.fc25.src.rpm

Description: Testpath is a collection of utilities for Python code working with
files and commands. It contains functions to check things on the filesystem,
and tools for mocking system commands and recording calls to those.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426851] Review Request: golang-github-bep-inflect - Go library to perform word transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426851



--- Comment #4 from Athos Ribeiro  ---
Thank you for the reviews, Olivier and Fabio!

I will clean up the empty conditionals before uploading the package!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430476] New: Review Request: python-xmlrunner - unittest-based test runner with Ant/ JUnit like XML reporting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430476

Bug ID: 1430476
   Summary: Review Request: python-xmlrunner - unittest-based test
runner with Ant/JUnit like XML reporting
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: or...@cora.nwra.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.cora.nwra.com/~orion/fedora/python-xmlrunner.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-xmlrunner-1.7.7-1.fc27.src.rpm
Description:
xmlrunner is a unittest test runner that can save test results to XML files
that can be consumed by a wide range of tools, such as build systems, IDEs
and continuous integration servers.

Fedora Account System Username: orion

https://koji.fedoraproject.org/koji/taskinfo?taskID=18266859

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202

Damian Wrobel  changed:

   What|Removed |Added

 CC||dwro...@ertelnet.rybnik.pl
   Assignee|nob...@fedoraproject.org|dwro...@ertelnet.rybnik.pl



--- Comment #2 from Damian Wrobel  ---
Please find some initial comments:

 %doc COPYING
COPYING should go to %license, please also remove the redundant space character
in front of %doc 


%doc README*
It's minor, but it causes that both README and README.md are packaged, although
both are identical:
$ sha256sum README README.md 
6b6f723b4db0fe3468e32a6cb488c42f2cc3c499538367bb89bebd3b432fe6c6  README
6b6f723b4db0fe3468e32a6cb488c42f2cc3c499538367bb89bebd3b432fe6c6  README.md
Maybe upstream can simply remove one of it?


%dir %{_datadir}/%{name}/translations
%dir %{_datadir}/%{name}
Please consider reverting the order of them, will look more natural.


-rwxr-xr-x1 rootroot  332 Mar  8 16:24
/usr/share/applications/sirikali.desktop
Destkop file seems to have superfluous executable attribute.


Based on the project's homepage[1]:

cryfs binary application is required to be installed for SiriKali to gain
support for cryfs volumes.

gocryptfs binary application is required to be installed for SiriKali to gain
support for gocryptfs volumes.

encfs binary application is required to be installed for SiriKali to gain
support for encfs volumes.

securefs binary application is required to be installed for SiriKali to gain
support for securefs volumes.

But the package itself doesn't list any of them as a run-time dependency.

BTW, we don't seem to have cryfs:

$ dnf provides '*cryfs'
Last metadata expiration check: 2:21:08 ago on Wed Mar  8 15:59:56 2017.
Error: No Matches found

[1] https://mhogomchungu.github.io/sirikali/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427990] Review Request: kf5-kirigami2 - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427990



--- Comment #9 from Fedora Update System  ---
plasma-discover-5.9.3-2.fc26 kf5-kirigami2-2.0.0-2.fc26 has been submitted as
an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1156554295

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297550] Review Request: golang-github-jmespath-go-jmespath - Golang implementation of JMESPath

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297550

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-05-27 23:34:01 |2017-03-08 10:50:46



--- Comment #26 from Fedora Update System  ---
golang-github-jmespath-go-jmespath-0.2.2-0.1.gitbd40a43.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405074] Review Request: golang-github-xeipuuv-gojsonschema - An implementation of JSON Schema, draft v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405074



--- Comment #16 from Fedora Update System  ---
golang-github-xeipuuv-gojsonschema-0-0.1.gitd5336c7.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1206886] Review Request: golang-github-spf13-afero - A FileSystem Abstraction System for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206886



--- Comment #14 from Fedora Update System  ---
golang-github-spf13-afero-0-0.2.git20500e2.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405067] Review Request: golang-github-xeipuuv-gojsonpointer - JSON Pointer implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405067



--- Comment #15 from Fedora Update System  ---
golang-github-xeipuuv-gojsonpointer-0-0.1.gite0fe6f6.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387203] Review Request: golang-github-pelletier-go-toml - Go library for the TOML language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387203



--- Comment #9 from Fedora Update System  ---
golang-github-pelletier-go-toml-0.3.5-0.1.git31055c2.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405072] Review Request: golang-github-xeipuuv-gojsonreference - JSON Reference implementation in Golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405072



--- Comment #14 from Fedora Update System  ---
golang-github-xeipuuv-gojsonreference-0-0.1.gite02fc20.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412152] Review Request: golang-github-blang-semver - Semantic Versioning library written in golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412152



--- Comment #13 from Fedora Update System  ---
golang-github-blang-semver-3.3.0-0.1.git60ec348.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429683] Review Request: xorgxrdp - Implementation of xrdp backend Xorg modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429683



--- Comment #5 from Itamar Reis Peixoto  ---
I have a question, 

installing xrdp will also install this package by default ? (adding a requires
into xrdp package) 

or

It will continue "as is" and xorgxrdp will be only installed if user install it
using dnf install xorgxrdp 

?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1269992] Review Request: golang-github-juju-ratelimit - Efficient token-bucket-based rate limiter package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269992

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-01-26 13:16:13 |2017-03-08 10:51:42



--- Comment #12 from Fedora Update System  ---
golang-github-juju-ratelimit-0-0.5.git77ed1c8.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412167] Review Request: golang-github-cloudfoundry-incubator-candiedyaml - YAML for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412167



--- Comment #14 from Fedora Update System  ---
golang-github-cloudfoundry-incubator-candiedyaml-0-0.1.git99c3df8.el6 has been
pushed to the Fedora EPEL 6 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387131] Review Request: golang-github-pkg-sftp - SFTP support for the go.crypto/ssh package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387131



--- Comment #14 from Fedora Update System  ---
golang-github-pkg-sftp-0-0.1.git8197a2e.el6 has been pushed to the Fedora EPEL
6 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428760] Review Request: dist-git - Distributed Git Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428760



--- Comment #2 from cl...@redhat.com ---
(In reply to Miroslav Suchý from comment #1)
> > Group:  Applications/Productivity
> 
> This is no longer used. And it is not needed unless you target EL5.
> Please remove it.

Done.

> 
> After groupadd you should add exit 0. See
> https://fedoraproject.org/wiki/Packaging:
> UsersAndGroups#Rationale_for_some_of_the_implementation_choices

Done.

> 
> > # /usr/local/bin ... scripts
> The path has been changed obviously.
> 

Done.

> Can you call restorecon only if the policy has been changed?

Restorecon is called only on dirs themselves. It's not recursive except for web
dir with the single script file upload.cgi. We don't need to further optimize,
I think.

> 
> >%defattr(-,root,root,0755)
> This is the default. No need to write it here.

Yeah, but it's nice to be explicit in some cases.

> 
> 
> You are missing systemd post and pre scripts:
> https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:
> ScriptletSnippets#Systemd

Added.

> 
> > %global selinux_policyver %(%{__sed} -e 
> > 's,.*selinux-policy-\\([^/]*\\)/.*,\\1,' 
> > /usr/share/selinux/devel/policyhelp || echo 0.0.0)
> This will print error when selinux-policy-doc is not installed.
> You should add
> BuildRequires: /usr/share/selinux/devel/policyhelp

Added.

Updated according to review:
srpm: http://clime.cz/dist-git-0.13-1.git.60.591bd54.fc24.src.rpm
spec: http://clime.cz/dist-git.spec

I am thinking about dropping epel6 support for simplification, although it
would be very nice to have it. BuildRequire:
/usr/share/selinux/devel/policyhelp seems to be a bit clumsy and I get some sed
warnings when building srpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1246277] Review Request: golang-github-golang-sys - Go packages for low-level interaction with the operating system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246277

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-10-03 13:58:59 |2017-03-08 10:51:07



--- Comment #22 from Fedora Update System  ---
golang-github-golang-sys-0-0.9.git8f0908a.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354378] Review Request: golang-github-urfave-cli - A simple, fast, and fun package for building command line apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354378



--- Comment #23 from Fedora Update System  ---
golang-github-urfave-cli-1.18.0-0.1.git61f519f.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1148447] Review Request: golang-github-kr-fs - Provides Go filesystem-related functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1148447

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2014-10-19 09:22:07 |2017-03-08 10:50:12



--- Comment #21 from Fedora Update System  ---
golang-github-kr-fs-0-0.8.git2788f0d.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387178] Review Request: golang-github-pelletier-go-buffruneio - Wrapper around bufio to provide buffered runes access with unlimited unreads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387178



--- Comment #13 from Fedora Update System  ---
golang-github-pelletier-go-buffruneio-0-0.1.gitdf1e16f.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410386] Review Request: golang-github-d2g-dhcp4client - DHCP Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410386



--- Comment #14 from Fedora Update System  ---
golang-github-d2g-dhcp4client-0-0.1.gitbed07e1.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1270032] Review Request: golang-github-bugsnag-bugsnag-go - Automatic panic monitoring for golang, net/http and revel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270032

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-01-26 13:01:21 |2017-03-08 10:49:53



--- Comment #13 from Fedora Update System  ---
golang-github-bugsnag-bugsnag-go-1.0.4-5.el6 has been pushed to the Fedora EPEL
6 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410390] Review Request: golang-github-d2g-dhcp4 - DHCP4 library written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410390



--- Comment #13 from Fedora Update System  ---
golang-github-d2g-dhcp4-0-0.1.gitf0e4d29.el6 has been pushed to the Fedora EPEL
6 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1270034] Review Request: golang-github-bugsnag-panicwrap - Go library for catching and handling panics in Go applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270034

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-03-11 08:27:12 |2017-03-08 10:49:47



--- Comment #15 from Fedora Update System  ---
golang-github-bugsnag-panicwrap-1.1.0-0.3.gitaceac81.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362419] Review Request: golang-github-grpc-ecosystem-grpc-gateway - GRPC to JSON proxy generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362419



--- Comment #14 from Fedora Update System  ---
golang-github-grpc-ecosystem-grpc-gateway-1.0.0-0.2.gitf52d055.el6 has been
pushed to the Fedora EPEL 6 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245958



--- Comment #45 from Fedora Update System  ---
golang-github-coreos-pkg-0-0.10.gitfa29b1d.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336217] Review Request: golang-github-dustin-go-humanize - Formatters for units to human friendly sizes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336217

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-05-30 17:22:47 |2017-03-08 10:49:21



--- Comment #20 from Fedora Update System  ---
golang-github-dustin-go-humanize-0-0.3.git8929fe9.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336218] Review Request: golang-github-cockroachdb-cmux - Connection mux for serving different services on the same port

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336218

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-05-30 17:22:39 |2017-03-08 10:49:00



--- Comment #21 from Fedora Update System  ---
golang-github-cockroachdb-cmux-0-0.4.git112f050.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258878] Review Request: golang-github-coreos-go-iptables - Go wrapper around iptables utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258878

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-10-03 13:59:54 |2017-03-08 10:48:16



--- Comment #17 from Fedora Update System  ---
golang-github-coreos-go-iptables-0-0.6.gitfbb7337.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1333531] Review Request: opa-ff - OPA Fast Fabric Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333531



--- Comment #14 from Michal Schmidt  ---
The package does not build in Rawhide due to API changes in OpenSSL 1.1. For
example:

src/fe_ssl.c: In function 'fe_ssl_x509_verify_callback':
src/fe_ssl.c:116:62: error: dereferencing pointer to incomplete type
'X509_STORE_CTX {aka struct x509_store_ctx_st}'
 char *str = (char *)X509_verify_cert_error_string(ctx->error);

I guess X509_STORE_CTX_get_error() needs to be used instead of accessing ctx's
fields directly.

This page might be helpful:
https://wiki.openssl.org/index.php/1.1_API_Changes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354375] Review Request: golang-github-gengo-grpc-gateway - GRPC to JSON proxy generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354375



--- Comment #12 from Fedora Update System  ---
golang-github-gengo-grpc-gateway-0-0.1.gitdcb8443.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373612] Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373612



--- Comment #15 from Fedora Update System  ---
golang-github-Masterminds-vcs-1.8.0-0.1.gitfbe9fb6.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373551] Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373551



--- Comment #15 from Fedora Update System  ---
golang-github-Masterminds-semver-1.1.1-0.1.git8d04313.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go library for Apache Kafka 0.8 and 0.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327762



--- Comment #16 from Fedora Update System  ---
golang-github-Shopify-sarama-1.7.0-0.1.git87ec8d7.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354398] Review Request: golang-github-golang-time - Go supplementary time packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354398



--- Comment #12 from Fedora Update System  ---
golang-github-golang-time-0-0.1.gita4bde12.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1285767] Review Request: golang-github-seccomp-libseccomp-golang - The libseccomp golang bindings repository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285767

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-02-23 14:23:21 |2017-03-08 10:47:45



--- Comment #12 from Fedora Update System  ---
golang-github-seccomp-libseccomp-golang-0-0.4.git60c9953.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1333531] Review Request: opa-ff - OPA Fast Fabric Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333531



--- Comment #13 from Michal Schmidt  ---
When creating a SRPM I got a warning:
  warning: bogus date in %changelog: Fri Feb 23 2017
Feb 23 was a Thursday.

When building it I get a lot of errors:
  /usr/bin/perl: bad interpreter: No such file or directory
This needs to be added:
  BuildRequires: perl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327753] Review Request: golang-github-Shopify-toxiproxy - A proxy to simulate network and system conditions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327753



--- Comment #14 from Fedora Update System  ---
golang-github-Shopify-toxiproxy-2.0.0-0.1.rc2.gitfc5a9c0.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #20 from Karel Volný  ---
(In reply to Sergio Monteiro Basto from comment #19)
> (In reply to Karel Volný from comment #10) 
> > meanwhile, the license got simplified, however still I'm unsure how is it
> > treated in Fedora, so I've resent a question to
> > le...@lists.fedoraproject.org today
> 
> first it accepted by Fedora legal or not ?

yep, the fonts are in Fedora already

ping, is there anyone having some spare time to continue with this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327291] Review Request: golang-github-mistifyio-go-zfs - Go wrappers for ZFS commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327291



--- Comment #18 from Fedora Update System  ---
golang-github-mistifyio-go-zfs-0-0.1.git1b4ae6f.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #8 from Fabio Valentini  ---
I updated the .spec and built a new .src.rpm package for the recent 0.14.24
release:

Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/syncthing-0.14.24-1.fc25.src.rpm


The only issue blocking the build is the too-old version of the gogoprotobuf go
library (linked as blocker bug above).

Also, I'm not sure if the %systemd macros work for the units as they should,
since one of them takes an argument(a username - and I don't know if @systemd_*
macros work for something like "syncthing@.service").

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426851] Review Request: golang-github-bep-inflect - Go library to perform word transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426851

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Fabio Valentini  ---
koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18265648

I agree that this package looks good, just one minor remark: You could remove
the 3 empty %if-blocks at lines 52, 69 and 77 to clean the .spec file up a bit.

But since the .spec file is automatically generated (and the %if-blocks are
only empty because there are no additional dependencies), that is okay (and
this way it's easier to add dependencies, should the package grow new
dependencies in the future - which I doubt in this case, though).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426954] Review Request: golang-github-chaseadamsio-goorgeous - Org to HTML Parser written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426954



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-chaseadamsio-goorgeous

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429970] Review Request: libjaylink

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429970



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libjaylink

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428035] Review Request: fedora-modular-release - Fedora Modular release files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428035

Stephen Gallagher  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-03-08 10:08:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429683] Review Request: xorgxrdp - Implementation of xrdp backend Xorg modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429683



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xorgxrdp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429272] Re-Review Request: zanata-platform - Zanata the web-based translation platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429272



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/zanata-platform

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426851] Review Request: golang-github-bep-inflect - Go library to perform word transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426851

Fabio Valentini  changed:

   What|Removed |Added

 CC||decatho...@gmail.com
   Assignee|nob...@fedoraproject.org|decatho...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Fabio Valentini  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1333531] Review Request: opa-ff - OPA Fast Fabric Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333531



--- Comment #12 from Michal Schmidt  ---
So I checked out the tag, looking for a spec file.
$ find . -name '*.spec'
./Dsap/dsap.spec
./opasadb/opasadb.spec
./OpenIb_Host/mpi-apps.spec

What are these spec files? Are they distinct packages that we need to add to
Fedora (and RHEL) too?

Where is the spec file for this review?
I found a template opa-ff.spec.in. And there is a script to fill it in. Let's
run it:
$ ./update_opa-ff.spec.sh opa-ff.spec.in opa.spec

That did not work. opa.spec is 100% identical to opa-ff.spec.in, so it's not a
syntactically valid spec file ("error: line 13: Unknown tag: __RPM_DEBUG").
Looking into update_opa-ff.spec.sh... I see it assumes I'm using either RHEL or
SLES. I am using neither, so let's hack it:

diff --git a/update_opa-ff.spec.sh b/update_opa-ff.spec.sh
index d1da2a2ef6..8cc3a594f7 100755
--- a/update_opa-ff.spec.sh
+++ b/update_opa-ff.spec.sh
@@ -37,7 +37,7 @@ then
exit 1
 fi

-id=$(grep ^ID= /etc/os-release | cut -f2 -d\")
+id=rhel  #$(grep ^ID= /etc/os-release | cut -f2 -d\")
 versionid=$(grep ^VERSION_ID= /etc/os-release | cut -f2 -d\")

 from=$1

...and try again:
$ ./update_opa-ff.spec.sh opa-ff.spec.in opa.spec

This is the result:
Spec URL: https://michich.fedorapeople.org/opa-ff/opa.spec

I see you added ff_install.sh and the spec file is now shorter. Thank you!

Unfortunately it still uses generated file lists. In mentioned that as an issue
in comments #3, #5, and #8. I don't know if you missed those comments, or you
simply insist on the use of file lists. Please comment.

There are several items that go against the Packaging Guidelines. What's worse
is that some of them were already fixed in the previously reviewed spec file
from comment #7 and now they're back, so we're regressing.

> Summary: Intel Omni-Path basic tools and libraries for fabric managment.
Typo. "managment" -> "management"
There should be no dot at the end of the Summary.
See http://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

> Group: System Environment/Libraries
In comment #3 I wrote the Group tag was unnecessary. Since then the Fedora
packaging guidelines got updated. The wording is now stronger:
The [...] Group: tag, [...] SHOULD NOT be used. 
(http://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections)
Please remove the Group tags.

> License: GPLv2/BSD
The correct syntax is:
License: GPLv2 or BSD
See
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Dual_Licensing_Scenarios

> Url: http://www.intel.com/
Repeating from comment #3:
The URL should point to a page that's more relevant to the package. For
instance, opa-ff's page on github.
The previously reviewed spec file had:
Url: https://github.com/01org/opa-ff

> Source: opa.tgz
The previously reviewed spec file included a comment on how to reproduce the
tarball.
The comment is now gone!

> %description
> This package contains the tools necessary to manage an Intel(R)
> Omni-Path Architecture fabric.
The "(R)" symbol must not be used in %description.
See
http://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description

> Requires: opa-basic-tools
Explicit Requires between subpackages of the same source package should be
fully
versioned and arch-specific:
Requires: opa-basic-tools%{?_isa} = %{version}-%{release}
See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

> Requires: atlas
What is the reason for requiring atlas explicitly? Does the software dlopen()
lib[st]atlas.so.3? I did not find anything by grepping.

> %build
> if [ -d OpenIb_Host ]
As a packager, you should know whether the tarball contains this directory or
not. No such conditional should be necessary. Just a minor issue.

> %preun fastfabric
> cd /usr/lib/opa/src/mpi_apps >/dev/null 2>&1
> make -k clean >/dev/null 2>&1 || : # suppress all errors and return codes 
> from the make clean.
Could you explain the purpose of this scriptlet? And perhaps more generally,
the intended purpose of the /usr/lib/opa/src/mpi_apps directory?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430132] Review Request: golang-github-google-go-github - Go library for accessing the GitHub API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430132



--- Comment #2 from Fabio Valentini  ---
It would have been nice if you provided a successful koji scratch build for
rawhide - it shows that the package builds and that tests succeed on all
architectures. [0]


I see two issues with the current .spec and package:


1. Why are you packaging a specific commit that is over half a year old, and
not the latest git master?

2. Is it reasonable to include the sources+provides for
> golang(github.com/google/go-github/tests/integration)
in the package, e.g. are those sources imported by any packages using this
library, or are they only internal tests?

If the tests are just used internally, exclude them from the -devel and
-unit-test-devel package (for example by removing the sources before running
the scripts generated by gofed). I had to do that for one of my packages, see
[1].


[0]: https://koji.fedoraproject.org/koji/taskinfo?taskID=18265357

[1]:
https://src.fedoraproject.org/cgit/rpms/golang-github-d4l3k-messagediff.git/tree/golang-github-d4l3k-messagediff.spec#n93

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428437] Review Request: golang-github-bkaradzic-go-lz4 - Port of LZ4 lossless compression algorithm to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428437

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
golang-github-bkaradzic-go-lz4-1.0.0-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e516c276d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429001] Review Request: pyosmium - Python bindings for libosmium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429001

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
libosmium-2.11.1-1.fc25, osmium-tool-1.5.1-2.fc25, protozero-1.5.1-3.fc25,
pyosmium-2.11.0-2.fc25, rapidjson-1.1.0-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-895f23ba2a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410408] Review Request: golang-github-circonus-labs-circonus-gometrics - A go implementation of metrics reporting for Circonus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410408



--- Comment #8 from Fedora Update System  ---
golang-github-circonus-labs-circonus-gometrics-0-0.1.gitd17a842.fc25 has been
pushed to the Fedora 25 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b28797ca9c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410378] Review Request: golang-github-hashicorp-hil - HIL is a small embedded language for string interpolations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410378



--- Comment #10 from Fedora Update System  ---
golang-github-hashicorp-hil-0-0.1.git1e86c6b.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-273aa2ef18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410392] Review Request: golang-github-hashicorp-go-retryablehttp - Retryable HTTP client in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410392



--- Comment #7 from Fedora Update System  ---
golang-github-hashicorp-go-retryablehttp-0-0.1.git6e85be8.fc25 has been pushed
to the Fedora 25 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5370d746ac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org