[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #13 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3ad56ffc05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #14 from Fedora Update System  ---
rhash-1.3.4-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ac9767acaa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #59 from Fedora Update System  ---
gsequencer-0.7.122.7-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab05cb9c57

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #33 from Fedora Update System  ---
legion-17.02.0-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-afffad953e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #12 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ffe86c893

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #13 from Fedora Update System  ---
rhash-1.3.4-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-32aa797500

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #58 from Fedora Update System  ---
gsequencer-0.7.122.7-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-da19e9160d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #12 from Fedora Update System  ---
rhash-1.3.4-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-304745e071

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #11 from Fedora Update System  ---
openblas-srpm-macros-1-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0fd5d555e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
openblas-srpm-macros-1-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-90b7ce39a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
rhash-1.3.4-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8082242eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769958] Review Request: eqp - Automated theorem prover for first-order equational logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769958

Orion Poplawski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from Orion Poplawski  ---
Looks good.  Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614



--- Comment #10 from Fedora Update System  ---
gnome-shell-extension-topicons-plus-20-1.fc24 has been submitted as an update
to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-976faa2478

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614



--- Comment #9 from Fedora Update System  ---
gnome-shell-extension-topicons-plus-20-1.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef36437454

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614



--- Comment #8 from Fedora Update System  ---
gnome-shell-extension-topicons-plus-20-1.fc25 has been submitted as an update
to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e530405e6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413646] Review Request: librealsense - Cross-platform camera capture for Intel RealSense

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413646



--- Comment #6 from Mamoru TASAKA  ---
Okay, thank you, spot.

(In reply to Till Hofmann from comment #3)
> Spec URL: https://thofmann.fedorapeople.org/librealsense.spec
> SRPM URL:
> https://thofmann.fedorapeople.org/librealsense-1.12.1-4.fc25.src.rpm
> 

Does not build on either F-27 or F-26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18498661
https://koji.fedoraproject.org/koji/taskinfo?taskID=18498684

BTW I forgot to mention that now BR: gcc is needed:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

Will review again when build issue on F-27 and F-26 is fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #16 from Fedora Update System  ---
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3f803eecff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #19 from Fedora Update System  ---
gnome-shell-extension-no-topleft-hot-corner-14.0-2.el7 has been submitted as an
update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c340eeff19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #17 from Fedora Update System  ---
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc9a888e36

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #18 from Fedora Update System  ---
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc26 has been submitted as
an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2cf84e0e7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422203] Review Request: python-persist-queue - persistent queue for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422203

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-20 23:20:01



--- Comment #7 from Fedora Update System  ---
python-persist-queue-0.1.6-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #13 from Fedora Update System  ---
gnome-shell-extension-freon-23-1.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc08e27adc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #11 from Fedora Update System  ---
gnome-shell-extension-freon-23-1.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e00c7f74b8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #12 from Fedora Update System  ---
gnome-shell-extension-freon-23-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-611188e1d5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397692] Review Request: gnome-shell-extension-activities-configurator - Configure the top bar and Activities button in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397692



--- Comment #10 from Fedora Update System  ---
gnome-shell-extension-activities-configurator-53-1.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-51607832c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397692] Review Request: gnome-shell-extension-activities-configurator - Configure the top bar and Activities button in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397692



--- Comment #11 from Fedora Update System  ---
gnome-shell-extension-activities-configurator-53-1.fc26 has been submitted as
an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-32b50bc8e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397692] Review Request: gnome-shell-extension-activities-configurator - Configure the top bar and Activities button in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397692

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397692] Review Request: gnome-shell-extension-activities-configurator - Configure the top bar and Activities button in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397692



--- Comment #9 from Fedora Update System  ---
gnome-shell-extension-activities-configurator-53-1.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bd617872f5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433686] Review Request: scram - Probabilistic risk analysis tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433686



--- Comment #7 from Fedora Update System  ---
scram-0.12.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5c9dce6ae2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433686] Review Request: scram - Probabilistic risk analysis tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433686



--- Comment #6 from Fedora Update System  ---
scram-0.12.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-504a913664

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433686] Review Request: scram - Probabilistic risk analysis tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433686

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377631

Andrew Toskin  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|and...@tosk.in



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377631

Andrew Toskin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #10 from Andrew Toskin  ---
Anyway, more review:

Line 17 of the spec: Source1 tag is missing a colon.


You're still including the schemas in the extension's own directory. You don't
need this. Spec file line 50:

  mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas

Lines 56 and 57:

  install -Dp -m 0644 schemas/gschemas.compiled \
 
%{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas/gschemas.compiled


Everything else looks good to me, except for the pending issues on GitHub.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434127] Review Request: dehydrated - A client for signing certificates with an ACME server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434127



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/dehydrated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297524] Review Request: golang-github-asaskevich-govalidator - Validators and sanitizers for strings , numerics, slices and structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297524

marcindulak  changed:

   What|Removed |Added

 CC||marcin.du...@gmail.com



--- Comment #3 from marcindulak  ---
Hi, are you planning to make your vault dependencies available also in EPEL7?

Several of them are needed for
https://copr.fedorainfracloud.org/coprs/marcindulak/minishift/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790



--- Comment #10 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-freon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397692] Review Request: gnome-shell-extension-activities-configurator - Configure the top bar and Activities button in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397692



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-activities-configurator

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #15 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/tilix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433686] Review Request: scram - Probabilistic risk analysis tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433686



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/scram

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384984] Review Request: rubygem-strptime - Fast strptime engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384984



--- Comment #4 from Rich Megginson  ---
(In reply to Vít Ondruch from comment #3)
> (In reply to Rich Megginson from comment #2)
> > I would say the biggest problems are the spec file name;
> 
> This one should be ok:
> 
> https://fedoraproject.org/wiki/Packaging:Ruby#Naming_Guidelines

How so?  The spec file should be rubygem-%{gem_name}.spec not
rubygem-%{gem_name}-%{version}.spec

> 
> > -doc package bundles fonts generated by rdoc;
> 
> This is long standing issue common to all rubygem- packages (bug 1224715).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377631



--- Comment #9 from Andrew Toskin  ---
(In reply to leigh scott from comment #6)
> The changelog declares the current version as 3.16
> 
> https://github.com/hedayaty/NetSpeed/blob/master/CHANGELOG

I'd interpreted the version numbers there to be the version of GNOME Shell with
which they were working to be compatible. This would be an abuse of the usual
CHANGELOG format, but would explain why:

* Each listed releases seems to skip several releases -- not just odd/even
releases like the current GNOME convention, but often *four* "minor" releases
at a time. 
* The "Oct 12 2013" release has two different versions, which match the
explicitly referenced GNOME Shell versions in that release's description.
* A version number of 3.x matching the GNOME scheme conflicts with the version
number used in metadata.json which is a single integer, currently in the mid
20s.

...But maybe that's also something upstream should clarify. I've added another
comment to this issue:

  https://github.com/hedayaty/NetSpeed/issues/52

I'm beginning to have doubts that upstream is ever going to answer, though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434127] Review Request: dehydrated - A client for signing certificates with an ACME server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434127



--- Comment #3 from Patrick Uiterwijk  ---
I had the bitmask wrong inside my head, and thought that 1=read, but 4=read and
1=execute. File permissions look good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434127] Review Request: dehydrated - A client for signing certificates with an ACME server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434127

Patrick Uiterwijk  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #2 from Patrick Uiterwijk  ---
Please add the %license file before import and please check file permissions.

No serious issues, so APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434127] Review Request: dehydrated - A client for signing certificates with an ACME server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434127



--- Comment #1 from Patrick Uiterwijk  ---
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
X License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
8114ba0144a158d5ad1bdf02e6f43195  v0.4.0
8114ba0144a158d5ad1bdf02e6f43195  srpm/dehydrated-0.4.0.tar.gz
+ Package needs ExcludeArch
+ BuildRequires correct
X Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
Fine:
dehydrated.src: W: spelling-error %description -l en_US openssl -> slope
dehydrated.src: W: spelling-error %description -l en_US subdomains -> sub
domains, sub-domains, domains
dehydrated.noarch: W: spelling-error %description -l en_US subdomains ->
sub domains, sub-domains, domains
dehydrated.noarch: W: only-non-binary-in-usr-lib
dehydrated.noarch: E: non-standard-executable-perm /etc/dehydrated/hook.sh
750
dehydrated.noarch: E: wrong-script-interpreter /etc/dehydrated/hook.sh
/usr/bin/env bash
dehydrated.noarch: W: non-ghost-in-run /run/dehydrated
dehydrated.noarch: E: non-standard-dir-perm /run/dehydrated 750
dehydrated.noarch: E: wrong-script-interpreter /usr/bin/dehydrated
/usr/bin/env bash
dehydrated.noarch: E: wrong-script-interpreter
/usr/share/doc/dehydrated/examples/hook.sh /usr/bin/env bash
dehydrated.noarch: W: no-manual-page-for-binary dehydrated

Understandable:
dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated 750
dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/accounts 750
dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/archive 750
dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/certs 750
dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/conf.d 750

Possibly wrong:
dehydrated.noarch: E: non-readable /etc/dehydrated/conf.d/local.sh 640
dehydrated.noarch: E: non-readable /etc/dehydrated/config 640
dehydrated.noarch: E: non-readable /etc/dehydrated/domains.txt 640
dehydrated.noarch: E: non-readable /etc/dehydrated/hook.sh 750


+ final provides and requires are sane:
Provides:
config(dehydrated) = 0.4.0-4.fc27
dehydrated = 0.4.0-4.fc27

Requires:
/bin/sh
/usr/bin/env
config(dehydrated) = 0.4.0-4.fc27
curl
openssl


SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
+ Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version

Issues:

1. License file included in package
2. Package has %defattr and permissions on files is good. - Some of the
permissions are strange

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433744] Review Request: python-mutatormath - Python library for piecewise linear interpolation in multiple dimensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433744



--- Comment #2 from Athos Ribeiro  ---
Hello,

Thank you for taking this! All dependencies are now in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433744] Review Request: python-mutatormath - Python library for piecewise linear interpolation in multiple dimensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433744
Bug 1433744 depends on bug 1433745, which changed state.

Bug 1433745 Summary: Python 3 version is available
https://bugzilla.redhat.com/show_bug.cgi?id=1433745

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769958] Review Request: eqp - Automated theorem prover for first-order equational logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769958



--- Comment #17 from John C Peterson  ---

I have posted an updated SRPM as noted below.

I added the emails I got from Argonne National Lab in response to my query for
clarification of the license terms to the LICENSE file. In the spec file, I
moved LICENSE from %doc to the %license macro in the %files section.

When running eqp, the output contains some dynamic information such as run
date/time stamps, and CPU time used. This makes it complicated to test the
program using a simple diff command on the output produced. However, eqp
returns a status code of 10 to the shell when a proof is found. I used this
feature to construct a %check section in the spec file. It runs the executable
on some of the provided examples and checks for the expected return status code
of 10 to determine success / failure.

A scratch build of the updated SRPM against rawhide here;
https://koji.fedoraproject.org/koji/taskinfo?taskID=18494235

Spec URL: http://www.eskimo.com/~jcp/eqp.spec
SRPM URL: http://www.eskimo.com/~jcp/eqp-09e-5.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #10 from Fedora Update System  ---
rhash-1.3.4-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-151dcf8238

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #9 from Fedora Update System  ---
rhash-1.3.4-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-304745e071

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #8 from Fedora Update System  ---
rhash-1.3.4-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8082242eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #7 from Fedora Update System  ---
rhash-1.3.4-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ac9767acaa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #6 from Fedora Update System  ---
rhash-1.3.4-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-32aa797500

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #8 from Fedora Update System  ---
openblas-srpm-macros-1-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0fd5d555e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #9 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-234297c86d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #6 from Fedora Update System  ---
openblas-srpm-macros-1-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-90b7ce39a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #7 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ffe86c893

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #5 from Fedora Update System  ---
openblas-srpm-macros-1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3ad56ffc05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #14 from Kalev Lember  ---
Excellent. Thank you for the quick review, Neal!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Neal Gompa  ---
Hmm, if you're sure... Aside from this and the metainfo thing, fedora-review
and rpmlint are happy, so...

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433686] Review Request: scram - Probabilistic risk analysis tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433686



--- Comment #4 from ol.rakhi...@gmail.com ---
Thanks Peter for the review and sponsorship!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #12 from Kalev Lember  ---
It most definitely gets pulled in. Something like tilix->gtkd->gtk3->glib2 dep
chain or so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #11 from Neal Gompa  ---
Actually, it appears that glib2 isn't pulled in by *any* dependencies, so it
needs to be added as a Requires. It's also needed to ensure the file trigger
fires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #10 from Kalev Lember  ---
I've updated the spec file to make sure all the license files that upstream
ships are included.

* Mon Mar 20 2017 Kalev Lember  - 1.5.4-4
- Include data/icons/LICENSE and source/x11/LICENSE as %%license (#1434003)

Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-4.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428974] Review Request: rgbds - A development package for Game Boy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428974



--- Comment #11 from Miro Hrončok  ---
Thanks spot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #9 from Kalev Lember  ---
Probably, but this shouldn't be a blocker for the package review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #8 from Neal Gompa  ---
Can you get upstream to include license files for all licenses that the project
is covered under?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413646] Review Request: librealsense - Cross-platform camera capture for Intel RealSense

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413646

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #5 from Tom "spot" Callaway  ---
CLA does not impose additional restrictions on the license of librealsense,
only on their acceptance of contributions to that codebase. 

Lifting FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434127] Review Request: dehydrated - A client for signing certificates with an ACME server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434127

Paul Wouters  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|puiterw...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #7 from Kalev Lember  ---
(In reply to Neal Gompa from comment #6)
> Created attachment 1264822 [details]
> licensecheck output for tilix
> 
> Some issues encountered by fedora-review:
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "GPL (v2 or later)", "GPL (v3 or later)", "*No copyright* CC
>  by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL (v2.0)",
>  "MPL (v2.0)". 126 files have unknown license. Detailed output of
>  licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt
> 
> Please verify with upstream that the licensing is sane. licensecheck output
> attached to this bug.

Thanks. I've updated the licensing breakdown, which now reads:

# The tilix source code is MPLv2.0,
# source/gx/gtk/x11.d is GPLv2+,
# source/secret is LGPLv3+,
# source/x11 and com.gexperts.Tilix.gschema.xml are GPLv3+,
# icons are CC-BY-SA.
# This makes the combined license: 
License:MPLv2.0 and GPLv3+ and CC-BY-SA

> [!]: Package requires other packages for directories it uses.
>  Note: No known owner of /usr/share/metainfo
> 
> Until we migrate from /usr/share/appdata to /usr/share/metainfo completely
> (tooling, dependency generators, etc.), please move metainfo/appdata files
> to /usr/share/appdata.

Putting appdata files in that directory is completely fine. I just recently
fixed the appstream generator to work with /usr/share/metainfo. As for the
directory ownership, this belongs to the filesystem package. I've already filed
a filesystem ticket earlier today to add it,
https://bugzilla.redhat.com/show_bug.cgi?id=1434008


> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners:
>  /usr/share/icons/hicolor/22x22/apps,
>  /usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo,
>  /usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24,
>  /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16,
>  /usr/share/icons/hicolor/48x48/apps,
>  /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
>  /usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1,
>  /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32,
>  /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22,
>  /usr/share/glib-2.0, /usr/share/icons/hicolor/512x512,
>  /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48,
>  /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable
> 
> The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The
> dbus dir ownership can be fixed with Req on dbus, I believe. The glib-2.0
> dirs issue can probably be fixed by Req glib2, though that should be
> happening already...

Thanks, I've added explicit dbus and hicolor-icon-theme deps. glib2 is
definitely pulled in via dependencies and there's no need to add it.

* Mon Mar 20 2017 Kalev Lember  - 1.5.4-3
- Update licensing breakdown (#1434003)
- Add explicit dbus and hicolor-icon-theme deps for directory ownership

Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434127] New: Review Request: dehydrated - A client for signing certificates with an ACME server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434127

Bug ID: 1434127
   Summary: Review Request: dehydrated - A client for signing
certificates with an ACME server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: pwout...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://nohats.ca/ftp/dehydrated/dehydrated.spec
SRPM URL:
https://nohats.ca/ftp/dehydrated/dehydrated-0.4.0-4.el7.centos.src.rpm
Description: A client for signing certificates with an ACME server
Fedora Account System Username: pwouters

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425275] Review Request: php-szymach-c-pchart - A project bringing composer support and PSR standards to pChart 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425275

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428974] Review Request: rgbds - A development package for Game Boy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428974

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #10 from Tom "spot" Callaway  ---
The use of the Nintendo logo in this specific scenario is fair use in the
United States, and is permissible. Please be careful not to expose it or use it
in any other situations.

Lifting FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #32 from Fedora Update System  ---
legion-17.02.0-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-afffad953e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #31 from Fedora Update System  ---
legion-17.02.0-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-66f593ab1a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #7 from Yaakov Selkowitz  ---
(In reply to Nicolas Chauvet (kwizart) from comment #6)
> Changelog:
> - Add obsoletes/provides for a52dec-devel

Not quite:

-Provides:   %{name} = %{version}-%{release}
-Obsoletes:  %{name} < 0.7.4-23
+Provides:   %{name}-devel = %{version}-%{release}
+Obsoletes:  %{name}-devel < 0.7.4-23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #6 from Neal Gompa  ---
Created attachment 1264822
  --> https://bugzilla.redhat.com/attachment.cgi?id=1264822=edit
licensecheck output for tilix

Some issues encountered by fedora-review:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "GPL (v3 or later)", "*No copyright* CC
 by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL (v2.0)",
 "MPL (v2.0)". 126 files have unknown license. Detailed output of
 licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt

Please verify with upstream that the licensing is sane. licensecheck output
attached to this bug.

[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/metainfo

Until we migrate from /usr/share/appdata to /usr/share/metainfo completely
(tooling, dependency generators, etc.), please move metainfo/appdata files to
/usr/share/appdata.

[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/22x22/apps,
 /usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo,
 /usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24,
 /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16,
 /usr/share/icons/hicolor/48x48/apps,
 /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1,
 /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32,
 /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22,
 /usr/share/glib-2.0, /usr/share/icons/hicolor/512x512,
 /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48,
 /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable

The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The dbus
dir ownership can be fixed with Req on dbus, I believe. The glib-2.0 dirs issue
can probably be fixed by Req glib2, though that should be happening already...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rhash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/openblas-srpm-macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974

Orion Poplawski  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jama...@fc.up.pt



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430974] Review Request: rhash - Great utility for computing hash sums

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430974



--- Comment #4 from Orion Poplawski  ---
Thanks for the review and catching the test-shared target.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #6 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-24.fc24.src.rpm
Description: Small test program for liba52

Changelog:
- Add obsoletes/provides for a52dec-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #5 from Kalev Lember  ---
Sorry, I typoed the SRPM link above.

Spec URL: https://kalev.fedorapeople.org/tilix.spec
SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030

Dan Horák  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Dan Horák  ---
All is good now, package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003



--- Comment #4 from Neal Gompa  ---
@Kalev,

Your SRPM and spec don't match.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #5 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-23.fc24.src.rpm
Description: Small test program for liba52

(typo on SRPM URL address).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434003] Review Request: tilix - Tiling terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434003

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030



--- Comment #2 from Orion Poplawski  ---
Gah, didn't switch over from the old method properly.  Updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

Summary|Review Request: a52dec - A  |Review Request: a52dec -
   |free ATSC A/52 stream   |Small test program for
   |decoder |liba52



--- Comment #4 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-24.fc24.src.rpm
Description: Small test program for liba52

Changelog:
- Multilibs support - rhbz#1433758
- Simplify description
- Convert AUTHORS to UTF-8
- Drop Groups

rpmlint issue is about wrong fsf address are not expected to be patched:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030

Dan Horák  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||d...@danny.cz
   Assignee|nob...@fedoraproject.org|d...@danny.cz
  Flags||fedora-review+



--- Comment #1 from Dan Horák  ---
review notes before approving
- I would change the Summary to eg. OpenBLAS architecture macros
- the content of the macros.openblas-srpm file should be like
http://pkgs.fedoraproject.org/cgit/rpms/ocaml-srpm-macros.git/tree/macros.ocaml-srpm
- not a plain list of arches, but rather proper macro definition

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434030] Review Request: openblas-srpm-macros - RPM macros for building source packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434030

Dan Horák  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261

Yaakov Selkowitz  changed:

   What|Removed |Added

  Flags|needinfo?(yselkowi@redhat.c |
   |om) |



--- Comment #13 from Yaakov Selkowitz  ---
(In reply to Peter Lemenkov from comment #12)
> Turned out that mad-plugin was removed from the repo:

Well, that answers my question.

> So we should stick with mpg123.

Agreed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261



--- Comment #12 from Peter Lemenkov  ---
(In reply to Yaakov Selkowitz from comment #6)
> (In reply to Peter Lemenkov from comment #5)
> > I wonder why do we have libmad plugin enabled. AFAIK mad development was
> > halted ~12 years ago or so. On the contrary mpg123' development is still
> > ongoing.
> > 
> > Does mad plugin provides some extra functionality missing in mpg123?
> > Performance benefits?
> 
> mad has been around longer and therefore more established.  The mpg123
> plugin was just moved from -bad to -ugly, and also has lower rank than mad. 
> Therefore, without any additional information, I have to presume that the
> GStreamer developers consider the mad plugin to be preferred; whether that
> can or should be changed would be up to them.

Turned out that mad-plugin was removed from the repo:

https://cgit.freedesktop.org/gstreamer/gst-plugins-ugly/commit/ext?id=2f767fb

So we should stick with mpg123.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261

Yaakov Selkowitz  changed:

   What|Removed |Added

 Depends On||1433758



--- Comment #11 from Yaakov Selkowitz  ---
a52dec can be enabled pending bug 1433758.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1433758
[Bug 1433758] Review Request: a52dec - A free ATSC A/52 stream decoder
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - A free ATSC A/52 stream decoder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1397261




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397261
[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly
plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org