[Bug 1448778] Review Request: cockatrice - A cross-platform virtual tabletop for multiplayer card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448778



--- Comment #17 from Fedora Update System  ---
cockatrice-2.3.17-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b23dedc563

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448778] Review Request: cockatrice - A cross-platform virtual tabletop for multiplayer card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448778



--- Comment #16 from Fedora Update System  ---
cockatrice-2.3.17-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-54dfd06b53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448778] Review Request: cockatrice - A cross-platform virtual tabletop for multiplayer card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448778



--- Comment #15 from Fedora Update System  ---
cockatrice-2.3.17-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ccfa72ff5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448778] Review Request: cockatrice - A cross-platform virtual tabletop for multiplayer card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448778

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324863



--- Comment #23 from Fedora Update System  ---
varnish-modules-0.12.1-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-304f58adbe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324863

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
varnish-modules-0.12.1-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f99d33da0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457395] Review Request: R-futile.logger - A logging utility for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457395

Mattias Ellert  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mattias.ell...@physics.uu.s
   ||e
  Flags||fedora-review+



--- Comment #3 from Mattias Ellert  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===

Approved, but there is a warning during %check as mentioned below.
Please check if it is relevant.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
 The DESCRIPTION file states "License: LGPL-3".
 This licence is also mentioned in the package's documentation and
 in a comment in one of its source files.
 No other license statements found in sources.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
 No license file in sources.
[x]: License field in the package spec file matches the actual license.
 Spec file states "License: LGPLv3".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
 The package naming guidelines say:
 "the maintainer must use the dash '-' as the delimiter for name parts"
 However, this package uses a full stop as a separator between parts.
 The R packaging guidlines say:
 "Packages of R modules have their own naming scheme. They should
 take into account the upstream name of the R module. This makes a
 package name format of R-$NAME. When in doubt, use the name of
 the module that you type to import it in R."
 So according to this the name with the full stop should be used.
 Since the package R-BSgenome.Celegans.UCSC.ce2 already exists in
 Fedora using the name with the full stop is consistent with the
 naming of existing packages.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
 Matches the Imports in the DESCRIPTION file.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.
[x]: Package requires R-core.

[Bug 1458247] Review Request: translate-shell - a command-line online translator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458247



--- Comment #2 from Vasiliy Glazov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/translate-shell/master/translate-shell.spec
SRPM URL:
http://koji.russianfedora.pro/kojifiles/work/tasks/9617/49617/translate-shell-0.9.6.4-2.fc27.src.rpm

Patched Makefile to correct install path and remove build during install. Clean
spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448661] Review Request: brotli - Lossless compression algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448661

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-06-02 22:35:48



--- Comment #17 from Fedora Update System  ---
brotli-0.6.0-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1452985] Review Request: zef - Perl6 Module Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1452985



--- Comment #13 from Gerd Pokorra  ---
Thank you for your support so far Paul. I like the idea that the rakudo package
should provide a macro file. Thank you for the information and organisation
that someone is running on that. I will be on a trip this weekend. Next week I
will not have much time. So I can not do a rakudo package update before the
next 7 or 14 days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404883] Review Request: python-aiosmtpd - Asyncio-based SMTP server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404883

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404883] Review Request: python-aiosmtpd - Asyncio-based SMTP server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404883



--- Comment #2 from Neal Gompa  ---
> BuildRequires:  python3-pkgversion-macros

This package has been superseded by "python-srpm-macros" and thus doesn't build
in Rawhide anymore. Please replace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445923] Review Request: streameye - Simple MJPEG streamer for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445923



--- Comment #9 from Jan Kalina  ---
Package update by fedora-review notes:
http://test.jazkor.cz/streameye-0.8-2.fc25.src.rpm
http://test.jazkor.cz/streameye.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404882] Review Request: python-atpublic - Decorator for populating a Python module's __all__

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404882



--- Comment #2 from Neal Gompa  ---
> BuildRequires: python3-pkgversion-macros

This package has been superseded by "python-srpm-macros" and thus doesn't build
in Rawhide anymore. Please replace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404882] Review Request: python-atpublic - Decorator for populating a Python module's __all__

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404882

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458441] Review Request: python-script - Bindings for the scrypt key derivation function library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458441

Haïkel Guémar  changed:

   What|Removed |Added

 Blocks||1427510 (RDO-PIKE)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427510
[Bug 1427510] Tracker: Blockers and Review requests for new RDO Pike
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458441] New: Review Request: python-script - Bindings for the scrypt key derivation function library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458441

Bug ID: 1458441
   Summary: Review Request: python-script - Bindings for the
scrypt key derivation function library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: karlthe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://hguemar.fedorapeople.org/reviews/python-scrypt.spec
SRPM URL:
https://hguemar.fedorapeople.org/reviews/python-scrypt-0.8.0-1.fc26.src.rpm
Description: Bindings for the scrypt key derivation function library
Fedora Account System Username: hguemar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728



--- Comment #14 from Jan Kalina  ---
Thanks for update!
If you are not owner of upstream repo, please ignore my note about tagging - in
such case is using git hash to identity version OK. Just note that we have
following guidelines for snapshot versions packaging:

- When upstream has never chosen a version, you MUST use "Version: 0".
- All snapshots MUST contain a snapshot information field in the Release: tag.
That field must at minimum consist of the date in eight-digit "MMDD"
format. The packager MAY include up to 17 characters of additional information
after the date. The following formats are suggested:

MMDD.
MMDD 

see https://fedoraproject.org/wiki/Packaging:Versioning

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456244] Review Request: vocal - Powerful, beautiful, and simple podcast client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456244

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Neal Gompa  ---
Looks good.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456244] Review Request: vocal - Powerful, beautiful, and simple podcast client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456244



--- Comment #2 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "LGPL (v3)", "GPL (v3 or later)", "Unknown or
 generated". 239 files have unknown license. Detailed output of
 licensecheck in /home/makerpm/1456244-vocal/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/locale/ckb,
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
 /usr/share/locale/ckb/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in vocal
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vocal-
 debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English 

[Bug 812758] Review Request: trader - Star Traders, a simple game of interstellar trading

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=812758



--- Comment #28 from John Zaitseff  ---
I am not sure why I never received comment 27.  I apologise: life has been
extremely busy the past year, but I am able to get back to this package.

To answer concerns in comment 27 and 22, I have added a .desktop file to the
latest release of Star Traders, as well as matching icons.  I have not, at this
stage, added an .xml.appdata file.  I have also used the %license macro in the
spec file:

Spec URL: ftp://ftp.zap.org.au/pub/trader/unix/binary/fedora/trader.spec
SRPM URL:
ftp://ftp.zap.org.au/pub/trader/unix/binary/fedora/trader-7.10-1.fc25.src.rpm

x86_64 binary URL:
ftp://ftp.zap.org.au/pub/trader/unix/binary/fedora/trader-7.10-1.fc25.x86_64.rpm
i686 binary URL:
ftp://ftp.zap.org.au/pub/trader/unix/binary/fedora/trader-7.10-1.fc25.i686.rpm

Could someone please review (in light of previous comments) and, hopefully,
approve.  Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #8 from srakitnican  ---
This is much more like it:
$ rpm -qp --requires
/var/lib/mock/fedora-25-x86_64/result/libdxflib-3.17.0-2.fc25.x86_64.rpm 
/sbin/ldconfig
/sbin/ldconfig
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit)
libstdc++.so.6(GLIBCXX_3.4.11)(64bit)
libstdc++.so.6(GLIBCXX_3.4.20)(64bit)
libstdc++.so.6(GLIBCXX_3.4.21)(64bit)
libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)


Changes from previous release:

* Remove unicode trademark sign from description
* Use macro for make
* Disable qmake linking to Qt


SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/srakitnican/default/libdxflib.git/plain/libdxflib.spec?id=408bff6bcd4c11bae4a063e7115b2c8c792fa153
SRPM:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-25-ppc64le/00561004-libdxflib/libdxflib-3.17.0-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458355] Review Request: fedora-modular-repos - Fedora Modular package repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458355



--- Comment #1 from Troy Dawson  ---
The spec file was missing %{dist}.  Here is the updated spec and srpm

Spec URL: https://tdawson.fedorapeople.org/review/fedora-modular-repos.spec
SRPM URL:
https://tdawson.fedorapeople.org/review/fedora-modular-repos-26-0.1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457395] Review Request: R-futile.logger - A logging utility for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457395



--- Comment #2 from Tom "spot" Callaway  ---
Fixed in -2:

Spec URL: https://spot.fedorapeople.org/R-futile.logger.spec
SRPM URL: https://spot.fedorapeople.org/R-futile.logger-1.4.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457395] Review Request: R-futile.logger - A logging utility for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457395

Mattias Ellert  changed:

   What|Removed |Added

 CC||mattias.ell...@physics.uu.s
   ||e



--- Comment #1 from Mattias Ellert  ---
Missing BuildRequires: R-testthat

* checking tests ...
  Running 'testthat.R'
 ERROR
Running the tests in 'tests/testthat.R' failed.
Complete output:
  > library(testthat)
  Error in library(testthat) : there is no package called 'testthat'
  Execution halted

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418396] Review Request: the-new-hotness - Consume Anitya fedmsg messages to file bugzilla bugs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418396

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Björn "besser82" Esser  ---
Package LGTM now!

One suggestion:

 * I'd use
   %{python2_sitelib}/the_new_hotness-%{version}-py%{python2_version}.egg-info
   instead of globbing %{python2_sitelib}/the_new_hotness-*.egg-info
   You are free whether to change this or not during import.


= Solution =

Package APPROVED!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418396] Review Request: the-new-hotness - Consume Anitya fedmsg messages to file bugzilla bugs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418396



--- Comment #11 from Jeremy Cline  ---
Thanks for the review, I've addressed the issues.

SRPM URL: https://jcline.fedorapeople.org/the-new-hotness-0.8.1-2.fc27.src.rpm
Spec URL: https://jcline.fedorapeople.org/the-new-hotness.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #7 from srakitnican  ---
I am actually wondering why it depends on Qt at all, I thought it is using it
just for the build system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409654

Randy Barlow  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409654

Randy Barlow  changed:

   What|Removed |Added

  Flags|needinfo?(randy@electronswe |
   |atshop.com) |



--- Comment #10 from Randy Barlow  ---
Created attachment 1284508
  --> https://bugzilla.redhat.com/attachment.cgi?id=1284508=edit
review.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409654

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456203] Review Request: jumpnbump - Cute multiplayer platform game with bunnies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456203



--- Comment #22 from Fedora Update System  ---
jumpnbump-1.60-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf8d29889c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456203] Review Request: jumpnbump - Cute multiplayer platform game with bunnies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456203



--- Comment #21 from Fedora Update System  ---
jumpnbump-1.60-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2206fc38a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456203] Review Request: jumpnbump - Cute multiplayer platform game with bunnies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456203



--- Comment #20 from Fedora Update System  ---
jumpnbump-1.60-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7f7dd3851b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456203] Review Request: jumpnbump - Cute multiplayer platform game with bunnies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456203

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456203] Review Request: jumpnbump - Cute multiplayer platform game with bunnies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456203



--- Comment #19 from Fedora Update System  ---
jumpnbump-1.60-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e6d3ae98ce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #6 from srakitnican  ---
Under the same name/path?

I am asking because here's the case that library is called exactly the same for
both qt4 and qt5, in that case packages would conflict, is that OK?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418396] Review Request: the-new-hotness - Consume Anitya fedmsg messages to file bugzilla bugs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418396



--- Comment #10 from Björn "besser82" Esser  ---
Created attachment 1284493
  --> https://bugzilla.redhat.com/attachment.cgi?id=1284493=edit
licensecheck from fedora-review

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "*No copyright* GPL (v2 or later)",
 "GPL (v2 or later)", "Unknown or generated". 29 files have unknown
 license. Detailed output of licensecheck is attached.

 ---> Some of the (installed) sources are licensed GPLv2+, which is not
  reflected by the License tag.

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines

 ---> Severe issues in License tag are present

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep


= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in the-new-
 hotness-doc

 ---> doc-pkg is fine to be standalone.

[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: 

[Bug 1458394] Re-Review Request: nuvolaruntime - Tight integration of web apps with your desktop, renaming nuvolaplayer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458394

mgans...@alice.de  changed:

   What|Removed |Added

URL||https://github.com/tiliado/
   ||nuvolaruntime
 CC||vondr...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #5 from Antonio Trande  ---
(In reply to srakitnican from comment #4)
> Thank you for your review!
> 
> (In reply to Antonio Trande from comment #3)
> > SPEC url is not reachable with Fedora tools, please use that one from copr
> > or a direct link to the file as a plain text.
> 
> There is no git tree when first version of the package is submitted, hence I
> can not use copr for that, but I should be able to use it for next releases.
> 
> 
> > ===
> > - qcad is built with Qt5 on Fedora rawhide (27).
> >   Please, make a Qt5 version too.
> 
> I am not sure what do you mean by that. Should I build a separate package,
> subpackage, or just make it an option?
> 
> Do you have any examples of similar packages?
>  
> > - You can use %make_build and %make_install macros.
> 
> I think I can use %make_build, not so sure about %make_install.

A sub-package like 'qt5-streamer':
http://pkgs.fedoraproject.org/cgit/rpms/qt-gstreamer.git/tree/qt-gstreamer.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458394] New: Re-Review Request: nuvolaruntime - Tight integration of web apps with your desktop, renaming nuvolaplayer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458394

Bug ID: 1458394
   Summary: Re-Review Request: nuvolaruntime - Tight integration
of web apps with your desktop, renaming nuvolaplayer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mgans...@online.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaruntime.specSRPM
URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaruntime-4.4.0-1.fc25.src.rpmDescription:


Fedora Account System Username: martinkg

Description: This is a rename of nuvolaplayer which has had a rename upstream. 
Nuvola Apps™ is a runtime for semi-sandboxed web apps providing more native
user experience and tighter integration with Linux desktop environments than
usual web browsers can offer. It tries to feel and look like a native
application as much as possible. Nuvola™ mostly specializes on music streaming
web apps (e.g. Google Play Music, Spotify, Amazon Music, Deezer, nd more), but
progress is being made to support generic web apps (e.g. Google Calendar,
Google Keep, etc.).

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19811293

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #4 from srakitnican  ---
Thank you for your review!

(In reply to Antonio Trande from comment #3)
> SPEC url is not reachable with Fedora tools, please use that one from copr
> or a direct link to the file as a plain text.

There is no git tree when first version of the package is submitted, hence I
can not use copr for that, but I should be able to use it for next releases.


> ===
> - qcad is built with Qt5 on Fedora rawhide (27).
>   Please, make a Qt5 version too.

I am not sure what do you mean by that. Should I build a separate package,
subpackage, or just make it an option?

Do you have any examples of similar packages?

> - You can use %make_build and %make_install macros.

I think I can use %make_build, not so sure about %make_install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #86 from Fedora Update System  ---
openjfx-8.0.152-10.b04.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2f213a60e5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418396] Review Request: the-new-hotness - Consume Anitya fedmsg messages to file bugzilla bugs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418396

Björn "besser82" Esser  changed:

   What|Removed |Added

 CC||besse...@fedoraproject.org
   Assignee|ignate...@redhat.com|besse...@fedoraproject.org
  Flags||fedora-review?



--- Comment #9 from Björn "besser82" Esser  ---
I'll take it for review…

From having a quick look over the spec file:

 * Group tag is obsolete since el6.  I'd suggest removal.

 * It's better to use %make_build instead of make %{?_smp_mflags}.

 * %autosetup -p1 -n %{name}-%{version}:  You can omit ' -n
%{name}-%{version}'.

 * %{python2_sitelib}/*:  Simply globbing the whole contents of this subdir
   usualy isn't a good idea…  It's better to explicitly name the single dirs
   or files being dropped there;  this is especially important when converting
   a package to python3 later.


I'll run f-r in the meantime.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #85 from Fedora Update System  ---
openjfx-8.0.152-10.b04.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9d1a0520b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421366] Review Request: MSearch - Mandatory library for MediathekView

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421366
Bug 1421366 depends on bug 1438673, which changed state.

Bug 1438673 Summary: Review Request: openjfx - Rich client application platform 
for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1438673

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426243] Review Request: MediathekView - Searches the online media library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426243
Bug 1426243 depends on bug 1438673, which changed state.

Bug 1438673 Summary: Review Request: openjfx - Rich client application platform 
for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1438673

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673

Jonny Heggheim  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-06-02 13:40:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949



--- Comment #3 from Antonio Trande  ---
SPEC url is not reachable with Fedora tools, please use that one from copr or a
direct link to the file as a plain text.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- qcad is built with Qt5 on Fedora rawhide (27).
  Please, make a Qt5 version too.

- You can use %make_build and %make_install macros.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL", "GPL (v2 or later)", "Unknown or generated". 14 files
 have unknown license. Detailed output of licensecheck in
 /home/sagitter/libdxflib/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 libdxflib-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 

[Bug 1418396] Review Request: the-new-hotness - Consume Anitya fedmsg messages to file bugzilla bugs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418396



--- Comment #8 from Jeremy Cline  ---
Updated to latest upstream


SRPM URL: https://jcline.fedorapeople.org/the-new-hotness-0.8.1-1.fc27.src.rpm
Spec URL: https://jcline.fedorapeople.org/the-new-hotness.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458355] Review Request: fedora-modular-repos - Fedora Modular package repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458355

Troy Dawson  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|sgall...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442497] Review Request: nodejs-is-plain-object - Returns true if an object was created by the constructor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442497



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-is-plain-object

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #84 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/openjfx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437036] Review Request: apache-logging-parent - Parent pom for Apache Logging Services projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437036

Jonny Heggheim  changed:

   What|Removed |Added

 CC||heg...@gmail.com
 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #83 from Jonny Heggheim  ---
(In reply to Michal Vala from comment #82)
> please remove commented-out code from spec before submit.
> 
> approved. Thank you for great job!

Great, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458355] New: Review Request: fedora-modular-repos - Fedora Modular package repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458355

Bug ID: 1458355
   Summary: Review Request: fedora-modular-repos - Fedora Modular
package repositories
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tdaw...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://tdawson.fedorapeople.org/review/fedora-modular-repos.spec
SRPM URL:
https://tdawson.fedorapeople.org/review/fedora-modular-repos-26-0.1.src.rpm
Description: Fedora modular repository files for yum and dnf along with gpg
public keys
Fedora Account System Username: tdawson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451075] Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451075

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-06-02 12:07:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728



--- Comment #13 from c72...@yahoo.de ---
Dear Jan,
thank you very much for your valuable feedback and the review.

The spec file has been updated according to your suggestions:

* Fri Jun 02 2017 Wolfgang Stöggl  - 0.0.0-0.6.gitb56fa78
- Removed BR: gcc-c++
- Added check section and tests

Concerning the hidden ".build-id", I found the following:
https://bugzilla.redhat.com/show_bug.cgi?id=1431408

Versioning or tag library version in git before packaging seems to be a
challenge. Upstream is "difficult" to reach and "not too active". Any advice
how to handle the versioning alternatively?

Spec URL:
https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cld2.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/c72578/cld2/fedora-rawhide-x86_64/00560950-cld2/cld2-0.0.0-0.6.gitb56fa78.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457447] Review Request: R-matrixStats - Functions that Apply to Rows and Columns of Matrices ( and to Vectors)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457447



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-matrixStats

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457405] Review Request: R-R6 - Classes with Reference Semantics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457405



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-R6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457404] Review Request: R-magrittr - Provides a mechanism for chaining commands with a new forward-pipe operato

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457404



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-magrittr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457393] Review Request: R-lambda.r - Modeling data with functional programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457393



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-lambda.r

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457391] Review Request: R-futile.options - Futile options management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457391



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-futile.options

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457390] Review Request: R-snow - Simple Network of Workstations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457390



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-snow

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1456973] Review Request: R-GenomeInfoDbData - Species and taxonomy ID look up tables used by GenomeInfoDb

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1456973



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/R-GenomeInfoDbData

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #2 from Tom "spot" Callaway  ---
** This file is free software; you can redistribute it and/or modify
** it under the terms of the GNU General Public License as published by
** the Free Software Foundation; either version 2 of the License, or
** (at your option) any later version.
**
** Licensees holding valid dxflib Professional Edition licenses may use 
** this file in accordance with the dxflib Commercial License
** Agreement provided with the Software.
**
** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
**

Basically, in English, if the GPL makes you uncomfortable, you can buy a
proprietary license to use dxflib. Since the GPL does not make us
uncomfortable, we will use it under that license. :)

Lifting FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448778] Review Request: cockatrice - A cross-platform virtual tabletop for multiplayer card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448778



--- Comment #14 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/cockatrice

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420100] Review Request: perl-Mail-Transport - Email message exchange code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420100



--- Comment #9 from Fedora Update System  ---
perl-Mail-Box-3.002-1.fc26 perl-Mail-Transport-3.000-2.fc26 has been submitted
as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fda53d1ef7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420100] Review Request: perl-Mail-Transport - Email message exchange code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420100

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445923] Review Request: streameye - Simple MJPEG streamer for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445923



--- Comment #8 from Jan Kalina  ---
Third informal review: https://bugzilla.redhat.com/show_bug.cgi?id=1441728#c12

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728

Jan Kalina  changed:

   What|Removed |Added

 CC||jkal...@redhat.com



--- Comment #12 from Jan Kalina  ---
Informal (UNOFFICIAL) Package Review

I dont think it is fedora requirement, but I would recommend to tag
library version in git before packaging - version "0.0.0" in RPM looks
weird and you can use readable git tag name instead of commit hash.

As automated tests are included in source package, their run SHOULD
be also included in %check section.

Not sure, but I also think hidden ".build-id" directory should not be
included in package.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 25 files have unknown license. Detailed output of
 licensecheck in /home/jkalina/review-cld2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(ddcutil)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 747520 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or 

[Bug 1448041] Review Request: python-metakernel - Metakernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448041

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448041] Review Request: python-metakernel - Metakernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448041



--- Comment #5 from Fedora Update System  ---
python-metakernel-0.20.2-2.fc26 python-ipyparallel-6.0.2-2.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9c373ea651

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448040] Review Request: python-ipyparallel - Interactive Parallel Computing with IPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448040

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448040] Review Request: python-ipyparallel - Interactive Parallel Computing with IPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448040



--- Comment #5 from Fedora Update System  ---
python-metakernel-0.20.2-2.fc26 python-ipyparallel-6.0.2-2.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9c373ea651

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457447] Review Request: R-matrixStats - Functions that Apply to Rows and Columns of Matrices ( and to Vectors)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457447

José Matos  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from José Matos  ---
The package is simple

This package is approved.

As in other packages I am not sure about DESCRIPTION as %doc but, if necessary,
this can be fixed later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457447] Review Request: R-matrixStats - Functions that Apply to Rows and Columns of Matrices ( and to Vectors)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457447

José Matos  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jama...@fc.up.pt
   Assignee|nob...@fedoraproject.org|jama...@fc.up.pt
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 886112] Review Request: gwyddion - SPM analysis tool in gtk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=886112

Jan Kalina  changed:

   What|Removed |Added

 CC||jkal...@redhat.com
  Flags||needinfo?(lennart@die-frick
   ||es.eu)



--- Comment #14 from Jan Kalina  ---
It is not possible to build in mocked environment (try it in fedora-review
tool):

/usr/bin/install: cannot stat 'Gwyddion::dump.3pm': No such file or directory
make[2]: *** [Makefile:583: install-data-local] Error 1
make[2]: Leaving directory '/builddir/build/BUILD/gwyddion-2.30/perl'
make[1]: *** [Makefile:464: install-am] Error 2
make[1]: Leaving directory '/builddir/build/BUILD/gwyddion-2.30/perl'
make: *** [Makefile:531: install-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.yjtbOC (%install)
Bad exit status from /var/tmp/rpm-tmp.yjtbOC (%install)

Also "rm -rf %{buildroot}" should be removed from %install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1171746] Review Request: garmon - Gnome/GTK+ Car Monitor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1171746

Jan Kalina  changed:

   What|Removed |Added

 CC||jkal...@redhat.com
  Flags||needinfo?(ppapadeas@gmail.c
   ||om)



--- Comment #5 from Jan Kalina  ---
SRPM url and Spec url are invalid - unable to download SRPM of Spec - please
send new links in comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458247] Review Request: translate-shell - a command-line online translator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458247

Vitaly Zaitsev  changed:

   What|Removed |Added

 CC||vit...@easycoding.org
   Assignee|nob...@fedoraproject.org|vit...@easycoding.org



--- Comment #1 from Vitaly Zaitsev  ---
I will review this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673

Michal Vala  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #82 from Michal Vala  ---
please remove commented-out code from spec before submit.

approved. Thank you for great job!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448041] Review Request: python-metakernel - Metakernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448041



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-metakernel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448040] Review Request: python-ipyparallel - Interactive Parallel Computing with IPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448040



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-ipyparallel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438842] Review Request: matrix-synapse - a Matrix reference homeserver written in Python using Twisted

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438842



--- Comment #10 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/matrix-synapse

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457405] Review Request: R-R6 - Classes with Reference Semantics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457405

José Matos  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from José Matos  ---
This package is approved.

Just like in #1457404 fedora-review complains about LICENSE but that is bogus.

On the other hand the complain about DESCRIPTION as %doc seems reasonable, no?

Because R needs the DESCRIPTION file to be present and the package will not
work if the documentation is not installed. Unless this has changed recently I
suggest to leave it out of %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457404] Review Request: R-magrittr - Provides a mechanism for chaining commands with a new forward-pipe operato

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457404



--- Comment #3 from José Matos  ---
Replying to myself again:

(In reply to José Matos from comment #1)
> 
> Note: License file LICENSE is not marked as %license
> 
> it is marked as %doc.

LICENSE is not really a license file. It just has the authors/copyright holders
and the year.

So ignore that. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457404] Review Request: R-magrittr - Provides a mechanism for chaining commands with a new forward-pipe operato

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457404

José Matos  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from José Matos  ---
(In reply to José Matos from comment #1)
> 
> The only issue that appears when using fedora is that:

Oops, I meant "when using fedora-review..."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458247] New: Review Request: translate-shell - a command-line online translator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458247

Bug ID: 1458247
   Summary: Review Request: translate-shell - a command-line
online translator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: vasc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/RussianFedora/translate-shell/master/translate-shell.spec
SRPM URL:
http://koji.russianfedora.pro/kojifiles/packages/translate-shell/0.9.6.4/1.fc27/src/translate-shell-0.9.6.4-1.fc27.src.rpm

Description:
Translate Shell (formerly Google Translate CLI) is a command-line
translator powered by Google Translate (default), Bing Translator,
Yandex.Translate and Apertium.

It has great functional and simple cli interface.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458243] Review Request: abrt-addon-python3 - catching and analyzing Python 3 exceptions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458243

Matej Habrnal  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458243] New: Review Request: abrt-addon-python3 - catching and analyzing Python 3 exceptions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458243

Bug ID: 1458243
   Summary: Review Request: abrt-addon-python3 - catching and
analyzing Python 3 exceptions
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhabr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mhabrnal.fedorapeople.org/abrt-addon-python3/abrt-addon-python3.spec
SRPM URL:
https://mhabrnal.fedorapeople.org/abrt-addon-python3/abrt-addon-python3-2.1.11-48.el7.src.rpm

Description: 

Hi,

there is bugzilla bug https://bugzilla.redhat.com/show_bug.cgi?id=1445615 which
requires abrt should catch Python34 (from epel7) exception in RHEL7.

I've created package 'abrt-addon-python3' which ships tools allowing catching
and analyzing Python 3 exceptions. The package is available on Fedora so this
package is created basically by backporting patches from Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1452985] Review Request: zef - Perl6 Module Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1452985



--- Comment #12 from Paul Howarth  ---
I think perl6 code in rpms should be in the vendor directories rather than the
site directories.

I think the precompiling of the code should happen in the rpm, as is done for
python packages, but how tight a dependency on compiler version would that
require? I imagine having to do a mass rebuild of all perl6 modules for minor
updates of rakudo would be an onerous task if it was necessary.

(In reply to Gerd Pokorra from comment #11)
> I created a github repository 
> 
>  https://github.com/gerd/macro.perl6.git
> 
> with a draft for the file macros.perl6
> (https://github.com/gerd/macro.perl6/blob/master/macros.perl6) to collect
> code and suggestions.

I think hard-coding version numbers and directory locations is fine,
particularly if the file comes with/is built from the rakudo package itself,
which is where these things would be specified anyway. Everything should at
least be consistent then.

I think now is probably a time to brainstorm how to do perl6 packaging rather
moving forward with it just yet: I'll have limited computer access next week
and Petr may be busy with the Perl 5.26 mass rebuild in rawhide, though i think
Jitka is running with that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457404] Review Request: R-magrittr - Provides a mechanism for chaining commands with a new forward-pipe operato

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457404

José Matos  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from José Matos  ---
The package is approved.

The only issue that appears when using fedora is that:

Note: License file LICENSE is not marked as %license

it is marked as %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457405] Review Request: R-R6 - Classes with Reference Semantics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457405

José Matos  changed:

   What|Removed |Added

 CC||jama...@fc.up.pt
   Assignee|nob...@fedoraproject.org|jama...@fc.up.pt
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457404] Review Request: R-magrittr - Provides a mechanism for chaining commands with a new forward-pipe operato

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457404

José Matos  changed:

   What|Removed |Added

 CC||jama...@fc.up.pt
   Assignee|nob...@fedoraproject.org|jama...@fc.up.pt
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457929] Review Request: proxysql, a high-performance MySQL proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457929

Pavel Raiskup  changed:

   What|Removed |Added

 CC||acari...@redhat.com,
   ||hho...@redhat.com,
   ||msch...@redhat.com
  Flags||needinfo?(acaringi@redhat.c
   ||om)



--- Comment #3 from Pavel Raiskup  ---
> 1. There is the question regarding the user/group.

I would prefer to discuss this with mysql/mariadb maintainers, so I'm CCing
Michal/Honza.  My personal preference is somewhere between 1.3 or 1.4, though
that's my POV;  reasoning is that it is pretty ugly to create the same users
and UIDs in several spec files.

> 2. I did a koji scratch build and it fails on arm architecture due to some
> use of x86 assembly code. It seems that the upstream is already aware: 

We can probably ExcludeArch for the time being.

> 3. rpmlint complains about 2 things:
> 
>3.1: The lacking of man page for proxysql: 
> 
> W: no-manual-page-for-binary proxysql

It is fair to provide downstream manual page in such cases, and propose it
upstream, too.  Also, have a look at help2man.  This is warning-only but
installing a binary into %_bindir deserves manpage in Fedora.

>3.2: Crypto policies: 
> 
> W: crypto-policy-non-compliance-openssl /usr/bin/proxysql 
> SSL_CTX_set_cipher_list

Have a look at [2].

The spec file looks nice, thanks!  Some things that are worth looking at:

* license tag says 'GPL+', but the license file seems to be 'GPLv3'
* there are some bundled libraries, I would suggest to investigate (a)
  whether we can de-bundle, or (b) add artificial Provides according to [1]
  or if that code is not used -- we could (c) 'rm -rf' the source directory
  to make sure that the code is not used in spec file.
  Note that if the bundling is needed, there are several other license files
  in the provided tarball.
* /usr/share/doc/proxysql directory is not owned by the package,
  /usr/share/proxysql/tools neither
* there's no %configure, which means %optflags are not used automatically -
  this probably needs to be added
* consider working together with upstream on having better 'make install'
  code ... so we can use this, for the time being - please at least raise
  issue upstream and put the link near manual `install` commands in
  %install so everybody understands that this is temporary issue..
* %bulidroot%_bindir is enough (no need for the additional '/' in between)


[1]
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
[2] https://fedoraproject.org/wiki/Packaging:CryptoPolicies

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #31 from Miro Hrončok  ---
(In reply to VincentS from comment #30)
> I'm sorry about no news and thank you for all your work on it, actually I'm
> waiting a response from le...@lists.fedoraproject.org about license.


I don't see your e-mail there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #81 from Jonny Heggheim  ---
(In reply to Michal Vala from comment #77)
> Issues:
> ===
> - %build honors applicable compiler flags or justifies otherwise.
>   Note: I don't see this as an issue as I would take openjdx as exception

I agree, I tried earlier to pass in %optflags, but it took too much work and
the build script got duplicated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457929] Review Request: proxysql, a high-performance MySQL proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457929

Pavel Raiskup  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||prais...@redhat.com
 Blocks||177841 (FE-NEEDSPONSOR)
   Assignee|nob...@fedoraproject.org|prais...@redhat.com



--- Comment #2 from Pavel Raiskup  ---
Thanks for the package, I'll take the review.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457949] Review Request: libdxflib - A C++ library for reading and writing DXF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457949

Antonio Trande  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)



--- Comment #1 from Antonio Trande  ---
We need legal review for this software. Commercial license included:

**
dxflib COMMERCIAL LICENSE AGREEMENT
FOR PROFESSIONAL EDITIONS
Agreement version 1.2

IMPORTANT-READ CAREFULLY: 
1. This RibbonSoft End-User License Agreement ("Agreement") is a legal
agreement between you (either an individual or a legal entity)
("Licensee") and RibbonSoft GmbH ("RibbonSoft") for the RibbonSoft 
software product(s) accompanying this Agreement, which include(s) 
computer software and may include "online" or electronic documentation,
associated media, and printed materials, including the source code,
example programs and the documentation ("Licensed Software").

2. The Licensed Software is protected by copyright laws and
international copyright treaties, as well as other intellectual
property laws and treaties. The Licensed Software is licensed, not
sold.

3. By installing, copying, or otherwise using the Licensed Software,
Licensee agrees to be bound by the terms of this Agreement. If
Licensee does not agree to the terms of this Agreement, Licensee may
not install, copy, or otherwise use the Licensed Software. 

4. Upon Licensee's acceptance of the terms and conditions of this
Agreement, RibbonSoft grants Licensee the right to use the Licensed
Software in the manner provided below.

5. RibbonSoft grants to Licensee as an individual a royalty-free,
personal, non-exclusive, non-transferable, perpetual license to make 
and use copies of the Licensed Software for the sole purposes of 
designing, developing, and testing Licensee's software product(s)
("Applications"). Licensee may install copies of the Licensed Software
on an unlimited number of computers provided that Licensee is the only
individual using the Licensed Software. If Licensee is an entity,
RibbonSoft grants Licensee the right to designate one, and only one,
individual within Licensee's organization who shall have the sole
right to use the Licensed Software in the manner provided
above. Licensee may at any time, but not more frequently that once
every six (6) months, designate another individual within Licensee's
organization to replace the current designated user by notifying
RibbonSoft, so long as there is no more than one designated user at any
given time.

GENERAL TERMS THAT APPLY TO APPLICATIONS AND REDISTRIBUTABLES
6. RibbonSoft grants Licensee a nonexclusive, royalty-free right to
reproduce and distribute the object code form of certain portions of the
Licensed Software ("Redistributables"), as specified in Appendix 1,
Section 1, for execution on any operating system. Copies of 
Redistributables may only be distributed with and for the sole purpose 
of executing Applications permitted under this Agreement that Licensee 
has created using the Licensed Software. Under no circumstances may any 
copies of Redistributables be distributed separately. This Agreement 
does not give Licensee any rights to distribute any of the parts of 
the Licensed Software listed in Appendix 1, Section 2, neither as a 
whole nor as parts or snippets of code. 

7. The license granted in this Agreement for Licensee to create
Applications and distribute them to Licensee's customers is subject 
to all of the following conditions:
(i) Licensee will indemnify and hold RibbonSoft, its related companies 
and its suppliers, harmless from and against any claims or liabilities 
arising out of the use, reproduction or distribution of Applications; 
(ii) Applications must be developed using a licensed, registered copy 
of the Licensed Software; (iii) Applications must add primary and 
substantial functionality to the Licensed Software; (iv) Applications 
may not pass on functionality which in any way makes it possible for 
others to create software with the Licensed Software; (v) Applications 
may not compete with the Licensed Software; (iv) Licensee may not use 
RibbonSoft's or any of its suppliers' names, logos, or trademarks to 
market Application(s), except to state that Application was developed 
using the Licensed Software.

NOTE: dxflib Open Source Edition is licensed under the terms of the 
GPL and not under this Agreement. If Licensee has, at any time, 
developed all (or any portions of) the Application(s) using RibbonSoft's 
publicly licensed dxflib Open Source Edition, Licensee must comply 
with RibbonSoft's requirements and license such Application(s) 
(or any portions derived there from) under the terms of the Free Software 
Foundation's GNU General Public License version 2 (the "GPL") a copy of 
which is located at