[Bug 1472663] Review Request: variety - Wallpaper changer that automatically downloads wallpapers
https://bugzilla.redhat.com/show_bug.cgi?id=1472663 --- Comment #4 from Robert-André Mauchin --- Sorry but I was still missing Requires: I had to add libappindicator-gtk3 and webkitgtk3 as dependency. Also imagemagick is case sensitive, it's ImageMagick. See https://copr-be.cloud.fedoraproject.org/results/eclipseo/variety/fedora-rawhide-x86_64/00591769-variety/variety.spec If you want I can review your package later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468872] Review Request: python-descartes - Use geometric objects as Matplotlib paths and patches
https://bugzilla.redhat.com/show_bug.cgi?id=1468872 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468872] Review Request: python-descartes - Use geometric objects as Matplotlib paths and patches
https://bugzilla.redhat.com/show_bug.cgi?id=1468872 --- Comment #4 from Fedora Update System --- python-descartes-1.1.0-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-39f11814f2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468873] Review Request: python-click-plugins - Click extension to enable registering CLI commands via setuptools entry-points
https://bugzilla.redhat.com/show_bug.cgi?id=1468873 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468873] Review Request: python-click-plugins - Click extension to enable registering CLI commands via setuptools entry-points
https://bugzilla.redhat.com/show_bug.cgi?id=1468873 --- Comment #4 from Fedora Update System --- python-click-plugins-1.0.3-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cb75d0bea9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #5 from Elliott Sales de Andrade --- Is there much need to package a Python 2 executable (on Fedora at least)? You can create envs for either version regardless of the root with the standalone builds. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1483201 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483201 [Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1483201 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483201 [Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package
https://bugzilla.redhat.com/show_bug.cgi?id=1483201 Elliott Sales de Andrade changed: What|Removed |Added Depends On||1483200, 1483198 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483198 [Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org/x/net/encoding https://bugzilla.redhat.com/show_bug.cgi?id=1483200 [Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words
https://bugzilla.redhat.com/show_bug.cgi?id=1483202 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1483203 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483203 [Bug 1483203] Review Request: fzf - A command-line fuzzy finder written in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package
https://bugzilla.redhat.com/show_bug.cgi?id=1483201 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1483203 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483203 [Bug 1483203] Review Request: fzf - A command-line fuzzy finder written in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483203] Review Request: fzf - A command-line fuzzy finder written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483203 Elliott Sales de Andrade changed: What|Removed |Added Depends On||1483201, 1430143, 1483202 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1430143 [Bug 1430143] Review Request: golang-github-mattn-go-isatty - isatty for Go (golang) https://bugzilla.redhat.com/show_bug.cgi?id=1483201 [Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package https://bugzilla.redhat.com/show_bug.cgi?id=1483202 [Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1430143] Review Request: golang-github-mattn-go-isatty - isatty for Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1483203 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483203 [Bug 1483203] Review Request: fzf - A command-line fuzzy finder written in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483203] New: Review Request: fzf - A command-line fuzzy finder written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483203 Bug ID: 1483203 Summary: Review Request: fzf - A command-line fuzzy finder written in Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591737-fzf/fzf.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591737-fzf/fzf-0.16.11-1.src.rpm Description: A command-line fuzzy finder written in Go Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483202] New: Review Request: golang-github-mattn-go-shellwords - Parse line as shell words
https://bugzilla.redhat.com/show_bug.cgi?id=1483202 Bug ID: 1483202 Summary: Review Request: golang-github-mattn-go-shellwords - Parse line as shell words Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591726-golang-github-mattn-go-shellwords/golang-github-mattn-go-shellwords.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591726-golang-github-mattn-go-shellwords/golang-github-mattn-go-shellwords-0-0.1.git9858af9.fc27.src.rpm Description: Parse line as shell words Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483201] New: Review Request: golang-github-gdamore-tcell - An alternate terminal package
https://bugzilla.redhat.com/show_bug.cgi?id=1483201 Bug ID: 1483201 Summary: Review Request: golang-github-gdamore-tcell - An alternate terminal package Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591725-golang-github-gdamore-tcell/golang-github-gdamore-tcell.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591725-golang-github-gdamore-tcell/golang-github-gdamore-tcell-0-0.1.gitd55f61c.fc27.src.rpm Description: An alternate terminal package Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] New: Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 Bug ID: 1483200 Summary: Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591722-golang-github-lucasb-eyer-go-colorful/golang-github-lucasb-eyer-go-colorful.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591722-golang-github-lucasb-eyer-go-colorful/golang-github-lucasb-eyer-go-colorful-0-0.1.gitd1be5f1.fc27.src.rpm Description: A library for playing with colors in Go Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483198] New: Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198 Bug ID: 1483198 Summary: Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org/x/net/encoding Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591721-golang-github-gdamore-encoding/golang-github-gdamore-encoding.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591721-golang-github-gdamore-encoding/golang-github-gdamore-encoding-0-0.1.gitb23993c.fc27.src.rpm Description: Various character map encodings missing from golang.org/x/net/encoding Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1430143] Review Request: golang-github-mattn-go-isatty - isatty for Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #4 from Elliott Sales de Andrade --- Any idea when/if this will be going into F26? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1452958] Review Request: sasutils - Serial Attached SCSI (SAS) Linux utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1452958 --- Comment #5 from Stephane Thiell --- Updated version and added man pages. Spec URL: http://web.stanford.edu/~sthiell/sasutils.spec SRPM URL: http://web.stanford.edu/~sthiell/sasutils-0.3.8-1.fc26.src.rpm New rawhide scratch build in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=21314914 Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #21 from Fedora Update System --- lammps-20170811-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f348e9d287 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479022] Review Request: preeny - Some helpful preload libraries for pwning stuff
https://bugzilla.redhat.com/show_bug.cgi?id=1479022 --- Comment #10 from Fedora Update System --- preeny-0.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-224cdd4d83 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #29 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d1c2a6b67 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1441728] Review Request: cld2 - Compact Language Detector 2
https://bugzilla.redhat.com/show_bug.cgi?id=1441728 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- cld2-0-0.9.20150821gitb56fa78.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e803b2d329 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475961] Review Request: cmrt - C for Media Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1475961 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- cmrt-1.0.6-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c8bda49173 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483154] New: Review Request: nodejs-set-blocking - Set blocking stdio and stderr ensuring that terminal output does not truncate
https://bugzilla.redhat.com/show_bug.cgi?id=1483154 Bug ID: 1483154 Summary: Review Request: nodejs-set-blocking - Set blocking stdio and stderr ensuring that terminal output does not truncate Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED) Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-set-blocking/nodejs-set-blocking.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-set-blocking/nodejs-set-blocking-2.0.0-1.fc27.src.rpm Description: Set blocking stdio and stderr ensuring that terminal output does not truncate Fedora Account System Username: jsmith Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1359416] Review Request: gawk-xml - XML support for gawk
https://bugzilla.redhat.com/show_bug.cgi?id=1359416 --- Comment #10 from Andrew J. Schorr --- Hi David, thanks for reviewing this! If I am reading your notes properly, I seem to see only one concern, regarding the licensing: >> License field should probably be (based on contents of binary rpm and how >> the rpm is built): GPLv2+ and GPLv3+ I ran licensecheck, and this seems to be due to the copyright in xml_puller.h and xml_puller.c. Is that correct? I will look into whether we can simply update the copyright in those files to GPLv3. Are there any other issues? Thanks, Andy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741
--- Comment #4 from Athos Ribeiro ---
Hi Robert, I am taking this one.
- If they are to be packaged, the files under examples directory should be
under %doc
- Upstream does provide versions, have you considered using them?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if pac
[Bug 1482893] Review Request: perl-Regexp-Pattern - Collection of regexp patterns
https://bugzilla.redhat.com/show_bug.cgi?id=1482893 --- Comment #4 from Sandro Mani --- Thanks for the review and the comments, I'll fix the remaining issues @Björn Fedora review is out of date, all build dependencies should be explicitly listed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479022] Review Request: preeny - Some helpful preload libraries for pwning stuff
https://bugzilla.redhat.com/show_bug.cgi?id=1479022 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #9 from Fedora Update System --- preeny-0.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f9be6a6352 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817
Athos Ribeiro changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Athos Ribeiro ---
Package looks good to me. Approved!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on al
[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1469331 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #48 from Fedora Update System --- fedrepo-req-1.3.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2bf593c298 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479073] Review Request: tcl-tclnagios - Library to simplify writing Nagios plugins in Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1479073 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #9 from Fedora Update System --- tcl-tclnagios-1.3-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a3c6361bc6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1472663] Review Request: variety - Wallpaper changer that automatically downloads wallpapers
https://bugzilla.redhat.com/show_bug.cgi?id=1472663 --- Comment #3 from mgans...@alice.de --- (In reply to Robert-André Mauchin from comment #2) > It seems you borrowed from my COPR package. I had to update it because of a > bug report for missing dependencies. You seem to have removed all Requires: > this won't work because variety will be missing some Python lib in some > systems. > > Please take a look at my updated SPEC: > https://copr-be.cloud.fedoraproject.org/results/eclipseo/variety/fedora- > rawhide-x86_64/00591522-variety/variety.spec Thanks for the hint. $ fedora-review fails with IndexError: list index out of range fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -rn ../SRPMS/variety-0.6.4-2.fc26.src.rpm Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/variety.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/variety-0.6.4-2.fc26.src.rpm %changelog * Fri Aug 18 2017 Martin Gansser - 0.6.4-2 - Add RR python-lxml - Add RR python-pillow - Add RR pycairo - Add RR dbus-python - Add RR python-appindicator - Add RR python-beautifulsoup4 - Add RR python-configobj - Add RR python2-gexiv2 - Add RR python-pycurl - Add RR python2-requests - Add RR pyexiv2 - Add RR imagemagick - Add RR hicolor-icon-theme - Add BR libappstream-glib - Add appdata.xml file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC||athoscribe...@gmail.com Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475872] Review Request: golang-github-golang-sync - Go concurrency primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1475872 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC||athoscribe...@gmail.com Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC||athoscribe...@gmail.com Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480762] Review Request: golang-github-jdkato-prose - Golang library for text processing
https://bugzilla.redhat.com/show_bug.cgi?id=1480762 --- Comment #4 from Athos Ribeiro --- Added the missing dependency (which was not packaged in fedora) using upstream sources (from github). Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-jdkato-prose.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-jdkato-prose-0-0.2.20170806gita678fc7.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480762] Review Request: golang-github-jdkato-prose - Golang library for text processing
https://bugzilla.redhat.com/show_bug.cgi?id=1480762 Athos Ribeiro changed: What|Removed |Added Depends On||1483129 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483129 [Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129 Athos Ribeiro changed: What|Removed |Added Blocks||1480762 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1480762 [Bug 1480762] Review Request: golang-github-jdkato-prose - Golang library for text processing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] New: golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129 Bug ID: 1483129 Summary: golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: athoscribe...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-neurosnap-sentences.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-neurosnap-sentences-1.0.6-1.fc26.src.rpm Description: Multilingual command line sentence tokenizer in Golang Fedora Account System Username: athoscr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 Robert Scheck changed: What|Removed |Added Flags|needinfo?(space...@gmail.co | |m) | --- Comment #22 from Robert Scheck --- Robert-André, thank you very much for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231 --- Comment #4 from Orion Poplawski --- See https://bugzilla.redhat.com/show_bug.cgi?id=1483123 for dep. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments
https://bugzilla.redhat.com/show_bug.cgi?id=1431235 Orion Poplawski changed: What|Removed |Added Blocks||1483123 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483123 [Bug 1483123] Review Request: python3-pytest-cov - Pytest plugin for coverage reporting -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483123] Review Request: python3-pytest-cov - Pytest plugin for coverage reporting
https://bugzilla.redhat.com/show_bug.cgi?id=1483123 Orion Poplawski changed: What|Removed |Added Depends On||1431235 Summary|Review Request: |Review Request: |python3-pytest-cov -|python3-pytest-cov - Pytest ||plugin for coverage ||reporting Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1431235 [Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483123] New: Review Request: python3-pytest-cov -
https://bugzilla.redhat.com/show_bug.cgi?id=1483123 Bug ID: 1483123 Summary: Review Request: python3-pytest-cov - Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: or...@nwra.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-pytest-cov.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/python3-pytest-cov-2.5.1-1.el7.src.rpm Description: Py.test plugin for coverage reporting with support for both centralised and distributed testing, including subprocesses and multiprocessing for Python. Fedora Account System Username: orion This is an epel only package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231 --- Comment #3 from Orion Poplawski --- Created attachment 1315375 --> https://bugzilla.redhat.com/attachment.cgi?id=1315375&action=edit patch to try to support epel7 It would be nice if we could support EPEL7. This patch helps. Still missing some deps though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 jiri vanek changed: What|Removed |Added Blocks||1447237 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1447237 [Bug 1447237] Java 9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480955] Review Request: golang-github-alecthomas-repr - Python' s repr for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480955 --- Comment #2 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/c150bbe104fa267a41def2a05d324d410ca81e9d Thanks. i solved all of issue about the changelog version formats. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480956] Review Request: golang-github-alecthomas-template - Go' s text/template package with newline elisio
https://bugzilla.redhat.com/show_bug.cgi?id=1480956 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package accepted. Thanks for your work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 --- Comment #52 from jiri vanek --- f27+ spec needed huge macro usage adaptation for rpmbuild 4.14 f28 https://koji.fedoraproject.org/koji/buildinfo?buildID=958063 f27 https://koji.fedoraproject.org/koji/buildinfo?buildID=955944 for record, unchanged build with original mcros usage: f26 https://koji.fedoraproject.org/koji/buildinfo?buildID=956299 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- All good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480965] Review Request: golang-github-nfnt-resize - Pure golang image resize
https://bugzilla.redhat.com/show_bug.cgi?id=1480965 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Everything's okay, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480956] Review Request: golang-github-alecthomas-template - Go' s text/template package with newline elisio
https://bugzilla.redhat.com/show_bug.cgi?id=1480956 --- Comment #2 from sensor@gmail.com --- https://github.com/FZUG/repo/commit/2ba81cbed703bc14c8a810f7b68e547ffe2503aa Fixed. Thanks~ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 Bug 1443076 depends on bug 1482192, which changed state. Bug 1482192 Summary: rpmbuild's new macro evaluation is causing nil to disapear https://bugzilla.redhat.com/show_bug.cgi?id=1482192 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 --- Comment #2 from sensor@gmail.com --- https://github.com/FZUG/repo/commit/860cbdf9fdc46c3df38e5348143376e009f4c02b Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480965] Review Request: golang-github-nfnt-resize - Pure golang image resize
https://bugzilla.redhat.com/show_bug.cgi?id=1480965 --- Comment #2 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/86b3508e4e03909718e5faeede9ac7f8a75c2ceb Fixed. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961 --- Comment #17 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/datamash -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961 Hannes Frederic Sowa changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jama...@fc.up.pt --- Comment #16 from Hannes Frederic Sowa --- Jose, I assigned the ticket to you, it seems I need to do this for requesting a repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
https://bugzilla.redhat.com/show_bug.cgi?id=1431868 --- Comment #10 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/syncthing-inotify -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
https://bugzilla.redhat.com/show_bug.cgi?id=1431868 --- Comment #9 from Fabio Valentini --- Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
https://bugzilla.redhat.com/show_bug.cgi?id=1431868 Athos Ribeiro changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Athos Ribeiro --- Thanks for the comments and fixes! Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker
https://bugzilla.redhat.com/show_bug.cgi?id=1482202 --- Comment #7 from Tom Gundersen --- I tried to address all the comments, the only outstanding thing is > dbus-broker.src: W: file-size-mismatch dbus-broker-2.tar.gz = 136357, > https://github.com/bus1/dbus-broker/archive/v2/dbus-broker-2.tar.gz = 138241 which I could not figure out. Any suggestions welcome. New files can be found: Spec URL: https://copr-be.cloud.fedoraproject.org/results/%40bus1/dbus/fedora-26-x86_64/00591586-dbus-broker/dbus-broker.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/%40bus1/dbus/fedora-26-x86_64/00591586-dbus-broker/dbus-broker-3-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 --- Comment #12 from Robert-André Mauchin --- See https://fedoraproject.org/wiki/Licensing:MIT#Old_Style_with_legal_disclaimer It's the same text. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 --- Comment #11 from Robert-André Mauchin --- It's a MIT type license. More close to a BSD Clause 3 with the no advertising part. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480966] Review Request: golang-github-sergi-go-diff - Diff, match and patch text in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480966 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- It's ok now. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 Antonio Trande changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #10 from Antonio Trande --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed NTP license looks not listed among that 'Good for Fedora' (https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List) Need Fedora-Legal review. /* * Copyright © 2008-2011 Kristian Høgsberg * Copyright © 2010-2011 Intel Corporation * * Permission to use, copy, modify, distribute, and sell this * software and its documentation for any purpose is hereby granted * without fee, provided that\n the above copyright notice appear in * all copies and that both that copyright notice and this permission * notice appear in supporting documentation, and that the name of * the copyright holders not be used in advertising or publicity * pertaining to distribution of the software without specific, * written prior permission. The copyright holders make no * representations about the suitability of this software for any * purpose. It is provided "as is" without express or implied * warranty. * * THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS * SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND * FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY * SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN * AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF * THIS SOFTWARE. */ However, source files released with NTP are not involved during compilation and we don't need list it with License tag. - Please, Make must be verbose; add V=1 to %make_build = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (unspecified)", "BSD (3 clause)", "NTP (legal disclaimer)", "Unknown or generated". 193 files have unknown license. Detailed output of licensecheck in /home/sagitter/1475962-libva-intel- hybrid-driver/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must
[Bug 1483014] Review Request: shim-unsigned-x64 - arch specific build for shim
https://bugzilla.redhat.com/show_bug.cgi?id=1483014 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/shim-unsigned-x64. You may create the branch "f27" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
https://bugzilla.redhat.com/show_bug.cgi?id=1431868 --- Comment #7 from Fabio Valentini --- - Supplements vs. Recommends: There was a reason, because no syncthing-inotify existed in fedora when I built syncthing, and adding "Recommends" on a third-party package is forbidden. Since both packages will soon be in the official fedora repositories, I can remove the "Supplements" tag from syncthing-inotify and then add a "Recommends" tag to syncthing once the syncthing-inotify package is in the repositories. - Wrong permissions on patch: Sorry about that, I didn't notice. The patch is the autogenerated one from the github pull request, and I didn't check for file permissions (who would?). Remaining rpmlint issues when built locally in mock: - Spelling error (synchronisation, rescan): The text is from the upstream README. I don't want to change "fix" it downstream. - Hardcoded library path: No way around this, but systemd will soon (TM) ship the missing macro to fix this. And in a way, this is a false positive anyway. The rest of the message are false positives. Spec URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/syncthing-inotify-0.8.7-4.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #21 from Fedora Update System --- partclone-0.3.5a-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f81abe5e43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480966] Review Request: golang-github-sergi-go-diff - Diff, match and patch text in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480966 --- Comment #3 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/5217d471236bff8df823d1dc8f46726ba58221cb Fixed version format. Thanks~ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480717] Review Request: golang-github-shogo82148-go-shuffle - Provides primitives for shuffling slices and user-defined collections
https://bugzilla.redhat.com/show_bug.cgi?id=1480717 Athos Ribeiro changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-08-18 12:07:32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480762] Review Request: golang-github-jdkato-prose - Golang library for text processing
https://bugzilla.redhat.com/show_bug.cgi?id=1480762 Bug 1480762 depends on bug 1480717, which changed state. Bug 1480717 Summary: Review Request: golang-github-shogo82148-go-shuffle - Provides primitives for shuffling slices and user-defined collections https://bugzilla.redhat.com/show_bug.cgi?id=1480717 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483014] Review Request: shim-unsigned-x64 - arch specific build for shim
https://bugzilla.redhat.com/show_bug.cgi?id=1483014
Adam Jackson changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Adam Jackson ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Header files in -devel subpackage, if present.
Note: shim-unsigned-x64-debugsource :
/usr/src/debug/shim-12-0.1.fc27/Cryptlib/Base.h shim-
unsigned-x64-debugsource :
[A lot of this, this is just the tool not understanding split debuginfo yet]
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /vol1/review-shim-
unsigned-x64/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
I assume this is github messing with us, the md5sum appears to be different
every time.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[-]: Package contains no static executables.
It's a bootloader, they're gonna be static.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "BSD (2 clause)", "BSD (unspecified)",
"Unknown or generated". 678 files have unknown license. Detailed
output of licensecheck in /vol1/review-shim-
unsigned-x64/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/shim(shim-
unsigned), /usr/src/debug(filesystem)
This will be fixed once the package is imported, can't be fixed yet.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
Again, not yet, which is fine.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Uses parallel make
[Bug 1472663] Review Request: variety - Wallpaper changer that automatically downloads wallpapers
https://bugzilla.redhat.com/show_bug.cgi?id=1472663 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #2 from Robert-André Mauchin --- It seems you borrowed from my COPR package. I had to update it because of a bug report for missing dependencies. You seem to have removed all Requires: this won't work because variety will be missing some Python lib in some systems. Please take a look at my updated SPEC: https://copr-be.cloud.fedoraproject.org/results/eclipseo/variety/fedora-rawhide-x86_64/00591522-variety/variety.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher
https://bugzilla.redhat.com/show_bug.cgi?id=1431868
--- Comment #6 from Athos Ribeiro ---
Hi Fabio,
- Is there any reason for using Supplements: here? As I understood it in [1],
you should use Recommends in syncthing instead, if you believe both packages
should be installed.
- There are a few rpmlint warnings/error which may require your attention, in
special, the permissions for your patch:
syncthing-inotify.x86_64: W: spelling-error %description -l en_US rescan -> re
scan, re-scan, res can
syncthing-inotify.x86_64: W: spelling-error %description -l en_US
synchronisation -> synchronization, synchronicity
syncthing-inotify.src: W: strange-permission 00-syncthing-01433-bump.patch 600
- It would be nice to add a comment with a link to the github issue or the PR
that led to the patch
%check is not mandatory here, so it is ok to comment the failing tests: the
issue pointed shows that there is a problem with them. The package looks good.
I will wait for your feedback on the Supplements and patch permission issues
before approving it, but fixing those would do it for me.
[1]
https://fedoraproject.org/wiki/Packaging:WeakDependencies#Forward_vs_Backward_Dependencies
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/.build-id(syncthing,
jackthejanitor)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
There is a comment on the Supplements line though.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to in
[Bug 1483014] Review Request: shim-unsigned-x64 - arch specific build for shim
https://bugzilla.redhat.com/show_bug.cgi?id=1483014 --- Comment #1 from Adam Jackson --- Only seems to build for F27, mockbuild for F26 says: No matching package to install: 'gnu-efi >= 1:3.0.5-6' No matching package to install: 'gnu-efi-devel >= 1:3.0.5-6' Which seems to be intentional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483014] Review Request: shim-unsigned-x64 - arch specific build for shim
https://bugzilla.redhat.com/show_bug.cgi?id=1483014 Adam Jackson changed: What|Removed |Added Assignee|nob...@fedoraproject.org|a...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483014] New: Review Request: shim-unsigned-x64 - arch specific build for shim
https://bugzilla.redhat.com/show_bug.cgi?id=1483014 Bug ID: 1483014 Summary: Review Request: shim-unsigned-x64 - arch specific build for shim Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pjo...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://pjones.fedorapeople.org/shim-unsigned-x64/shim-unsigned-x64.spec SRPM URL: https://pjones.fedorapeople.org/shim-unsigned-x64/shim-unsigned-x64-12-0.1.fc27.src.rpm Description: unsigned shim builds for x64 and ia32 Fedora Account System Username: pjones A fedora-review report is here: https://pjones.fedorapeople.org/shim-unsigned-x64/review-shim-unsigned-x64/review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson 's Clipper library
https://bugzilla.redhat.com/show_bug.cgi?id=1440971 --- Comment #7 from Athos Ribeiro --- (In reply to Elliott Sales de Andrade from comment #6) > It might be faster to open a PR there if the change is straightforward. It is not, it will require some work, since the ABI has changed. I am also proposing a way to install the package with de-bundled libraries. Upstream is being responsive [1], so I believe this could hold for a few more days, what do you think? [1] https://github.com/greginvm/pyclipper/issues/10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482997] New: Review Request: prename - Perl script to rename multiple files
https://bugzilla.redhat.com/show_bug.cgi?id=1482997 Bug ID: 1482997 Summary: Review Request: prename - Perl script to rename multiple files Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: zebo...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/prename/fedora-rawhide-x86_64/00591541-prename/prename.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/prename/fedora-rawhide-x86_64/00591541-prename/prename-1.9-4.fc27.noarch.rpm Description: Prename renames the file names supplied according to the rule specified as the first argument. The argument is a Perl expression which is expected to modify the $_ string for at least some of the file names specified. FAS username: eclipseo Note: the LICENSE is fetched from GIT as it was just added by my request. The original name is rename, but in order not to conflict with GNU rename, I've elected to use a prefix, p for perl. A similar script exists in Arch under prename too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482867] Review Request: perl-JSON-Parse - Read JSON into a Perl variable
https://bugzilla.redhat.com/show_bug.cgi?id=1482867 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-JSON-Parse -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482867] Review Request: perl-JSON-Parse - Read JSON into a Perl variable
https://bugzilla.redhat.com/show_bug.cgi?id=1482867 Emmanuel Seyman changed: What|Removed |Added Blocks||1472755 --- Comment #2 from Emmanuel Seyman --- (In reply to Jitka Plesnikova from comment #1) > > FIX: Please remove execute permission from examples/tokenize-synopsis.pl, > it is part of documentation. Done. > BuildRequires are almost ok. > FIX: Please add perl-devel and gcc, because it is XS package Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-JSON-Parse/perl-JSON-Parse.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-JSON-Parse/perl-JSON-Parse-0.49-2.fc26.src.rpm > Otherwise, the package looks good. > Approved. \o/ Thanks for the review, Jitka. Repo requested : https://pagure.io/releng/fedora-scm-requests/issue/130 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1472755 [Bug 1472755] perl-JSON-Path-0.411 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481876 Scott Talbert changed: What|Removed |Added Blocks||1481875 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481875 [Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture for py.test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481875 Scott Talbert changed: What|Removed |Added Depends On||1481876 --- Comment #2 from Scott Talbert --- @Robert-André, I believe this needs pytest-shutil, for which Kevin has another review request open. That's why I stepped back for now. I added it as a blocker. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481876 [Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 Bill Peck changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-08-18 10:04:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481875 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- I've got an error while running the test: + /usr/bin/python2 setup.py test running test Searching for pytest-shutil Reading https://pypi.python.org/simple/pytest-shutil/ Download error on https://pypi.python.org/simple/pytest-shutil/: [Errno -2] Name or service not known -- Some packages may not be found! Scanning index of all packages (this may take a while) Couldn't find index page for 'pytest-shutil' (maybe misspelled?) Thus mock fails. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1344276 --- Comment #44 from Gwyn Ciesla --- (fedrepo-req-admin): The sync took place when you logged in the first time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1344276 --- Comment #43 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gdeploy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481416] Review Request: light - control backlight controllers
https://bugzilla.redhat.com/show_bug.cgi?id=1481416 --- Comment #5 from Robert-André Mauchin --- I've accepted your package already, so you can request the repo. No need to remove the special characters from your name, vaĺue was detected by rpmlint because it was not recognized by the spell checker. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482893] Review Request: perl-Regexp-Pattern - Collection of regexp patterns
https://bugzilla.redhat.com/show_bug.cgi?id=1482893 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com --- Comment #3 from Petr Pisar --- The package should build-require perl-interpreter. Not perl (this is a metapackage with a lot of dependencies). It should buildrequire coreutils because of rm command in the %install section. Actually the whole command could be avoided if NO_PACKLIST=1 argument were passed to "perl Makefile.PL" argument and build-dependency on perl(ExtUtils::MakeMaker) constrained with ">= 6.76" version (this is the first version supporting the NO_PACKLIST argument) added. It's missing BuildRequires on "perl(Exporter)" (lib/Regexp/Pattern.pm:9). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482577] Review Request: python3-cryptography - PyCA' s cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1482577 --- Comment #3 from Nathaniel McCallum --- I was thrown off by "This package is identical to the python-cryptography that is already in Fedora." However, this statement isn't true because Fedora has python-cryptography-2.0.2-1.fc27. So long as you're using the same bits (modified to build against python3) from RHEL, I'm cool. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482945] Review Request: perl-Alien-cmake3 - Find or download or build cmake 3 or better
https://bugzilla.redhat.com/show_bug.cgi?id=1482945 Petr Pisar changed: What|Removed |Added Depends On||1474425 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1474425 [Bug 1474425] Review Request: perl-Alien-Build - Build external dependencies for use in CPAN -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474425] Review Request: perl-Alien-Build - Build external dependencies for use in CPAN
https://bugzilla.redhat.com/show_bug.cgi?id=1474425 Petr Pisar changed: What|Removed |Added Blocks||1482945 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1482945 [Bug 1482945] Review Request: perl-Alien-cmake3 - Find or download or build cmake 3 or better -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482945] New: Review Request: perl-Alien-cmake3 - Find or download or build cmake 3 or better
https://bugzilla.redhat.com/show_bug.cgi?id=1482945 Bug ID: 1482945 Summary: Review Request: perl-Alien-cmake3 - Find or download or build cmake 3 or better Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Alien-cmake3/perl-Alien-cmake3.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-cmake3/perl-Alien-cmake3-0.03-1.fc28.src.rpm Description: This Perl Alien distribution provides an external dependency on the build tool cmake version 3.0.0 or better. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481416] Review Request: light - control backlight controllers
https://bugzilla.redhat.com/show_bug.cgi?id=1481416 --- Comment #4 from Jakub Kadlčík --- That is strange, good catch. I've fixed it and also removed special characters from my name in the changelog. Spec URL: https://copr-be.cloud.fedoraproject.org/results/frostyx/light/fedora-rawhide-x86_64/00591506-light/light.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/frostyx/light/fedora-rawhide-x86_64/00591506-light/light-1.0-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #20 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lammps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482524] ansible-kubespray - Ansible library for kubernetes installer needed to install tripleo openstack on top
https://bugzilla.redhat.com/show_bug.cgi?id=1482524 --- Comment #5 from Bogdan Dobrelya --- WIP spec file : https://github.com/bogdando/kargo/blob/rpm_spec/contrib/packaging/rpm/ansible-kubespray.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
