[Bug 1359416] Review Request: gawk-xml - XML support for gawk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359416

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
gawk-xml-1.0.7-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b835e0e2f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #41 from Fedora Update System  ---
scidavis-1.21-6.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497330] Review Request: python-pylons-sphinx-themes - Sphinx themes for projects under the Pylons Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497330



--- Comment #12 from Fedora Update System  ---
python-pylons-sphinx-themes-1.0.6-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376689] Review Request: golang-github-go-macaron-inject - Provides utilities for mapping and injecting dependencies in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376689



--- Comment #9 from Fedora Update System  ---
golang-github-go-macaron-inject-0-0.1.20160627gitd8a0b86.fc25 has been pushed
to the Fedora 25 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499496] Review Request: golang-github-patrickmn-go-cache - An in-memory key:value store/ cache library for Go (Golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499496



--- Comment #9 from Fedora Update System  ---
golang-github-patrickmn-go-cache-2.0.0-1.fc27 has been pushed to the Fedora 27
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499504] Review Request: golang-github-ryanuber-go-glob - Basic string globs in Go (Golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499504



--- Comment #9 from Fedora Update System  ---
golang-github-ryanuber-go-glob-0.1-1.fc27 has been pushed to the Fedora 27
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499488] Review Request: golang-github-armon-go-proxyproto - Golang package to handle HAProxy Proxy Protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499488



--- Comment #10 from Fedora Update System  ---
golang-github-armon-go-proxyproto-0-0.1.20170621git48572f1.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499501] Review Request: gocomplete - A tool for bash writing bash completion in Go (Golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499501

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 20:15:08



--- Comment #9 from Fedora Update System  ---
gocomplete-0-0.1.20170908git88e5976.fc27 has been pushed to the Fedora 27
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499502] Review Request: golang-github-boombuler-barcode - A barcode creation lib for Go (Golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499502



--- Comment #9 from Fedora Update System  ---
golang-github-boombuler-barcode-0-0.1.20170922git3cfea5a.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499491] Review Request: golang-github-cockroachdb-cockroach-go - CockroachDB helpers for Go ( Golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499491



--- Comment #10 from Fedora Update System  ---
golang-github-cockroachdb-cockroach-go-0-0.1.20170809gitc806b48.fc27 has been
pushed to the Fedora 27 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499494] Review Request: golang-github-hashicorp-go-hclog - A common logging package for HashiCorp tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499494

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 20:14:54



--- Comment #8 from Fedora Update System  ---
golang-github-hashicorp-go-hclog-0-0.1.20171005gitca137eb.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499495] Review Request: golang-github-mitchellh-go-testing-interface - Go (Golang) library to expose *testing.T as an interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499495



--- Comment #9 from Fedora Update System  ---
golang-github-mitchellh-go-testing-interface-0-0.1.20171004gita61a995.fc27 has
been pushed to the Fedora 27 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499490] Review Request: golang-github-chrismalek-oktasdk-go - OKTA REST API Client for Go (Golang )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499490

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 20:14:49



--- Comment #8 from Fedora Update System  ---
golang-github-chrismalek-oktasdk-go-0-0.1.20170911gitae553c9.fc27 has been
pushed to the Fedora 27 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1499486] Review Request: golang-github-SAP-go-hdb - SAP HANA Database Client for Go (Golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1499486



--- Comment #10 from Fedora Update System  ---
golang-github-SAP-go-hdb-0.9.1-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500691] Review Request: perl-lib-relative - Add paths relative to the current file to @INC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500691



--- Comment #6 from Fedora Update System  ---
perl-lib-relative-0.002-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495290] Review Request: dlrn - Build and maintain yum repositories following OpenStack upstream commits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495290

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 20:12:56



--- Comment #7 from Fedora Update System  ---
dlrn-0.5.0-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498468] Review Request: appstream-generator - A fast AppStream metadata generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498468

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 20:12:45



--- Comment #11 from Fedora Update System  ---
appstream-generator-0.6.7-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 20:13:32



--- Comment #47 from Fedora Update System  ---
hugo-0.27.1-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497330] Review Request: python-pylons-sphinx-themes - Sphinx themes for projects under the Pylons Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497330



--- Comment #11 from Fedora Update System  ---
python-pylons-sphinx-themes-1.0.6-1.fc27 has been pushed to the Fedora 27
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495985] Review Request: libcouchbase - client and protocol library for the Couchbase project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495985

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444925] Review Request: python-rpm-generators - Requires and Provides generators for Python RPMs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444925

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-10-16 18:46:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495985] Review Request: libcouchbase - client and protocol library for the Couchbase project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495985

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495985] Review Request: libcouchbase - client and protocol library for the Couchbase project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495985

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487420] Review Request: python-django16 - A high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487420



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-django16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502769] Review Request: python3-mysql - An interface to MySQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502769

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello Aurélien,

 - There's an issue, the main packaqe is python3-mysql, but you also defines: 

%package -n python%{python3_pkgversion}-mysql

   which could also be resolved to python3-mysql, hence two package with the
same name. This confuses fedpkg when I try to rebuild the SRPM:

error: line 42: %package -n python3-mysql: package python3-mysql already exists

   The solution is to enclose the subpackage within an if statement:

%if %{python3_pkgversion} != 3
%package -n python%{python3_pkgversion}-mysql
Summary: %{sum}
Group: Development/Libraries
Provides: MySQL-python%{python3_pkgversion} = %{version}-%{release}

%description -n python%{python3_pkgversion}-mysql %{desc}
%endif

And don't forget to add the Provides to the main package.


Other than that, the package is good, it is accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 50 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python3-mysql/review-
 python3-mysql/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/python3.4/site-
 packages/__pycache__(python34)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match 

[Bug 1476458] Review Request: paho-c - MQTT client library in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476458



--- Comment #12 from Otavio R. Piske  ---
Thanks for the explanation Michael.

Dear Fedora community, any additional suggestion about how I could improve this
package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #6 from Neal Gompa  ---
Ah, yeah, Iwiki did already point out the Source URL thing, and he's correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #5 from Neal Gompa  ---
The description needs to be wrapped at 79 columns.

The Source URL should be a valid URL for people to be able to get the sources
using "spectool -g". See for reference:
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #12 from Raphael Groner  ---
Spec URL: https://raphgro.fedorapeople.org/review/util/speedometer.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/util/speedometer-2.8-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487420] Review Request: python-django16 - A high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487420

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+
   |needinfo?(projects.rg@smart |
   |.ms)|



--- Comment #10 from Raphael Groner  ---
Thanks for the fixes and your comments in IRC.
APPROVED

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Binary eggs must be removed in %prep
  Note: Binary egg files not removed in %prep:
  ./tests/app_loading/eggs/brokenapp.egg
  ./tests/app_loading/eggs/modelapp.egg
  ./tests/app_loading/eggs/nomodelapp.egg
  ./tests/app_loading/eggs/omelet.egg
  ./tests/template_tests/eggs/tagsegg.egg
  ./tests/utils_tests/eggs/test_egg.egg
  See:
 
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
=> Ignore, tests folder is unused for binary packages.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)",
 "PSF (v2)", "*No copyright* BSD (unspecified)", "BSD (3 clause)". 4497
 files have unknown license. Detailed output of licensecheck in
 /home/builder/fedora-review/1487420-python-django16/licensecheck.txt
=> In assumption, BSD generally is considered okay for also all the other
   python-django* packages.

[x]: Package contains no bundled libraries without FPC exception.
=> Okay, there are known issues with jquery, so to be considered a copylib.

[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the 

[Bug 1430364] Review Request: argbash - Bash argument parsing code generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430364

Stephen Gallagher  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||argbash-2.5.0-1.fc28
 Resolution|--- |RAWHIDE
Last Closed||2017-10-16 14:38:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1417631] Review Request: mingw-libftdi - MinGW library to program and control the FTDI USB controller

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1417631



--- Comment #13 from Fedora Update System  ---
mingw-libftdi-1.3-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498686] Review Request: ghc-iproute - IP Routing Table

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498686



--- Comment #7 from Fedora Update System  ---
ghc-iproute-1.7.1-8.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498683] Review Request: ghc-appar - A simple applicative parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498683



--- Comment #9 from Fedora Update System  ---
ghc-appar-0.1.4-8.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1417628] Review Request: mingw-libconfuse - MinGW configuration file parser library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1417628



--- Comment #15 from Fedora Update System  ---
mingw-libconfuse-3.2.1-3.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498692] Review Request: ghc-uuid-types - Type definitions for Universally Unique Identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498692



--- Comment #7 from Fedora Update System  ---
ghc-uuid-types-1.0.3-4.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498685] Review Request: ghc-cryptohash-sha1 - Fast, pure and practical SHA-1 implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498685



--- Comment #9 from Fedora Update System  ---
ghc-cryptohash-sha1-0.11.100.1-4.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498691] Review Request: ghc-StateVar - State variables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498691



--- Comment #7 from Fedora Update System  ---
ghc-StateVar-1.1.0.4-4.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498684] Review Request: ghc-cryptohash-md5 - Fast, pure and practical MD5 implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498684



--- Comment #9 from Fedora Update System  ---
ghc-cryptohash-md5-0.11.100.1-4.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497658] Review Request: eclipse-m2e-wtp - Maven Integration for WTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497658



--- Comment #12 from Fedora Update System  ---
eclipse-m2e-apt-1.3.0-0.1.git12a8d33.fc26,
eclipse-m2e-wtp-1.3.3-0.2.git9202520.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497657] Review Request: eclipse-m2e-apt - M2E JDT Annotation Processor Toolkit connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497657



--- Comment #10 from Fedora Update System  ---
eclipse-m2e-apt-1.3.0-0.1.git12a8d33.fc26,
eclipse-m2e-wtp-1.3.3-0.2.git9202520.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1490054] Review Request: scidavis - Application for Scientific Data Analysis and Visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1490054



--- Comment #40 from Fedora Update System  ---
scidavis-1.21-6.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1498039] Review Request: python-adduserpath - Cross-platform tool for adding locations to the user PATH

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1498039



--- Comment #9 from Fedora Update System  ---
python-adduserpath-0.4.0-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497330] Review Request: python-pylons-sphinx-themes - Sphinx themes for projects under the Pylons Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497330

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 13:52:04



--- Comment #10 from Fedora Update System  ---
python-pylons-sphinx-themes-1.0.6-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376691] Review Request: golang-github-go-macaron-macaron - A high productive and modular web framework in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376691
Bug 1376691 depends on bug 1376689, which changed state.

Bug 1376689 Summary: Review Request: golang-github-go-macaron-inject - Provides 
utilities for mapping and injecting dependencies in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1376689

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376689] Review Request: golang-github-go-macaron-inject - Provides utilities for mapping and injecting dependencies in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376689

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-16 13:51:46



--- Comment #8 from Fedora Update System  ---
golang-github-go-macaron-inject-0-0.1.20160627gitd8a0b86.fc26 has been pushed
to the Fedora 26 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #4 from Pavlina Moravcova Varekova  ---
All comments in review corrected except the second comment from Iwicki Artur.
Should I correct it too?
Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec
SRPM URL:
https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522

Christian Fredrik Kalager Schaller  changed:

   What|Removed |Added

 CC||cscha...@redhat.com



--- Comment #28 from Christian Fredrik Kalager Schaller  
---
The GStreamer plugins have the ability to clearly negotiate the profiles they
support, so not supporting all possible profiles is not a good reason to not
ship this. If people need the less used profiles they will keep having the
ability to download software from various places that support those.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502769] New: Review Request: python3-mysql - An interface to MySQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502769

Bug ID: 1502769
   Summary: Review Request: python3-mysql - An interface to MySQL
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: aurel...@bompard.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://abompard.fedorapeople.org/reviews/python3-mysql/python3-mysql.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/python3-mysql/python3-mysql-1.3.12-1.el7.centos.src.rpm
Description:
This is a package for EPEL7+ only. The Python2 version is provided by
RHEL/CentOS so this package is necessary to get the Python3 version, and does
not build for Python2.
Ideally I would have used the same version as RHEL/CentOS but that version does
not support Python3 yet so I had to use a later one, I used the latest version.

Fedora Account System Username: abompard

RPMLint issues:
- spelling-error: can be ignored
- no-documentation: only for the "-devel" subpackage, which depends on the main
package, which has documentation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502072] Review Request: python-Mastodon - Python wrapper for the Mastodon API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502072



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-Mastodon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502072] Review Request: python-Mastodon - Python wrapper for the Mastodon API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502072

Gwyn Ciesla  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from Gwyn Ciesla  ---
Thanks so much!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502072] Review Request: python-Mastodon - Python wrapper for the Mastodon API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502072

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Neal Gompa  ---
Review notes:

- package is appropriately named
- license is properly declared (and license file properly marked in files list)
- package follows Python packaging guidelines
- dependencies are properly declared

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430364] Review Request: argbash - Bash argument parsing code generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430364



--- Comment #15 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/argbash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502600] Review Request: kabi-dw - Detect changes in the ABI between kernel builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502600



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/kabi-dw

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497687] Review Request: popub - Upstream rename of portpub

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497687



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/popub

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #27 from Olivier Crête  ---
Maybe we can just give it a different soname and then have the GStreamer plugin
register under a different name "fdk-aac-mini" that will only claim to accept
the profiles that are really support, that is the non HE profiles. I'm afraid
that may also require some work on aacparse to actually recognize those
profiles as we don't have full profile recognition in there yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502072] Review Request: python-Mastodon - Python wrapper for the Mastodon API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502072



--- Comment #3 from Gwyn Ciesla  ---
Fixed, thanks!

SPEC:
https://fedorapeople.org/~limb/review/python-Mastodon/python-Mastodon.spec
SRPM:
https://fedorapeople.org/~limb/review/python-Mastodon/python-Mastodon-1.1.1-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502181] Review Request: seahorse-caja - PGP encryption and signing for caja

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502181



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/seahorse-caja

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430364] Review Request: argbash - Bash argument parsing code generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430364

James Hogarth  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(james.hogarth@gma |
   |il.com) |



--- Comment #14 from James Hogarth  ---
Heh I figured as much ... but fedora-review was whining so thought it sensible
to include a brief comment covering that ;)

Based on the changes made marking this APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430364] Review Request: argbash - Bash argument parsing code generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430364

Stephen Gallagher  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||needinfo?(james.hogarth@gma
   ||il.com)



--- Comment #13 from Stephen Gallagher  ---
Spec: https://sgallagh.fedorapeople.org/packagereview/argbash/argbash.spec
SRPM:
https://sgallagh.fedorapeople.org/packagereview/argbash/argbash-2.5.0-0.3.fc27.src.rpm
Scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22485375


BTW, the actual spec file inside the SRPM was never argbash-2.4.0-0.2.spec. I
had just renamed the version I uploaded to fedorapeople so that it could be
compared with the prior version. I've since renamed it to just argbash.spec

You convinced me that it belongs in /usr/share, so I made that change. I also
added the missing `Requires:`.

I've submitted a patch upstream for `cp -p` at
https://github.com/matejak/argbash/pull/28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476608] Review Request: ubridge - Bridge for UDP tunnels, Ethernet, TAP and VMnet interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476608



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ubridge

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500574] Review Request: golang-github-alecthomas-chroma - A general purpose syntax highlighter in pure Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500574



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-alecthomas-chroma

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-time-compat. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1198196] Review Request: ghc-auto-update - Efficiently run periodic, on-demand actions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198196



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-auto-update. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388908] Review Request: python-flask-bootstrap - Python flask bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388908



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-flask-bootstrap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-picker

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489983] Review Request: llvm4.0 - Compatibility package for LLVM 4.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489983



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/llvm4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #25 from Michal Schmidt  ---
(In reply to Andrey Maslennikov from comment #23)
> >> %{_datadir}/doc/ucx
> > Did you intentionally avoid using %{_pkgdocdir}? Is it because older 
> > distros do not define the macro? You could do what some other Fedora 
> > packages did for compatibility with EPEL 6:
> > %{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}}
> Yes, I expect issue with old distros we support. Should I add this WA and
> use %{_pkgdocdir} instead?

Yes, please.

> >> %doc %{_datadir}/doc/ucx/examples
> > I believe it is unnecessary to use the explicit "%doc" marking. RPM 
> > automatically marks files under _pkgdocdir as documentation.
> Will move %{_datadir}/doc/ucx/examples out of %doc tag.

You still have:
 %doc %{_datadir}/doc/ucx/examples
in the "%files devel" section in the current version.
Here the %doc tag is simply redundant.

> > I am not sure how safe it is to mix the usage of both %doc with relative 
> > paths (for README, etc.) and _docdir / _pkgdocdir. The guidelines forbid it 
> > if I'm reading them correctly:
> > https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> > I see no obvious issue in the built packages, but maybe it could cause 
> > trouble with other versions of RPM. Better avoid the mixed usage by 
> > installing the files README, AUTHORS, NEWS into _pkgdocdir in the %install 
> > step instead of relying on %doc with relative paths.
> Considering the previous paragraph, no issue here, right?

It is an issue. You have these two lines:

  %{_datadir}/doc/ucx
  %doc README AUTHORS NEWS

(The first line should be written as "%{_pkgdocdir}", but that does not change
the argument.)

The first line uses the method of placing the documentation files in
%_pkgdocdir.
The second line uses the method of letting RPM copy the files from %_builddir
to %_pkgdocdir.
According to my reading of the guidelines, these two methods must not be both
used in the same source package.

> >> # UCX ships both static and dynamic libs to support different use-cases
> > I still don't get what the usecase is. Is it for performance reasons?
> Yes.

OK, can you please mention "for performance" in the comment rather than the
vague "to support different use-cases"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502181] Review Request: seahorse-caja - PGP encryption and signing for caja

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502181



--- Comment #7 from Wolfgang Ulbrich  ---
Thanks, for the review.
I will add you hints to package before pushing to git.
Personal, i prefer not to use pkgconfig to handle your dependencies, but i can
change it.
Guys from irc fedora-devel told me that transfiletriggers is use for
scripplets.
ie.
[rave@mother ~]$ rpm -q --filetriggers glib2
transfiletriggerin scriptlet (using /bin/sh) -- /usr/lib64/gio/modules
gio-querymodules-64 /usr/lib64/gio/modules &> /dev/null || :
transfiletriggerpostun scriptlet (using /bin/sh) -- /usr/lib64/gio/modules
gio-querymodules-64 /usr/lib64/gio/modules &> /dev/null || :
transfiletriggerin scriptlet (using /bin/sh) -- /usr/share/glib-2.0/schemas
glib-compile-schemas /usr/share/glib-2.0/schemas &> /dev/null || :
transfiletriggerpostun scriptlet (using /bin/sh) -- /usr/share/glib-2.0/schemas
glib-compile-schemas /usr/share/glib-2.0/schemas &> /dev/null || :

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502600] Review Request: kabi-dw - Detect changes in the ABI between kernel builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502600

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello,

You need to split the %description line to stay below 80 characters per line.

This is trivial so the package is bccepted, just don't forget to fix it before
import.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "GPL (v3 or later)", "Unknown or
 generated". 3 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/kabi-dw/review-kabi-
 dw/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kabi-dw-
 

[Bug 1497687] Review Request: popub - Upstream rename of portpub

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497687

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
All ok, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502181] Review Request: seahorse-caja - PGP encryption and signing for caja

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502181

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
> But how the keys were applied nowadays?

AFAIK, it is automated when you install the package.

> Same for old desktop database scriptlet which was required by review-tool 
> here?

Yes

> And is it save to to remove those scriplets from all packages?

Yes, since F24 is EOL, all packages should be upgraded to remove the scriplets.

>And do you know how the situation is for epel7 repo, as most packages of mine 
>i build for rhel7 too?

You should keep the scriplets for EPEL/RHEL, as they are based on an oldder
Fedora.


Now the review:

 - seahorse-caja.x86_64: E: incorrect-fsf-address
/usr/share/licenses/seahorse-caja/COPYING

You should notify upstream about this.

 - You could use pkgconfig to handle your dependencies:

BuildRequires:  mate-common
BuildRequires:  pkgconfig(gtk+-3.0)
BuildRequires:  desktop-file-utils
BuildRequires:  pkgconfig(gcr-3)
BuildRequires:  gnupg2
BuildRequires:  gpgme-devel >= 1.0
BuildRequires:  pkgconfig(libcaja-extension)
BuildRequires:  pkgconfig(gnome-keyring-1)
BuildRequires:  pkgconfig(dbus-glib-1)
BuildRequires:  pkgconfig(cryptui-0.0)
BuildRequires:  pkgconfig(libnotify)


None of this is blocking, so the package is accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect FSF
 address)", "FSF All Permissive", "GPL (v2 or later)", "Unknown or
 generated". 136 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/seahorse-caja/review-
 seahorse-caja/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or 

[Bug 1497687] Review Request: popub - Upstream rename of portpub

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497687



--- Comment #4 from Zamir SUN  ---
Thanks for the help.

SRPM:
https://copr-be.cloud.fedoraproject.org/results/zsun/test/fedora-rawhide-x86_64/00637494-popub/popub-0-0.3.20171007git6ffa11c.fc28.src.rpm
SPEC:
https://raw.githubusercontent.com/sztsian/packaging/master/portpub/popub.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502334] Review Request: afl - A security-oriented fuzzer that automatically discovers test cases that trigger new internal states in the targeted binary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502334

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2017-10-16 06:34:20



--- Comment #2 from Igor Gnatenko  ---
yep, it does.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502600] Review Request: kabi-dw - Detect changes in the ABI between kernel builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502600

Zamir SUN  changed:

   What|Removed |Added

 CC||skoz...@redhat.com
  Alias||kabi-dw



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502600] New: Review Request: kabi-dw - Detect changes in the ABI between kernel builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502600

Bug ID: 1502600
   Summary: Review Request: kabi-dw - Detect changes in the ABI
between kernel builds
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: szts...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/sztsian/packaging/3ce99798b2478c767037f4aff3cf81f03e8c8d2c/kabi-dw.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/zsun/test/fedora-rawhide-x86_64/00637467-kabi-dw/kabi-dw-0-0.1.20171012git2ef3f81.fc28.src.rpm
 
Description: Detect changes in the ABI between kernel builds
Fedora Account System Username: zsun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502584] Review Request: boost-nowide - boost library making cross platform Unicode aware programming easier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502584

James Hogarth  changed:

   What|Removed |Added

 Blocks||1419271




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1419271
[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake
utility libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419271] Review Request: leatherman -A collection of C++ and CMake utility libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419271

James Hogarth  changed:

   What|Removed |Added

 Depends On||1502584



--- Comment #6 from James Hogarth  ---
Marking this blocked on the boost-nowide module as that's required to be
unbundled for this review to complete.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1502584
[Bug 1502584] Review Request: boost-nowide - boost library making cross
platform Unicode aware programming easier
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502584] Review Request: boost-nowide - boost library making cross platform Unicode aware programming easier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502584

James Hogarth  changed:

   What|Removed |Added

 CC||denis.arnaud_fed...@m4x.org



--- Comment #1 from James Hogarth  ---
Not marking this as blocked on the EPEL7 boost157 review as this is a *Fedora*
review ... the EPEL part is just for information and future intent only...

Note this is the first time I've dealt with boost so would appreciate feedback
on the proper way to handle this module until such time as nowide upstream
submits, and has it included in, boost upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1210993

James Hogarth  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1210993

James Hogarth  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502584] New: Review Request: boost-nowide - boost library making cross platform Unicode aware programming easier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502584

Bug ID: 1502584
   Summary: Review Request: boost-nowide - boost library making
cross platform Unicode aware programming easier
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: james.hoga...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jhogarth.fedorapeople.org/boost-nowide/boost-nowide.spec
SRPM URL:
https://jhogarth.fedorapeople.org/boost-nowide/boost-nowide-0-20171003.gitec9672b.fc28.src.rpm

Description: Boost.Nowide is a library implemented by Artyom Beilis
that makes cross platform Unicode aware programming
easier.

The library provides an implementation of standard C and C++ library
functions, such that their inputs are UTF-8 aware on Windows without
requiring to use Wide API.


Fedora Account System Username: jhogarth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #24 from Andrey Maslennikov  ---
Spec URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/4a3cc83297b579f2ab89fbe6c804a1b858449394/ucx.spec
SRPM URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/4a3cc83297b579f2ab89fbe6c804a1b858449394/ucx-1.2.2-1.fc25.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22481063

Changes:
-%doc README AUTHORS NEWS
 %{_datadir}/doc/ucx
 %exclude %{_datadir}/doc/ucx/examples
+%doc README AUTHORS NEWS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502181] Review Request: seahorse-caja - PGP encryption and signing for caja

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502181



--- Comment #5 from Wolfgang Ulbrich  ---
New SPEC and SRPM:
Spec URL: https://raveit65.fedorapeople.org/Mate/Specs/seahorse-caja.spec
SRPM URL:
https://raveit65.fedorapeople.org/Mate/SRPM/seahorse-caja-1.18.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #26 from David Vásquez  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #25)
> So, I am actually rejecting this review request on the grounds that it
> doesn't work as advertised (applications linking against this library expect
> it to support HE-AAC fully, including SBR). However, I'm open to hearing
> arguments to convince me that it's still a good idea to have a broken AAC
> codec in Fedora. Right now, I'm convinced it would only give Fedora a bad
> name.

Ok, the test show the differences. It fails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502334] Review Request: afl - A security-oriented fuzzer that automatically discovers test cases that trigger new internal states in the targeted binary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502334

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #1 from Elliott Sales de Andrade  ---
I think this already exists:
https://apps.fedoraproject.org/packages/american-fuzzy-lop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502181] Review Request: seahorse-caja - PGP encryption and signing for caja

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502181



--- Comment #4 from Wolfgang Ulbrich  ---
Ok, all seems to be needed only for epel7.
https://fedoraproject.org/wiki/EPEL:Packaging?rd=Packaging:EPEL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502181] Review Request: seahorse-caja - PGP encryption and signing for caja

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502181



--- Comment #3 from Wolfgang Ulbrich  ---
Thanks, for this site i was searching for. I found only the new one.
But how the keys were applied nowadays?
Same for old desktop database scriptlet which was required by review-tool here?
And is it save to to remove those scriplets from all packages?
And do you know how the situation is for epel7 repo, as most packages of mine i
build for rhel7 too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org