[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 --- Comment #7 from Christopher Engelhard --- (In reply to Otto Urpelainen from comment #6) > If you get in touch with upstream about phpunit 9 support, > you could take care of this warning that is currently emitted: Will do. > I will take one more of your php requests when I find the time, > assuming there are still some left. that would be great, thank you. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #7 from Neal Gompa --- The SRPM is not updated, fedora-review continues to fail. :( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114
--- Comment #8 from Stuart D Gathman ---
I did a scratch build with all %{rust_arches}.
https://koji.fedoraproject.org/koji/taskinfo?taskID=73652213
It all but armv7hl have finished and unit tests run with no errors as I write.
I think there might be a misunderstanding about what cpufeatures means.
Apparently, the library can use CPU features to accelerate operations - but
only on the supported CPUs. The other arches work, but are slower. I believe
now that you should use %{rust_arches}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1986953] Review Request: snoopy - A preload library to send shell commands to syslog
https://bugzilla.redhat.com/show_bug.cgi?id=1986953 --- Comment #16 from Fedora Update System --- FEDORA-EPEL-2021-ddae0be390 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977110] Review Request: rust-gtk4-macros - Macros helpers for GTK 4 bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1977110 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2021-2766a68e92 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-2766a68e92 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2766a68e92 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1676544] Review Request: nodejs-event-stream - Construct pipes of streams of events
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Jared Smith 's needinfo: Bug 1676544: Review Request: nodejs-event-stream - Construct pipes of streams of events https://bugzilla.redhat.com/show_bug.cgi?id=1676544 --- Comment #5 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1673956] Review Request: octave-openems - An electromagnetic field solver for octave
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Thomas Sailer 's needinfo: Bug 1673956: Review Request: octave-openems - An electromagnetic field solver for octave https://bugzilla.redhat.com/show_bug.cgi?id=1673956 --- Comment #6 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1269001] Review Request: tinycbor - Concise Binary Object Representation (CBOR) Library
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Jared Smith 's needinfo: Bug 1269001: Review Request: tinycbor - Concise Binary Object Representation (CBOR) Library https://bugzilla.redhat.com/show_bug.cgi?id=1269001 --- Comment #6 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979736] Review Request: emacs-logstash-conf - Emacs mode for editing Logstash configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1979736 --- Comment #3 from Mohamed El Morabity --- Hello Hirotaka, thanks for the review. (In reply to Hirotaka Wakabayashi from comment #2) > Could you add a license text to logstash-conf-init.el like logstash-conf.el > or > ask the upstream to add a license file? logstash-conf-init.el is not part of the original source code. It was written by me. It allows all the macros/modes provided by the package to be conveniently loaded and available when starting Emacs. Without any explicit license, such a file is licensed, as for SPEC files, under the MIT license according to the FPCA (https://fedoraproject.org/wiki/Legal:Fedora_Project_Contributor_Agreement). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977132] Review Request: rust-gtk4 - Rust bindings of the GTK 4 library
https://bugzilla.redhat.com/show_bug.cgi?id=1977132 Rémi Lauzier changed: What|Removed |Added Resolution|--- |ERRATA Status|POST|CLOSED Last Closed||2021-08-10 21:18:00 --- Comment #3 from Rémi Lauzier --- https://bodhi.fedoraproject.org/updates/FEDORA-2021-e6ecf42136 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981114] Review Request: rust-curve25519-dalek - Pure-Rust implementation of group operations on ristretto255 and Curve25519
https://bugzilla.redhat.com/show_bug.cgi?id=1981114 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com --- Comment #7 from Fabio Valentini --- (In reply to Jens Petersen from comment #3) > One please tweak: revisiting the cpufeatures review, > I think should package can and should be enabled for all rust_arches? Hi Jens, what do you mean here? cpufeatures is an aarch64 and x86_64 specific dependency, but it is also only a dependency on those architectures ... It should always be scoped to those two targets and not be a dependency otherwise, like here, in sha2: https://github.com/RustCrypto/hashes/blob/master/sha2/Cargo.toml#L24 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1984114] Review Request: rust-trash - Library for moving files and folders to the Recycle Bin
https://bugzilla.redhat.com/show_bug.cgi?id=1984114 Fabio Valentini changed: What|Removed |Added Blocks||1991267 CC||remilauz...@protonmail.com --- Comment #3 from Fabio Valentini --- *** Bug 1991292 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1991267 [Bug 1991267] rust-image-roll-1.3.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991292] Review Request: rust-trash - Moving files and folders to the Recycle Bin
https://bugzilla.redhat.com/show_bug.cgi?id=1991292 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com Resolution|--- |DUPLICATE Status|NEW |CLOSED Last Closed||2021-08-10 21:03:20 --- Comment #2 from Fabio Valentini --- This package has already been reviewed, it's just not been imported yet. *** This bug has been marked as a duplicate of bug 1984114 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #6 from Owen Taylor --- Added the python3-devel BuildRequires (same URLs). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #8 from Georg Sauthoff --- >> I revisited it again, the rspec build-requires comes from my modified >> gem2rpm fedora template. So, I take this back: > no, that one should be there since that's what the test suite needs to run > (at according to gemspec as well). And that is the reason for the build > failure; the rubygem-rspec package is not present. Yes, this is what I thought, and what I observed a few weeks ago, when I created the package. > I was talking about the conditional `> 3`, since Fedora does not provide > rubygem-rspec <= 2, it is superfluous. I see, I misread that part. > > `Upload text to gist.github.com` > > Because it does not need to be code to upload it. Fair enough, what about 'content' then? I've updated the .spec file: https://raw.githubusercontent.com/gsauthof/copr-fedora/e7e3fe19107bb6de63c83c7e0527f035d3257af9/rubygem-gist/rubygem-gist.spec Corresponding Copr build (all green on rawhide/f33/f34): https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2504491/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #5 from Neal Gompa --- You're missing "BuildRequires: python3-devel", so the macros don't exist to build the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1896742] Review Request: python-radexreader - Reader for the RADEX RD1212 Geiger counter
https://bugzilla.redhat.com/show_bug.cgi?id=1896742 --- Comment #24 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-radexreader -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1970050] Review Request: cri-o - Kubernetes Container Runtime Interface for OCI-based containers
https://bugzilla.redhat.com/show_bug.cgi?id=1970050 --- Comment #29 from Peter Hunt --- Spec URL: https://haircommander.fedorapeople.org/cri-o.spec SRPM URL: https://haircommander.fedorapeople.org/cri-o-1.21.2-1.fc32.src.rpm (note, I ended up dropping the ln -sf from the spec, as the Makefile was already doing it, so the build failed when it was duplicated) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 --- Comment #4 from Owen Taylor --- Spec file and SRPM have been updated to fix the identified problems. Thanks for the review! Spec URL: https://pagure.io/fedora-third-party/raw/main/f/fedora-third-party.spec SRPM URL: https://otaylor.fedorapeople.org/fedora-third-party-0.1-1.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992232] Review Request: disciplining-minipod - Disciplining algorithm for Atomic Reference Time Card
https://bugzilla.redhat.com/show_bug.cgi?id=1992232 --- Comment #1 from Davide Cavalca --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=73639746 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992232] New: Review Request: disciplining-minipod - Disciplining algorithm for Atomic Reference Time Card
https://bugzilla.redhat.com/show_bug.cgi?id=1992232 Bug ID: 1992232 Summary: Review Request: disciplining-minipod - Disciplining algorithm for Atomic Reference Time Card Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: dcava...@fb.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://dcavalca.fedorapeople.org/review/disciplining-minipod/disciplining-minipod.spec SRPM URL: https://dcavalca.fedorapeople.org/review/disciplining-minipod/disciplining-minipod-1.0.1-1.fc35.src.rpm Description: Library providing C disciplining algorithm used with oscillatord to discipling oscillators using the minipod algorithm developed by Matthias Lorentz. Fedora Account System Username: dcavalca -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386 Link Dupont changed: What|Removed |Added Assignee|nob...@fedoraproject.org|l...@sub-pop.net CC||l...@sub-pop.net Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991085] Review Request: rust-xkbcommon-sys - Bindings to libxkbcommon
https://bugzilla.redhat.com/show_bug.cgi?id=1991085 Rémi Lauzier changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2021-08-10 17:29:55 --- Comment #1 from Rémi Lauzier --- I won't need it since i will orphaned rust-line_drawing and not package castle-game. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991198] Review Request: rust-const-tweaker-attribute - Tweak constant variables live from a web GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1991198 Rémi Lauzier changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed||2021-08-10 17:29:10 --- Comment #1 from Rémi Lauzier --- I won't need it since i will orphaned rust-line_drawing. so i won't package castle-game that need it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989360] Review Request: fedora-flathub-remote - Third party remote pointing to a filtered version of flathub.org
https://bugzilla.redhat.com/show_bug.cgi?id=1989360
--- Comment #2 from Neal Gompa ---
This package looks fairly trivial.
There are only two issues:
* Release needs to be "1%{?dist}" to include the DistTag
* Missing license file
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1989360] Review Request: fedora-flathub-remote - Third party remote pointing to a filtered version of flathub.org
https://bugzilla.redhat.com/show_bug.cgi?id=1989360 Neal Gompa changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://pagure.io/fedora-flathub-filter/raw/main/f/fedora-flathub-remote.spec SRPM URL: https://otaylor.fedorapeople.org/fedora-flathub-remote-1-1.src.rpm Description: This package adds configuration to add a remote pointing to flathub.org when third-party repositories are enabled on a Fedora Linux system. This remote is filtered to include only specific Fedora-approved packages. (If the user installs the Flathub remote manually, the filter is removed, and the flathub remote is no longer managed as a third-party repository.) See: https://fedoraproject.org/wiki/Changes/Filtered_Flathub_Applications Fedora Account System Username: otaylor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988465] Review Request: yggdrasil - Remote execution client and dispatch service
https://bugzilla.redhat.com/show_bug.cgi?id=1988465 Link Dupont changed: What|Removed |Added Summary|Review Request: yggd - |Review Request: yggdrasil - |Remote execution client and |Remote execution client and |dispatch service|dispatch service --- Comment #2 from Link Dupont --- Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02504287-yggdrasil/yggdrasil.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02504287-yggdrasil/yggdrasil-0.2.98%5E1.ffb580f-0.1.20210810gitffb580f.fc35.src.rpm Description: yggd is a client daemon that establishes a receiving queue for instructions to be sent to the system via a broker. Fedora Account System Username: linkdupont Fedora Review: https://copr-be.cloud.fedoraproject.org/results/linkdupont/reviews/fedora-rawhide-x86_64/02504287-yggdrasil/fedora-review/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386
Link Dupont changed:
What|Removed |Added
Flags||needinfo?(obu...@redhat.com
||)
--- Comment #1 from Link Dupont ---
[FIX] Your name has some unicode character encoding issue in the %changelog
[FIX] The %changelog includes the %{?dist} macro; over time, that macro will
update what it expands to, causing the historical entries in %changelog
to
change too. I suggest removing %{dist} from the %changelog entries.
They're not necessary or required.
[FIX] Two separate README.md files are listed in %docs. These will conflict
with
each other and cause a warning in the build logs.
"warning: File listed twice:
/usr/share/doc/golang-github-jwt-devel/README.md"
If both README files are needed, one should be manually installed into
the
doc dir under a different name (i.e. README-jwt.md).
[NOTE] Lots of other packages own /usr/share/gocode/src/github.com. If this is
incorrect, it's a bug in the golang macros that needs to be addressed.
It's not something that can be fixed here.
[NOTE] A new upstream version (4.0.0) was released 7 days ago, as of this
writing.
[NOTE] The -devel subpackage does not explicitly require the main package, but
that is not a problem. The main package is not required when compiling a
project that uses the "jwt" Go package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/doc/golang-github-
jwt/README.md
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "MIT License", "Unknown or
generated". 54 files have unknown license. Detailed output of
licensecheck in /home/link/1989386-golang-github-jwt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by other packages:
/usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[Bug 1980562] Review Request: catch22 - CAnonical Time-series CHaracteristics
https://bugzilla.redhat.com/show_bug.cgi?id=1980562 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/catch22 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977132] Review Request: rust-gtk4 - Rust bindings of the GTK 4 library
https://bugzilla.redhat.com/show_bug.cgi?id=1977132 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gtk4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988465] Review Request: yggd - Remote execution client and dispatch service
https://bugzilla.redhat.com/show_bug.cgi?id=1988465 Neal Gompa changed: What|Removed |Added Flags||fedora-review? Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ngomp...@gmail.com CC||ngomp...@gmail.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357 Neal Gompa changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://pagure.io/fedora-third-party/raw/main/f/fedora-third-party.spec SRPM URL: https://otaylor.fedorapeople.org/fedora-third-party-0.1-1.src.rpm Description: fedora-third-party is a tool for handling third-party RPM and Flatpak repositories in Fedora. It is used to handle the user changing their opt-in status for these repositories, and enables/disables RPM repositories and adds/removes Flatpak repositories as necessary. See: https://fedoraproject.org/wiki/Changes/Third_Party_Software_Mechanism Examples of usage: https://src.fedoraproject.org/rpms/fedora-workstation-repositories/diff/main..private-otaylor-fedora-third-party https://pagure.io/fedora-flathub-filter/c/8277908dc9e60b39ca197517a40c85806a704e1b?branch=main Fedora Account System Username: otaylor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357
--- Comment #3 from Neal Gompa ---
> Release: 1
This should be "Release: 1%{?dist}" as we require the DistTag to be present.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1989360] Review Request: fedora-flathub-remote - Third party remote pointing to a filtered version of flathub.org
https://bugzilla.redhat.com/show_bug.cgi?id=1989360 Neal Gompa changed: What|Removed |Added Blocks||1982741 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1982741 [Bug 1982741] Filtered Flathub Applications -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989357] Review Request: fedora-third-party - Tool for handling third-party RPM and Flatpak repositories in Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1989357
--- Comment #2 from Neal Gompa ---
Initial review notes:
> %autosetup -p1 -n fedora-third-party-0.1
This should be "%autosetup -p1" or "%autosetup -p1 -n %{name}-%{version}" (the
-n stuff is optional since name-version matches the package name)
> %{python3_sitelib}/*
This is not allowed, you should use "%{python3_sitelib}/fedora_third_party*"
instead
Also, it seems to install a "tests" thing, which you shouldn't do. That
requires fixing setup.py accordingly:
https://pagure.io/fedora-third-party/blob/main/f/setup.py#_15
> %dnl This enables/adds any newly added repositories/remotes
> %transfiletriggerin -- %{_prefix}/lib/%{name}/conf.d
> fedora-third-party refresh
>
> %dnl This could potentially be used to remove Flatpak repositories (not
> currently implemented)
> %transfiletriggerpostun -- %{_prefix}/lib/%{name}/conf.d
> fedora-third-party refresh
"fedora-third-party refresh" should be "fedora-third-party refresh || :" so
that it won't fail if the package is uninstalled.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 --- Comment #3 from Mikel Olasagasti Uranga --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-pytest-postgresql.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-pytest-postgresql-3.1.1-2.fc34.src.rpm - Fixed license - Adapted better to pyproject macros -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991135] Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests
https://bugzilla.redhat.com/show_bug.cgi?id=1991135 --- Comment #3 from Mikel Olasagasti Uranga --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-mirakuru.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-mirakuru-2.4.1-2.fc34.src.rpm - Removed unneeded bits - Added --no-cov to %check -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991096] Review Request: python-port-for - Utility that helps with local TCP ports management
https://bugzilla.redhat.com/show_bug.cgi?id=1991096 --- Comment #4 from Mikel Olasagasti Uranga --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-port-for.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-port-for-0.6.1-2.fc34.src.rpm - Added PR reference to Patch0 - Changed to pyproject macros - Added "--no-cov" to %check section -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979736] Review Request: emacs-logstash-conf - Emacs mode for editing Logstash configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1979736
--- Comment #2 from Hirotaka Wakabayashi ---
Hello Mohamed,
Could you add a license text to logstash-conf-init.el like logstash-conf.el or
ask the upstream to add a license file?
This package doesn't have %license and the license of Source1 code is unknown.
The upstream doesn't have a license file but it is reasonable for me because
the upstream provides only one source code(logstash-conf.el) that includes the
license text in its own file.
Thanks in advance,
Hirotaka Wakabayashi
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
[Bug 1308742] Review Request: collectd5 - Statistics collection daemon for filling RRD files
https://bugzilla.redhat.com/show_bug.cgi?id=1308742 Ruben Kerkhof changed: What|Removed |Added Resolution|--- |WONTFIX Status|ASSIGNED|CLOSED Last Closed||2021-08-10 11:31:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1931183] Review Request: python-spikeextractors - Python module for extracting recorded and spike sorted extracellular data from different file types and formats
https://bugzilla.redhat.com/show_bug.cgi?id=1931183 --- Comment #10 from Andy Mender --- Looks like the PR linked above was merged and hdmf is at version 3.1.1: https://github.com/hdmf-dev/hdmf/releases/tag/3.1.1 I think we can proceed as soon as the python-h5py package is updated in Fedora, correct? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982306] Review Request: libyang2 - YANG data modeling language library v2
https://bugzilla.redhat.com/show_bug.cgi?id=1982306 Michal Ruprich changed: What|Removed |Added CC||mrupr...@redhat.com --- Comment #17 from Michal Ruprich --- Hi guys, I understand the reasons that Jakub described here in the comments, why it is a good idea to make this into a new package, but next time please make sure you invite the maintainer of the current version in the process as well. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
