[Bug 1858360] Review Request: perl-HTTP-Headers-ActionPack - HTTP Action, Adventure and Excitement
https://bugzilla.redhat.com/show_bug.cgi?id=1858360 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|ppi...@redhat.com |nob...@fedoraproject.org Flags|fedora-review+ |needinfo?(rc040203@freenet. ||de) --- Comment #2 from Mattia Verga --- Package never imported, resetting ticket status. Ralf, are you still on this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1858360] Review Request: perl-HTTP-Headers-ActionPack - HTTP Action, Adventure and Excitement
https://bugzilla.redhat.com/show_bug.cgi?id=1858360
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar ---
URL and Source0 addresses are Ok.
TODO: Remove a trailing slash from the URL value.
Source0 archive (SHA-256:
c78111ab857e48c69824903d4b6ce8293feffc6b5d670db550a767f853acc7da) is original.
Ok.
Summary verified from lib/HTTP/Headers/ActionPack.pm. OK.
TODO: The summary is not much descriptive. Have you consider not following the
upstream here? Something like "Parsing and constructing HTTP headers" would be
more helpful.
Description verified from lib/HTTP/Headers/ActionPack.pm. Ok.
License verified from Makefile.PL, LICENSE, README,
lib/HTTP/Headers/ActionPack.pm, and others. OK.
No XS code, noArch BuildArch is Ok.
FIX: Build-require "perl-interpreter" (perl-HTTP-Headers-ActionPack.spec:44).
TODO: Use %{make_build} and %{make_install} instead of "make %{?_smp_mflags}"
and "make pure_install".
TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null
\;". It's not needed.
FIX: Build-require "make" (perl-HTTP-Headers-ActionPack.spec:58).
FIX: Build-require "coreutils" (perl-HTTP-Headers-ActionPack.spec:66).
TODO: Packaging both README and REAMDE.md seens redundant. Consider dropping
README.
TODO: Constrain "perl(ExtUtils::MakeMaker)" with ">= 6.30" (Makefile.PL:7).
HTTP::Message::PSGI is optional and build-required. Ok.
Web::Request is optional and not build-required. Ok.
TODO: Plack::Request and Plack::Response are used by tests only. Please
categorize them as "Testsuite only". Not as "Optional runtime".
Test::Spelling, Test::NoTabs, Test::Pod::LinkCheck, Test::Pod::No404s, and
Test::Pod are not used. Ok.
TODO: Consider unsetting AUTHOR_TESTING and RELEASE_TESTING environment
variable in %check section to make sure the modules are not used.
All tests pass. Ok.
$ rpmlint perl-HTTP-Headers-ActionPack.spec
../SRPMS/perl-HTTP-Headers-ActionPack-0.09-1.fc33.src.rpm
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p
../RPMS/noarch/perl-HTTP-Headers-ActionPack-0.09-1.fc33.noarch.rpm
drwxr-xr-x2 root root0 Jul 20 15:03
/usr/share/doc/perl-HTTP-Headers-ActionPack
-rw-r--r--1 root root 2120 Jun 18 2013
/usr/share/doc/perl-HTTP-Headers-ActionPack/Changes
-rw-r--r--1 root root 327 Jun 18 2013
/usr/share/doc/perl-HTTP-Headers-ActionPack/README
-rw-r--r--1 root root 1513 Jun 18 2013
/usr/share/doc/perl-HTTP-Headers-ActionPack/README.md
drwxr-xr-x2 root root0 Jul 20 15:03
/usr/share/licenses/perl-HTTP-Headers-ActionPack
-rw-r--r--1 root root18389 Jun 18 2013
/usr/share/licenses/perl-HTTP-Headers-ActionPack/LICENSE
-rw-r--r--1 root root 3652 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack.3pm.gz
-rw-r--r--1 root root 2060 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::AcceptCharset.3pm.gz
-rw-r--r--1 root root 1889 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::AcceptLanguage.3pm.gz
-rw-r--r--1 root root 1866 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::AuthenticationInfo.3pm.gz
-rw-r--r--1 root root 2137 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Authorization.3pm.gz
-rw-r--r--1 root root 1996 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Authorization::Basic.3pm.gz
-rw-r--r--1 root root 2076 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Authorization::Digest.3pm.gz
-rw-r--r--1 root root 2421 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::ContentNegotiation.3pm.gz
-rw-r--r--1 root root 1638 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::Base.3pm.gz
-rw-r--r--1 root root 1673 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseAuthHeader.3pm.gz
-rw-r--r--1 root root 1739 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseHeaderList.3pm.gz
-rw-r--r--1 root root 1848 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseHeaderType.3pm.gz
-rw-r--r--1 root root 1805 Jul 20 15:03
/usr/share/man/man3/HTTP::Headers::ActionPack::Core::BaseHeaderWithParams.3pm.gz
-rw-r--r--1 root root 2210 Jul 20 15:03
[Bug 1858360] Review Request: perl-HTTP-Headers-ActionPack - HTTP Action, Adventure and Excitement
https://bugzilla.redhat.com/show_bug.cgi?id=1858360 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858360] Review Request: perl-HTTP-Headers-ActionPack - HTTP Action, Adventure and Excitement
https://bugzilla.redhat.com/show_bug.cgi?id=1858360 Ralf Corsepius changed: What|Removed |Added Blocks||1858381 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858381 [Bug 1858381] Review Request: perl-Web-Machine - Perl port of Webmachine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858360] Review Request: perl-HTTP-Headers-ActionPack - HTTP Action, Adventure and Excitement
https://bugzilla.redhat.com/show_bug.cgi?id=1858360 Ralf Corsepius changed: What|Removed |Added Blocks|1858048 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858048 [Bug 1858048] rt-5.0.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858360] Review Request: perl-HTTP-Headers-ActionPack - HTTP Action, Adventure and Excitement
https://bugzilla.redhat.com/show_bug.cgi?id=1858360 Ralf Corsepius changed: What|Removed |Added Blocks||1858048 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1858048 [Bug 1858048] rt-5.0.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
