[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #32 from Fedora Update System  ---
rubygem-colorize-0.8.1-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-06-01 01:09:40



--- Comment #31 from Fedora Update System  ---
rubygem-colorize-0.8.1-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #30 from Fedora Update System  ---
rubygem-colorize-0.8.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c08a5b1590

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #29 from Fedora Update System  ---
rubygem-colorize-0.8.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5673253c83

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #28 from Fedora Update System  ---
rubygem-colorize-0.8.1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5673253c83

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #27 from Fedora Update System  ---
rubygem-colorize-0.8.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c08a5b1590

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #26 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-colorize

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #25 from Christos Triantafyllidis 
 ---
Thank you Germano!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Germano Massullo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #24 from Germano Massullo  ---
Package approved




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
 colorize-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires 

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #23 from Christos Triantafyllidis 
 ---
Hello Germano,

SRPM:
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.8.1-1.fc25.src.rpm
SPEC:
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize.spec

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #22 from Germano Massullo  ---
Could you re upload the srpm file some elsewhere? It is no longer available in
Koji

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Christos Triantafyllidis  changed:

   What|Removed |Added

  Flags|needinfo?(steve.traylen@cer |
   |n.ch)   |
   |needinfo?(ctrianta@redhat.c |
   |om) |



--- Comment #21 from Christos Triantafyllidis 
 ---
Hello,

Looks like I missed the updates on that.

Thank you for the review.

I've changed the comment for the patch to:
Removes the reporting of test coverage to Code Climate's host

I hope that is clear now.

Scratch builds:
F25: http://koji.fedoraproject.org/koji/taskinfo?taskID=17204830
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=17204832

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Germano Massullo  changed:

   What|Removed |Added

 CC||ctria...@redhat.com
  Flags||needinfo?(ctrianta@redhat.c
   ||om)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Germano Massullo  changed:

   What|Removed |Added

   Assignee|steve.tray...@cern.ch   |germano.massu...@gmail.com



--- Comment #20 from Germano Massullo  ---
|===|
|  ISSUES   |
|===|

- Please add into the spec file a comment that describes
the patch




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
 colorize-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: 

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #19 from Germano Massullo  ---
(In reply to Fabio Alessandro Locati from comment #18)
> I can pickup the review, if Steve is not interested/active on this anymore!

I have no hope in Steve's reply

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #18 from Fabio Alessandro Locati  ---
I can pickup the review, if Steve is not interested/active on this anymore!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #17 from Christos Triantafyllidis 
 ---
Hello,

Updated to the latest upstream (0.8.1):
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize.spec
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.8.1-1.fc24.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15590740

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Christos Triantafyllidis  changed:

   What|Removed |Added

  Flags||needinfo?(steve.traylen@cer
   ||n.ch)



--- Comment #16 from Christos Triantafyllidis 
 ---
Hey Steve,

Are you still available to review that?

I'll update the request later today to current upstream version (0.8.1).

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Germano Massullo  changed:

   What|Removed |Added

   Priority|medium  |urgent



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #15 from Fabio Alessandro Locati  ---
This is blocking rubygem-bettercap and seems like there has been no updates in
the last 7+ months. Any updates from Christos/Steve?

If a reviewer is needed, I can do it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Germano Massullo  changed:

   What|Removed |Added

 Blocks||1348005




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1348005
[Bug 1348005] Review Request: rubygem-bettercap - A complete, modular,
portable and easily extensible MITM framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #12 from Upstream Release Monitoring 
 ---
ctria's scratch build of rubygem-colorize-0.7.7-1.fc23.src.rpm for rawhide
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11705294

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #14 from Christos Triantafyllidis 
 ---
Hello Steve,

Sure, let's finish that.

Updated to the latest upstream (0.7.7):
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize.spec
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.7.7-1.fc23.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11706052

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #13 from Upstream Release Monitoring 
 ---
ctria's scratch build of rubygem-colorize-0.7.7-1.fc23.src.rpm for f23
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11706052

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #9 from Steve Traylen  ---
Christos, do you want to finish this off and close it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #4 from Upstream Release Monitoring 
 ---
awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11324994

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #5 from Upstream Release Monitoring 
 ---
awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11324998

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #8 from Upstream Release Monitoring 
 ---
awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11325018

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #7 from Upstream Release Monitoring 
 ---
awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11325010

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #6 from Upstream Release Monitoring 
 ---
awd123's scratch build of color-0.0.8-1.src.rpm for f21 failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11325006

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Christos Triantafyllidis christos.triantafylli...@gmail.com changed:

   What|Removed |Added

 CC||christos.triantafyllidis@gm
   ||ail.com



--- Comment #3 from Christos Triantafyllidis 
christos.triantafylli...@gmail.com ---
Hello Steve,

   Thank you for your time on this and I apologize for the long delay on that
(the project I needed this for got postponed a bit).

   On your comments:
- gems should require rubygems package
  Note: Requires: rubygems missing in rubygem-colorize-doc
  See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems

  fedora-review which produced this comment
  is no longer correct here:
 https://bugzilla.redhat.com/show_bug.cgi?id=1128094
  submitted.

I didn't change anything on that. At any case the -doc file should not directly
require rubygems.

- It should be hopefully easy enough to get the tests to run 
  in %check
  A simple execution of 'testrb -Ilib test' looks to do the job.

Done. I tried to use minitest but I couldn't make it run without changing
upstream's tests so I preferred to keep the Test::UNIT based ones.

- Drop the Buidrequires on rake , the guidelines say not 
  to use it for tests (not sure I actually agree with that but
  that is what it says)

Done.

- All of the Requires and Provides should go for fc  21. They
  are automatic now.

Done.

- Use %{gem_install} rather than way you have for %install.

Not sure if I got what you mean correctly here. The current ruby packaging
guide says to not do so:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#.25build

- The README and CHANGELOG should be the docs package I would 
  say.

Done.

-  The files %{gem_spec} and %{gem_instdir}/%{gem_name}.gemspec are the same
   I would %exclude the latter. The first is needed runtime.

Done.


  In addition I upgraded it to the latest upstream (0.7.5):
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize.spec
https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.7.5-1.fc21.src.rpm

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Steve Traylen steve.tray...@cern.ch changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||steve.tray...@cern.ch
   Assignee|nob...@fedoraproject.org|steve.tray...@cern.ch
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579



--- Comment #1 from Steve Traylen steve.tray...@cern.ch ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- gems should require rubygems package
  Note: Requires: rubygems missing in rubygem-colorize-doc
  See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems

  fedora-review which produced this comment
  is no longer correct here:
 https://bugzilla.redhat.com/show_bug.cgi?id=1128094
  submitted.

- It should be hopefully easy enough to get the tests to run 
  in %check
  A simple execution of 'testrb -Ilib test' looks to do the job.

- Drop the Buidrequires on rake , the guidelines say not 
  to use it for tests (not sure I actually agree with that but
  that is what it says)

- All of the Requires and Provides should go for fc  21. They
  are automatic now.

- Use %{gem_install} rather than way you have for %install.

- The README and CHANGELOG should be the docs package I would 
  say.

-  The files %{gem_spec} and %{gem_instdir}/%{gem_name}.gemspec are the same
   I would %exclude the latter. The first is needed runtime.



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
 Clearly GPL2+
[X]: License field in the package spec file matches the actual license.
[X]: License file installed when any subpackage combination is installed.
[X]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query