[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #30 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc27, python-azure-storage-0.36.0-1.fc27,
python-msrestazure-0.4.13-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #29 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.el7, python-azure-storage-0.36.0-1.el7,
python-msrestazure-0.4.13-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #28 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc25, python-azure-storage-0.36.0-1.fc25,
python-msrestazure-0.4.13-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-16 23:50:46



--- Comment #27 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc26, python-azure-storage-0.36.0-1.fc26,
python-msrestazure-0.4.13-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852
Bug 1297852 depends on bug 1358741, which changed state.

Bug 1358741 Summary: Review Request: python-msrestazure - AutoRest swagger 
generator Python client runtime (Azure-specific module)
https://bugzilla.redhat.com/show_bug.cgi?id=1358741

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #26 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc26, python-azure-storage-0.36.0-1.fc26,
python-msrestazure-0.4.13-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da1c58958

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #25 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc25, python-azure-storage-0.36.0-1.fc25,
python-msrestazure-0.4.13-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f67a2c575f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #24 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.el7, python-azure-storage-0.36.0-1.el7,
python-msrestazure-0.4.13-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-50395615c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #23 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc27, python-azure-storage-0.36.0-1.fc27,
python-msrestazure-0.4.13-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e28803615

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #22 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.el7 python-azure-storage-0.36.0-1.el7
python-msrestazure-0.4.13-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-50395615c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #21 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.el7 python-azure-storage-0.36.0-1.el7
python-msrestazure-0.4.13-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-50395615c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #20 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc26 python-azure-storage-0.36.0-1.fc26
python-msrestazure-0.4.13-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da1c58958

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #19 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc26 python-azure-storage-0.36.0-1.fc26
python-msrestazure-0.4.13-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da1c58958

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #18 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc25 python-azure-storage-0.36.0-1.fc25
python-msrestazure-0.4.13-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f67a2c575f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #17 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc25 python-azure-storage-0.36.0-1.fc25
python-msrestazure-0.4.13-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f67a2c575f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #16 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc27 python-azure-storage-0.36.0-1.fc27
python-msrestazure-0.4.13-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e28803615

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #15 from Fedora Update System  ---
python-azure-sdk-2.0.0-2.fc27 python-azure-storage-0.36.0-1.fc27
python-msrestazure-0.4.13-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e28803615

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #13 from mpr...@redhat.com  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.stg.fedoraproject.org/rpms/python-azure-sdk. You may modify the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

mpr...@redhat.com  changed:

   What|Removed |Added

 CC||mpr...@redhat.com



--- Comment #14 from mpr...@redhat.com  ---
Please disregard the above comment. That was testing in stage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #12 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-azure-sdk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review? needinfo+|fedora-review+



--- Comment #11 from Robert-André Mauchin  ---
All good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #10 from Mohamed El Morabity  ---
Thannks again for your review. Here is an updated version:

Spec file:
https://copr-be.cloud.fedoraproject.org/results/melmorabity/azure/fedora-rawhide-x86_64/00597636-python-azure-sdk/python-azure-sdk.spec
SRPM file:
https://copr-be.cloud.fedoraproject.org/results/melmorabity/azure/fedora-rawhide-x86_64/00597636-python-azure-sdk/python-azure-sdk-2.0.0-2.fc28.src.rpm

Changes:
- Use python2- prefix for Fedora dependencies wherever it's possible
- Use parallel make to build documentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Patrick Laimbock  changed:

   What|Removed |Added

 CC||patr...@laimbock.com



--- Comment #9 from Patrick Laimbock  ---
Created attachment 1319761
  --> https://bugzilla.redhat.com/attachment.cgi?id=1319761=edit
Updated python-azure-sdk-2.0.1-build.patch for EL7

This is an updated python-azure-sdk-2.0.1-build.patch for git HEAD of 20170824
git rev a89367799a3f700d897459b17aa0bfd92659b8c5. Thank you for packaging it
and William for reviewing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|williamjmore...@gmail.com   |zebo...@gmail.com



--- Comment #8 from Robert-André Mauchin  ---
Hello,


 - The Group: tag is not needed on Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - You could use the %{py2_dist/%{py3_dist macros for your dependencies. See: 
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

i.e. like this:

BuildRequires:  python-setuptools
BuildRequires:  python2-devel
# Needed to build documentation
%if 0%{?_with_doc}
BuildRequires:  %{py2_dist pip}
BuildRequires:  %{py2_dist sphinx}
BuildRequires:  %{py2_dist sphinx-rtd-theme}
%endif
%if 0%{?_with_python3}
BuildRequires:  python3-devel
%endif
# Needed for tests
%if 0%{?_with_tests}
BuildRequires:  %{py2_dist certifi}
BuildRequires:  %{py2_dist chardet}
BuildRequires:  %{py2_dist coverage}
BuildRequires:  %{py2_dist enum34}
BuildRequires:  %{py2_dist isodate}
BuildRequires:  %{py2_dist keyring}
BuildRequires:  %{py2_dist msrest}
BuildRequires:  %{py2_dist msrestazure}
BuildRequires:  %{py2_dist nose}
BuildRequires:  %{py2_dist oauthlib}
BuildRequires:  %{py2_dist requests}
BuildRequires:  %{py2_dist requests-oauthlib}
BuildRequires:  %{py2_dist vcrpy} >= 1.8.0
%if 0%{?_with_python3}
BuildRequires:  %{py3_dist certifi}
BuildRequires:  %{py3_dist chardet}
BuildRequires:  %{py3_dist coverage}
BuildRequires:  %{py3_dist isodate}
BuildRequires:  %{py3_dist keyring}
BuildRequires:  %{py3_dist msrest}
BuildRequires:  %{py3_dist msrestazure}
BuildRequires:  %{py3_dist nose}
BuildRequires:  %{py3_dist oauthlib}
BuildRequires:  %{py3_dist requests}
BuildRequires:  %{py3_dist requests-oauthlib}
BuildRequires:  %{py3_dist vcrpy} >= 1.8.0
%endif
%endif
BuildArch:  noarch

%description
%{common_description}


%package -n python2-%{srcname}
Summary:%{common_summary}
Requires:   pyOpenSSL
Requires:   %{py2_dist msrest}
Requires:   %{py2_dist msrestazure}
Requires:   %{py2_dist requests}
%{?python_provide:%python_provide python2-%{srcname}}

%description -n python2-%{srcname}
%{common_description}


%if 0%{?_with_python3}
%package -n python3-%{srcname}
Summary:%{common_summary}
Requires:   %{py3_dist msrest}
Requires:   %{py3_dist msrestazure}
Requires:   %{py3_dist pyOpenSSL}
Requires:   %{py3_dist requests}
%{?python_provide:%python_provide python3-%{srcname}}

 - You should use the %make_build macro instead of make alone

%make_build -C doc/ html




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
 4432 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-azure-sdk/review-python-azure-
 sdk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 102400 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported 

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #7 from Mohamed El Morabity  ---
- Update to 2.0.0
- Move doc. to a subpackage

Spec URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk-2.0.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852
Bug 1297852 depends on bug 1358739, which changed state.

Bug 1358739 Summary: Review Request: python-msrest - AutoRest swagger generator 
Python client runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1358739

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #6 from Mohamed El Morabity  ---
Update to 2.0.0rc6:

Spec URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk-2.0.0-0.8.rc6.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Mohamed El Morabity  changed:

   What|Removed |Added

 Depends On||1358741, 1358739
  Flags|needinfo?(pikachu.2014@gmai |needinfo+
   |l.com)  |



--- Comment #5 from Mohamed El Morabity  ---
New release for the Python Azure SDK:

Spec URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk-2.0.0-0.7.rc5.fc24.src.rpm

This new release depends on two new Python libraries:
- msrest (RHBZ #1358739)
- msrestazure (RHBZ #1358741)

The unit tests are now run at package build, as suggested. The documentation is
also generated and installed.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1358739
[Bug 1358739] Review Request: python-msrest - AutoRest swagger generator
Python client runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1358741
[Bug 1358741] Review Request: python-msrestazure - AutoRest swagger
generator Python client runtime (Azure-specific module)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

William Moreno  changed:

   What|Removed |Added

 CC||pikachu.2...@gmail.com
  Flags||needinfo?(pikachu.2014@gmai
   ||l.com)



--- Comment #4 from William Moreno  ---
ping

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #3 from Mohamed El Morabity  ---
Sorry for this late answer, and thanks for your review.
I will upload very soon an updated version for this package, improved with your
suggestions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #2 from William Moreno  ---
Package Review
==
[!]: Large documentation must go in a -doc subpackage.
There is a doc directoty than you can build to html with sphinx and include as
subpackage.

[!]: %check is present and all tests pass.
There are many tests directories than you can try to run in the build procces.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852



--- Comment #1 from Mohamed El Morabity  ---
Update to 1.0.3:
Spec URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-azure-sdk/python-azure-sdk-1.0.3-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297852] Review Request: python-azure-sdk - Microsoft Azure SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297852

Mohamed El Morabity  changed:

   What|Removed |Added

 Blocks||1298131




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1298131
[Bug 1298131] Review Request: python-azure-storage - Microsoft Azure
Storage Library for Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review