[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #36 from Neil Horman --- Nothing, you can proceed with the documentation at the link you have above -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #35 from dennis.dalessan...@intel.com --- Thank Neil. So looks like the next steps for me are to follow:

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |needinfo-

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #33 from dennis.dalessan...@intel.com --- Just now seen this. I have been out for a couple weeks. My fedora user name is ddalessa. -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Janet Morgan changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #31 from dennis.dalessan...@intel.com --- Hi Neil, What info is being requested from me at this point? So you marked it approved, now am I waiting to get a sponsor? Does the FE_NEEDSPONSOR in the blocks section accomplish that or

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |fedora-review+

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Janet Morgan changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|needinfo?(nhor...@redhat.co |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #25 from dennis.dalessan...@intel.com --- Ok sounds like we are on the same page then. I've made the other changes and have it out for review/testing on our end. Should be posted as a new version here soon. -- You are receiving

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Honggang LI changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #23 from dennis.dalessan...@intel.com --- (In reply to Neil Horman from comment #22) > Just because the source has multiple license options, doesn't mean you just > pass that through to the binary. The dual license option is for

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #22 from Neil Horman --- Concur with comment 20, we need the latest package from upstream However, the license does need to get fixed. As per the licensing guidelines:

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #21 from Honggang LI --- (In reply to dennis.dalessandro from comment #19) > (In reply to Honggang LI from comment #12) > > 6) As this package is licensed by multiple licenses, so add comment in spec > > file as

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #20 from Honggang LI --- (In reply to dennis.dalessandro from comment #18) > So I'm asking is it a hard requirement to use the newer package? If so, why? > is there a specific problem with the older version

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #19 from dennis.dalessan...@intel.com --- (In reply to Honggang LI from comment #12) > 6) As this package is licensed by multiple licenses, so add comment in spec > file as required. Not sure what you mean here? The spec file has

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #18 from dennis.dalessan...@intel.com --- So I'm asking is it a hard requirement to use the newer package? If so, why? is there a specific problem with the older version (which would be good to know for other reasons), or is a

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #17 from Neil Horman --- Its a BuildRequires. If someone is building the rpm they can adhere to the levels Fedora requires. If they aren't using fedora, then they can modify the spec file. -- You are

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Honggang LI changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Honggang LI changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #12 from Honggang LI --- Hello, Dennis http://people.redhat.com/honli/.b187328c893321f3baa62cc5ef46f5d1/ I uploaded my review result into this http dir. Please fix the obsoleted m4s macros in upstream git repo

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added CC||nhor...@redhat.com

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Flags|needinfo?(dennis.dalessandr |

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Honggang LI changed: What|Removed |Added CC|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Don Bayly changed: What|Removed |Added Blocks||1171868 -- You are

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #9 from dennis.dalessan...@intel.com --- (In reply to Honggang LI from comment #8) > Please re-post the old version then someone else can review those files. And > I also need those files to run fedora-review as suggested by

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #8 from Honggang LI --- Please re-post the old version then someone else can review those files. And I also need those files to run fedora-review as suggested by someone in IRC channel #fedora-devel. -- You are

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #7 from dennis.dalessan...@intel.com --- (In reply to Honggang LI from comment #6) > (In reply to dennis.dalessandro from comment #0) > > Spec URL: > > https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/ > >

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #6 from Honggang LI --- (In reply to dennis.dalessandro from comment #0) > Spec URL: > https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/ > libhfi1verbs.spec > SRPM URL: >

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #5 from Honggang LI --- (In reply to dennis.dalessandro from comment #4) > Is this a hard requirement? I'm checking into its impact regardless. Yes, it is a hard requirement for RHEL. So, it is better to build

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Honggang LI changed: What|Removed |Added Attachment|0 |1 #1134688 is|

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #2 from Honggang LI --- Created attachment 1134688 --> https://bugzilla.redhat.com/attachment.cgi?id=1134688=edit spec review patch -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #1 from Honggang LI --- (In reply to dennis.dalessandro from comment #0) > Spec URL: > https://github.com/01org/opa-libhfi1verbs/releases/download/10_1/ > libhfi1verbs.spec Please see the attachment and update

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Honggang LI changed: What|Removed |Added CC||ho...@redhat.com

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Blocks||1273171 -- You are

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added CC||john.fl...@intel.com