[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Raphael Groner changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Björn "besser82" Esserchanged: What|Removed |Added CC||besse...@fedoraproject.org Resolution|NOTABUG |DUPLICATE Alias|xviewer | --- Comment #16 from Björn "besser82" Esser --- *** This bug has been marked as a duplicate of bug 1424825 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Björn "besser82" Esserchanged: What|Removed |Added Blocks|1359390 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1359390 [Bug 1359390] Cinnamon X-apps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Bug 1354210 depends on bug 1357974, which changed state. Bug 1357974 Summary: Directory /usr/share/help is not owned by any package https://bugzilla.redhat.com/show_bug.cgi?id=1357974 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Mario Blättermannchanged: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Flags|needinfo?(mario.blaetterman | |n...@gmail.com)| Last Closed||2016-09-10 14:39:56 --- Comment #15 from Mario Blättermann --- (In reply to Raphael Groner from comment #12) > Friendly reminder. Are you still interested in this package? Sorry, I'm pretty busy with other things, especially translations. Those have priority for me, and actually I feel unable to maintain more packages than my current ones... Well, submitting Cinnamon's X-apps for review was a result of the first euphoria after noticing their releases. But I really don't have the time to continue here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #14 from leigh scott--- (In reply to Raphael Groner from comment #9) > Forgot, sorry: > > Unknown or generated > > xviewer-1.0.4/jpegutils/jpegint-8a.h > xviewer-1.0.4/jpegutils/transupp-8a.h > > These two files have IJG license, see README.8a file. > https://fedoraproject.org/wiki/Licensing/IJG > > Although: > > GPL (v2 or later) > - > xviewer-1.0.4/jpegutils/jpegint.h > xviewer-1.0.4/jpegutils/transupp-6b.c > xviewer-1.0.4/jpegutils/transupp-6b.h > xviewer-1.0.4/jpegutils/transupp-8a.c > xviewer-1.0.4/jpegutils/transupp.h > > make[2]: Entering directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' > CC transupp-6b.lo > CCLD libxviewer-jpegutils.la > make[2]: Leaving directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' > > I don't understand. Do we see a (forbidden) try to relicense jpegutils files > from IJG to GPLv2+ and a case of bundling? How are those files relevant for > the project because 'BR: pkgconfig(libjpeg)'? > > AND: > Did you report or ask about the unlicensed files as in comment #6 to > upstream? P.S I think your being OTT/OCD about it! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #13 from leigh scott--- (In reply to Raphael Groner from comment #9) > Forgot, sorry: > > Unknown or generated > > xviewer-1.0.4/jpegutils/jpegint-8a.h > xviewer-1.0.4/jpegutils/transupp-8a.h > > These two files have IJG license, see README.8a file. > https://fedoraproject.org/wiki/Licensing/IJG > > Although: > > GPL (v2 or later) > - > xviewer-1.0.4/jpegutils/jpegint.h > xviewer-1.0.4/jpegutils/transupp-6b.c > xviewer-1.0.4/jpegutils/transupp-6b.h > xviewer-1.0.4/jpegutils/transupp-8a.c > xviewer-1.0.4/jpegutils/transupp.h > > make[2]: Entering directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' > CC transupp-6b.lo > CCLD libxviewer-jpegutils.la > make[2]: Leaving directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' > > I don't understand. Do we see a (forbidden) try to relicense jpegutils files > from IJG to GPLv2+ and a case of bundling? How are those files relevant for > the project because 'BR: pkgconfig(libjpeg)'? > > AND: > Did you report or ask about the unlicensed files as in comment #6 to > upstream? After your finished busting Mario's arse on the licensing issues you can file a bug against eog for the same (xviewer inherited the licenses from eog). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Raphael Gronerchanged: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m Whiteboard||AwaitingSubmitter Flags||needinfo?(mario.blaetterman ||n...@gmail.com) --- Comment #12 from Raphael Groner --- Friendly reminder. Are you still interested in this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #11 from Raphael Groner--- https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #10 from Raphael Groner--- License discussion continued. Why license CC-BY-SA for the doc subpackage? I can not validate because I don't find any file from upstream that says so. Still not fixed as in comment #4: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated", "GPL (v2 or later) LGPL (v2 or later)", "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later)". 43 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1354210-xviewer/licensecheck.txt [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. => Add MIT to license tag and a comment about license breakdown. I'll attach full licensetext.txt content. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #9 from Raphael Groner--- Forgot, sorry: Unknown or generated xviewer-1.0.4/jpegutils/jpegint-8a.h xviewer-1.0.4/jpegutils/transupp-8a.h These two files have IJG license, see README.8a file. https://fedoraproject.org/wiki/Licensing/IJG Although: GPL (v2 or later) - xviewer-1.0.4/jpegutils/jpegint.h xviewer-1.0.4/jpegutils/transupp-6b.c xviewer-1.0.4/jpegutils/transupp-6b.h xviewer-1.0.4/jpegutils/transupp-8a.c xviewer-1.0.4/jpegutils/transupp.h make[2]: Entering directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' CC transupp-6b.lo CCLD libxviewer-jpegutils.la make[2]: Leaving directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' I don't understand. Do we see a (forbidden) try to relicense jpegutils files from IJG to GPLv2+ and a case of bundling? How are those files relevant for the project because 'BR: pkgconfig(libjpeg)'? AND: Did you report or ask about the unlicensed files as in comment #6 to upstream? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Mario Blättermannchanged: What|Removed |Added Blocks||1359392 (xviewer-plugins) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1359392 [Bug 1359392] Review Request: xviewer-plugins - A collection of plugins for xviewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Mario Blättermannchanged: What|Removed |Added Blocks||1359390 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1359390 [Bug 1359390] Cinnamon X-apps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Mario Blättermannchanged: What|Removed |Added Depends On||1357974 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1357974 [Bug 1357974] Directory /usr/share/help is not owned by any package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #8 from Mario Blättermann--- There is a general problem with /usr/share/help and all of its language-based subdirectories. They are not owned by *any* package. Some ownerships on a real system happen by accidence, but there's no regular owner, see https://bugzilla.redhat.com/show_bug.cgi?id=1357974. The bug in the Amharic translation has been fixed already in Launchpad: https://translations.launchpad.net/linuxmint/latest/+pots/xviewer/am/+translate?batch=10=all=%E1%88%9D%E1%88%B5%E1%88%8E%E1%89%BD%3A%E1%89%B0%E1%8A%95%E1%88%B8%E1%88%AB%E1%89%B3%E1%89%BD+%E1%88%9B%E1%88%B3%E1%8B%AB%3A%E1%8A%95%E1%8B%B5%E1%8D%8E%E1%89%BD%3B I've renamed the ChangeLog files amd added them to doc. The user documentation has now its own subpackage. This behaves the same as in Glabels (which I've used as template): The -doc package is independent, because in fact it contains text files only. It will be pulled in automatically by the main package, to avoid unexpected behavior when calling the help in the GUI. The advantages are, the -doc package is noarch, and it is easier to declare the license (CC-BY-SA). Spec URL: https://mariobl.fedorapeople.org/Review/SPECS/xviewer.spec SRPM URL: https://mariobl.fedorapeople.org/Review/SRPMS/xviewer-1.0.4-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #7 from Raphael Groner--- … And please add ChangeLog files: %doc help-ChangeLog %doc plugins-ChangeLog %doc po-ChangeLog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #6 from Raphael Groner--- Created attachment 1180246 --> https://bugzilla.redhat.com/attachment.cgi?id=1180246=edit licensecheck.txt Please also poke upstream about sources without license header: xviewer-1.0.4/cut-n-paste/toolbar-editor/eggmarshalers.c xviewer-1.0.4/cut-n-paste/toolbar-editor/eggmarshalers.h xviewer-1.0.4/cut-n-paste/toolbar-editor/eggtypebuiltins.c xviewer-1.0.4/cut-n-paste/toolbar-editor/eggtypebuiltins.h xviewer-1.0.4/src/xviewer-image-jpeg.h xviewer-1.0.4/src/xviewer-image-save-info.c xviewer-1.0.4/src/xviewer-image-save-info.h xviewer-1.0.4/src/xviewer-pixbuf-util.c xviewer-1.0.4/src/xviewer-pixbuf-util.h xviewer-1.0.4/src/xviewer-save-as-dialog-helper.c xviewer-1.0.4/src/xviewer-save-as-dialog-helper.h xviewer-1.0.4/src/xviewer-scroll-view.c xviewer-1.0.4/src/xviewer-scroll-view.h xviewer-1.0.4/src/xviewer-transform.h xviewer-1.0.4/src/xviewer-uri-converter.c xviewer-1.0.4/src/xviewer-uri-converter.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #5 from Mario Blättermann--- Note: License file license.page is not marked as %license This is bogus, the mentioned *.page file is part of the user documentation, and as such not to be considered as a license file for inclusion in %license. I will have a deeper look at the issues generated by fedora-review tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #4 from Raphael Groner--- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.page is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. => OK: Plugins folder. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated", "GPL (v2 or later) LGPL (v2 or later)", "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later)". 43 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1354210-xviewer/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. => Add MIT to license tag and a comment about license breakdown. I'll attach full licensetext.txt content. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/help/ar, /usr/share/help/th, /usr/share/help/pa, /usr/share/help/da => Propably wrong installation. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/help/lv, /usr/share/help/fi, /usr/share/help/uk, /usr/share/help/de, /usr/share/help/da, /usr/share/help/sv, /usr/share/help/hu, /usr/share/help/fr, /usr/share/help/pl, /usr/share/help/C, /usr/share/help/ja, /usr/share/help/es, /usr/share/help/eu, /usr/share/help, /usr/share/help/ar, /usr/share/help/ca, /usr/share/help/ro, /usr/share/help/el, /usr/share/help/en_GB, /usr/share/help/gl, /usr/share/help/pa, /usr/share/help/pt_BR, /usr/share/help/oc, /usr/share/help/it, /usr/share/help/sl, /usr/share/help/zh_TW, /usr/share/help/te, /usr/share/help/cs, /usr/share/help/ko, /usr/share/help/ru, /usr/share/help/th, /usr/share/help/zh_CN => Please fix. Propably: %{_datadir}/%{name}/help/ [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/appdata(filesystem) => Remove folder from %files, maybe be more concrete about subfolder(s) and contained files. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. => You use a lesser Release number than previous packager. [?]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in xviewer [!]: The spec file handles locales properly. => See above for folders ownership. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. => See above for folders ownership. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in xviewer [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in xviewer [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Raphael Gronerchanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|projects...@smart.ms Flags||fedora-review? --- Comment #3 from Raphael Groner --- Taken. Thanks for the review swap. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 Mario Blättermannchanged: What|Removed |Added Alias||xviewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #1 from Mario Blättermann--- Scratch build for f24 was successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=14850867 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org