[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #44 from Fedora Update System  ---
snapd-2.23.6-3.fc24, snapd-glib-1.10-1.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #43 from Fedora Update System  ---
snapd-2.23.6-4.fc26, snapd-glib-1.10-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-08 22:53:54



--- Comment #42 from Fedora Update System  ---
snapd-2.23.6-4.fc25, snapd-glib-1.10-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #41 from Fedora Update System  ---
snapd-2.23.6-4.fc26, snapd-glib-1.10-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #40 from Fedora Update System  ---
snapd-2.23.6-4.fc25, snapd-glib-1.10-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #39 from Fedora Update System  ---
snapd-2.23.6-3.fc24 snapd-glib-1.10-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #38 from Fedora Update System  ---
snapd-2.23.6-4.fc25 snapd-glib-1.10-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #37 from Fedora Update System  ---
snapd-2.23.6-4.fc26 snapd-glib-1.10-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #36 from Fedora Update System  ---
snapd-2.23.6-3.fc26, snapd-glib-1.9-2.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #35 from Fedora Update System  ---
snapd-2.23.6-3.fc25, snapd-glib-1.9-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #34 from Fedora Update System  ---
snapd-2.23.6-3.fc24, snapd-glib-1.9-2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #33 from Fedora Update System  ---
snapd-2.23.6-3.fc25 snapd-glib-1.9-2.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #32 from Fedora Update System  ---
snapd-2.23.6-3.fc24 snapd-glib-1.9-2.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #31 from Fedora Update System  ---
snapd-2.23.6-3.fc26 snapd-glib-1.9-2.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #30 from Fedora Update System  ---
snapd-2.23.6-2.fc26, snapd-glib-1.9-2.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #29 from Fedora Update System  ---
snapd-2.23.6-2.fc25, snapd-glib-1.9-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #28 from Fedora Update System  ---
snapd-2.23.6-2.fc24, snapd-glib-1.9-2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #27 from Fedora Update System  ---
snapd-glib-1.9-2.fc24 snapd-2.23.6-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #26 from Fedora Update System  ---
snapd-glib-1.9-2.fc25 snapd-2.23.6-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #25 from Fedora Update System  ---
snapd-2.23.6-1.fc26 snapd-glib-1.9-2.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #24 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/snapd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #23 from Neal Gompa  ---
Package was generated through gofed, simplifying the review considerably.

- Conforms to packaging guidelines (gofed generated spec)
- license correct and valid
- Binaries for applications installed, sources installed for devel subpackage
- SELinux module subpackage uses appropriate macros
- SELinux module subpackage is appropriately required by main package

PACKAGE APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

  Flags|needinfo?(m...@zygoon.pl) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

 CC||m...@zygoon.pl
  Flags||needinfo?(m...@zygoon.pl)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #22 from Zygmunt Krynicki  ---
Updated spec and SRPM

Spec URL: https://fedorapeople.org/~zyga/snapd.spec
SRPM URL: https://fedorapeople.org/~zyga/snapd-2.16-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

   See Also|https://fedorahosted.org/fe |
   |sco/ticket/1614 |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #21 from Neal Gompa  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #20)
> https://pagure.io/fesco/issue/1614#comment-27728
> 
> > We rejected this exception during the last meeting:
> > * REJECTED: FHS exception for /snap (9:+ 0:- 0:0)
> 
> So, what the is the plan going forward here?

I met with Zygmunt at last weeks Snappy developer sprint and we've agreed to
relocate /snap to /var/lib/snapd/snap.

snap-confine has already been updated to use this new path[1].

[1]:
http://pkgs.fedoraproject.org/cgit/rpms/snap-confine.git/tree/snap-confine.spec#n41

Zygmunt will soon update this ticket with an updated snapd spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #20 from Zbigniew Jędrzejewski-Szmek  ---
https://pagure.io/fesco/issue/1614#comment-27728

> We rejected this exception during the last meeting:
> * REJECTED: FHS exception for /snap (9:+ 0:- 0:0)

So, what the is the plan going forward here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

   See Also||https://fedorahosted.org/fe
   ||sco/ticket/1614



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

 Blocks||1367932
 Depends On|1367932 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1367932
[Bug 1367932] systemd presets request - snapd.socket snapd.refresh.timer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #19 from Zbigniew Jędrzejewski-Szmek  ---
The summary of "the snapd and snap tools enable systems to work with .snap
files" is not very informative: it should say what the snapd daemon actually
does. (It's like saying that gcc allows programmers to work with .c files).

In the built binary rpm:
#/etc/profile.d/snapd.sh

PATH=/home/zbyszek/bin:/usr/lib64/qt-3.3/bin:/usr/lib64/ccache:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/snap/bin
if [ -z "" ]; then
XDG_DATA_DIRS=/usr/local/share/:/usr/share/:/var/lib/snapd/desktop
else
XDG_DATA_DIRS="":/var/lib/snapd/desktop
fi
export XDG_DATA_DIRS

This doesn't look right ;)

/usr/lib/systemd/system-preset/91-snapd.preset → no, that's what the FESCo
ticket is for.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825
Bug 1367825 depends on bug 1360199, which changed state.

Bug 1360199 Summary: Review Request: snap-confine - Confinement system for snap 
applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360199

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #18 from Neal Gompa  ---
An exception for /snap has been requested to FESCo:
https://fedorahosted.org/fesco/ticket/1614

Please prepare a contingency plan (such as an alternate path in
/var/lib/snapd/, /run/snapd/, etc.) in the event it is rejected, otherwise this
package cannot be added to Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #17 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #16)
> You should fix the changelog versions for the two newest entries. They say
> 2.11 when they should say 2.12.

Fixed and pushed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #16 from Neal Gompa  ---
You should fix the changelog versions for the two newest entries. They say 2.11
when they should say 2.12.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #15 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #13)
> That part looks good.
> 
> I just noticed that your License tag is invalid. "GPL-3" needs to be
> replaced with "GPLv3". If it's v3 or any later version, set it to "GPLv3+".

Updated in 2.12-2 now, thanks for spotting this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #14 from Zygmunt Krynicki  ---
I've updated snapd to 2.12 without any packaging changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #13 from Neal Gompa  ---
That part looks good.

I just noticed that your License tag is invalid. "GPL-3" needs to be replaced
with "GPLv3". If it's v3 or any later version, set it to "GPLv3+".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #12 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #10)
> The usage of /snap hierarchy is forbidden in Fedora, see
> https://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout
> 
> Would it be possible to relocate /snap to an FHS compliant location, like
> /var/lib/snapd/snaps? You're already using /var/lib/snapd/desktop for
> desktop files...

I'm not sure yet. I'm exploring options at this time.

> You also probably want /var/lib/snapd and associated subdirs to be owned by
> the snapd package. To do so, just add the following to the %files list:
> %dir %{_sharedstatedir}/snapd
> %dir %{_sharedstatedir}/snapd/desktop
> %dir %{_sharedstatedir}/snapd/snaps

Done in -8, along with the, apparently now working, Source0 URL

Pushed to the same address and to github.

Thanks
ZK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #11 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #9)
> The URL used in Source0 is bad. See
> https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/
> SourceURL#Git_Tags
> 
> A suggestion: Set Source0 to
> "https://%{provider_prefix}/archive/%{version}/%{name}-%{version}.tar.gz;

This URL doesn't work.

This one does:

https://%{provider_prefix}/archive/%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #10 from Neal Gompa  ---
The usage of /snap hierarchy is forbidden in Fedora, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout

Would it be possible to relocate /snap to an FHS compliant location, like
/var/lib/snapd/snaps? You're already using /var/lib/snapd/desktop for desktop
files...

You also probably want /var/lib/snapd and associated subdirs to be owned by the
snapd package. To do so, just add the following to the %files list:
%dir %{_sharedstatedir}/snapd
%dir %{_sharedstatedir}/snapd/desktop
%dir %{_sharedstatedir}/snapd/snaps

The above lines will ensure the directories exist and are owned by the snapd
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #9 from Neal Gompa  ---
The URL used in Source0 is bad. See
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

A suggestion: Set Source0 to
"https://%{provider_prefix}/archive/%{version}/%{name}-%{version}.tar.gz;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

 Depends On||1367932




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1367932
[Bug 1367932] systemd presets request - snapd.socket snapd.refresh.timer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #8 from Zygmunt Krynicki  ---
FESCO request: https://bugzilla.redhat.com/show_bug.cgi?id=1367932

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #7 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #5)
> Two more things:
> 
> * Can you please tell me why you are pulling in /etc/environment in
> snapd.service through EnvironmentFile? The file is empty in Fedora. If
> there's a reason that a user may want to pass options or variables to
> snapd.service, then set this to "/etc/sysconfig/snapd" and create a file in
> that location. This file should be marked as %config(noreplace), since
> administrator changes should be preserved by default.
> 
> * Remove the portion of the %post scriptlet that starts the socket and
> timer. This is not allowed in Fedora without approval from FESCo. See

Done removing, working on the ticket now.

Updated spec file at: https://fedorapeople.org/~zyga/snapd.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #6 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #5)
> Two more things:
> 
> * Can you please tell me why you are pulling in /etc/environment in
> snapd.service through EnvironmentFile? The file is empty in Fedora. If
> there's a reason that a user may want to pass options or variables to
> snapd.service, then set this to "/etc/sysconfig/snapd" and create a file in
> that location. This file should be marked as %config(noreplace), since
> administrator changes should be preserved by default.

This was done to teach snapd about proxy settings (http_proxy). If there's a
better way to do that without having to synchronize proxy settings across
applications please let me know


> 
> * Remove the portion of the %post scriptlet that starts the socket and
> timer. This is not allowed in Fedora without approval from FESCo. See
> https://fedoraproject.org/wiki/Packaging:DefaultServices for details. When
> the preset is pre-installed (as in fedora-release), then the unit is enabled
> and started automatically. Please file a bug using the following URL to get
> the presets in and to have the units started automatically in the event
> snapd is installed:
> https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora=fedora-
> systemd-request

Ack. Will do!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

 Depends On||1360199




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1360199
[Bug 1360199] Review Request: snap-confine - Confinement system for snap
applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #5 from Neal Gompa  ---
Two more things:

* Can you please tell me why you are pulling in /etc/environment in
snapd.service through EnvironmentFile? The file is empty in Fedora. If there's
a reason that a user may want to pass options or variables to snapd.service,
then set this to "/etc/sysconfig/snapd" and create a file in that location.
This file should be marked as %config(noreplace), since administrator changes
should be preserved by default.

* Remove the portion of the %post scriptlet that starts the socket and timer.
This is not allowed in Fedora without approval from FESCo. See
https://fedoraproject.org/wiki/Packaging:DefaultServices for details. When the
preset is pre-installed (as in fedora-release), then the unit is enabled and
started automatically. Please file a bug using the following URL to get the
presets in and to have the units started automatically in the event snapd is
installed:
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora=fedora-systemd-request

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #4 from Zygmunt Krynicki  ---
The updated SRPM file is:
https://fedorapeople.org/~zyga/snapd-2.11-5.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #3 from Zygmunt Krynicki  ---
(In reply to Neal Gompa from comment #2)
> A few things I see stand out:
> 
> * Presets are supposed to be centrally managed in Fedora. Please remove the
> preset from snapd and file a bug against fedora-release to add the snapd
> preset. This is per Fedora policy:
> https://fedoraproject.org/wiki/Packaging:DefaultServices

Understood, will do. I removed the presets now.

> * If you require specific kernel modules, please use their kmod provides.
> For example, for squashfs, require "kmod(squashfs.ko)" instead of
> kernel-modules.

All the nice things that Fedora has :-). Updated to use this.

> * Shouldn't modprobe be done before snapd is started? My understanding is
> that snapd itself triggers the mounts of snaps, so modprobe should probably
> occur as an ExecStartPre for snapd.

Ha, yes. This probably also explains why the Fedora cloud images didn't work
with snapd (because squashfs wasn't available early enough). Let me know if the
modification I did is okay.

> * I'm not sure it's a good idea to go and torch user data in the event snapd
> is uninstalled. Can snapd be (theoretically) uninstalled and then installed
> later and use the snaps/configs that already exist? If so, it *definitely*
> makes no sense to purge everything like that.

Yes it can be used as you described. Each distribution has different policy
here, I'm totally happy to keep snapd state and state of particular snaps
around (less scripts, less mistakes!).

Updated spec file at: https://fedorapeople.org/~zyga/snapd.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #2 from Neal Gompa  ---
A few things I see stand out:

* Presets are supposed to be centrally managed in Fedora. Please remove the
preset from snapd and file a bug against fedora-release to add the snapd
preset. This is per Fedora policy:
https://fedoraproject.org/wiki/Packaging:DefaultServices

* If you require specific kernel modules, please use their kmod provides. For
example, for squashfs, require "kmod(squashfs.ko)" instead of kernel-modules.

* Shouldn't modprobe be done before snapd is started? My understanding is that
snapd itself triggers the mounts of snaps, so modprobe should probably occur as
an ExecStartPre for snapd.

* I'm not sure it's a good idea to go and torch user data in the event snapd is
uninstalled. Can snapd be (theoretically) uninstalled and then installed later
and use the snaps/configs that already exist? If so, it *definitely* makes no
sense to purge everything like that.

There may be more, but those stand out at the moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org